Repository navigation
fix: name the binary min in the generated minimal.toml header - #1284
Conversation
The `min init` command wrote a `minimal.toml` whose opening comment read `# Generated by minimal init`, but the binary is named `min`. Update the generated header and the matching example in the setup guide to `min init`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe generated configuration comments now use ChangesInit command naming
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This changes only the generated Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the change, identifies both affected files, and provides detailed verification results. It does not use the template headings or include an explicit checklist, but it covers the required information. Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
minimal-review — advisory review
Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.
Scope: matches intent exactly - a two-line header-string fix (minimal init → `min init`) in the generated minimal.toml comment and its matching doc snippet, nothing else touched.
Correctness: the change is correct and brings these two spots in line with the rest of the repo - rg confirms every other generated/user-facing string (README, install.sh, MOTD banners, other docs) already says min init.
Redundant, not clobbering: this PR's diff is already on main. Commit 02f8ec3 ("fix(init): name the binary min in generated minimal.toml header") landed independently with a byte-identical diff to both files, and it's already an ancestor of this PR's own head commit a5a1f60 (via the "Merge branch 'main'" merge visible in the branch history) - so the file content at head already matches what this diff produces. There's nothing left for this PR to add; merging it would be a no-op against current main. Worth closing rather than merging to avoid confusion/duplicate history, though it isn't harmful (no revert, no conflict, no risk) if merged as-is.
No secrets, no dependency/lockfile changes, no added comments narrating the change - nothing else to flag.
What ran
4 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.
Verification log
1. rg 'minimal init|min init' across repo (excluding target/.review) — exit 0 · self-reported
Every other occurrence of the generated-header phrase in docs, README, install.sh, and MOTD strings already reads
min init; this diff's two lines were the only staleminimal initspellings in generated/user-facing text. No further instances of the same typo remain elsewhere.
2. git log --oneline -10 -- crates/op/src/project/init.rs docs/guide/setup.md — exit 0 · self-reported
Immediately preceding commit 02f8ec3, titled identically ('fix(init): name the binary
minin generated minimal.toml header'), already made this exact change to both files.
3. git merge-base --is-ancestor 02f8ec3 <base_sha 529040b> — exit 1 · self-reported
02f8ec3 is NOT an ancestor of this PR's base_sha, confirming this PR's branch made the fix independently before the two histories diverged/reconverged - it isn't simply stacked on top of 02f8ec3.
4. git merge-base --is-ancestor 02f8ec3 <head_sha a5a1f60>; git show 02f8ec3 -- crates/op/src/project/init.rs docs/guide/setup.md — exit 0 · self-reported
02f8ec3 IS an ancestor of head_sha (pulled in via the 'Merge branch main' commit that produced a5a1f60), and its diff is byte-for-byte identical to this PR's diff. The file content at head_sha already matches what this PR's diff produces.
minimal-review · schema minimal-review/v1 · persona generalist · model claude-sonnet-5 via claude-code · prompt review-prompt/v2 · head a5a1f601ebdf · verdict COMMENT · 0 finding(s), 0 inline
Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.
Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".
Owner triageConflicts: none. CI: all 31 check runs green on Correcting the
|
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKmgx0w
min initgenerates aminimal.tomlwhose opening comment read# Generated by minimal init, naming the pre-rename binary. The CLIbinary is
min, and the rest of the generated file already uses thatname, so the header was the lone stale spelling. This updates the header
emitted in
crates/op/src/project/init.rsand the matching examplesnippet in
docs/guide/setup.mdto# Generated by min init.Verification
cargo fmt --all --check — clean, no drift
cargo clippy --workspace --locked -- -D warnings — clean, 0 warnings
cargo build --workspace --locked — ok
cargo test --workspace --locked — all suites passed, 0 failed
Summary by CodeRabbit
min initcommand.