Skip to content

fix: name the binary min in the generated minimal.toml header - #1284

Merged
norrietaylor merged 2 commits into
mainfrom
inbox-patch/min-init-header-7abed816c39b2439
Aug 25, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
inbox-patch/min-init-header-7abed816c39b2439

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKmgx0w

min init generates a minimal.toml whose opening comment read
# Generated by minimal init, naming the pre-rename binary. The CLI
binary is min, and the rest of the generated file already uses that
name, so the header was the lone stale spelling. This updates the header
emitted in crates/op/src/project/init.rs and the matching example
snippet in docs/guide/setup.md to # Generated by min init.

Verification

cargo fmt --all --check — clean, no drift
cargo clippy --workspace --locked -- -D warnings — clean, 0 warnings
cargo build --workspace --locked — ok
cargo test --workspace --locked — all suites passed, 0 failed

Summary by CodeRabbit

  • Documentation
    • Updated generated configuration guidance to use the current min init command.
    • Aligned setup instructions and generated headers for consistent command usage.

The `min init` command wrote a `minimal.toml` whose opening comment
read `# Generated by minimal init`, but the binary is named `min`.
Update the generated header and the matching example in the setup
guide to `min init`.
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Aug 25, 2026
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner August 25, 2026 03:16
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 729b39af-cb80-4ea4-94e7-835edf2d81c7

📥 Commits

Reviewing files that changed from the base of the PR and between 0957ff8 and 02f8ec3.

📒 Files selected for processing (2)
  • crates/op/src/project/init.rs
  • docs/guide/setup.md

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The generated configuration comments now use min init instead of minimal init in the initialization source and setup guide.

Changes

Init command naming

Layer / File(s) Summary
Update generated init comments
crates/op/src/project/init.rs, docs/guide/setup.md
Updated both comments to reference min init. No behavior changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 02f8e

This changes only the generated minimal.toml header and its matching documentation example to use the current min binary name. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: norrietaylor

Poem

A rabbit found a shorter command,
min init now appears as planned.
The comments speak clear,
With no behavior to fear,
And carrots align across the land.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: updating the generated minimal.toml header to use the min binary name. It uses a concise Conventional Commit format.
Description check ✅ Passed The description explains the change, identifies both affected files, and provides detailed verification results. It does not use the template headings or include an explicit checklist, but it covers t…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, identifies both affected files, and provides detailed verification results. It does not use the template headings or include an explicit checklist, but it covers the required information.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch inbox-patch/min-init-header-7abed816c39b2439

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.

Scope: matches intent exactly - a two-line header-string fix (minimal init → `min init`) in the generated minimal.toml comment and its matching doc snippet, nothing else touched.

Correctness: the change is correct and brings these two spots in line with the rest of the repo - rg confirms every other generated/user-facing string (README, install.sh, MOTD banners, other docs) already says min init.

Redundant, not clobbering: this PR's diff is already on main. Commit 02f8ec3 ("fix(init): name the binary min in generated minimal.toml header") landed independently with a byte-identical diff to both files, and it's already an ancestor of this PR's own head commit a5a1f60 (via the "Merge branch 'main'" merge visible in the branch history) - so the file content at head already matches what this diff produces. There's nothing left for this PR to add; merging it would be a no-op against current main. Worth closing rather than merging to avoid confusion/duplicate history, though it isn't harmful (no revert, no conflict, no risk) if merged as-is.

No secrets, no dependency/lockfile changes, no added comments narrating the change - nothing else to flag.

What ran

4 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.

Verification log

1. rg 'minimal init|min init' across repo (excluding target/.review) — exit 0 · self-reported

Every other occurrence of the generated-header phrase in docs, README, install.sh, and MOTD strings already reads min init; this diff's two lines were the only stale minimal init spellings in generated/user-facing text. No further instances of the same typo remain elsewhere.

2. git log --oneline -10 -- crates/op/src/project/init.rs docs/guide/setup.md — exit 0 · self-reported

Immediately preceding commit 02f8ec3, titled identically ('fix(init): name the binary min in generated minimal.toml header'), already made this exact change to both files.

3. git merge-base --is-ancestor 02f8ec3 <base_sha 529040b> — exit 1 · self-reported

02f8ec3 is NOT an ancestor of this PR's base_sha, confirming this PR's branch made the fix independently before the two histories diverged/reconverged - it isn't simply stacked on top of 02f8ec3.

4. git merge-base --is-ancestor 02f8ec3 <head_sha a5a1f60>; git show 02f8ec3 -- crates/op/src/project/init.rs docs/guide/setup.md — exit 0 · self-reported

02f8ec3 IS an ancestor of head_sha (pulled in via the 'Merge branch main' commit that produced a5a1f60), and its diff is byte-for-byte identical to this PR's diff. The file content at head_sha already matches what this PR's diff produces.


minimal-review · schema minimal-review/v1 · persona generalist · model claude-sonnet-5 via claude-code · prompt review-prompt/v2 · head a5a1f601ebdf · verdict COMMENT · 0 finding(s), 0 inline

Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.

Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".

@norrietaylor

Copy link
Copy Markdown
Member

Owner triage

Conflicts: none. CI: all 31 check runs green on a5a1f60 (five aggregators — ci-success, ci-linux-native-success, ci-linux-kvm-success, ci-macos-success, ci-shell-installer-success — plus license/cla and CodeRabbit both success). CodeRabbit: no actionable comments. Inline review threads: none. No changes were needed, so nothing new was pushed.

Correcting the minimal-review advisory

The advisory's central claim is wrong, and I want it on the record before anyone acts on its "worth closing rather than merging" recommendation.

this PR's diff is already on main. Commit 02f8ec3 … landed independently with a byte-identical diff … merging it would be a no-op against current main.

02f8ec37 is this PR's own commit, not an independent commit on main. The branch has exactly two commits: 02f8ec37 (the fix) and a5a1f601 (a Merge branch 'main' merge). The reviewer's probes 3 and 4 are consistent with exactly that — not an ancestor of base_sha, but an ancestor of head_sha — and it read that pattern as "landed on main and was merged back in" rather than "is the PR's own commit."

Verified against the current base:

$ git merge-base --is-ancestor 02f8ec37 origin/main; echo $?
1                                                    # NOT on main

$ git show origin/main:crates/op/src/project/init.rs | sed -n '155p'
    content.push_str("# Generated by `minimal init`\n\n");

$ git show origin/main:docs/guide/setup.md | sed -n '20p'
# Generated by `minimal init`

main still carries the stale minimal init spelling in both files. This PR is not a no-op and should be merged, not closed.

The rest of the advisory (scope matches intent, change is correct, no secrets, no lockfile churn) holds.

Verification performed

  • cargo fmt --all --check — clean.
  • Grepped the whole tree (all files, not just *.rs/*.md) for the old header text: zero remaining occurrences of Generated by minimal init`` after this diff, so no test, doc, or snapshot asserts on the old string.
  • The two generate_mfile unit tests (crates/op/src/project/init.rs:306,330) assert on [upstream]/[stack]/[session] fields only — neither touches the header line, so neither is affected.

One adjacent stale spelling exists but is deliberately out of scope here: crates/mctx/src/lib.rs:294, a rustdoc line reading unless you are `minimal init` . It is an internal doc comment, not generated or user-facing output, and folding it in would widen a two-line header fix. Worth a separate cleanup.

Remaining blocker

mergeable_state is blocked with every check green and no unresolved threads, which points at the required approving review. That needs a human — minimal-review is advisory-only (policy.actions.approve is off) and cannot satisfy it.

@norrietaylor
norrietaylor enabled auto-merge (squash) August 25, 2026 22:46
@norrietaylor
norrietaylor merged commit 6400f5d into main Aug 25, 2026
33 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/min-init-header-7abed816c39b2439 branch August 25, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant