Skip to content

fix: correct dead links to the removed profiles concept page in docs - #1224

Merged
norrietaylor merged 2 commits into
mainfrom
inbox-patch/fix-stale-profiles-doc-links-898c2aa6168aadd6
Aug 17, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
inbox-patch/fix-stale-profiles-doc-links-898c2aa6168aadd6

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABMz0kDg

The profiles concept page (docs/concepts/profiles.md) was removed when profiles were superseded by the session config and loadouts, but three concept pages still linked to it, so they render as dead links wherever the docs are published. packages.md now points at the session concept, since package and env declaration moved from profiles into the [session] block (informed by #665). sandboxing.md and software-supply-chain.md drop their profile clauses (including from_profile), which no longer describe the current model.

Verification

cargo fmt --all --check --manifest-path target/Cargo.toml — clean, no drift
cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings — exit 0, no warnings
cargo build --workspace --locked --manifest-path target/Cargo.toml — exit 0
cargo test --workspace --locked --manifest-path target/Cargo.toml — exit 0, 84 suites passed, 0 failed

Note

Fix dead links by removing references to the deleted profiles concept page in docs

Updates three concept pages to remove or replace references to profiles, which no longer have a dedicated docs page. In packages.md, replaces mention of profile-scoped packages with session-scoped packages. In sandboxing.md, removes the bullet about packages from a task's profile being included in the sandbox. In software-supply-chain.md, removes profiles from the list of declarable entities and deletes the related from_profile exception.

Macroscope summarized fd4ce56.

Summary by CodeRabbit

  • Documentation
    • Clarified that session packages are available within the session where they are declared.
    • Updated sandboxing guidance to reflect package sources from tasks and repository stacks only.
    • Revised software supply-chain documentation to describe package and stack inheritance, including duplicate-name handling.

The profiles concept was removed (superseded by the session config and
loadouts), but three concept pages still linked to the deleted
profiles.md, rendering as dead links wherever the docs are consumed.

Point the packages page at the session concept, since package and env
declaration moved from profiles into the [session] block. Drop the
profile clauses from the task-sandbox and supply-chain pages, where
profiles (and from_profile) no longer apply.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 91fdce57-7f9a-4d2e-8aef-dc02838eac12

📥 Commits

Reviewing files that changed from the base of the PR and between dd11a8d and fd4ce56.

📒 Files selected for processing (3)
  • docs/concepts/packages.md
  • docs/concepts/sandboxing.md
  • docs/concepts/software-supply-chain.md

Included review availability: 1 review is currently available. Based on recent review activity, included reviews refill at 5 per hour.


📝 Walkthrough

Walkthrough

The documentation now describes package availability and supply-chain composition without profile-based inheritance. Session declarations define session packages, task sandboxes use task and repository-stack packages, and layers compose packages and stacks.

Changes

Package documentation

Layer / File(s) Summary
Package availability and composition rules
docs/concepts/packages.md, docs/concepts/sandboxing.md, docs/concepts/software-supply-chain.md
The documentation removes profile-based package availability and inheritance. It defines session packages, task sandbox package sources, and package or stack composition with duplicate-name errors.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to fd4ce

This updates stale documentation links and removes outdated profile references without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: 0chroma

Poem

I hopped through docs with a tidy decree,
No profile packages hiding from me.
Sessions declare what sessions contain,
Tasks keep their own supplies in the chain.
Packages and stacks now compose just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the documentation fix for dead links to the removed profiles concept page.
Description check ✅ Passed The description explains the documentation changes and provides verification results, but it omits the template's checklist section.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch inbox-patch/fix-stale-profiles-doc-links-898c2aa6168aadd6

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor marked this pull request as ready for review August 17, 2026 16:45
@norrietaylor
norrietaylor requested a review from a team as a code owner August 17, 2026 16:45
@norrietaylor
norrietaylor merged commit f4c021e into main Aug 17, 2026
30 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/fix-stale-profiles-doc-links-898c2aa6168aadd6 branch August 17, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant