Repository navigation
fix: correct dead links to the removed profiles concept page in docs - #1224
norrietaylor merged 2 commits into
Conversation
The profiles concept was removed (superseded by the session config and loadouts), but three concept pages still linked to the deleted profiles.md, rendering as dead links wherever the docs are consumed. Point the packages page at the session concept, since package and env declaration moved from profiles into the [session] block. Drop the profile clauses from the task-sandbox and supply-chain pages, where profiles (and from_profile) no longer apply.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Included review availability: 1 review is currently available. Based on recent review activity, included reviews refill at 5 per hour. 📝 WalkthroughWalkthroughThe documentation now describes package availability and supply-chain composition without profile-based inheritance. Session declarations define session packages, task sandboxes use task and repository-stack packages, and layers compose packages and stacks. ChangesPackage documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This updates stale documentation links and removes outdated profile references without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABMz0kDg
The profiles concept page (docs/concepts/profiles.md) was removed when profiles were superseded by the session config and loadouts, but three concept pages still linked to it, so they render as dead links wherever the docs are published. packages.md now points at the session concept, since package and env declaration moved from profiles into the [session] block (informed by #665). sandboxing.md and software-supply-chain.md drop their profile clauses (including from_profile), which no longer describe the current model.
Verification
cargo fmt --all --check --manifest-path target/Cargo.toml — clean, no drift
cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings — exit 0, no warnings
cargo build --workspace --locked --manifest-path target/Cargo.toml — exit 0
cargo test --workspace --locked --manifest-path target/Cargo.toml — exit 0, 84 suites passed, 0 failed
Note
Fix dead links by removing references to the deleted profiles concept page in docs
Updates three concept pages to remove or replace references to profiles, which no longer have a dedicated docs page. In packages.md, replaces mention of profile-scoped packages with session-scoped packages. In sandboxing.md, removes the bullet about packages from a task's profile being included in the sandbox. In software-supply-chain.md, removes profiles from the list of declarable entities and deletes the related
from_profileexception.Macroscope summarized fd4ce56.
Summary by CodeRabbit