Repository navigation
fix: clarify that Minimal is not a multiplexer and name the loadouts skill in the README - #1399
Conversation
The loadouts material described terminal multiplexers without stating that Minimal is not one, and it did not point to the skill that automates loadout authoring. Add the positioning sentence to the loadout section, name and link the minimal-loadouts skill, and reword the two remaining "multiplexer" mentions so the word appears once.
|
Warning Review limit reached
On-demand reviews are free for the next 4 days. After that, they cost $0.25 per reviewed file. Or wait 59 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe README updates Loadout terminology and explains that users can run tmux or zellij inside the Minimal sandbox. ChangesLoadout documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The README clarification is consistent with the stated Loadout behavior and presents no merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
I’m a rabbit with a tidy Loadout today Comment |
|
This PR has merge conflicts with its base branch ( Conflicted files:
Reason it's not trivial: both sides edit the same paragraph differently — the PR removes "terminal multiplexer" from the loadout description and adds a "Minimal is not a multiplexer" sentence, while Recommended action: rebase or merge manually, then remove the
|
…ltiplexer-positioning-bedba3007035ccf6 # Conflicts: # README.md
There was a problem hiding this comment.
minimal-review — advisory review
Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.
Scope matches the title: a README-only wording change that positions Minimal as not a multiplexer and names the minimal-loadouts skill, exactly one file touched. Clobber none: git log on README.md shows the change commit 9eac45d is the PR's own; the merge into c470798 adapted the new sentence cleanly to the #1346 loadout.toml wording already on origin/main instead of overwriting it. Correctness docs-only, so nothing to compile — checked by reading. The new skill link resolves (gominimal/minimal-skills skills/minimal-loadouts/SKILL.md exists), and the stated goal of making "multiplexer" appear exactly once is met (grep -c -i multiplexer README.md → 1). The one issue below is a stylistic echo: the new sentence lifts the closing catchphrase of the intro paragraph verbatim, so that phrase now appears twice in the README. Not checked: nothing needed a build.
What ran
4 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.
Verification log
1. grep -n 'muscle memory you have earned' README.md — exit 0 · self-reported
Two hits: line 36 (pre-existing intro sentence, only 'terminal multiplexers'->'shells' changed there) and line 162, the new sentence added by this PR. The distinctive catchphrase is now duplicated across the doc.
2. grep -c -i 'multiplexer' README.md — exit 0 · self-reported
Count is 1 (line 161), confirming the PR body's claim that the reorder leaves the word appearing exactly once.
3. WebFetch https://github.com/gominimal/minimal-skills/tree/main/skills/minimal-loadouts — self-reported
Path exists; contains SKILL.md, no 404/redirect. The new link in the README is not broken. The SKILL.md is a reference guide for agents authoring/selecting loadouts, so 'the skill automates authoring one' is a fair characterization, not a finding.
4. git log --oneline -15 -- README.md && git log --format='%H %P' c470798 — exit 0 · self-reported
Head merges the PR commit 9eac45d with af90016 (#1394); no recent README fix is reverted. The diff's adapted '/loadout.toml' clause tracks #1346 already on main, not a silent revert.
minimal-review · schema minimal-review/v1 · persona generalist · model deepseek/deepseek-v4-flash-0731:nitro via claude-code unknown · prompt review-prompt/v2 · head c4707983d98b · verdict COMMENT · 1 finding(s), 1 inline
Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.
Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".
| config, and dotfiles. Minimal is not a multiplexer: run tmux or zellij inside | ||
| the box, from your loadout, and keep the muscle memory you have earned. |
There was a problem hiding this comment.
NIT · style · confidence 0.55
The new sentence reuses the intro paragraph's closing phrase verbatim: 'keep the muscle memory you have earned' now appears twice in the README (line 36 and here). For a PR whose stated purpose is tightening repeated copy ('so the word [multiplexer] appears exactly once'), introducing a second occurrence of this distinctive catchphrase undercuts that. Consider ending the new sentence at 'from your loadout' instead.
What the reviewer checked
README.md:162 "the box, from your loadout, and keep the muscle memory you have earned." — echoes README.md:36 "...while you keep the muscle memory you have earned."
Hand this to an agent
Act on a code-review finding.
File: README.md
Lines: 161-162
Category: style
Severity: nit (reviewer confidence 0.55)
Finding:
The new sentence reuses the intro paragraph's closing phrase verbatim: 'keep the muscle memory you have earned' now appears twice in the README (line 36 and here). For a PR whose stated purpose is tightening repeated copy ('so the word [multiplexer] appears exactly once'), introducing a second occurrence of this distinctive catchphrase undercuts that. Consider ending the new sentence at 'from your loadout' instead.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
There was a problem hiding this comment.
minimal-review — advisory review
Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.
Scope matches the title and body exactly: a single-file, docs-only change to README.md that (a) rewords the intro's 'terminal multiplexers' to 'shells', (b) repositions the loadout copy around 'Minimal is not a multiplexer — run tmux or zellij inside the box, from your loadout', and (c) names and links the minimal-loadouts skill. The loadout TOML example is untouched, and rg -i multiplexer README.md confirms the word now appears exactly once (line 161), as the body claims.
Clobber none. The prior same-intent commit 9eac45d lives only on this PR branch (origin/inbox-patch/readme-multiplexer-positioning-bedba3007035ccf6); 36475b7 (merge-base and base) predates it, so the PR is the first place the change lands on main. The skill link was verified live: https://github.com/gominimal/minimal-skills/tree/main/skills/minimal-loadouts resolves to a directory containing SKILL.md.
Correctness no new findings. The one nit this review would otherwise raise — the distinctive catchphrase 'keep the muscle memory you have earned' now appears twice (intro line 36 and the new loadout sentence line 162), mildly undercutting a PR whose purpose is tightening repeated copy — is already an open thread on this PR (.review/threads.json), so it is not re-raised here. Worth noting to the author: that thread is still unresolved and would be worth addressing (e.g. ending the new sentence at 'from your loadout'). Not checked: nothing needed a build; the Rust verification steps in the PR body are irrelevant to a prose-only change.
What ran
4 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.
Verification log
1. rg -n -i 'multiplexer|muscle memory|zellij|tmux' README.md — exit 0 · self-reported
'multiplexer' occurs exactly once (line 161) as the PR claims; 'keep the muscle memory you have earned' occurs at both line 36 and line 162.
2. WebFetch https://github.com/gominimal/minimal-skills/tree/main/skills/minimal-loadouts — self-reported
URL resolves to a live directory titled 'minimal-skills/skills/minimal-loadouts at main' containing a single SKILL.md file — the new README link is not a 404.
3. git log --oneline -8 -- README.md; git branch -a --contains 9eac45d; git merge-base HEAD 36475b7 — exit 0 · self-reported
The earlier same-intent commit 9eac45d is contained only in the PR branch; base 36475b7 is an ancestor of HEAD, so the change has never landed on main and nothing recent is overwritten.
4. Read .review/threads.json — self-reported
A github-actions thread (unresolved) already flags the duplicated 'keep the muscle memory you have earned' phrase at README.md:162; not re-raised per the threads contract.
minimal-review · schema minimal-review/v1 · persona generalist · model deepseek/deepseek-v4-flash-0731:nitro via claude-code · prompt review-prompt/v2 · head fb0729221183 · verdict COMMENT · 0 finding(s), 0 inline
Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.
Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABQwZrUA
The README loadouts material described "terminal multiplexers" twice but never stated what Minimal is not, and it did not name the skill that automates loadout authoring. This adds a sentence positioning Minimal as not a multiplexer — run tmux or zellij inside the box, from your loadout — names and links the
minimal-loadoutsskill in the loadout section, and rewords the two prior "multiplexer" mentions so the word now appears exactly once. Docs-only; the loadout TOML example is untouched.Verification
cargo fmt --all --check --manifest-path target/Cargo.toml— clean, no driftcargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings— passed, no warnings (8m23s)cargo build --workspace --locked --manifest-path target/Cargo.toml— passed (3m20s)cargo test --workspace --locked --manifest-path target/Cargo.toml— passed, 85 suites ok, 0 failedSummary by CodeRabbit