Skip to content

fix: clarify that Minimal is not a multiplexer and name the loadouts skill in the README - #1399

Merged
norrietaylor merged 3 commits into
mainfrom
inbox-patch/readme-multiplexer-positioning-bedba3007035ccf6
Sep 16, 2026
Merged

norrietaylor merged 3 commits into
mainfrom
inbox-patch/readme-multiplexer-positioning-bedba3007035ccf6

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABQwZrUA

The README loadouts material described "terminal multiplexers" twice but never stated what Minimal is not, and it did not name the skill that automates loadout authoring. This adds a sentence positioning Minimal as not a multiplexer — run tmux or zellij inside the box, from your loadout — names and links the minimal-loadouts skill in the loadout section, and rewords the two prior "multiplexer" mentions so the word now appears exactly once. Docs-only; the loadout TOML example is untouched.

Verification

  • cargo fmt --all --check --manifest-path target/Cargo.toml — clean, no drift
  • cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings — passed, no warnings (8m23s)
  • cargo build --workspace --locked --manifest-path target/Cargo.toml — passed (3m20s)
  • cargo test --workspace --locked --manifest-path target/Cargo.toml — passed, 85 suites ok, 0 failed

Summary by CodeRabbit

  • Documentation
    • Updated the README to describe Loadouts as layering editors and shells.
    • Clarified that the Minimal Loadout is not a terminal multiplexer.
    • Added guidance for running tmux or zellij inside the sandbox from a Loadout.

The loadouts material described terminal multiplexers without stating
that Minimal is not one, and it did not point to the skill that
automates loadout authoring. Add the positioning sentence to the
loadout section, name and link the minimal-loadouts skill, and reword
the two remaining "multiplexer" mentions so the word appears once.
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner September 14, 2026 14:39
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 4 days. After that, they cost $0.25 per reviewed file.

Or wait 59 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 20411dae-4e28-48d6-9df5-c7d404f9258d

📥 Commits

Reviewing files that changed from the base of the PR and between 9eac45d and fb07292.

📒 Files selected for processing (1)
  • README.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: e6c1a73a-5eeb-4967-b6dd-35bb26227271

📥 Commits

Reviewing files that changed from the base of the PR and between c6cc5fe and 9eac45d.

📒 Files selected for processing (1)
  • README.md

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The README updates Loadout terminology and explains that users can run tmux or zellij inside the Minimal sandbox.

Changes

Loadout documentation

Layer / File(s) Summary
Clarify Loadout behavior
README.md
The Loadout overview now refers to personal editors and shells. The documentation states that Minimal is not a multiplexer, directs users to run tmux or zellij inside the sandbox, and links to the minimal-loadouts skill.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: msample

Merge Risk: ⚪ Minimal · up to 9eac4

The README clarification is consistent with the stated Loadout behavior and presents no merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the README documentation change: it clarifies that Minimal is not a multiplexer and names the loadouts skill. It uses a suitable Conventional Commit format.
Description check ✅ Passed The description explains the documentation changes and includes verification commands with results. It omits the template's Checklist section, but the required summary and testing information are pres…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch inbox-patch/readme-multiplexer-positioning-bedba3007035ccf6

I’m a rabbit with a tidy Loadout today
Editors and shells now lead the way
Tmux hops inside the sandbox bright
Zellij joins for terminal delight
The skill link helps each setup grow
Documentation guides the flow

Comment @coderabbitai help to get the list of available commands.

@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Sep 14, 2026
@gominimal-aw-bot gominimal-aw-bot Bot added the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Sep 16, 2026
@gominimal-aw-bot

Copy link
Copy Markdown
Contributor Author

This PR has merge conflicts with its base branch (main) that need human resolution.

Conflicted files:

  • README.md

Reason it's not trivial: both sides edit the same paragraph differently — the PR removes "terminal multiplexer" from the loadout description and adds a "Minimal is not a multiplexer" sentence, while main keeps "terminal multiplexer" in that position and expands the loadout-path text. These are not disjoint additions; the same lines are edited differently by both sides.

Recommended action: rebase or merge manually, then remove the needs-human label so this chore re-evaluates.

Generated by PR conflict resolver (side-repo-ops operator) · ◷

…ltiplexer-positioning-bedba3007035ccf6

# Conflicts:
#	README.md

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.

Scope matches the title: a README-only wording change that positions Minimal as not a multiplexer and names the minimal-loadouts skill, exactly one file touched. Clobber none: git log on README.md shows the change commit 9eac45d is the PR's own; the merge into c470798 adapted the new sentence cleanly to the #1346 loadout.toml wording already on origin/main instead of overwriting it. Correctness docs-only, so nothing to compile — checked by reading. The new skill link resolves (gominimal/minimal-skills skills/minimal-loadouts/SKILL.md exists), and the stated goal of making "multiplexer" appear exactly once is met (grep -c -i multiplexer README.md → 1). The one issue below is a stylistic echo: the new sentence lifts the closing catchphrase of the intro paragraph verbatim, so that phrase now appears twice in the README. Not checked: nothing needed a build.

What ran

4 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.

Verification log

1. grep -n 'muscle memory you have earned' README.md — exit 0 · self-reported

Two hits: line 36 (pre-existing intro sentence, only 'terminal multiplexers'->'shells' changed there) and line 162, the new sentence added by this PR. The distinctive catchphrase is now duplicated across the doc.

2. grep -c -i 'multiplexer' README.md — exit 0 · self-reported

Count is 1 (line 161), confirming the PR body's claim that the reorder leaves the word appearing exactly once.

3. WebFetch https://github.com/gominimal/minimal-skills/tree/main/skills/minimal-loadouts — self-reported

Path exists; contains SKILL.md, no 404/redirect. The new link in the README is not broken. The SKILL.md is a reference guide for agents authoring/selecting loadouts, so 'the skill automates authoring one' is a fair characterization, not a finding.

4. git log --oneline -15 -- README.md && git log --format='%H %P' c470798 — exit 0 · self-reported

Head merges the PR commit 9eac45d with af90016 (#1394); no recent README fix is reverted. The diff's adapted '/loadout.toml' clause tracks #1346 already on main, not a silent revert.


minimal-review · schema minimal-review/v1 · persona generalist · model deepseek/deepseek-v4-flash-0731:nitro via claude-code unknown · prompt review-prompt/v2 · head c4707983d98b · verdict COMMENT · 1 finding(s), 1 inline

Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.

Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".

Comment thread README.md
Comment on lines +161 to +162
config, and dotfiles. Minimal is not a multiplexer: run tmux or zellij inside
the box, from your loadout, and keep the muscle memory you have earned.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT · style · confidence 0.55

The new sentence reuses the intro paragraph's closing phrase verbatim: 'keep the muscle memory you have earned' now appears twice in the README (line 36 and here). For a PR whose stated purpose is tightening repeated copy ('so the word [multiplexer] appears exactly once'), introducing a second occurrence of this distinctive catchphrase undercuts that. Consider ending the new sentence at 'from your loadout' instead.

What the reviewer checked

README.md:162 "the box, from your loadout, and keep the muscle memory you have earned." — echoes README.md:36 "...while you keep the muscle memory you have earned."

Hand this to an agent
Act on a code-review finding.

File:       README.md
Lines:      161-162
Category:   style
Severity:   nit (reviewer confidence 0.55)

Finding:
The new sentence reuses the intro paragraph's closing phrase verbatim: 'keep the muscle memory you have earned' now appears twice in the README (line 36 and here). For a PR whose stated purpose is tightening repeated copy ('so the word [multiplexer] appears exactly once'), introducing a second occurrence of this distinctive catchphrase undercuts that. Consider ending the new sentence at 'from your loadout' instead.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.

Scope matches the title and body exactly: a single-file, docs-only change to README.md that (a) rewords the intro's 'terminal multiplexers' to 'shells', (b) repositions the loadout copy around 'Minimal is not a multiplexer — run tmux or zellij inside the box, from your loadout', and (c) names and links the minimal-loadouts skill. The loadout TOML example is untouched, and rg -i multiplexer README.md confirms the word now appears exactly once (line 161), as the body claims.

Clobber none. The prior same-intent commit 9eac45d lives only on this PR branch (origin/inbox-patch/readme-multiplexer-positioning-bedba3007035ccf6); 36475b7 (merge-base and base) predates it, so the PR is the first place the change lands on main. The skill link was verified live: https://github.com/gominimal/minimal-skills/tree/main/skills/minimal-loadouts resolves to a directory containing SKILL.md.

Correctness no new findings. The one nit this review would otherwise raise — the distinctive catchphrase 'keep the muscle memory you have earned' now appears twice (intro line 36 and the new loadout sentence line 162), mildly undercutting a PR whose purpose is tightening repeated copy — is already an open thread on this PR (.review/threads.json), so it is not re-raised here. Worth noting to the author: that thread is still unresolved and would be worth addressing (e.g. ending the new sentence at 'from your loadout'). Not checked: nothing needed a build; the Rust verification steps in the PR body are irrelevant to a prose-only change.

What ran

4 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.

Verification log

1. rg -n -i 'multiplexer|muscle memory|zellij|tmux' README.md — exit 0 · self-reported

'multiplexer' occurs exactly once (line 161) as the PR claims; 'keep the muscle memory you have earned' occurs at both line 36 and line 162.

2. WebFetch https://github.com/gominimal/minimal-skills/tree/main/skills/minimal-loadouts — self-reported

URL resolves to a live directory titled 'minimal-skills/skills/minimal-loadouts at main' containing a single SKILL.md file — the new README link is not a 404.

3. git log --oneline -8 -- README.md; git branch -a --contains 9eac45d; git merge-base HEAD 36475b7 — exit 0 · self-reported

The earlier same-intent commit 9eac45d is contained only in the PR branch; base 36475b7 is an ancestor of HEAD, so the change has never landed on main and nothing recent is overwritten.

4. Read .review/threads.json — self-reported

A github-actions thread (unresolved) already flags the duplicated 'keep the muscle memory you have earned' phrase at README.md:162; not re-raised per the threads contract.


minimal-review · schema minimal-review/v1 · persona generalist · model deepseek/deepseek-v4-flash-0731:nitro via claude-code · prompt review-prompt/v2 · head fb0729221183 · verdict COMMENT · 0 finding(s), 0 inline

Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.

Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".

@norrietaylor
norrietaylor merged commit e740e8e into main Sep 16, 2026
33 checks passed
@norrietaylor
norrietaylor deleted the inbox-patch/readme-multiplexer-positioning-bedba3007035ccf6 branch September 16, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants