Skip to content

[worker:coverage] cover Error::report_to AttrTooDeep branch - #1413

Merged
gominimal-aw-bot[bot] merged 1 commit into
mainfrom
chore/coverage-decode-error-report-to-0b9b9c440dd9c283
Sep 16, 2026
Merged

gominimal-aw-bot[bot] merged 1 commit into
mainfrom
chore/coverage-decode-error-report-to-0b9b9c440dd9c283

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Adds a unit test covering the AttrTooDeep variant of decode::error::Error::report_to, the one branch of the method not previously exercised. The test asserts the rendered output contains the "nested too deeply" headline and the configured max depth.

Verification

  • cargo build --workspace --all-targets passed.
  • cargo test -p decode --lib passed (70 tests).
  • cargo fmt --all applied.
  • Host backstop gates (fmt-check, build --locked, clippy -D warnings, test) run before the PR opens.

Closes #1388

Generated by Chore-issue worker agent (side-repo-ops operator) · ⊞ 26.6K · ◷

Summary by CodeRabbit

  • Tests
    • Added coverage verifying that excessive attribute nesting errors include both the nesting-depth details and the configured maximum depth.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner September 16, 2026 22:47
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Sep 16, 2026
@gominimal-aw-bot
gominimal-aw-bot Bot enabled auto-merge (squash) September 16, 2026 22:47
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Sep 16, 2026
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 46bee0d3-f169-4f4e-a884-24d9ad3ae5b8

📥 Commits

Reviewing files that changed from the base of the PR and between 5f36593 and 24f7210.

📒 Files selected for processing (1)
  • crates/decode/src/error.rs

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The change adds a unit test for Error::AttrTooDeep. The test verifies that formatted output includes the nesting-depth message and the configured maximum depth.

Changes

Decode error reporting

Layer / File(s) Summary
Attribute depth error output
crates/decode/src/error.rs
Adds attr_too_deep_reports_max_depth, which checks output for the nesting-depth message and maximum depth 42.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: 0chroma

Merge Risk: ⚪ Minimal · up to 24f72

The added test improves coverage of attribute-depth error reporting and introduces no merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #1388 requests coverage for decode::error::Error::report_to across its error variants and branches. The PR adds one test for Error::AttrTooDeep only. That test checks nested too deeply and… Add unit tests that exercise the remaining relevant Error::report_to variants and assert their user-facing output contains the expected error names, fields, and positions without depending on exact formatting.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the coverage change for the AttrTooDeep branch of Error::report_to. It is concise and directly related to the pull request.
Description check ✅ Passed The description explains the change, states the verification performed, and references the linked issue. It does not use the template's exact ## Summary, ## Testing, and ## Checklist headings, a…
Out of Scope Changes check ✅ Passed The only change is a focused unit test in crates/decode/src/error.rs. The test directly supports issue #1388 by covering the AttrTooDeep reporting branch.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.
Full details: Linked Issues check

Explanation

Issue #1388 requests coverage for decode::error::Error::report_to across its error variants and branches. The PR adds one test for Error::AttrTooDeep only. That test checks nested too deeply and 42, but the reviewed changes do not add coverage for the other variants and output fields described in the issue.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/coverage-decode-error-report-to-0b9b9c440dd9c283

A rabbit checks the depth with care
Forty-two is written there
The nesting message stands in view
A tiny test confirms it true
Ears perk up; the error’s clear

Comment @coderabbitai help to get the list of available commands.

@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Sep 16, 2026
@gominimal-aw-bot
gominimal-aw-bot Bot merged commit 43183a4 into main Sep 16, 2026
32 checks passed
@gominimal-aw-bot
gominimal-aw-bot Bot deleted the chore/coverage-decode-error-report-to-0b9b9c440dd9c283 branch September 16, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent:coverage: decode::error::Error::report_to is untested (regions=222)

1 participant