Repository navigation
spec: package verification — min pkg verify, fail-closed pulls, a Sigstore bundle on every artifact (inbox#721) - #1585
bryan-minimal wants to merge 1 commit into
Conversation
…store bundle on every artifact (inbox#721) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Spec lint
Advisory. None of this blocks the merge; the review decides. Advisory, and never a merge gate. Linter: |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Reading This comment updates when the review finishes. |
|
Replaced by #1586: same spec, one commit with a conforming Conventional Commits header (commitlint rejected |
Spec for the package-verification epic gominimal/inbox#721 (supersedes inbox#348):
min pkg verify, fail-closed pulls, and a Sigstore bundle on every artifact's provenance.Bound to
architecture.md@ faccc370: D3 (supply chain and verification), D3.1, "What verified means" (a)–(d), thepkgcommand tree, exit codes 4 and 6, Security & Compliance use cases 1–3 and 5, AT2. Two rulings requested from the architecture in gominimal/arch#91 (well-known trust-root URL + meta-key custody; stating the post-quantum plane); the spec carries them as open questions and keeps PKV-015 attier: noneuntil then.Shape: 20 requirements, PKV-001..020. Two signature planes: the Sigstore bundle (index today, provenance statement per artifact after build-servers#185) as the interoperable plane an auditor verifies with stock
cosignv3; the KMS DSSE envelope (ECDSA P-256 + ML-DSA-65) as the post-quantum planeminverifies against a vendored, append-only trust root. Index first, always; fail closed on a required plane's absence; threshold over distinct trusted keys, never first-valid; byte-exact PAE; a cache miss is exit 4, not a verification failure.Process: foundry
spec@0.7.0template and linter (18 findings, all P004 named-test-not-found, the expected pre-implementation state); stories transcribed byte-for-byte from the epic; interview held; adversarial review against the architecture, the producer'sdsse.rs/provenance.rs/commit_index.rs,rcacheand the related issues produced 18 confirmed findings, all applied (notably: the sealed map is unsigned so nothing gates on it;commitis reported not asserted because identical rebuilds are never re-uploaded; the RFC 3161 timestamp is the signing time on Rekor v2; the KMS key-window check is self-asserted until build-servers#95; object names follow #185; a newbundledmap state instead of redefiningsigned).Related: build-servers#185, #230, #322, #329, #332, #338, #86; inbox#582, #583.
🤖 Generated with Claude Code
Summary by CodeRabbit