Skip to content

chore(agent-verify): scope clippy to the touched crates - #1674

Merged
norrietaylor merged 1 commit into
mainfrom
chore/agent-verify-scoped-clippy
Sep 24, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
chore/agent-verify-scoped-clippy

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Scopes agent-verify's clippy to the crates the coder touched, with the same -p flags nextest already takes from MINIMAL_CHANGED_PATHS. With no touched crate it still runs over the workspace.

Why. A cold workspace clippy alone ran 9 m 10 s of the gate's 600 s on #1673 and the gate was stopped before nextest began, so a tree every CI lane passed opened as a draft. -p still checks every dependency of the touched crates, so a warning there is still caught; what it skips is the crates nothing in the change reaches.

Companion on the runtime side raises the verify budget from 600 s to 1800 s (agent-runtime, branch fix/verify-wall-clock-1800).

Verified: the TOML parses and the flag derivation yields -p minimal for a change under crates/minimal/ beside a docs path.

Summary by CodeRabbit

  • Chores
    • Clippy checks now focus on crates affected by the changes. If no changed crates are identified, checks still run across the entire workspace.

A cold workspace clippy alone ran 9 m 10 s of the gate's 600 s on #1673
and the gate was stopped before nextest began, so a green tree opened as
a draft. Clippy now takes the same -p flags nextest already does; with no
touched crate it still runs over the workspace. -p checks every
dependency of the touched crates, so a warning there is still caught.
Copilot AI lite review requested due to automatic review settings September 24, 2026 06:15
@norrietaylor
norrietaylor requested a review from a team as a code owner September 24, 2026 06:15
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 6aaff172-b776-4acb-ae44-c7269b37bae5

📥 Commits

Reviewing files that changed from the base of the PR and between 24dd6f2 and 35b88c3.

📒 Files selected for processing (1)
  • .minimal/minimal.toml

Included review availability: Your plan provides up to 5 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The agent-verify task now derives crate names from MINIMAL_CHANGED_PATHS and passes them to Clippy as package filters. If it finds no crate names, Clippy runs across the workspace.

Changes

Clippy verification

Layer / File(s) Summary
Package-scoped Clippy
.minimal/minimal.toml
The task builds package filters before running Clippy. If no crate names are found, the filters are empty and Clippy runs across the workspace. Comments describe this behavior and its runtime context.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: evanspearman

Merge Risk: ⚪ Minimal · up to 35b88

No actionable regression was established in the Clippy scoping change; it is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: scoping Clippy to the crates touched by the change. It follows the repository's Conventional Commit format.
Description check ✅ Passed The description explains the change, motivation, fallback behavior, validation performed, and related runtime work. It does not use the template's explicit Summary, Testing, and Checklist headings, an…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the crates in view
Then calls the Clippy crew
If paths name none, the workspace goes
The comments tell how that flow goes
The rabbit hops, its checks complete

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 35b88c3146a1.

Nothing to do.

Clobber: none: git log on .minimal/minimal.toml shows this is the direct follow-up to 25d38aaa (which introduced the touched-crate scoping for nextest); nothing reverted. No dependency moves (Cargo.toml/Cargo.lock untouched), no secrets in the diff.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

What changed in this PR

Scopes agent-verify Clippy and nextest checks to crates touched by the agent, with workspace-wide fallback when none are detected.

Changes:

  • Derives deduplicated Cargo package flags from MINIMAL_CHANGED_PATHS.
  • Applies them to Clippy and nextest.
File Description
.minimal/​minimal.toml Updates agent verification command scoping.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Sep 24, 2026
@norrietaylor
norrietaylor enabled auto-merge (squash) September 24, 2026 06:22
@norrietaylor
norrietaylor merged commit 6356668 into main Sep 24, 2026
34 checks passed
@norrietaylor
norrietaylor deleted the chore/agent-verify-scoped-clippy branch September 24, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants