Repository navigation
chore(agent-verify): scope clippy to the touched crates - #1674
Conversation
A cold workspace clippy alone ran 9 m 10 s of the gate's 600 s on #1673 and the gate was stopped before nextest began, so a green tree opened as a draft. Clippy now takes the same -p flags nextest already does; with no touched crate it still runs over the workspace. -p checks every dependency of the touched crates, so a warning there is still caught.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 5 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe ChangesClippy verification
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable regression was established in the Clippy scoping change; it is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the crates in view Comment |
|
Approved: no findings at Nothing to do. Clobber: none: |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Scopes agent-verify Clippy and nextest checks to crates touched by the agent, with workspace-wide fallback when none are detected.
Changes:
- Derives deduplicated Cargo package flags from
MINIMAL_CHANGED_PATHS. - Applies them to Clippy and nextest.
| File | Description |
|---|---|
.minimal/minimal.toml |
Updates agent verification command scoping. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Scopes
agent-verify's clippy to the crates the coder touched, with the same-pflags nextest already takes fromMINIMAL_CHANGED_PATHS. With no touched crate it still runs over the workspace.Why. A cold workspace clippy alone ran 9 m 10 s of the gate's 600 s on #1673 and the gate was stopped before nextest began, so a tree every CI lane passed opened as a draft.
-pstill checks every dependency of the touched crates, so a warning there is still caught; what it skips is the crates nothing in the change reaches.Companion on the runtime side raises the verify budget from 600 s to 1800 s (agent-runtime, branch
fix/verify-wall-clock-1800).Verified: the TOML parses and the flag derivation yields
-p minimalfor a change undercrates/minimal/beside a docs path.Summary by CodeRabbit