Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ Verified against the current tree; sources in parentheses.
resolutions. The fetch scripts warn explicitly: do not run it as part of
artifact fetching (`scripts/fetch-libkrun.sh`).
- **Initramfs features come from the `FEATURES` env.**
`scripts/build-initramfs.sh` compiles the guest `minimald` with
`FEATURES` (empty by default; the justfile passes `networking-proxy`).
Calling the script directly yields a guest daemon without networking
features; with a prebuilt `MINIMALD_BIN`, `TARGET`/`FEATURES` are ignored.
`scripts/build-initramfs.sh` still honours `FEATURES` when it compiles the
guest `minimald`, but the justfile passes none, so every guest daemon the
recipes ship carries the default feature set; with a prebuilt
`MINIMALD_BIN`, `TARGET`/`FEATURES` are ignored.
- **macOS `--output` must stay under the repo.** On macOS the `minimal` shim
runs the CLI inside a VM and only syncs the project dir back to the host,
so `materialize --output` paths outside the repo tree are not visible to
Expand Down
130 changes: 0 additions & 130 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,7 @@ rand = "0.10"
rand_core = { version = "0.6", features = ["getrandom"] }
rayon = "1.12"
ratatui = "0.30"
rcgen = { version = "0.14", default-features = false, features = ["crypto", "pem", "ring"] }
regex = "1" # keep in sync with nickel-lang-core
rustls = { version = "0.23", default-features = false, features = ["ring", "logging", "std"] }
tokio-rustls = { version = "0.26", default-features = false, features = ["ring", "logging"] }
reqwest = { version = "0.13.4", features = ["stream"], default-features = false } # keep in sync with google-cloud-gax
rustc-hash = "2.1.3"
serde = { version = "1.0", features = ["derive", "rc"] } # Keep within the same minor version as nickel-lang-core
Expand Down
6 changes: 3 additions & 3 deletions crates/minimal/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ name = "min"
path = "src/main.rs"

[features]
# Off by default: gates the `mesh` and `ssh-forward` CLI subcommands. WireGuard
# mesh (UC7 / UC2b-A) and the SSH port-forward fallback are deferred for now; the
# daemon-side `direct-tcpip` handler is behind minimald's `ssh-forward` feature.
# Off by default: gates the `mesh` CLI subcommand. WireGuard mesh (UC7 / UC2b-A)
# is deferred for now; the daemon-side `direct-tcpip` handler needs no feature
# and is served in every build.
remote-access = []

[dependencies]
Expand Down
12 changes: 0 additions & 12 deletions crates/minimal/src/cmd/list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ pub async fn cmd_ls(global: &GlobalArgs, args: LsArgs) -> Result<(), anyhow::Err
// is exactly what will go on using hostnames that no longer resolve — and
// stdout stays clean for the parser either way.
warn_if_hostname_routing_down(resp.hostname_routing_unavailable.as_deref(), "min ls");
warn_if_mtls_proxy_down(resp.mtls_proxy_unavailable.as_deref());
format_ls(&mut std::io::stdout(), &args, &resp)?;
Ok(())
}
Expand Down Expand Up @@ -351,17 +350,6 @@ pub(crate) fn warn_if_hostname_routing_down(reason: Option<&str>, command: &str)
}
}

/// Tells the user the mTLS reverse proxy is not serving, and why.
///
/// Kept separate from [`warn_if_hostname_routing_down`] so the two faults read
/// as what they are: hostnames failing to resolve and TLS termination being
/// absent are different problems with different fixes.
pub(crate) fn warn_if_mtls_proxy_down(reason: Option<&str>) {
if let Some(reason) = reason {
eprintln!("warning: the mTLS reverse proxy is not serving: {reason}");
}
}

/// Format the session list for the given output mode. Split from
/// [`cmd_ls`] so integration tests can capture output into a buffer
/// instead of stdout.
Expand Down
1 change: 0 additions & 1 deletion crates/minimal/src/cmd/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ pub(crate) async fn activate_session(
created.hostname_routing_unavailable.as_deref(),
"min session activate",
);
warn_if_mtls_proxy_down(created.mtls_proxy_unavailable.as_deref());
let id = created.id;

// From here the session exists on the daemon in an unfinalized state.
Expand Down
Loading
Loading