Repository navigation
T43 — Own the proxy's switch address from a host-side stack peer of the switch #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
norrietaylor
wants to merge
8
commits into
main
from
agent/1652-own-the-proxy-s-switch-address-from-a-host-side
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9726b68
feat(switch): add box egress proxy address above the ptask lease pool
minimal-foundry[bot] 9063324
feat(minimald,minvmd): the coder's uncommitted work as it stood when …
minimal-foundry[bot] 2884cc3
Merge remote-tracking branch 'origin/main' into agent/1652-own-the-pr…
minimal-foundry[bot] 1a5c7e0
fix(minvmd): let the proxy peer's poll loop exit when the peer drops
minimal-foundry[bot] 901448d
feat(minvmd): keep the proxy peer silent, socketless, and pinned to t…
minimal-foundry[bot] 331342f
feat(minvmd): rate-limit the proxy peer's answer lines
minimal-foundry[bot] 84b2987
test(e2e): drop the unused probe capture in the proxy-MAC case
minimal-foundry[bot] 878cac1
test(minimald): pin the tiny subnet's PTask run below the proxy address
minimal-foundry[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT ·
style· confidence 0.75 · inrun_foregroundThe peer-start event is announced twice for the same occurrence. net.rs:807-811 already logs
box egress proxy peer startedfrom insideHostGvproxy's supervising runtime at the moment the peer is up, andrun_foregroundlogshost gvproxy switch up; box egress proxy peer startedimmediately whenHostGvproxy::spawnreturns — the same event, two info lines per boot. The run.rs line is redundant with the net.rs one and can drift if the peer-start timing changes (e.g. if the peer is later moved to a path that doesn't run inHostGvproxy). Drop theproxy_ip/proxy_mac/peer phrasing from the run.rs line and keep the net.rs one as the single authoritative announcement.What the reviewer checked
Hand this to an agent
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.