Repository navigation
feat(installer): install a staged version with --version - #1716
Conversation
--version VER (or --version=VER) installs versions/VER/ directly and skips the pointer fetch, so a staged release that no channel points at can be tested without writing a private pointer. The value takes the same charset and dot-segment guard as a fetched version, and cannot be combined with a target. Co-Authored-By: Claude <noreply@anthropic.com>
Spec lint
Advisory. None of this blocks the merge; the review decides. Advisory, and never a merge gate. Linter: |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 5 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe installer adds ChangesDirect Version Installation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~15 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new option installs a staged version without resolving a channel pointer, and the supplied tests cover invalid, missing, conflicting, and unstaged versions. No identified issue requires delaying merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit checks the version flag, Comment |
|
Approved: no findings at Nothing to do. Clobber: none: |
The `--version=VER` form skipped the `''|-*` guard the space form applies, so `--version=` died with a misleading "invalid version" and `--version=--force-stop` was taken as the version and failed only at the manifest fetch. Both forms now die with "needs a value"; R2.5 tests and spec text cover the `=` form. Co-Authored-By: Claude <noreply@anthropic.com>
Summary
install.shaccepts--version VER/--version=VER. It installsversions/VER/directly and fetches no pointer, so testers can install a staged release that no channel points at. Versioned release runs stop movingunstableonce #1712 lands.A-Za-z0-9._-, with.and..rejected. The script exits with an error if the value is missing or is a flag, or if a target (positional orMINIMAL_INSTALL_TARGET_OVERRIDE) is passed too.curl -fsSL https://storage.googleapis.com/minimal-one/versions/X.Y.Z/install.sh | sh -s -- --version X.Y.ZThis only works for versions staged after this merges, because each staged version ships its own
install.sh. The runbook's step 5 keeps the private-pointer route for now. I'll switch it in a follow-up after #1712, which rewrites the same paragraph.Test plan
sh scripts/install_test.sh: 289 passed, 0 failed (macOS sh)dash scripts/install_test.sh: 289 passed, 0 failedshellcheck scripts/install.sh scripts/install_test.sh: clean--version=VERcombined with--force-stop,.., a bad charset, no value, a flag as the value, target plus--version, and an unstaged version.🤖 Generated with Claude Code
Summary by CodeRabbit
--version VERor--version=VER, without resolving a target pointer. This option can be combined with other flags.