Skip to content

T76 — Reserve the local range on the macOS host by the advisory's privileged step - #1825

Merged
norrietaylor merged 24 commits into
mainfrom
agent/1817-reserve-the-local-range-on-the-macos-host-by-the
Oct 3, 2026
Merged

norrietaylor merged 24 commits into
mainfrom
agent/1817-reserve-the-local-range-on-the-macos-host-by-the

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

T76 — Reserve the local range on the macOS host by the advisory's privileged step

slice: S3
kind: task
covers: NET-123
size: M
est: 220 code, 300 tests
executor: agent
difficulty: needs care
model: strongest
diagnostics: the bundle's naming surface records whether the range unit is installed, the owner and mode of its plist and its program, the program path the plist runs, and the custody verdict beside the bind probe's result, so a macOS host still on the 127.0.0.1 interim, or holding a range unit whose custody fails, reads why in a bundle
observability: one info log line at session start naming the range unit's state (absent, installed, or custody failed and which check) beside the probe result and the surface chosen; the advisory stops re-surfacing for the range once the probe reads present and custody holds
layers:
- cli:
- crates/minimal/src/resolver.rs: on macOS the advisory command gains the range step in the same one sudo sh -c that writes the resolver file. The step writes the range program and its LaunchDaemon plist from bytes the command itself carries (no staged file, no user-writable source copied), to /Library/PrivilegedHelperTools/dev.minimal.local-range and /Library/LaunchDaemons/dev.minimal.local-range.plist, owned root:wheel, the program 0755 and the plist 0644, and bootstraps the unit into the system domain so it runs now and, with RunAtLoad and no KeepAlive, at every boot; a re-run boots the old unit out first, so the step is idempotent. The program is rendered from its template with the range's host addresses from switch::loopback::range_hosts filled in at render time, so it reads no argument, environment variable or file, and applies exactly the reserved range 127.0.64.0/24 as /32 lo0 aliases by absolute path (/sbin/ifconfig lo0 alias for host parts 1 to 254, the addresses the bind probe reads) and nothing else. Custody is checked where the hook is detected and covers the path, not just the two files: every directory component of both paths, from / down, is owned by uid 0 with no group or other write (never a path under $HOME or a user-owned Homebrew prefix), both files are owned by uid 0 with no group or other write, the plist's ProgramArguments names the root-owned program path, and the loaded job's Program/ProgramArguments in launchctl print system/dev.minimal.local-range names that same path, so a job loaded from elsewhere under the label fails custody; a failed check re-surfaces the advisory naming the failed check and the command, which reinstalls both files. The comment "The command rendered here does not carry that step yet" and advisory_at's doc line "not yet part of the command it renders here" are replaced: on macOS the interim fact says the command below installs the range and ends the interim, and the command line says it configures the resolver and reserves the range. The privileged step is shared with T71 as one command with two units: the range unit runs as root once per load, and T71's answerer unit runs as the operator under socket activation and must never be root, so neither unit is folded into the other, they share no file, label or program, and whichever of the two tasks lands second appends its step to the same command, which stays one command with exactly one privilege elevation (one sudo), never two invocations the user runs separately; T71's text is not changed. On Linux the command is unchanged: any 127/8 address binds on lo, so Linux takes no range step, and the dedicated link keeps its routable-scope /32 address (ZONE_LINK_ADDR), without which resolved never consults the routing domain. NamingSurface gains the range unit's state and custody verdict for the bundle
- crates/minimal/src/resolver/reserve-local-range.sh (new): the range program's template, a /bin/sh script with no inputs that aliases each host address of the reserved range on lo0 by absolute path and exits non-zero on the first failure
- crates/minimal/src/resolver/dev.minimal.local-range.plist (new): the LaunchDaemon plist template: label dev.minimal.local-range, ProgramArguments the root-owned program path alone, RunAtLoad true, no KeepAlive, no UserName (it runs as root), no EnvironmentVariables
test: cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos
test: cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range
test: cargo nextest run -p minimal range_step_custody_is_root_owned
test: cargo nextest run -p minimal range_step_custody_walks_every_path_component
test: cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once
test: cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory
test: cargo nextest run -p minimal linux_advisory_command_is_unchanged
test: cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step
test: cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos
- docs:
- docs/specs/18-spec-box-networking/18-spec-box-networking.md: NET-123 gains the sub-requirement "WHERE the host is macOS THE SYSTEM SHALL name, in NET-122's advisory command, a privileged step that installs a boot-time service, from root-owned non-user-writable paths and reading no configuration, which applies exactly the reserved local range to the host loopback at install and at every boot", tier T0, verify cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos; its comment says Linux takes no range step and keeps the routing-domain link's address
- e2e:
- scripts/session-e2e.sh: adds the case local_range_reserved_by_privileged_step, a privileged, operator-run case that no CI lane runs: it installs a root LaunchDaemon, and the macOS lane's runner is a persistent shared host that is not given passwordless sudo. Unless MINIMAL_E2E_PRIVILEGED=1 is set it prints SKIPPED (privileged: set MINIMAL_E2E_PRIVILEGED=1 on a macOS host with passwordless sudo) and exits 0; with it set, a missing precondition (not macOS, no launchctl, no passwordless sudo) fails rather than skips (Linux needs no range step, so it is never run there): it runs the advisory's command, asserts both files' custody and that the plist runs the root-owned copy, asserts the bind probe reads present and a session started afterwards publishes from the range with no interim and no advisory, asserts launchctl print system/dev.minimal.local-range shows the job loaded with RunAtLoad true and launchctl print-disabled system does not list it disabled, removes the aliases and kickstarts the unit as a boot would load it to show the range re-applied with no user action, then boots the unit out, removes both files and the aliases
test: ./scripts/session-e2e.sh local_range_reserved_by_privileged_step
produces: none
consumes:
- crates/minimal/src/resolver.rs
- crates/switch/src/loopback.rs
proof: On macOS, the one advisory command configures the resolver and installs a LaunchDaemon whose plist and program sit at root-owned, non-user-writable paths, read no configuration and apply exactly 127.0.64.0/24 as lo0 aliases now and at every boot; afterwards the bind probe the daemon runs at session start, read on the host, reads present, a session publishes from the range, and the 127.0.0.1 interim ends with no prompt; custody (owner root, not user-writable, the plist pointing at the root-owned copy) is checked and a failure re-surfaces the advisory; the range comes back after the unit is loaded again as at boot, the job is loaded and enabled for boot, and both this case and a real reboot are manual checks the PR body records with the date, macOS version and the case's transcript lines from the last by-hand run; in CI the rendered command is proved by the unit tests, which parse it with /bin/sh -n; the Linux command is unchanged, its routing-domain link keeping its routable-scope address.
depends on:
- blocked by #1656
- assumes T71 (#1803) appends its answerer unit to the same privileged command whichever of the two lands second; the range unit shares no file, label or program with it, so neither task blocks the other

Design ruling

Design §7.1 folds the reservation of the local range into the macOS advisory command NET-122 names, but the command the advisory renders today writes only the resolver file. crates/minimal/src/resolver.rs says so itself ("The command rendered here does not carry that step yet"). Until the step exists, a macOS host stays on NET-123's 127.0.0.1 interim, and running the advisory's command never ends it. This task completes the advisory text #1656 (T15) reports from.

The architecture ruling, binding on this task:

  • The macOS advisory command gains the range step.
  • The range step is a LaunchDaemon, with its plist and its program at root-owned, non-user-writable paths. It reads no configuration and applies exactly the reserved range, 127.0.64.0/24, as lo0 aliases, now and at every boot.
  • After the command runs, the session-start bind probe reads present and the 127.0.0.1 interim ends with no prompt.
  • Custody is checked: owner root, not user-writable, and the plist points at the root-owned copy.
  • The range survives a reboot.
  • The task is macOS-only. Linux takes no range step, because any 127/8 address is bindable on lo. The Linux command stays unchanged, and so does the routable-scope address on its dedicated link, which systemd-resolved needs before it consults the routing domain. A test pins the Linux command.

The privileged step is shared with T71 (#1803) as one command with two units. The range unit runs as root, once per load. T71's answerer unit runs as the operator under socket activation and must never be root. Neither unit is folded into the other, and they share no file, label or program. Whichever of the two tasks lands second appends its step to the same command, so neither blocks the other.

Acceptance:

  • on macOS the advisory's one command writes the resolver file and installs the range unit;
  • the installed program reads no argument, environment variable or file and aliases exactly the range's host addresses;
  • the plist and program are owned by root, not user-writable, and the plist runs the root-owned copy, and a failed custody check re-surfaces the advisory;
  • after the command, the bind probe reads present, a session publishes from the range, and no interim or prompt follows;
  • the range comes back when the unit loads again, as it does at boot;
  • the Linux command is byte-for-byte unchanged.

Proof

On macOS, the one advisory command configures the resolver and installs a LaunchDaemon whose plist and program sit at root-owned, non-user-writable paths, read no configuration and apply exactly 127.0.64.0/24 as lo0 aliases now and at every boot; afterwards the bind probe the daemon runs at session start, read on the host, reads present, a session publishes from the range, and the 127.0.0.1 interim ends with no prompt; custody (owner root, not user-writable, the plist pointing at the root-owned copy) is checked and a failure re-surfaces the advisory; the range comes back after the unit is loaded again as at boot, the job is loaded and enabled for boot, and both this case and a real reboot are manual checks the PR body records with the date, macOS version and the case's transcript lines from the last by-hand run; in CI the rendered command is proved by the unit tests, which parse it with /bin/sh -n; the Linux command is unchanged, its routing-domain link keeping its routable-scope address.

Tests

Plan test line Lane / where Result at de2b4cc
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos tests (ci-linux-native, job 111163197924) PASS [ 0.010s] ( 604/2657) minimal resolver::tests::advisory_command_reserves_the_range_on_macos
… range_program_applies_exactly_the_reserved_range same PASS [ 0.011s] ( 619/2657) minimal resolver::tests::range_program_applies_exactly_the_reserved_range
… range_step_custody_is_root_owned same PASS [ 0.009s] ( 621/2657) minimal resolver::tests::range_step_custody_is_root_owned
… range_step_custody_walks_every_path_component same PASS [ 0.010s] ( 623/2657) minimal resolver::tests::range_step_custody_walks_every_path_component
… macos_advisory_command_elevates_exactly_once same PASS [ 0.010s] ( 612/2657) minimal resolver::tests::macos_advisory_command_elevates_exactly_once
… range_step_custody_failure_resurfaces_the_advisory same PASS [ 0.011s] ( 620/2657) minimal resolver::tests::range_step_custody_failure_resurfaces_the_advisory
… linux_advisory_command_is_unchanged same PASS [ 0.011s] ( 608/2657) minimal resolver::tests::linux_advisory_command_is_unchanged
… bind_probe_reads_present_after_the_range_step same PASS [ 0.008s] ( 605/2657) minimal resolver::tests::bind_probe_reads_present_after_the_range_step
… interim_advisory_says_the_command_ends_it_on_macos same PASS [ 0.008s] ( 606/2657) minimal resolver::tests::interim_advisory_says_the_command_ends_it_on_macos

./scripts/session-e2e.sh local_range_reserved_by_privileged_step: CI prints SKIPPED (privileged), by design per the plan; the by-hand run passed, see below.

Out-of-layer file: crates/minimal/src/cmd/session.rs (5 lines) adds range_unit_state and range_unit_check to the session-start info log, which is the plan's observability: line.

Review fixes after the by-hand runs

  • fa8e8f49: file_custody records mode() & 0o7777, so the bundle's range_step modes read 0755/0644, as the struct doc and the bundle test say. The custody verdict is unchanged.
  • c94325d4: launchctl print runs under a 1 s LAUNCHCTL_BOUND with kill_on_drop. A wedged launchd reads as unverified custody instead of hanging min session activate or min ls.

Neither change touches the rendered command or the unit, so the by-hand privileged and reboot checks at de2b4cc9 still apply.

Closes #1817

By-hand checks (head de2b4cc, 2026-10-03, macOS 26.7 25G229, Apple Silicon)

  • Privileged case: MINIMAL_E2E_PRIVILEGED=1 ./scripts/session-e2e.sh local_range_reserved_by_privileged_step passed locally:

    • the unit installed and was enabled;
    • custody held, with root:wheel 0755/0644;
    • all 254 aliases were present once the unit finished;
    • the re-run was clean (last exit code 0);
    • kickstart re-applied the range;
    • the host was restored.

    Transcript of the case, verbatim:

    ::group::local range reserved by the advisory's privileged step (NET-123, macOS)
    ran the advisory's command: resolver file and range unit, one sudo
    custody holds: both files root-owned at 0755/0644, the plist runs the root-owned program
    the reserved range is present on lo0: 254 aliases
    session after the range step: no advisory, no interim, native DNS live — the probe reads present
    the unit is loaded (RunAtLoad, program = the root-owned copy) and enabled for boot
    the command re-runs clean over the aliases it had already applied: last exit code = 0, all 254 still on lo0
    kickstart re-applied the range with no user action, as a boot's load would
    local range reserved by the privileged step OK (unit installed, custody held, probe present, re-run clean, boot re-apply shown, host restored)
    session e2e OK
    
  • Reboot:

    • Before the reboot, only the range program and plist were installed, rendered from this head without the resolver file. The unit was loaded and enabled, and all 254 127.0.64.x aliases were then removed (count 0).
    • After a real reboot (boot at 01:49:51 local), ifconfig lo0 showed 254 aliases. launchctl print system/dev.minimal.local-range showed runs = 1 and last exit code = 0, and the unit was not disabled.
    • Background Task Management recorded it as a "legacy daemon", [enabled, allowed].
    • Afterwards the unit and the aliases were removed, and the host is clean.

…s ran out

the coder's uncommitted work as it stood when its 7200s ran out

The coder was stopped at the end of its time with these changes
not committed. The runtime committed its working tree as it stood so
the work is kept: this commit is a snapshot, not a finished step, and
may not build or pass its tests.
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1251ece-c463-4410-aaf1-071b92932e16

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

…s ran out

the coder's uncommitted work as it stood when its 7200s ran out

The coder was stopped at the end of its time with these changes
not committed. The runtime committed its working tree as it stood so
the work is kept: this commit is a snapshot, not a finished step, and
may not build or pass its tests.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a failed check suite, pushed as 49bb5b44051e.

The coder ran out of its 7200s before it finished. If it left work uncommitted, its last commit is the runtime's snapshot of that work as it stood — the commit message says so — and not a finished step: it may not build or pass its tests.

line exit tail
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos 101 ner/.local/state/minimal/sessions/9a041/tree/crates/mfile) Compiling minimald-rpc v0.0.1 (/home/runner/.local/state/minimal/sessions/9a041/tree/crates/minimald-rpc) Compiling json-subscriber v0.3.0 Compiling object v0.40.0 Compiling is_executable v1.0.6 Compiling opentelemetry-semanti
cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range 101 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-7f70... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/0760a/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/0760a/tree/crate
cargo nextest run -p minimal range_step_custody_is_root_owned 101 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-3e91... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/422cd/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/422cd/tree/crate
cargo nextest run -p minimal range_step_custody_walks_every_path_component 101 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-3dc8... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/adf23/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/adf23/tree/crate
cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once 101 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-08b9... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/29ce5/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/29ce5/tree/crate
cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory 101 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-83e9... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/00780/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/00780/tree/crate
cargo nextest run -p minimal linux_advisory_command_is_unchanged 101 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-4625... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/bf35f/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/bf35f/tree/crate
cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step 101 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-8352... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/abfd4/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/abfd4/tree/crate
cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos 101 Applying loadouts: default Running task runtime-implement-test-8 in session task-runtime-implement-test-8-7e18... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/bb7c2/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/bb7c2/tree/crate
./scripts/session-e2e.sh local_range_reserved_by_privileged_step 1 Applying loadouts: default Running task runtime-implement-test-9 in session task-runtime-implement-test-9-87d2... ::error::no usable 'minimald' on this host: the 'min' this run drives autospawns it by bare name (crates/minimal/src/autospawn.rs), so it must be on PATH — the pair has to come from one

Verify min task run agent-verify exited 101.

ns/95ba6/tree/crates/paths)
   Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/stdlib)
   Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/version)
    Checking switch v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/switch)
   Compiling minvmd v0.7.0 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/minvmd)
    Checking common v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/common)
    Checking diagnostics v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/diagnostics)
    Checking mlog v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/mlog)
    Checking async-dialog v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/async-dialog)
    Checking sessions v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/sessions)
    Checking sandbox2 v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/sandbox2)
    Checking mfile v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/mfile)
    Checking minimald-rpc v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/minimald-rpc)
    Checking checkouts v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/checkouts)
    Checking decode v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/decode)
    Checking minimal-client v0.7.0 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/minimal-client)
    Checking graph v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/graph)
    Checking minimal-tui v0.7.0 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/minimal-tui)
    Checking lcache v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/lcache)
    Checking op v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/op)
    Checking rcache v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/rcache)
    Checking orchestrator v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/orchestrator)
    Checking check v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/check)
    Checking mctx v0.0.1 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/mctx)
    Checking minimal v0.7.0 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/minimal)
    Checking minimald v0.7.0 (/home/runner/.local/state/minimal/sessions/95ba6/tree/crates/minimald)
error: constant `COMMAND_RESERVES_THE_RANGE` is never used
   --> crates/minimal/src/resolver.rs:131:7
    |
131 | const COMMAND_RESERVES_THE_RANGE: bool = false;
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[expect(dead_code)]` or `#[allow(dead_code)]`

error: could not compile `minimal` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Converted to a draft: something above needs a person before review.

On macOS, the one advisory command configures the resolver and installs a LaunchDaemon whose plist and program sit at root-owned, non-user-writable paths, read no configuration and apply exactly 127.0.64.0/24 as lo0 aliases now and at every boot; afterwards the bind probe the daemon runs at session start, read on the host, reads present, a session publishes from the range, and the 127.0.0.1 interim ends with no prompt; custody (owner root, not user-writable, the plist pointing at the root-owned copy) is checked and a failure re-surfaces the advisory; the range comes back after the unit is loaded again as at boot, the job is loaded and enabled for boot, and a real reboot is a manual check the PR body records with the date and macOS version it last ran on; the Linux command is unchanged, its routing-domain link keeping its routable-scope address.

Commit headers reworded by the runtime to fit commitlint. The header the coder wrote is the first paragraph of each of these commits' bodies:

  • feat(minimal): the coder's uncommitted work as it stood when its 7200s ran out

@norrietaylor

Copy link
Copy Markdown
Member

/revise Round 2. Both earlier rounds hit the 7200 s limit, so the branch holds partial work. It changes three files and contains none of the plan's tests. Finish the task to the plan block on #1817. Do these in order, and commit after each step so a timeout cannot lose finished work:

  1. Make the branch compile. In crates/minimal/src/resolver.rs, COMMAND_RESERVES_THE_RANGE is defined twice under cfg(test). This is E0428 in tests. On Linux clippy, the macOS arm is also never used. Gate the two definitions on target_os = "macos" and not(target_os = "macos") only. Tests that need the other platform's text should take the platform as a parameter of the render function, not read the cfg'd constant. Run just fix, then just test.
  2. Write the macOS range step. It goes in the one sudo sh -c the advisory already renders: write the program and plist from bytes the command carries, chown root:wheel, chmod 0755/0644, launchctl bootout then bootstrap system. Add the custody check: every directory component from / down, both files, the plist's ProgramArguments, and launchctl print system/dev.minimal.local-range. Replace the two "not yet" comments. Add the NamingSurface fields and the info line named in the block's observability entry.
  3. Add every test line in the plan block, under its exact name. That is the nine cargo nextest run -p minimal … tests and the e2e case local_range_reserved_by_privileged_step, which fails rather than self-skips on the macOS lane. Also add the NET-123 sub-requirement in docs/specs/18-spec-box-networking/18-spec-box-networking.md.

Leave the Linux command byte-identical (linux_advisory_command_is_unchanged pins it). Do not touch T71's answerer unit.

In the round report, list each plan test line with its result.

The one `sudo sh -c` NET-122's advisory names now carries NET-123's
privileged step (design section 7.1): it writes the range unit's program
and plist from bytes the command itself carries (quoted heredocs, no
staged copy), converges both to root:wheel at 0755/0644, boots the old
unit out and bootstraps the new one into the system domain — so the
range is present on this boot and RunAtLoad re-applies it at every one
after, and a re-run replaces the unit instead of dying on its label.

Detection reads the step beside the hook (RangeStep: absent, installed,
or custody failed with the check that failed) over the full custody
walk: every directory component of both paths from `/` down, both
files' owner and mode, the program path the plist's ProgramArguments
names, and the program path the loaded job names in `launchctl print`
— so files copied in without the unit behind them, or a job loaded
from elsewhere under the label, fail custody. The advisory's quiet arm
now needs custody holding beside the probe's present; a failed check
re-surfaces it naming the check and the command that reinstalls both
files. On macOS the interim fact says the command below installs the
range and ends the interim; the lead-in says the command configures
the resolver and reserves the local range. The Linux command is
byte-identical to the one NET-122 shipped, and takes no range step.

The session-start log line names the range unit's state and failed
check beside the probe result and the surface chosen, and the `min bug`
bundle carries the unit's state, its files' owner and mode, the
program the plist runs, and the custody verdict.
the coder's uncommitted work as it stood when its 7200s ran out

The coder was stopped at the end of its time with these changes
not committed. The runtime committed its working tree as it stood so
the work is kept: this commit is a snapshot, not a finished step, and
may not build or pass its tests.
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/18-spec-box-networking/18-spec-box-networking.md — 20 finding(s)

docs/specs/18-spec-box-networking/18-spec-box-networking.md:159: P004 NET-009 names test 'native_resolution_without_proxy_env', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:213: P004 NET-016 names test 'listen_publishes_permitted_port', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:224: P004 NET-017 names test 'listener_close_withdraws_publication', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:304: P004 NET-040 names test 'fresh_install_own_ip_ingress_publishes_loopback', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:309: P004 NET-041 names test 'installer_switch_binary_executable', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:314: P004 NET-043 names test 'expose_unenrolled_local_rpc_evaluates_dynamic_ingress', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:319: P004 NET-044 names test 'expose_allow_publishes_and_lists', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:328: P004 NET-045 names test 'expose_ask_prompts_attached_human', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:337: P004 NET-046 names test 'expose_unenrolled_decision_audited', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:342: P004 NET-047 names test 'expose_rejected_leaves_no_partial_mapping', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:347: P004 NET-048 names test 'linux_amd64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:352: P004 NET-049 names test 'fresh_linux_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:357: P004 NET-050 names test 'linux_arm64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:362: P004 NET-051 names test 'fresh_arm64_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:570: P004 NET-080 names test 'daemon_fetch_survives_cohort_deny', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:652: P004 NET-139 names test 'vsock_rpc_refuses_non_host_cid', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:669: P004 NET-132 names test 'proxy_sees_each_vm_box_by_its_switch_address', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:682: P004 NET-133 names test 'proxy_attachment_given_before_first_connection', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:695: P004 NET-134 names test 'deny_all_box_reaches_proxy_and_no_other_host_port', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:719: P004 NET-107 names test 'session_outbound_request', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@b913de94, spec format: How Minimal Writes Specs.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 1c2efdc854cd.

The coder ran out of its 7200s before it finished. If it left work uncommitted, its last commit is the runtime's snapshot of that work as it stood — the commit message says so — and not a finished step: it may not build or pass its tests.

line exit tail
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-3cbe... Updating crates.io index Downloading crates ... Downloaded nickel-lang-vector v0.2.0 Downloaded nickel-lang-core v0.19.0 Downloaded nickel-lang-parser v0.4.0 Compiling nick
cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-2c78... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/35fc4/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/35fc4/tree/crate
cargo nextest run -p minimal range_step_custody_is_root_owned 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-26a9... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/434e1/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/434e1/tree/crate
cargo nextest run -p minimal range_step_custody_walks_every_path_component 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-2c38... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/29bac/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/29bac/tree/crate
cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-4f5d... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/bbd3a/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/bbd3a/tree/crate
cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-1152... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/108ac/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/108ac/tree/crate
cargo nextest run -p minimal linux_advisory_command_is_unchanged 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-ba9b... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/e0eb4/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/e0eb4/tree/crate
cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-9fae... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/dcab4/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/dcab4/tree/crate
cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos 0 Applying loadouts: default Running task runtime-implement-test-8 in session task-runtime-implement-test-8-57d2... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/20ed1/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/20ed1/tree/crate
./scripts/session-e2e.sh local_range_reserved_by_privileged_step 1 Applying loadouts: default Running task runtime-implement-test-9 in session task-runtime-implement-test-9-3666... ::error::no usable 'minimald' on this host: the 'min' this run drives autospawns it by bare name (crates/minimal/src/autospawn.rs), so it must be on PATH — the pair has to come from one

Verify min task run agent-verify passed.

Outside the task's layers::

  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

On macOS, the one advisory command configures the resolver and installs a LaunchDaemon whose plist and program sit at root-owned, non-user-writable paths, read no configuration and apply exactly 127.0.64.0/24 as lo0 aliases now and at every boot; afterwards the bind probe the daemon runs at session start, read on the host, reads present, a session publishes from the range, and the 127.0.0.1 interim ends with no prompt; custody (owner root, not user-writable, the plist pointing at the root-owned copy) is checked and a failure re-surfaces the advisory; the range comes back after the unit is loaded again as at boot, the job is loaded and enabled for boot, and a real reboot is a manual check the PR body records with the date and macOS version it last ran on; the Linux command is unchanged, its routing-domain link keeping its routable-scope address.

Commit headers reworded by the runtime to fit commitlint. The header the coder wrote is the first paragraph of each of these commits' bodies:

  • feat: the coder's uncommitted work as it stood when its 7200s ran out

@norrietaylor

Copy link
Copy Markdown
Member

/revise Round 3. The step, the custody checks and all nine unit tests are in. Keep them. This round fixes the rendered macOS command and the e2e assertions only. Scope: crates/minimal/src/resolver.rs, crates/minimal/src/resolver/reserve-local-range.sh, scripts/session-e2e.sh. Leave the Linux command byte-identical, and leave T71's answerer unit alone. The plan block is on #1817.

  1. Make the macOS command parse. reserve-local-range.sh line 5 has an apostrophe ("the range's host addresses"). macos_command wraps everything in sudo sh -c '…', so that apostrophe closes the quote. sh -n and zsh -n both reject the rendered command, and a pasted copy hangs at quote>. Remove every ' from both templates. In advisory_command_reserves_the_range_on_macos, assert that neither heredoc body contains '. Also assert that the command parses: run /bin/sh -n -c <command> from the test, and do the same for the inner payload between the outer quotes.
  2. Fail closed inside the one command. The lines after each heredoc are separate commands, so a failed write does not stop the bootstrap. Start the inner script with set -e; and pin that in the same test.
  3. Fix the e2e's launchctl reads in local_range_reserved_by_privileged_step. launchctl print system/<label> reports RunAtLoad as runatload inside the properties = … | runatload | … line, never as runatload = true. Assert on that line. launchctl print-disabled system rows read "<label>" => enabled|disabled, with the label quoted, so the current awk never matches and the check always passes. Match the quoted label and fail on disabled. Also require both launchctl bootout system/<label> and launchctl bootstrap system <plist> in the extracted command, not either one.
  4. Idempotence over present aliases. The program's header claims that re-adding a present alias "re-applies cleanly", citing the spike. The spike got that from a skip guard and never measured a re-add. Either confirm on macOS that /sbin/ifconfig lo0 alias <addr> 255.255.255.255 exits 0 for an alias that is already present, and add an e2e step that runs the advisory's command a second time without removing the aliases first and then asserts the job's last exit code = 0. Or, if it does not exit 0, make the program skip present addresses as the spike's fixed script does.

In the round report, list each plan test line with its result. Also say whether the macOS lane's runner has passwordless sudo.

The advisory command wraps its payload in a single-quoted `sudo sh -c`,
so the apostrophe in the range program's header comment ("the range's
host addresses") closed the quote and left the pasted command
unparseable: `sh -n` rejects it with an unexpected EOF and zsh waits at
`quote>` forever. Remove every apostrophe from the program and plist
templates and pin that: the advisory test now asserts neither heredoc
body contains a single quote, that `/bin/sh -n -c` accepts the whole
command, and that it accepts the inner payload between the outer
quotes.

The lines after a heredoc are separate commands, so a failed write
underneath the heredocs previously could not stop the bootstrap: the
payload now begins with `set -e;`, which the same test pins by prefix.

The program itself now walks the range's host addresses in a for loop
over the rendered list and skips addresses lo0 already carries, rather
than re-adding them: the spike that claimed a re-add "re-applies
cleanly" never re-added a present alias (its guard skipped them), so
the skip is the shape the evidence supports, and a re-run now adds only
the missing aliases and removes nothing. The shape test pins the
walk's exact address list, the one guarded absolute-path `ifconfig`
alias form, and that the program substitutes nothing but its own two
reads.
Three of the local-range proof's launchctl reads asserted formats
launchd never writes, so each one either failed a healthy host or
passed a broken one:

- `launchctl print` reports RunAtLoad as a bare `runatload` token in
  the job's `properties = …` line, never as `runatload = true`; the
  check now matches that line (case-insensitively, the plist key is
  `RunAtLoad`).
- `launchctl print-disabled` rows read `"label" => enabled|disabled`
  with the label quoted, so matching the bare label never fired and
  every state passed, disabled included. The awk now matches the
  quoted label and the case accepts only no-row-or-`enabled`, failing
  on `disabled`.
- the extracted command needed either the guarded bootout or the
  bootstrap to be present; both are now required separately.

And the re-run a repeat install is: the proof now re-runs the
advisory's command verbatim over the aliases it had already applied,
without removing them first, and requires the re-loaded job's
`last exit code = 0` (polled from launchctl print) with all 254
aliases still on lo0 — the re-run adds only missing aliases and
removes nothing, which is what the program's skip guard promises and
the spike's recorded runs never measured.
The two tests that read the rendered program's `for addr in` line
sliced the string by offset, which trips the strict gate's
string_slice lint on the lines this round changed. Read the list with
strip_prefix/strip_suffix instead, and scan the program's `$`
identifiers over split('$') rather than match_indices — same
iteration, no manual index.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on a /revise note, pushed as a890439d59c1.

line exit tail
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-1bac... Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/68965/tree/crates/args) Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/68965/tree/crates/ot) C
cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-2508... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/f0bb0/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/f0bb0/tree/crate
cargo nextest run -p minimal range_step_custody_is_root_owned 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-35bf... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/fdec6/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/fdec6/tree/crate
cargo nextest run -p minimal range_step_custody_walks_every_path_component 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-0ee5... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/a9150/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/a9150/tree/crate
cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-ddba... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/f7ae6/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/f7ae6/tree/crate
cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-745e... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/36a4c/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/36a4c/tree/crate
cargo nextest run -p minimal linux_advisory_command_is_unchanged 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-c815... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/98f92/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/98f92/tree/crate
cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-e291... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/d9829/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/d9829/tree/crate
cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos 0 Applying loadouts: default Running task runtime-implement-test-8 in session task-runtime-implement-test-8-c6dd... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/072c8/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/072c8/tree/crate
./scripts/session-e2e.sh local_range_reserved_by_privileged_step 1 Applying loadouts: default Running task runtime-implement-test-9 in session task-runtime-implement-test-9-4d8d... ::error::no usable 'minimald' on this host: the 'min' this run drives autospawns it by bare name (crates/minimal/src/autospawn.rs), so it must be on PATH — the pair has to come from one

Verify min task run agent-verify passed.

Outside the task's layers::

  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

On macOS, the one advisory command now pastes and parses — its heredoc bodies carry no single quote, /bin/sh -n accepts both the whole command and the inner payload, and the payload begins with set -e, so a failed write stops the bootstrap — and it installs the root-owned LaunchDaemon whose program applies exactly 127.0.64.0/24 as lo0 aliases, skipping addresses lo0 already carries so a re-run adds only the missing ones, now and at every boot; afterwards the host-side bind probe reads present and the 127.0.0.1 interim ends; custody failures re-surface the advisory; the Linux command is unchanged. The macOS lane's e2e case now asserts what launchctl really prints (the properties line carrying runatload, the quoted label in print-disabled, both bootout and bootstrap present) and re-runs the command over the aliases it already applied, requiring the re-loaded job's last exit code = 0 with all 254 aliases still on lo0.

Notes from the agent: Round 3 directive, item by item. (1) Both templates are apostrophe-free — the program header's possessive was the only one — and the advisory test pins no-quote, /bin/sh -n on the command and the payload. (2) set -e; is the payload's first command, pinned in the same test. (3) The e2e now matches the real launchctl formats and requires bootout and bootstrap separately. (4) This box cannot run macOS, so ifconfig's exit code for re-adding a present alias could not be confirmed here; I took the directive's second option — the program skips present addresses exactly as the spike's fixed script does, which makes the re-run clean by construction — and still added the option-(a) e2e step, so the macOS lane measures the re-run over present aliases and requires last exit code = 0. The program's shape changed with that: 254 unrolled alias lines became one guarded for-loop over the render-time address list (placeholder renamed @RANGE_ALIASES@ to @RANGE_ADDRESSES@, still filled from switch::loopback::range_hosts()), which is why t…[truncated]

@norrietaylor

Copy link
Copy Markdown
Member

/revise Round 4. Round 3's four asks are met: the command parses, both templates carry no apostrophe, the launchctl reads match what launchd prints, and the program skips present aliases. Keep all of it. The plan for #1817 now makes local_range_reserved_by_privileged_step an operator-run case, because the macOS lane's runner is a persistent shared host and is not given passwordless sudo. Scope: crates/minimal/src/resolver.rs (the macos_command render and its test) and scripts/session-e2e.sh (that case only). Leave the Linux command byte-identical, and leave T71's answerer unit alone.

  1. Gate the case on an explicit opt-in. At the top of proof_local_range_reserved_by_privileged_step, before any uname, sudo or launchctl check, do this unless MINIMAL_E2E_PRIVILEGED=1 is set: print SKIPPED (privileged: set MINIMAL_E2E_PRIVILEGED=1 on a macOS host with passwordless sudo) and return 0 from the proof, so a whole-lane run continues past it. With it set, keep today's behaviour: a missing precondition (not macOS, no launchctl, no passwordless sudo) fails rather than skips. Update the proof's header comment and the whole-lane dispatch comment, which still say the case "fails rather than self-skips" and is "the macOS lane's alone".
  2. Make set -e actually fail closed. POSIX ignores -e for every command in an && list except the last. So in set -e; mkdir … && printf … > /etc/resolver/min.internal && cat > <program> <<…, a failed mkdir or printf short-circuits silently, and the script goes on to write the plist and run launchctl bootstrap. On a re-run where the program already exists, that exits 0 with no resolver file and the stale program loaded (reproduced by simulation). Under set -e, separate the steps with newlines or ; instead of &&. Keep the guarded (launchctl bootout system/dev.minimal.local-range 2>/dev/null || true). In advisory_command_reserves_the_range_on_macos, assert that the payload contains no && outside that guard. The /bin/sh -n parse checks stay; they are what CI runs against the rendered command.
  3. Poll the re-run's exit code until it is a number. Right after bootstrap, launchctl print reads last exit code = (never exited) until the program has run, and the loop stops on the first non-empty value. Keep polling until the value is numeric, then require 0.

The PR body is edited by hand; do not rewrite it. In the round report, list each plan test line with its result, and quote the SKIPPED line from the macOS lane.

POSIX ignores -e for every command of an && list except its last, so a
failed mkdir or printf in the advisory command payload short-circuited
its list silently and the script ran on: the plist landed beside a
resolver file that did not, launchctl bootstrap loaded the stale program,
and the command exited 0 over a host it half-configured (reproduced by
simulation). Separate the steps with ; instead — the guarded boot-out
keeps its || true — and assert in the command test that no step hides
in an && list outside that guard.
The case installs a root LaunchDaemon, and the macOS lane runner is a
persistent shared host that is not given passwordless sudo, so the plan
now runs it as an operator case: unless MINIMAL_E2E_PRIVILEGED=1 is set
it prints its SKIPPED line and returns 0, so a whole-lane run continues
past it, and only with the opt-in does a missing precondition fail
rather than skip. The case-list, header and dispatch comments say so
now.

And the re-run exit-code poll no longer stops on the first non-empty
value: launchd prints "last exit code = (never exited)" until the
re-loaded job has actually run, so the poll waits for a numeric one
before requiring 0.
The case self-skips unless MINIMAL_E2E_PRIVILEGED=1 is set, so no lane
proves the command against a real launchd — the operator run does. Two
test doc comments still credited the macOS lane with it.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a /revise note, pushed as fa366ee7ef25.

line exit tail
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-d972... Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/e6918/tree/crates/args) Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/e6918/tree/crates/ot) C
cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-9dca... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/843e9/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/843e9/tree/crate
cargo nextest run -p minimal range_step_custody_is_root_owned 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-570f... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/9361f/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/9361f/tree/crate
cargo nextest run -p minimal range_step_custody_walks_every_path_component 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-8212... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/fd5aa/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/fd5aa/tree/crate
cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-2d54... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/61098/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/61098/tree/crate
cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-3e32... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/9e453/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/9e453/tree/crate
cargo nextest run -p minimal linux_advisory_command_is_unchanged 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-7a6f... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/260d4/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/260d4/tree/crate
cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-b7ff... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/89618/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/89618/tree/crate
cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos 0 Applying loadouts: default Running task runtime-implement-test-8 in session task-runtime-implement-test-8-7bd6... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/6f5b7/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/6f5b7/tree/crate
./scripts/session-e2e.sh local_range_reserved_by_privileged_step 0 SKIPPED (privileged: set MINIMAL_E2E_PRIVILEGED=1 on a macOS host with passwordless sudo) session e2e OK Applying loadouts: default Running task runtime-implement-test-9 in session task-runtime-implement-test-9-1518...

Verify min task run agent-verify passed.

Outside the task's layers::

  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

On macOS, the one advisory command still configures the resolver and installs the range LaunchDaemon — root-owned, non-user-writable paths, no configuration read, exactly 127.0.64.0/24 applied as lo0 aliases now and at every boot — and its payload now fails closed for real: every step is its own statement under set -e, no step hidden in an && list (the unit test asserts it, /bin/sh -n still parses both halves, and a simulation of the rendered shape shows the old && form exiting 0 over a host with no resolver file and the stale program bootstrapped while the new form stops at the first failure); the e2e case is now operator-run — it prints its SKIPPED line and returns 0 unless MINIMAL_E2E_PRIVILEGED=1 is set, and with the opt-in a missing precondition still fails rather than skips — its re-run poll waits for launchd's last exit code to be numeric before requiring 0, and the whole minimal crate suite passes at the head (354 tests). The Linux command is byte-identical, its routing-domain link keeping its routable-scope address; the by-hand macOS run (custody, probe present, boot re-apply) and the real-reboot check remain what the PR body records, and the PR body was not touched.

Notes from the agent: All three round-4 asks are addressed, each in its own commit. (1) The opt-in gate is the first thing in proof_local_range_reserved_by_privileged_step, before any uname/sudo/launchctl check: without MINIMAL_E2E_PRIVILEGED=1 it prints 'SKIPPED (privileged: set MINIMAL_E2E_PRIVILEGED=1 on a macOS host with passwordless sudo)' and returns 0 (verified: the case exits 0 and the lane continues); with it set the preconditions still fail rather than skip — verified here on Linux, where the opted-in run fails at the not-macOS check with exit 1. The proof's header comment and the whole-lane dispatch comment no longer claim the case is 'the macOS lane's alone' or that it 'fails rather than self-skips'; the case-list entry at the top of session-e2e.sh now names the opt-in …[truncated]

…e-local-range-on-the-macos-host-by-the

# Conflicts:
#	scripts/session-e2e.sh
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a conflict with the base branch, pushed as e9c2e5bfb964.

Resolved conflicts in: scripts/session-e2e.sh

line exit tail
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-d4d7... Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/03b0d/tree/crates/ot) Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/03b0d/tree/crates/args) C
cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-daf7... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/0d4bf/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/0d4bf/tree/crate
cargo nextest run -p minimal range_step_custody_is_root_owned 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-583e... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/e8475/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/e8475/tree/crate
cargo nextest run -p minimal range_step_custody_walks_every_path_component 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-8dc0... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/fc574/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/fc574/tree/crate
cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-439c... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/1a5c5/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/1a5c5/tree/crate
cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-1344... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/e4bc9/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/e4bc9/tree/crate
cargo nextest run -p minimal linux_advisory_command_is_unchanged 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-78c7... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/c313e/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/c313e/tree/crate
cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-1a9f... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/9ebdb/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/9ebdb/tree/crate
cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos 0 Applying loadouts: default Running task runtime-implement-test-8 in session task-runtime-implement-test-8-580d... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/025ad/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/025ad/tree/crate
./scripts/session-e2e.sh local_range_reserved_by_privileged_step 0 SKIPPED (privileged: set MINIMAL_E2E_PRIVILEGED=1 on a macOS host with passwordless sudo) session e2e OK Applying loadouts: default Running task runtime-implement-test-9 in session task-runtime-implement-test-9-b784...

Verify min task run agent-verify passed.

Outside the task's layers::

  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

On macOS the one advisory command configures the resolver and installs a LaunchDaemon — plist and program at root-owned, non-user-writable paths, carrying both files' bytes itself and reading no configuration — that applies exactly 127.0.64.0/24 as /32 lo0 aliases now and, with RunAtLoad and no KeepAlive, at every boot, so the daemon's session-start bind probe reads present, a session publishes from the range, and the 127.0.0.1 interim ends with no prompt; custody (every path component and both files owned by root with no group or other write, and the loaded job's ProgramArguments naming the root-owned program) is checked and a failed check re-surfaces the advisory naming it and the command that reinstalls both files; after the unit is loaded again as a boot would load it the range comes back with no user action. In CI the rendered command is proved by the unit tests, which parse it with /bin/sh -n; the Linux command is unchanged and its routing-domain link keeps its routable-scope /32 address.

Notes from the agent: Revise round 5 was a conflict round with no review threads listed. The four conflict hunks in scripts/session-e2e.sh (the case doc list, the per-case variable block, the case-pattern list, and the usage listing) were additive on both sides — this branch's local_range_reserved_by_privileged_step case and main's new box_name_resolves_natively_without_proxy case — and were resolved by keeping both; the merge was completed in commit e9c2e5b and bash -n, the case dispatch, and the usage listing were re-verified. The merge commit also carries main's own changes (crates/sandbox2/src/lib.rs and main's new e2e case), which are main's, not this task's; the branch's diff against main is the six files listed in files_changed. No semantic conflict with main's new case exists: it is Linux-native-only (it skips unless Linux and non-VM) and greps the Linux advisory lead-in, which this task deliberately left unchanged — linux_advisory_command_is_unchanged p…[truncated]

@norrietaylor

Copy link
Copy Markdown
Member

/revise Round 6. One defect, found by the by-hand privileged run. Scope: scripts/session-e2e.sh (the local_range_reserved_by_privileged_step case only) and the two doc lines in crates/minimal/src/resolver.rs named below. No other files.

The operator ran MINIMAL_E2E_PRIVILEGED=1 ./scripts/session-e2e.sh local_range_reserved_by_privileged_step at e9c2e5bf, on macOS 26.7 (25G229). It failed twice the same way:

ran the advisory's command: resolver file and range unit, one sudo
custody holds: both files root-owned at 0755/0644, the plist runs the root-owned program
::error::the range step did not apply the whole reserved range (0 of 254 aliases on lo0)

The unit itself is correct. launchctl bootstrap returns before launchd runs the RunAtLoad job. A probe polling every 0.1 s beside the case saw the job running with 0 aliases, then the count climb 15 → 42 → 80 → 128 → 176 → 221 → 254, and last exit code = 0 about 0.9 s later. The case counts the aliases once, right after the command returns (session-e2e.sh:4035), so it reads 0.

  1. Wait for the unit before counting. At the first alias count, poll as the kickstart step already does (session-e2e.sh around 4158-4163). Poll until launchctl print system/dev.minimal.local-range shows a numeric last exit code and the count reaches 254, with a bound of about 10 s. Fail on a non-zero exit code, or on fewer than 254 aliases at the bound, naming which one. Apply the same wait anywhere else the case counts aliases right after a bootstrap (the re-run step).
  2. Fix the wording. crates/minimal/src/resolver.rs:1262 and :2542 say the bootstrap "runs the program now". Say that bootstrapping loads the unit and launchd starts it at once, asynchronously, so the range appears within about a second. Change no behaviour and no tests in resolver.rs.

Evidence for this round: bash -n scripts/session-e2e.sh and shellcheck -S warning on it are clean, and the case still prints the SKIPPED line without MINIMAL_E2E_PRIVILEGED. The operator re-runs the privileged case by hand after this round.

The PR body is edited by hand; do not rewrite it.

`launchctl bootstrap` returns before launchd runs the RunAtLoad job it
loaded, so the alias count right after the command returned read 0 —
the by-hand privileged run failed at 0 of 254 aliases on lo0. The new
range_wait_unit poll, shared by the two steps that bootstrap the unit
(the first install and the re-run), waits bounded at ~10 s until the
job's `last exit code` is numeric and all 254 aliases are on lo0; each
step then requires exit 0 and the whole range, failing with a line
that names which half fell short.
Both comments claimed the bootstrap "runs the program now"; it loads the
unit into the system domain and launchd starts it at once,
asynchronously, so the range appears within about a second of the
command returning — the wording the by-hand privileged run disproved.
Comments only: no behaviour and no tests change.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on a /revise note, pushed as de2b4cc96590.

line exit tail
cargo nextest run -p minimal advisory_command_reserves_the_range_on_macos 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-072a... Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/6c84d/tree/crates/ot) Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/6c84d/tree/crates/args) C
cargo nextest run -p minimal range_program_applies_exactly_the_reserved_range 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-4ebb... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/c1613/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/c1613/tree/crate
cargo nextest run -p minimal range_step_custody_is_root_owned 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-3bd3... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/8a06c/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/8a06c/tree/crate
cargo nextest run -p minimal range_step_custody_walks_every_path_component 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-3389... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/071ab/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/071ab/tree/crate
cargo nextest run -p minimal macos_advisory_command_elevates_exactly_once 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-9996... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/39a5b/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/39a5b/tree/crate
cargo nextest run -p minimal range_step_custody_failure_resurfaces_the_advisory 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-c0df... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/91525/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/91525/tree/crate
cargo nextest run -p minimal linux_advisory_command_is_unchanged 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-d606... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/00d35/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/00d35/tree/crate
cargo nextest run -p minimal bind_probe_reads_present_after_the_range_step 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-97fd... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/02d55/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/02d55/tree/crate
cargo nextest run -p minimal interim_advisory_says_the_command_ends_it_on_macos 0 Applying loadouts: default Running task runtime-implement-test-8 in session task-runtime-implement-test-8-cba9... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/dfb13/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/dfb13/tree/crate
./scripts/session-e2e.sh local_range_reserved_by_privileged_step 0 SKIPPED (privileged: set MINIMAL_E2E_PRIVILEGED=1 on a macOS host with passwordless sudo) session e2e OK Applying loadouts: default Running task runtime-implement-test-9 in session task-runtime-implement-test-9-84ec...

Verify min task run agent-verify passed.

Outside the task's layers::

  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

The privileged macOS case now waits for launchd to run the bootstrapped range unit before it counts: a shared poll (bounded at ~10 s) runs after both bootstraps — the first install and the re-run — until launchctl print shows a numeric last exit code and all 254 aliases are on lo0, then each step requires exit 0 and the whole range, failing with a line that names which half fell short, so the by-hand run that read 0 of 254 aliases now reads the unit's finished work; the two resolver.rs comments that claimed the bootstrap runs the program now say instead that bootstrapping loads the unit and launchd starts it at once, asynchronously, so the range appears within about a second.

Notes from the agent: Revise round 6, both directive items addressed, nothing else touched. (1) range_wait_unit, defined beside the other range helpers in scripts/session-e2e.sh, is applied at both sites that count aliases right after a bootstrap: the first install now gains the wait plus the exit-code check the directive asked for, and the re-run's inline poll is replaced by the same wait while keeping its own two bespoke verdicts (skip-don't-fail, remove-nothing). The kickstart re-apply keeps its existing poll (it follows a kickstart, not a bootstrap) and the removal check keeps its immediate count. (2) resolver.rs 1262/2542 reworded as directed; comments only, no behaviour and no tests changed — the nine resolver test lines pass against the edited file. Directive evidence reproduced here: bash -n scripts/session-e2e.sh clean and shellcheck -S warning scripts/session-e2e.sh clean (no new findings), and the case prints the SKIPPED line and exits 0 without MINIMAL_E2E_PRIVILEGED. The e2e run needed the min+minimald pair the script gates on (nextest had left a lone min under target/debug, which suppresses the script's own build branch), so I built exactly the pair the script's fallback names (cargo build --locked -p minimal --bin min -p minimald --bin minimald) before ru…[truncated]

@norrietaylor
norrietaylor marked this pull request as ready for review October 3, 2026 09:03
@norrietaylor
norrietaylor requested a review from a team as a code owner October 3, 2026 09:03
@norrietaylor

Copy link
Copy Markdown
Member

/review

@minimal-foundry

minimal-foundry Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at c94325d4609e.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none. git log over resolver.rs and session.rs shows only this PR's own commits; the two review-fix commits (fa8e8f4 mode-masking, c94325d launchctl deadline) are in the head and both prior threads are resolved. Nothing reverts recent work.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Comment thread crates/minimal/src/resolver.rs Resolved
Comment thread crates/minimal/src/resolver.rs Resolved
@minimal-foundry minimal-foundry Bot added the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Oct 3, 2026
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

The runtime will not revise this pull request again on its own: round 7 would exceed the cap of 6 (the last trigger was the runtime's review findings). A person decides now. Remove needs-human from this pull request to let /revise <note> or the automatic rounds resume, or finish #1817 by hand.

@norrietaylor norrietaylor removed the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Oct 3, 2026
@norrietaylor

Copy link
Copy Markdown
Member

/review

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 3, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review: both by-hand review fixes (custody mode bits, bounded launchctl read) are on c94325d. All required lanes are green on this head, including the macOS e2e, and minimal-review concluded on it. The architecture PASS at de2b4cc still holds; the changes since then are outside the design.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 3, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 3, 2026
Merged via the queue into main with commit f229d6b Oct 3, 2026
35 checks passed
@norrietaylor
norrietaylor deleted the agent/1817-reserve-the-local-range-on-the-macos-host-by-the branch October 3, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T76 — Reserve the local range on the macOS host by the advisory's privileged step

1 participant