Repository navigation
docs(specs): settle box reach to the host alias and the node address - #1946
Conversation
NET-003 and NET-004 now say, in their comments, that box-to-host reach over host.min.internal and the deprecated literal is default-deny except configured host exposures (design 7.1), so the literal grants nothing the name does not.
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 48 seconds for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Comment |
Spec lint
Advisory. None of this blocks the merge; the review decides. Advisory, and never a merge gate. Linter: |
NET-062's own-address sub-clause gains a fourth opening: the hostname proxy's port on the node address, while the node serves the interim proxy (design 7.1, NET-070). Box callers reach the :7654 proxy there, and the proxy grants nothing beyond the caller's own reach.
NET-010 gains a sub-requirement: a freed host loopback address stays out of allocation for the 15 s positive answer TTL, so a client that resolved the old name never reaches a different box. Its comment records allocation through the answerer channel from .2 upward.
…as-default-deny # Conflicts: # docs/specs/18-spec-box-networking/18-spec-box-networking.md
|
Approved: no findings at Nothing to do. Clobber: none: |
NET-003's comment kept "local reach under the box's egress rules" beside the new default-deny clause, so an allow-all box read two ways, and NET-134's comment still carried the old reading. Both now say box→host reach over the name is default-deny except configured host exposures, each exposure local reach under the box's rules.
What
Box-to-host reach over
host.min.internalis default-deny except for configured host exposures (design §7.1, local names). This PR states that in the spec at the two places a reader looks for it:NET-003's comment already says resolution is the requirement, not reach. It now says reach over the name is default-deny except configured host exposures, each exposure local reach under the box's egress rules: an allow-all box reaches only the exposures, a deny-all box reaches nothing. NET-134's comment carries the same reading in place of the old "local reach under the box's rules".
NET-004's comment now says what "route the connection as
host.min.internal" means: the deprecated literal100.64.255.254reaches what the name reaches, and nothing more.NET-062's own-address sub-clause gains a fourth opening: the hostname proxy's port on the node address while the node serves the interim proxy (design §7.1, NET-070). Own-address boxes reach the
:7654Host-header proxy at the node address, and the parity rule keeps it from granting more than the caller's own reach. The opening retires with the proxy.NET-010 gains a sub-requirement: a freed host loopback address is held back from allocation for the positive answer TTL (15 s), so a client that resolved the released name cannot reach a different box at it. Its comment names the second, independent hold on the same address: NET-138's withdrawal path holds it until the host has unbound every forward the withdrawn box published there. The allocator hands the address out only after both holds clear.
NET-138's interim-channel comment (S10a/AC1): the interim answerer's channel is per user. A helper under another state dir of the same operator publishes into it instead of binding, and the channel admits peers of the same user, plus root for the release verbs only.
NET-003, NET-004, NET-134 and NET-138 change only in their comments; NET-010's hold and NET-062's opening are the normative changes.
Why
#1943 (T79, NET-062's own-address sub-clause) enforces the default on the native relay, which also runs inside the VM on VM-backed hosts. The e2e's NET-003 own-address connect and NET-004 reach assertions relied on the alias being open under a box's own rules. #1943 narrows them, and this PR records the reading they now follow.
Follow-ups, tracked separately: host-exposure configuration, and VM host gate parity with the deprecation notice on a drop.