Skip to content

T87 — Refuse a host-address declaration the classifier cannot enforce on a host that decides per box - #1955

Merged
norrietaylor merged 6 commits into
mainfrom
agent/1917-refuse-a-host-address-declaration-the-classifier
Oct 4, 2026
Merged

norrietaylor merged 6 commits into
mainfrom
agent/1917-refuse-a-host-address-declaration-the-classifier

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

T87 — Refuse a host-address declaration the classifier cannot enforce on a host that decides per box

slice: S11
kind: task
covers: NET-079
size: M
est: 150 code, 280 tests
executor: agent
difficulty: needs care
model: strongest
diagnostics: the daemon log keeps one info line per refused create or launch naming the box, the host's per_box value and each unenforced rule; the launch record line is unchanged
observability: a counter of creates refused for an unenforceable host-address declaration
layers:
- classifier:
- crates/minimald/src/net/classifier.rs: adds a pure function beside verdict_of that names each rule of a host-address declaration the classifier cannot enforce: every deny_subnets entry, and every allow list when the declaration is not the deny-all shape (all three allow lists present and empty); an absent section and the deny-all shape name nothing; the module comment that says the allow subtree refuses nothing on a box's behalf stays true and now says why such a declaration never reaches it on a per_box host
test: cargo nextest run -p minimald unenforceable_rules_names_deny_subnets_and_partial_allow_lists
test: cargo nextest run -p minimald unenforceable_rules_empty_for_absent_section_and_deny_all
- daemon:
- crates/minimald/src/sessions.rs: the create path refuses a host-address box whose declaration names any unenforceable rule WHILE the box host decides per box (the same can_decide_per_box fact the launch reads, taken at create), with a typed error carrying every unenforced rule by field name, before anything is allocated; on a host that cannot decide per box nothing changes: the box is created, runs unenforced and is recorded as such, never refused on that ground; own-address boxes are untouched
- crates/minimald/src/rpc.rs: the typed error reaches the client as a create failure whose message names each unenforced rule and says own-address boxes enforce them
- crates/minimald/src/session_host.rs: the launch path calls the same pure function, gated on the classifier decision the launch has just re-read (the probe host_ip_enforcement takes its can_decide_per_box from), and refuses the launch with the same typed error when the host decides per box and the declaration names an unenforceable rule; one predicate, two call sites, no second copy; this closes the create-then-install race and boxes persisted before this task that are relaunched after it; the launch record derives per_box from the placement plus that function, never from the node fact alone, so it can never record per_box for a declaration the function marks unenforceable
test: cargo nextest run -p minimald per_box_host_refuses_unenforceable_host_ip_declaration
test: cargo nextest run -p minimald per_box_host_creates_host_ip_box_with_no_section_or_deny_all
test: cargo nextest run -p minimald unenforcing_host_still_creates_host_ip_box_with_any_declaration
test: cargo nextest run -p minimald launch_refuses_unenforceable_host_ip_declaration_after_host_gains_per_box
test: cargo nextest run -p minimald launch_record_never_per_box_for_unenforceable_declaration
test: cargo nextest run -p minimald create_session_rejects_policy_incompatible_with_network_mode
- e2e:
- scripts/session-e2e.sh: the daemon-fetch proof's host-address box drops --deny-subnets 0.0.0.0/0 (refused under the loaded table now) and runs with no section, its comment corrected (that flag is not a deny-all spelling, the box lands in boxes/allow either way); the proof adds one leg under the loaded table: --network host_ip --deny-subnets 0.0.0.0/0 and --network host_ip --allow-subnets 10.0.0.0/8 are each refused at activate, with the error naming the rule
test: ./scripts/session-e2e.sh daemon_fetch_under_deny_all_host_address_box
produces: none
consumes:
- crates/minimald/src/net/classifier.rs
proof: On a native host whose classifier decides per box, activating a host-address box with --deny-subnets 0.0.0.0/0 or a narrowing allow list fails with an error naming each rule the classifier cannot enforce; a box created while the host could not decide per box and launched after the classifier is installed is refused at launch with the same error and never lands in boxes/allow; a box with no section and a deny-all box are still created; a host that cannot decide per box still creates and runs every host-address box unenforced.
depends on:
- blocked by #1806

Requirement text. This quoted text is authoritative for this task: the spec 18 amendment stays a draft (#1916) until after this run, a sub-requirement of NET-079:

WHILE the box host decides per box, WHEN a host-address box is created or launched with an egress declaration the box host's classifier cannot enforce THE SYSTEM SHALL refuse the creation or launch with an error naming each unenforced rule.

This is interim and is retired when the classifier enforces a host-address box's declared address rules. It stays distinct from the sub-requirement for a host that cannot decide per box, where the box runs unenforced and is never refused.

Out of time

The coder ran out of its 7200s before it finished. If it left work uncommitted, its last commit is the runtime's snapshot of that work as it stood — the commit message says so — and not a finished step: it may not build or pass its tests. So this PR is a draft.

Proof

On a native host whose classifier decides per box, activating a host-address box with --deny-subnets 0.0.0.0/0 or a narrowing allow list fails with an error naming each rule the classifier cannot enforce; a box created while the host could not decide per box and launched after the classifier is installed is refused at launch with the same error and never lands in boxes/allow; a box with no section and a deny-all box are still created; a host that cannot decide per box still creates and runs every host-address box unenforced.

Commit headers reworded by the runtime to fit commitlint. The header the coder wrote is the first paragraph of each of these commits' bodies:

  • feat: the coder's uncommitted work as it stood when its 7200s ran out

Tests

line exit tail
cargo nextest run -p minimald unenforceable_rules_names_deny_subnets_and_partial_allow_lists 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-135c... Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/0d8be/tree/crates/args) Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/0d8be/tree/crates/ot) C
cargo nextest run -p minimald unenforceable_rules_empty_for_absent_section_and_deny_all 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-154b... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/3feb2/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/3feb2/tree/crate
cargo nextest run -p minimald per_box_host_refuses_unenforceable_host_ip_declaration 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-ccfa... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/a1729/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/a1729/tree/crate
cargo nextest run -p minimald per_box_host_creates_host_ip_box_with_no_section_or_deny_all 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-d103... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/09419/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/09419/tree/crate
cargo nextest run -p minimald unenforcing_host_still_creates_host_ip_box_with_any_declaration 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-5f59... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/deb65/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/deb65/tree/crate
cargo nextest run -p minimald launch_refuses_unenforceable_host_ip_declaration_after_host_gains_per_box 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-a814... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/0d2cd/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/0d2cd/tree/crate
cargo nextest run -p minimald launch_record_never_per_box_for_unenforceable_declaration 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-38f7... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/eaf57/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/eaf57/tree/crate
cargo nextest run -p minimald create_session_rejects_policy_incompatible_with_network_mode 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-0623... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/d0b30/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/d0b30/tree/crate
./scripts/session-e2e.sh daemon_fetch_under_deny_all_host_address_box 0 no usable 'min' on PATH and no build under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/build-cache/target/debug/min and /work/build-cache/target/debug/minimald ::group::the daemon's own fetch under a loaded c

Verify

min task run agent-verify exited 101, so this PR is a draft.

Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-631f...
    Checking args v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/args)
    Checking ot v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/ot)
    Checking paths v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/paths)
   Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/stdlib)
   Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/version)
    Checking common v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/common)
    Checking diagnostics v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/diagnostics)
    Checking async-dialog v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/async-dialog)
    Checking switch v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/switch)
    Checking mlog v0.0.1 (/home/runner/.local/state/minimal/sessions/28da7/tree/crates/mlog)
error: using `chunks_exact` with a constant chunk size
   --> crates/switch/src/refusal.rs:205:10
    |
205 |         .chunks_exact(2)
    |          ^^^^^^^^^^^^^^^ help: consider using `as_chunks` instead: `as_chunks::<2>().0.iter()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: using `chunks_exact` with a constant chunk size
   --> crates/switch/src/refusal.rs:209:31
    |
209 |     if let Some(tail) = bytes.chunks_exact(2).remainder().first() {
    |                               ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/switch/src/refusal.rs:209:31
    |
209 |     if let Some(tail) = bytes.chunks_exact(2).remainder().first() {
    |                               ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks

error: could not compile `switch` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

Base

The base branch moved while the coder worked and was merged in before the tests ran. These files changed on BOTH sides since the branch point — read them first, because a rewrite from a stale reading can undo a merge without a conflict:

  • crates/minimald/src/rpc.rs
  • crates/minimald/src/session_host/tests.rs
  • scripts/session-e2e.sh

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimald/src/session_host/tests.rs

Closes #1917

NET-079's per-box vocabulary is the two subtrees — deny-all, and
refuse nothing — so a host-address declaration that asks for anything
between the two (a deny_subnets entry, a narrowing allow list) names
rules no per-box verdict enforces. unenforceable_rules names each by
field, entry by entry; refuses_unenforceable_declaration folds the
host's can_decide_per_box in, and is the one predicate the create and
launch paths will share. An absent section and the deny-all shape name
nothing, and the module comment now says why such a declaration never
reaches the allow subtree on a per-box host.
NET-079's two subtrees are the whole vocabulary a loaded table decides
per box: boxes/deny refuses everything but the answerer, boxes/allow
refuses nothing on a box's behalf. A host-address box whose declaration
asks for more — a deny_subnets entry, a narrowing allow list — names
rules no per-box verdict enforces, so a host that decides per box
refuses it rather than run it placed and looking decided while its
rules go unenforced.

One predicate, two call sites, both reading their own decision:

- the create (sessions.rs) refuses over the daemon's node fact, before
  anything is allocated, as a typed InvalidInput whose words name each
  unenforced rule by field and say own-address boxes enforce them — the
  same arm the incompatible-policy refusal already rides;
- the launch (session_host.rs) re-reads the host for itself and refuses
  before the leaf is allocated, closing the create-then-install race and
  reaching records persisted before this gate existed; the box never
  lands in boxes/allow;
- the launch record derives per_box from the placement plus the same
  pure function, never from the node fact alone.

On a host that cannot decide per box nothing changes — NET-079's
exception is that host's to keep — and own-address boxes are untouched.
Each refusal logs one info line naming the box, the per-box value and
each unenforced rule, and a counter of refused creates rides the line
(refused_unenforceable_creates).
the coder's uncommitted work as it stood when its 7200s ran out

The coder was stopped at the end of its time with these changes
not committed. The runtime committed its working tree as it stood so
the work is kept: this commit is a snapshot, not a finished step, and
may not build or pass its tests.
@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 548e9478-ef03-447b-89f2-0d1654d9726a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@norrietaylor

Copy link
Copy Markdown
Member

/revise Apply two design conditions and one pinning test, staying inside this task's layers (classifier.rs, sessions.rs, rpc.rs, session_host.rs and its tests module, session-e2e.sh).

  1. Type the launch-path refusal. Create already returns SessionsError(InvalidInput, words), but the launch path returns io::Error::other(words). That reaches the client as an unspecified failure (exit 1). The same NET-079 refusal must map to the same machine-mode error kind and exit code whether it hits at create or at launch:

    • If the launch path's mapping keys on io::ErrorKind, use io::Error::new(io::ErrorKind::InvalidInput, words).
    • Otherwise carry it to the same InvalidInput arm create uses.
    • Add a test asserting the create and launch refusals map to the same machine-mode code.
  2. Name the remedy in the refusal. unenforceable_declaration_words names the rules but must also end with what to do. A launch refusal also hits boxes created before this change (or while the host could not decide per box) that now relaunch on a per-box host. The wording should cover:

    • Remove these rules.
    • Or declare deny-all egress: all three allow lists present and empty, with no deny entries.
    • Or run the box with --network own_ip, which enforces them.
    • Why: the host-address classifier enforces only deny-all until declared address rules are supported.

    Note that the CLI has no deny-all flag, so don't name one; point at the egress section. The words are one shared string, so both paths pick it up. Update any test that asserts the exact words.

  3. Pin a lone present-but-empty allow list as unenforceable: allow_subnets: Some(vec![]) with the other two absent names allow_subnets. Add a unit case unless one of the existing classifier tests already asserts exactly this.

Keep every existing test line green.

The create returned InvalidInput over the refusal's words while the
launch returned io::Error::other over the same words, so the one
NET-079 refusal reached a client as two machine-mode failures: a typed
one at a create, an unspecified one at a launch. Both paths now return
the one typed error, unenforceable_declaration_refusal, spelled once
in the classifier beside its words: the create's RPC answer keys on
this kind, and the kind is what the launch's io::Error carries to
whatever reads it downstream, so the same declaration's refusal maps
to the same machine-mode code wherever it meets a client.

The words also end with what to do, after the why: remove these rules,
or declare deny-all egress instead — the box's egress section, all
three allow lists present and empty, no deny entries, since the CLI
has no flag that writes an empty list — or run the box with
--network own_ip, which enforces them. The why stays named: the
host-address classifier enforces only deny-all until declared address
rules are supported.

Pinned beside both: a lone present-but-empty allow list names its own
rule (allow_subnets present and empty with the other two absent is not
the deny-all shape), the classifier test holds the words' remedy tail
and the one typed error, the launch test asserts the surfaced refusal
is the create's own kind, and the create test names the arm it rode
and the remedy it named.
The daemon-fetch proof's refused-create leg already greps the stderr a
person reads for the rule the refusal named and the mode that enforces
it; it now also greps the remedy the words end with, so the end-to-end
proof pins what a person is left to type, not only what they typed
wrong.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 1 on a /revise note, pushed as 3b7486112c76.

line exit tail
cargo nextest run -p minimald unenforceable_rules_names_deny_subnets_and_partial_allow_lists 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-2364... Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/1e2b7/tree/crates/ot) Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/1e2b7/tree/crates/args) C
cargo nextest run -p minimald unenforceable_rules_empty_for_absent_section_and_deny_all 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-26c3... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/e4132/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/e4132/tree/crate
cargo nextest run -p minimald per_box_host_refuses_unenforceable_host_ip_declaration 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-86df... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/0f7db/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/0f7db/tree/crate
cargo nextest run -p minimald per_box_host_creates_host_ip_box_with_no_section_or_deny_all 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-9909... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/0cd91/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/0cd91/tree/crate
cargo nextest run -p minimald unenforcing_host_still_creates_host_ip_box_with_any_declaration 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-5c03... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/fd93a/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/fd93a/tree/crate
cargo nextest run -p minimald launch_refuses_unenforceable_host_ip_declaration_after_host_gains_per_box 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-f502... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/ca14b/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/ca14b/tree/crate
cargo nextest run -p minimald launch_record_never_per_box_for_unenforceable_declaration 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-103d... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/5fc60/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/5fc60/tree/crate
cargo nextest run -p minimald create_session_rejects_policy_incompatible_with_network_mode 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-21bb... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/761a1/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/761a1/tree/crate
./scripts/session-e2e.sh daemon_fetch_under_deny_all_host_address_box 0 ::group::the daemon's own fetch under a loaded classifier table (NET-080) ::warning::daemon-fetch proof SKIPPED — the classifier table cannot be loaded on this host (no nft on PATH: the classifier table is loaded with it) asserted on the native CI lane, where the privileged step's tree and table

Verify min task run agent-verify exited 101.

Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-efe0...
    Checking args v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/args)
    Checking ot v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/ot)
    Checking paths v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/paths)
   Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/stdlib)
   Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/version)
    Checking diagnostics v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/diagnostics)
    Checking async-dialog v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/async-dialog)
    Checking common v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/common)
    Checking switch v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/switch)
    Checking mlog v0.0.1 (/home/runner/.local/state/minimal/sessions/08728/tree/crates/mlog)
error: using `chunks_exact` with a constant chunk size
   --> crates/switch/src/refusal.rs:205:10
    |
205 |         .chunks_exact(2)
    |          ^^^^^^^^^^^^^^^ help: consider using `as_chunks` instead: `as_chunks::<2>().0.iter()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: using `chunks_exact` with a constant chunk size
   --> crates/switch/src/refusal.rs:209:31
    |
209 |     if let Some(tail) = bytes.chunks_exact(2).remainder().first() {
    |                               ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/switch/src/refusal.rs:209:31
    |
209 |     if let Some(tail) = bytes.chunks_exact(2).remainder().first() {
    |                               ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks

error: could not compile `switch` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/minimald/src/session_host/tests.rs

Converted to a draft: something above needs a person before review.

On a native host whose classifier decides per box, activating a host-address box with --deny-subnets 0.0.0.0/0 or a narrowing allow list fails with an error naming each rule the classifier cannot enforce and ending with what to do about them — remove these rules, or declare deny-all egress in the box's egress section (all three allow lists present and empty, no deny entries; the CLI has no flag that writes an empty list), or run the box with --network own_ip, which enforces them; a lone present-but-empty allow_subnets list is refused too, named by its field. A box created while the host could not decide per box and launched after the classifier is installed is refused at launch with the same words and the same typed InvalidInput error the create returns — one machine-mode failure, not two — and never lands in boxes/allow. A box with no section and a deny-all box are still created, and a host that cannot decide per box still creates and runs every host-address box unenforced.

Notes from the agent: Revise round: all three directive items applied inside the task's layers, two commits (fix(minimald) 7d36984 for the five rust files, test(e2e) 3b74861 for the script). Item 1 route: no launch-path consumer keys on io::ErrorKind (the attach channel prints the Display text, the exec bridge maps every spawn error to exit 1, FinalizeSession maps every error to Errorable::Err), and the consumers that would have to — crates/minimald/src/session.rs, exec.rs, connection.rs — are outside this task's layers, so the fix is the error's construction: one unenforceable_declaration_refusal in the classifier, InvalidInput — the create's own kind — returned by both call sites, pinned at all three ends (classifier: the one error; launch: the surfaced error's kind; create: the refusal rides the RPC's InvalidInput arm, where any other kind answers as a transport error and never yields Errorable::Err). The e2e line ran as written and exited 0; its proof skips on this hos…[truncated]

@minimal-foundry minimal-foundry Bot added the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Oct 4, 2026
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

The runtime will not revise this pull request again on its own: round 2 would exceed the cap of 1 (the last trigger was a failed check suite). A person decides now. Remove needs-human from this pull request to let /revise <note> or the automatic rounds resume, or finish #1917 by hand.

@norrietaylor
norrietaylor marked this pull request as ready for review October 4, 2026 11:49
@norrietaylor
norrietaylor requested a review from a team as a code owner October 4, 2026 11:49
@minimal-foundry

minimal-foundry Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at 3b7486112c76.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none: the PR's own commits sit on a merge of origin/main; the three doubly-changed files (rpc.rs, session_host/tests.rs, session-e2e.sh) were re-merged, not reverted.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 4, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 3b74861. It implements NET-079's interim refusal: one predicate serves create and launch, a single typed InvalidInput reaches the client on both paths, the error names the remedy, and a lone empty allow list is pinned. ARCH passed it, minimal-review approved with no findings, and every lane is green.

@norrietaylor norrietaylor removed the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Oct 4, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 4, 2026
Merged via the queue into main with commit f6b1b18 Oct 4, 2026
37 of 39 checks passed
@norrietaylor
norrietaylor deleted the agent/1917-refuse-a-host-address-declaration-the-classifier branch October 4, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T87 — Refuse a host-address declaration the classifier cannot enforce on a host that decides per box

1 participant