Skip to content

T88 — Declare a deny-all egress box from the CLI and show declared and default egress by name - #1958

Merged
norrietaylor merged 9 commits into
mainfrom
agent/1918-declare-a-deny-all-egress-box-from-the-cli-and-s
Oct 4, 2026
Merged

norrietaylor merged 9 commits into
mainfrom
agent/1918-declare-a-deny-all-egress-box-from-the-cli-and-s

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

T88 — Declare a deny-all egress box from the CLI and show declared and default egress by name

slice: S11
kind: task
covers: NET-075
size: M
est: 110 code, 200 tests
executor: agent
difficulty: needs care
model: strongest
diagnostics: none new; the launch record's classifier leaf already names deny
observability: none
layers:
- cli:
- crates/minimal/src/cli.rs: adds --deny-all-egress to the one shared egress argument group, so every command that takes the egress flags takes it with one meaning; it conflicts with every --allow-* and --deny-* flag at parse
- crates/minimal/src/cmd/session.rs: the flag maps to sessions::EgressPolicy::deny_all() (every allow list present and empty); an empty value for any --allow-* or --deny-* flag stays a typed validation error and never becomes an empty list; min session policy shows deny-all for a declared deny-all box, and for a box with no section shows its effective default by name (deny-all for an own-address box under the deny-all default, allow-all for a host-address box or under the opt-out) marked as the default, never nothing; on a host-address box the line sits beside the per-box enforcement value T73 surfaces
test: cargo nextest run -p minimal deny_all_egress_flag_declares_every_allow_list_empty
test: cargo nextest run -p minimal deny_all_egress_conflicts_with_every_egress_flag
test: cargo nextest run -p minimal empty_egress_flag_value_is_a_validation_error
test: cargo nextest run -p minimal policy_shows_declared_deny_all
test: cargo nextest run -p minimal policy_shows_unset_egress_as_named_default
- classifier:
- crates/minimald/src/net/classifier.rs: unenforceable_declaration_words (T87's NET-079 refusal) names --deny-all-egress beside the declaration form as the deny-all remedy, so a refused host-address box is told the flag this task adds
test: cargo nextest run -p minimald unenforceable_refusal_names_the_deny_all_flag
- e2e:
- scripts/session-e2e.sh: the daemon-fetch proof's host-address box is declared with --deny-all-egress, lands in boxes/deny under the loaded table, and drives the refused-connect half the proof says today it cannot (a connection from the box to an undeclared address is refused while the daemon's fetch still completes); the comment that calls that half undrivable is removed; the proof's state directory stays short enough for a deny-all box's socket paths under the 107-byte AF_UNIX limit
test: ./scripts/session-e2e.sh daemon_fetch_under_deny_all_host_address_box
produces: none
consumes: none
proof: min session activate --network host_ip --deny-all-egress creates a box that lands in boxes/deny on a per_box host, cannot connect to 1.1.1.1:443, and shows deny-all in min session policy; a box with no section shows its effective default by name; combining the flag with any other egress flag fails at parse.
depends on:
- blocked by #1806
- blocked by #1917

Requirement text. This quoted text is authoritative for this task: the spec 18 amendment stays a draft (#1916) until after this run:

WHEN a box is activated with --deny-all-egress THE SYSTEM SHALL declare every allow list in its egress section present and empty.

  • WHILE a box's egress section is declared deny-all THE SYSTEM SHALL show deny-all in min session policy.
  • WHILE a box has no egress section THE SYSTEM SHALL show its effective default by name in min session policy, marked as a default and not as a declaration.

Mixed forms, such as no addresses but some names, are deliberately not offered. The box spec has no egress section today, so there is no file form to align with.

Proof

On this branch a person can run min session activate --network host_ip --deny-all-egress and get a box that lands in boxes/deny on a per_box host, whose own connection to 1.1.1.1:443 is refused while the daemon's own fetch completes on the same host, and whose min session policy reads deny all beside per-box enforcement per_box; a box activated with no egress flags shows its effective default by name (allow all on a host-address box, the rollout phase's default on an own-address box) instead of nothing; and combining --deny-all-egress with any --allow-* or --deny-* flag fails at parse with clap's ArgumentConflict naming both flags.

Notes from the agent: crates/minimal/src/cmd/list.rs is outside the named layers but had to change: it constructs an ActivateArgs literal (bare_activate_args) and the struct gained deny_all_egress, so the crate would not compile without the one-line deny_all_egress: false there. crates/minimal/src/tests.rs and crates/minimal/tests/cli.rs host the tests the layer's test: lines name. 'Marked as the default' was read as the name itself being the mark: the rendered line says deny all/allow all by name, while the strict GetSessionPolicy record keeps egress absent for an undeclared box and GetEffectiveSessionPolicy carries EffectiveEgress::{DenyAll,AllowAll,Declared}, so default and declaration stay distinguishable downstream; a separate textual marker row would have broken the pinned adjacency in policy_render_carries_the_enforcement_row_when_the_host_reported_it (T73) and policy_shows_deny_all_default (NET-075's own verify), both kept green along with the refusal-word pins across minimald's rpc.rs and session_host tests. docs/reference/cli-min.md has no row for --deny-all-egress: that file is outside this task's layers, so the flag ships documented via its clap help and the e2e proof text; the reference row is a follow-up. The e2e proof's behavioural half needs nft, passwordless sudo and a cgroup2 install thi…[truncated]

Tests

line exit tail
cargo nextest run -p minimal deny_all_egress_flag_declares_every_allow_list_empty 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-5c91... Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/6fb2c/tree/crates/args) Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/6fb2c/tree/crates/ot) C
cargo nextest run -p minimal deny_all_egress_conflicts_with_every_egress_flag 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-3012... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/18cd7/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/18cd7/tree/crate
cargo nextest run -p minimal empty_egress_flag_value_is_a_validation_error 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-c9ad... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/bbe0b/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/bbe0b/tree/crate
cargo nextest run -p minimal policy_shows_declared_deny_all 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-b7fe... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/b509b/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/b509b/tree/crate
cargo nextest run -p minimal policy_shows_unset_egress_as_named_default 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-e442... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/72154/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/72154/tree/crate
cargo nextest run -p minimald unenforceable_refusal_names_the_deny_all_flag 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-70f8... Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/28653/tree/crates/ot) Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/28653/tree/crates/args) C
./scripts/session-e2e.sh daemon_fetch_under_deny_all_host_address_box 0 ::group::the daemon's own fetch under a loaded classifier table (NET-080) ::warning::daemon-fetch proof SKIPPED — the classifier table cannot be loaded on this host (no nft on PATH: the classifier table is loaded with it) asserted on the native CI lane, where the privileged step's tree and table

Verify

min task run agent-verify exited 101, so this PR is a draft.

Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-5ccc...
    Checking args v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/args)
    Checking ot v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/ot)
    Checking paths v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/paths)
   Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/stdlib)
   Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/version)
    Checking switch v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/switch)
    Checking diagnostics v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/diagnostics)
    Checking common v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/common)
    Checking mlog v0.0.1 (/home/runner/.local/state/minimal/sessions/f8dde/tree/crates/mlog)
error: using `chunks_exact` with a constant chunk size
   --> crates/switch/src/refusal.rs:205:10
    |
205 |         .chunks_exact(2)
    |          ^^^^^^^^^^^^^^^ help: consider using `as_chunks` instead: `as_chunks::<2>().0.iter()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: using `chunks_exact` with a constant chunk size
   --> crates/switch/src/refusal.rs:209:31
    |
209 |     if let Some(tail) = bytes.chunks_exact(2).remainder().first() {
    |                               ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/switch/src/refusal.rs:209:31
    |
209 |     if let Some(tail) = bytes.chunks_exact(2).remainder().first() {
    |                               ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks

error: could not compile `switch` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimal/src/cmd/list.rs
  • crates/minimal/src/tests.rs
  • crates/minimal/tests/cli.rs

Closes #1918

Obligation recorded. The box spec has no egress file form yet. Whichever task adds one (docs/architecture.md [network] egress_*) must define whether --deny-all-egress and the other egress flags override that section or are refused alongside it, and must never merge the two: https://github.com/gominimal/inbox/issues/882.

Schema note (min/v1/session-policy)

The policy document's egress object changes shape in this PR. It is now {"effective": "deny-all" | "allow-all" | "rules", "source": "default" | "declared", "rules"?: <declared section>}, replacing a raw serialisation of the effective egress. The policy JSON has not shipped in a release (absent from v0.6.0), so no released consumer breaks. The first release that carries it documents this shape.

T88's CLI half (NET-075): `min session activate --deny-all-egress`
declares the deny-all section — every allow list present and empty,
nothing denied on top — mapping to sessions::EgressPolicy::deny_all(),
the shape the host-address classifier decides its deny verdict on, so a
box declared by flag reads in the record exactly like one declared by
file. The flag conflicts with every --allow-*/--deny-* rule flag at
parse, through one shared egress argument group, because deny-all
admits no exceptions; it still combines with --credentialed-upstream,
which declares a lane (NET-134), not a rule.

`min session policy` renders a declared deny-all by name — `deny all`
— rather than as four per-dimension rows whose every list is empty: a
rendering that reads as nothing, never as the verdict it is. A box
with no section keeps showing its effective default by name, the
already-shipped NET-075 behavior, now pinned by its own test, and
empty flag values stay typed validation errors rather than silently
becoming the empty lists that are deny-all.
T88's classifier half: the refusal a per-box host makes over a
host-address declaration it cannot enforce names the flag this task
adds, beside the egress-section form it has always spelled. Both
spellings write the same section into the record, so the words name
them as the one declaration they are: the flag a person types at the
next activate, and the section a project file carries.
The NET-080 proof's box is now activated with --deny-all-egress, so it
lands in boxes/deny under the loaded classifier table, and the launch
record asserts that subtree and its own leaf instead of boxes/allow.

The refused-connect half the proof used to call undrivable is driven:
a connection the box itself opens to 1.1.1.1:443 is asserted refused
before the daemon's fetch and again after it, with the completed fetch
(against the proof's empty package cache) standing between them as the
reach control. The undrivable-half comment is gone, along with the
net080_answered gate it explained.

Also measured: the deepest live box socket under the lane's state root
must fit the 107-byte AF_UNIX sun_path budget, which pins the lane's
own state-root choice rather than trusting the sandbox builder.
@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a959a415-235e-4ede-81c7-15ec37cd73a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@norrietaylor

Copy link
Copy Markdown
Member

/revise Make min session policy mark an egress default as a default, use the requirement's literal tokens, carry the same distinction in JSON, and add the reference row. Keep everything else in this PR as it is.

  1. Mark the default (NET-075, "marked as a default and not as a declaration").
    • Problem: today a box with no egress section renders the same row ( deny all / allow all) as a declared deny-all. The only place they differ is the strict GetSessionPolicy record, which min session policy never shows.
    • Render: an undeclared box shows its effective default with a same-row mark, deny-all (default) or allow-all (default). A declared deny-all box shows bare deny-all. Keep the row directly above T73's per-box enforcement row on host-address boxes.
  2. Use the requirement's literal tokens: print deny-all and allow-all (hyphenated), not deny all / allow all. Update every pinned test that matches the old spaced text: policy_shows_deny_all_default, policy_render_carries_the_enforcement_row_when_the_host_reported_it, and the new tests in this PR.
  3. Machine output: the -o json policy object must carry the same distinction, for example "egress": {"effective": "deny-all", "source": "default" | "declared"}, so a JSON consumer never has to recompute the default rule.
    • Add an assertion for it in policy_shows_unset_egress_as_named_default.
    • If a schema outside this task pins the JSON shape, say so in the notes rather than change it.
  4. Make the tests assert the difference: policy_shows_unset_egress_as_named_default and policy_shows_declared_deny_all must show that the declared and default renders differ, in both text and JSON.
  5. Docs: add one row for --deny-all-egress to docs/reference/cli-min.md, in the existing style. Run just lint-prose docs/reference/cli-min.md and leave no alerts on your line.
  6. Out of layer, allowed this round: crates/minimal/src/cmd/list.rs (the one-line deny_all_egress: false), crates/minimal/src/tests.rs, crates/minimal/tests/cli.rs, and docs/reference/cli-min.md.

Keep T87's classifier remedy test (main) green with the new refusal words. Re-run every test line in the plan block.

The reviewer's round: NET-075 asks for the effective default by name,
"marked as a default and not as a declaration", and the requirement's
tokens are hyphenated.

An undeclared box now prints `deny-all (default)` or `allow-all
(default)` on the egress row; a box that declared the deny-all section
prints bare `deny-all`, the same verdict without the mark. Every
posture token in the render is hyphenated (`deny-all`, `allow-all`),
egress and ingress rows alike, matching the requirement's literal
spelling.

The -o json document gains the same distinction: the `egress` object
carries `effective` (the posture's name, or `rules` when the
declaration's own lists say it) and `source` (`default` or
`declared`), so a client never recomputes the default rule. A declared
section rides under `rules`, present exactly when the box declared
one.

The pinned tests match the new rows, and the declared/default tests
assert the difference in both renders: text and JSON.
One row for the flag in the activate table: what it writes, how a
flag-declared box reads in the record, the classifier's per-box
decision on a host-address box, and the rule-flag conflict.

The policy section names the postures with the requirement's
hyphenated tokens, prints the deny-all declaration as its one row,
and marks the resolved defaults `deny-all (default)` and
`allow-all (default)` so a defaulted box reads differently from a
declared one. The -o json paragraph documents the `egress` object's
`effective` and `source` fields.

The new lines carry no vale alerts; the file's pre-existing ones are
left alone.
@minimal-foundry minimal-foundry Bot added the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Oct 4, 2026
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

The runtime will not revise this pull request again on its own: round 2 would exceed the cap of 1 (the last trigger was a failed check suite). A person decides now. Remove needs-human from this pull request to let /revise <note> or the automatic rounds resume, or finish #1918 by hand.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 1 on a /revise note, pushed as 0faf8ab6c985.

line exit tail
cargo nextest run -p minimal deny_all_egress_flag_declares_every_allow_list_empty 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-1f27... Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/c058b/tree/crates/args) Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/c058b/tree/crates/ot) C
cargo nextest run -p minimal deny_all_egress_conflicts_with_every_egress_flag 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-ceb7... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/39383/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/39383/tree/crate
cargo nextest run -p minimal empty_egress_flag_value_is_a_validation_error 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-1db6... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/69a03/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/69a03/tree/crate
cargo nextest run -p minimal policy_shows_declared_deny_all 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-4255... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/38deb/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/38deb/tree/crate
cargo nextest run -p minimal policy_shows_unset_egress_as_named_default 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-b6a5... Compiling stdlib v0.0.21 (/home/runner/.local/state/minimal/sessions/e20dd/tree/crates/stdlib) Compiling version v0.7.0 (/home/runner/.local/state/minimal/sessions/e20dd/tree/crate
cargo nextest run -p minimald unenforceable_refusal_names_the_deny_all_flag 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-c937... Compiling ot v0.0.1 (/home/runner/.local/state/minimal/sessions/84197/tree/crates/ot) Compiling args v0.0.1 (/home/runner/.local/state/minimal/sessions/84197/tree/crates/args) C
./scripts/session-e2e.sh daemon_fetch_under_deny_all_host_address_box 0 ::group::the daemon's own fetch under a loaded classifier table (NET-080) ::warning::daemon-fetch proof SKIPPED — the classifier table cannot be loaded on this host (no nft on PATH: the classifier table is loaded with it) asserted on the native CI lane, where the privileged step's tree and table

Verify min task run agent-verify exited 101.

tes/minimal-tui)
    Checking lcache v0.0.1 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/lcache)
    Checking op v0.0.1 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/op)
    Checking rcache v0.0.1 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/rcache)
    Checking orchestrator v0.0.1 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/orchestrator)
    Checking check v0.0.1 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/check)
    Checking mctx v0.0.1 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/mctx)
    Checking minimald v0.7.0 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/minimald)
    Checking minimal v0.7.0 (/home/runner/.local/state/minimal/sessions/29658/tree/crates/minimal)
error: this returns a `Result<_, ()>`
    --> crates/minimald/src/session_host.rs:1837:5
     |
1837 |     pub async fn kill(&self, for_shutdown: bool) -> Result<(), ()> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: use a custom `Error` type instead
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#result_unit_err
     = note: `-D clippy::result-unit-err` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::result_unit_err)]`

error: this returns a `Result<_, ()>`
    --> crates/minimald/src/session_host.rs:1981:5
     |
1981 |     pub async fn get_attrs(&self) -> Result<HostAttrs, ()> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: use a custom `Error` type instead
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#result_unit_err

error: this returns a `Result<_, ()>`
    --> crates/minimald/src/session_host.rs:1993:5
     |
1993 |     pub async fn get_screen(&self) -> Result<minimald_rpc::ScreenSnapshot, ()> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: use a custom `Error` type instead
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#result_unit_err

error: could not compile `minimald` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: using `chunks_exact` with a constant chunk size
    --> crates/minimald/src/net/switch.rs:4467:28
     |
4467 |         for word in summed.chunks_exact(2) {
     |                            ^^^^^^^^^^^^^^^ help: consider using `as_chunks` instead: `as_chunks::<2>().0`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
     = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald` (lib test) due to 4 previous errors

Outside the task's layers::

  • crates/minimal/src/cmd/list.rs
  • crates/minimal/src/tests.rs
  • crates/minimal/tests/cli.rs
  • docs/reference/cli-min.md

Converted to a draft: something above needs a person before review.

min session policy now names every egress posture with the requirement's hyphenated tokens and marks the defaults: a box that declared deny-all (by --deny-all-egress or by hand) prints bare deny-all, an undeclared box prints deny-all (default) or allow-all (default) on the row above the per-box enforcement row, and -o json carries the same distinction as egress.effective (deny-all, allow-all, rules) plus egress.source (default, declared) with the declared section under rules; docs/reference/cli-min.md documents the flag, the marks, and the JSON fields, and min session activate --network host_ip --deny-all-egress still lands in boxes/deny on a per_box host with its daemon-fetch refusal driven by the e2e script.

Notes from the agent: E2e self-skip: this host has no nft on PATH (and no privileged loading), so scripts/session-e2e.sh exercises its plumbing and prints its designed skip warning for the daemon-fetch proof (exit 0, 'asserted on the native CI lane, where the privileged step's tree and table load'); the KVM-shaped evidence stays owed to that lane, not to this box. Out-of-scope follow-up: crates/minimal-tui/src/render.rs still prints the spaced allow all/deny all tokens in its detail pane (lines ~508-576) — it renders the strict record (Option), not EffectiveEgress, and the file is outside this round's allowed set, so a task owning crates/minimal-tui should hyphenate it. No schema outside this task pins the -o json shape: the min/v1/session-policy stamp appears only in cmd/session.rs, cli.rs help text, tests/cli.rs, and the doc, and the RPC wire shape (EffectiveSessionPolicy with deny_unknown_fields, the strictness contract with older min clients) is untouched — only the CLI's own document changed. policy_render_carries_the_enforcement_row_when_the_host_reported_it now builds EffectiveEgress::Declared(EgressPolicy::deny_all()) for its first case so its comment ('a deny-all declaration beside an …[truncated]

@norrietaylor
norrietaylor marked this pull request as ready for review October 4, 2026 16:06
@norrietaylor
norrietaylor requested a review from a team as a code owner October 4, 2026 16:06
@minimal-foundry

minimal-foundry Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at e819e4e3bf7a.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none: git log on session.rs, render.rs and classifier.rs shows the head commit as the only post-merge change; no recent fix reverted.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Comment thread crates/minimal/src/cmd/session.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

The runtime will not revise this pull request again on its own: round 2 would exceed the cap of 1 (the last trigger was the runtime's review findings). A person decides now. Remove needs-human from this pull request to let /revise <note> or the automatic rounds resume, or finish #1918 by hand.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 4, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at e819e4e. The revise round covers all six points of the ask:

  • default mark, hyphenated tokens, JSON effective/source, tests asserting the difference, and the docs row;
  • e5b2461 updates the native e2e pin;
  • e819e4e brings the min dash TUI tokens in line and names a declared deny-all.
    ARCH PASS. The effective-default TUI rendering is tracked in gominimal/inbox#884. All lanes are green on head.

@norrietaylor norrietaylor removed the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Oct 4, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 4, 2026
Merged via the queue into main with commit cacb330 Oct 4, 2026
34 checks passed
@norrietaylor
norrietaylor deleted the agent/1918-declare-a-deny-all-egress-box-from-the-cli-and-s branch October 4, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T88 — Declare a deny-all egress box from the CLI and show declared and default egress by name

1 participant