Skip to content

build: bump the pkgs locked_commit to pkgs main - #1914

Merged
norrietaylor merged 1 commit into
mainfrom
chore/bump-pkgs-pin
Oct 3, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
chore/bump-pkgs-pin

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Moves .minimal/minimal.toml's pkgs locked_commit from f4de33d0 to c5839783 (pkgs main). Nothing else changes.

What the new pin brings into the guest:

  • guest kernel 6.12.105 → 6.12.111, with NFT_SOCKET enabled in the guest kernel config
  • libkrunfw 5.5.0 → 5.6.1
  • nftables in the microvm rootfs

libkrun stays 1.19.4, matching the vendored lock.

The guest classifier's socket cgroupv2 rules need both nft in the rootfs and NFT_SOCKET in the kernel. #1886's KVM lane fails without them (no /usr/sbin/nft in the guest).

Kernel review: in the 6.12.105..6.12.111 range, two commits touch code the guest could matter for, one in virtio_input and one in the virtio-pci INTx path. The guest uses neither: it runs virtio-mmio and has no input device.

This is the pin bump split out of #1875, which keeps the deps-freshness script.

Summary by CodeRabbit

  • Chores
    • Updated the upstream baseline to a newer revision. No user-facing behavior changes are noted.

Moves the guest kernel 6.12.105 -> 6.12.111 and libkrunfw 5.5.0 ->
5.6.1, adds nftables to the microvm rootfs and NFT_SOCKET to the guest
kernel config (what the guest classifier's `socket cgroupv2` rules
need). libkrun stays 1.19.4, matching the vendored lock.

The kernel-review range flags two commits, in virtio_input and the
virtio-pci INTx path; the guest has neither (virtio-mmio, no input).
@norrietaylor
norrietaylor requested a review from a team as a code owner October 3, 2026 23:26
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: fd53b0f2-24a7-4941-ba57-1fcf21a05f1f
📥 Commits

Reviewing files that changed from the base of the PR and between 1daeda3 and 30724e6.

📒 Files selected for processing (1)
  • .minimal/minimal.toml

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The minimal configuration updates its upstream locked_commit pin to a new commit hash.

Changes

Upstream pin update

Layer / File(s) Summary
Update locked commit pin
.minimal/minimal.toml
The locked_commit value changes from f4de33d06dada4edcf5076dded10e9c303cf597e to c5839783972733fdd25f5737e0dd395f748447b7.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: evanspearman

Merge Risk: ⚪ Minimal · up to 30724

No actionable issue with the pin update is established. The change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the change: it bumps the pkgs locked_commit pin to pkgs main.
Description check ✅ Passed The description explains the pin change, its purpose, and relevant compatibility context. It does not include a Testing section or the repository checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the pinned commit,
Then thumps a happy beat.
One hash steps out, a new one in,
The config rests complete.
By moonlit bytes, the change is neat.

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 30724e6e251d.

Nothing to do.

Clobber: none: git log -- .minimal/minimal.toml shows the previous edit was the commit that pinned f4de33d0 (#1551), and the diff moves strictly forward from it.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 3, 2026
@norrietaylor
norrietaylor merged commit c764e33 into main Oct 3, 2026
32 checks passed
@norrietaylor
norrietaylor deleted the chore/bump-pkgs-pin branch October 3, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant