Skip to content

docs(specs): refuse unenforceable host-address egress and add --deny-all-egress - #1916

Merged
norrietaylor merged 2 commits into
mainfrom
docs/spec18-host-ip-refusal
Oct 8, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
docs/spec18-host-ip-refusal

Conversation

@norrietaylor

Copy link
Copy Markdown
Member

Amends spec 18 (box networking) in two places.

Interim refusal (new sub-requirement under NET-079). On a host that decides per box, the classifier enforces only the deny-all verdict for host-address boxes. Every other declaration is unenforced while the node reports per-box enforcement: any deny_subnets entry, and any allow list short of all three present and empty. The new sub-requirement refuses creating such a box and names each rule that can't be enforced. It is written as an interim measure, retired once the classifier enforces declared address rules. It is deliberately distinct from the existing sub-requirement for hosts that cannot decide per box. There the box keeps running unenforced, is recorded as such, and is never refused.

--deny-all-egress (new NET-140). The CLI turns an empty flag value into an unset field, and an unset section on a host-address box admits everything (NET-120). So the one declaration the classifier enforces can't be expressed from min. NET-140 adds one flag, defined in the shared egress argument group, that conflicts with every --allow-*/--deny-* flag. Its sub-requirements cover min session policy, which shows deny-all for the declaration and names the effective default for an unset section, never showing nothing.

Ordering, from the design ruling: the refusal does not depend on the flag, and should ship in the same release as the classifier.

Stays a draft until the NET walk's current run ends.

…all-egress

Adds an interim sub-requirement under NET-079: on a host that decides per
box, creating a host-address box whose egress declaration the classifier
cannot enforce is refused, naming each unenforced rule. It is retired once
the classifier enforces declared address rules.

Adds NET-140: --deny-all-egress declares every allow list present and
empty, defined once for every command that takes the egress flags. Two
sub-requirements cover how min session policy shows declared deny-all and
an unset section's named default.
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 38 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: b0d7c2cc-4ed5-492b-99ec-69c76214b667
📥 Commits

Reviewing files that changed from the base of the PR and between c764e33 and 339a8a7.

📒 Files selected for processing (1)
  • docs/specs/18-spec-box-networking/18-spec-box-networking.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/18-spec-box-networking/18-spec-box-networking.md — 14 finding(s)

docs/specs/18-spec-box-networking/18-spec-box-networking.md:159: P004 NET-009 names test 'native_resolution_without_proxy_env', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:304: P004 NET-040 names test 'fresh_install_own_ip_ingress_publishes_loopback', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:309: P004 NET-041 names test 'installer_switch_binary_executable', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:328: P004 NET-045 names test 'expose_ask_prompts_attached_human', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:337: P004 NET-046 names test 'expose_unenrolled_decision_audited', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:347: P004 NET-048 names test 'linux_amd64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:352: P004 NET-049 names test 'fresh_linux_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:357: P004 NET-050 names test 'linux_arm64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:362: P004 NET-051 names test 'fresh_arm64_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:656: P004 NET-139 names test 'vsock_rpc_refuses_non_host_cid', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:673: P004 NET-132 names test 'proxy_sees_each_vm_box_by_its_switch_address', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:699: P004 NET-134 names test 'deny_all_box_reaches_proxy_and_no_other_host_port', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:723: P004 NET-107 names test 'session_outbound_request', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:748: P004 NET-140 names test 'deny_all_egress_flag_declares_every_allow_list_empty', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@b913de94, spec format: How Minimal Writes Specs.

@minimal-foundry

minimal-foundry Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 339a8a794578.

Nothing to do.

Clobber: none: the two PR commits (e95a827, 339a8a7) are additive; nothing recent reverted.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit 39dc440 Oct 8, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the docs/spec18-host-ip-refusal branch October 8, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants