Repository navigation
docs(specs): refuse unenforceable host-address egress and add --deny-all-egress - #1916
Merged
Merged
Conversation
…all-egress Adds an interim sub-requirement under NET-079: on a host that decides per box, creating a host-address box whose egress declaration the classifier cannot enforce is refused, naming each unenforced rule. It is retired once the classifier enforces declared address rules. Adds NET-140: --deny-all-egress declares every allow list present and empty, defined once for every command that takes the egress flags. Two sub-requirements cover how min session policy shows declared deny-all and an unset section's named default.
Contributor
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 38 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Comment |
Contributor
Spec lint
Advisory. None of this blocks the merge; the review decides. Advisory, and never a merge gate. Linter: |
Contributor
mitodrummer
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amends spec 18 (box networking) in two places.
Interim refusal (new sub-requirement under NET-079). On a host that decides per box, the classifier enforces only the deny-all verdict for host-address boxes. Every other declaration is unenforced while the node reports per-box enforcement: any
deny_subnetsentry, and any allow list short of all three present and empty. The new sub-requirement refuses creating such a box and names each rule that can't be enforced. It is written as an interim measure, retired once the classifier enforces declared address rules. It is deliberately distinct from the existing sub-requirement for hosts that cannot decide per box. There the box keeps running unenforced, is recorded as such, and is never refused.--deny-all-egress(new NET-140). The CLI turns an empty flag value into an unset field, and an unset section on a host-address box admits everything (NET-120). So the one declaration the classifier enforces can't be expressed frommin. NET-140 adds one flag, defined in the shared egress argument group, that conflicts with every--allow-*/--deny-*flag. Its sub-requirements covermin session policy, which showsdeny-allfor the declaration and names the effective default for an unset section, never showing nothing.Ordering, from the design ruling: the refusal does not depend on the flag, and should ship in the same release as the classifier.
Stays a draft until the NET walk's current run ends.