Repository navigation
fix(mfile): refuse a minimal.toml that still spells the stack table [harness] - #2162
Merged
norrietaylor merged 1 commit intoOct 11, 2026
Conversation
…[harness] `[harness]` stopped parsing in v0.5.0 and landed in `extra` as a warning, setting no stack: the toolchain its name promised was silently absent, and the gap only surfaced much later, as a bare `error: linker 'cc' not found` from a build inside the session. `File::validate` now refuses the table at load, so every disk load -- both layouts, and every parent found by `from_dir_recursive` -- fails before any session is built, with a message naming the rename to `[stack]`. The `misplaced_top_level_key` arm that pointed the warning at `[stack]` is gone: the error now carries that advice, before `warn_unknown_fields` runs. The reference doc says the load fails instead of warning. BREAKING CHANGE: a minimal.toml that still spells the stack table `[harness]` fails to load; the table must be renamed to `[stack]`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Member
|
/review |
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
norrietaylor
enabled auto-merge
October 11, 2026 05:39
norrietaylor
approved these changes
Oct 11, 2026
norrietaylor
deleted the
inbox-patch/fix/harness-table-hard-error-6c37a2e36c358382
branch
October 11, 2026 06:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABWX-XDw
A
minimal.tomlspelling the stack table[harness]— the pre-v0.5.0 name — only warned as an unknown field and loaded with no stack, so the missing toolchain surfaced much later aserror: linker 'cc' not foundfrom a build inside the session.File::validatenow refuses the table at load, so every disk load fails before any session is built, with a message naming the rename to[stack](informed by #192, which retired the spelling). Both disk loaders (from_dir,from_dir_recursive) runvalidate;File::from_toml_bytesdoes not. Themisplaced_top_level_keyhint is folded into the error and the reference doc now says the load fails instead of warning.Verification
cargo fmt --all --check --locked— cleancargo clippy --workspace --all-targets --locked -- -D warnings— cleancargo test --locked -p mfile— 69 passed, 0 failed (incl. rewrittenharness_table_no_longer_parses, which now expects the load error)min task run buildwent from warning + daemon spawn toerror: found a broken minimal.toml while resolving tasks:[harness]is no longer accepted: it sets no stack, so its toolchain would be missing. Rename the table to[stack].Breaking change
BREAKING CHANGE: a
minimal.tomlwith a top-levelharnesskey no longer loads. On main it loaded with a warning and no stack. Rename the table to[stack]. This applies to every layer's file, so an upstream layer that still carries the table fails the load too.Summary by CodeRabbit
[harness]section now fail to load with guidance to rename it to[stack], instead of continuing without a stack.