Repository navigation
fix(minimal): say the finalize-install egress item plainly - #2179
Merged
norrietaylor merged 3 commits intoOct 12, 2026
Merged
Conversation
The classifier item of min finalize-install --show rendered in design vocabulary a reader cannot act on: "classifier", "host-address boxes", "run unenforced", "egress verdict", "placement unit", "runs unplaced", "delegation", "socket table lookup", "did not read". Reword its label, its three today lines, its this-step line, its eight cannot-do causes, and the matching KVM-item cause in plain language that names the CLI words (--network host_ip with --deny-all-egress), and update the six pinned unit-test assertions. Wording only: no behaviour, flag, JSON key, item id or exit code changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 9920ade)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
…py cost Without its systemd units a daemon restart leaves the daemon outside the tree, so a deny-all box is refused, not run unenforced; only a reboot loses the tree. The stale-copy state also covers a host with no copy at all. The label becomes a noun phrase so a done line never reads as a claim that deny-all egress is enforced on a host whose table is not refusing, and drops the flag form, which named only one of the two ways to declare it.
…label The missing-units line fires when any one unit or wants link is absent, so it says what a daemon restart and a reboot can cost, not what they always cost. The label names the flag pair that declares the box and a unit test pins it.
norrietaylor
enabled auto-merge (squash)
October 12, 2026 05:32
norrietaylor
disabled auto-merge
October 12, 2026 05:50
norrietaylor
deleted the
fix/reword-finalize-install-egress-item-0.7.0
branch
October 12, 2026 05:50
norrietaylor
added a commit
that referenced
this pull request
Oct 15, 2026
* fix(minimal): say the finalize-install egress item plainly The classifier item of min finalize-install --show rendered in design vocabulary a reader cannot act on: "classifier", "host-address boxes", "run unenforced", "egress verdict", "placement unit", "runs unplaced", "delegation", "socket table lookup", "did not read". Reword its label, its three today lines, its this-step line, its eight cannot-do causes, and the matching KVM-item cause in plain language that names the CLI words (--network host_ip with --deny-all-egress), and update the six pinned unit-test assertions. Wording only: no behaviour, flag, JSON key, item id or exit code changes. (cherry picked from commit 9920ade) * fix(minimal): state what the egress item's missing units and stale copy cost Without its systemd units a daemon restart leaves the daemon outside the tree, so a deny-all box is refused, not run unenforced; only a reboot loses the tree. The stale-copy state also covers a host with no copy at all. The label becomes a noun phrase so a done line never reads as a claim that deny-all egress is enforced on a host whose table is not refusing, and drops the flag form, which named only one of the two ways to declare it. * fix(minimal): hedge the egress item's missing-units line and pin its label The missing-units line fires when any one unit or wants link is absent, so it says what a daemon restart and a reboot can cost, not what they always cost. The label names the flag pair that declares the box and a unit test pins it. --------- (cherry picked from commit 69f2d32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix commit from #2178, rebuilt on top of
release/0.7.0, plus the corrections review asked for.#2178 cannot land as opened: its base is main and its branch replays eight release-branch commits on top of main. This PR carries only the real change,
crates/minimal/src/cmd/finalize_install.rs. The first commit is cherry-picked from 9920ade with its original author.What changes
The egress-enforcement item of
min finalize-installis reworded in plain language: its label, its status lines, its step line and its causes. No behaviour, flag, JSON key, item id or exit code changes.multi-user.targetlink is absent, so it says what each event can cost.Not in this PR
The
--show --scriptcomments and echo, the--undonotes incrates/minimal/src/resolver.rs, and the item's bullet indocs/reference/cli-min.mdstill use the older terms. They change together with their test pins in a later wording PR onrelease/0.7.0.Test plan
classifier_item_tablepins the label, the three status lines, the step line and the causes.kvm_item_tablepins the KVM cause.