Skip to content

fix(minimal): say the finalize-install egress item plainly - #2179

Merged
norrietaylor merged 3 commits into
release/0.7.0from
fix/reword-finalize-install-egress-item-0.7.0
Oct 12, 2026
Merged

norrietaylor merged 3 commits into
release/0.7.0from
fix/reword-finalize-install-egress-item-0.7.0

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

The fix commit from #2178, rebuilt on top of release/0.7.0, plus the corrections review asked for.

#2178 cannot land as opened: its base is main and its branch replays eight release-branch commits on top of main. This PR carries only the real change, crates/minimal/src/cmd/finalize_install.rs. The first commit is cherry-picked from 9920ade with its original author.

What changes

The egress-enforcement item of min finalize-install is reworded in plain language: its label, its status lines, its step line and its causes. No behaviour, flag, JSON key, item id or exit code changes.

  • The label is a noun phrase, "deny-all egress enforcement for boxes that share this machine's address (--network host_ip with --deny-all-egress)". It prints after a done mark, after a missing mark and under "can't do on this machine:", so it names the thing and never claims a state.
  • The missing-units line separates the two costs. A daemon restart without the placement unit leaves deny-all boxes refused. A reboot without the boot unit leaves deny-all egress not enforced. The line fires when any one unit or multi-user.target link is absent, so it says what each event can cost.
  • The stale-copy line also covers a host with no installed copy at all.
  • The step line says what the units do: restore the cgroup tree and packet filter at boot, and place the daemon under them on every daemon start.
  • One line outside the egress item changes with its twin: the KVM item's cause for an unreadable user name now reads "could not read this process's user name, so there is no account to add to the kvm group".

Not in this PR

The --show --script comments and echo, the --undo notes in crates/minimal/src/resolver.rs, and the item's bullet in docs/reference/cli-min.md still use the older terms. They change together with their test pins in a later wording PR on release/0.7.0.

Test plan

  • CI lanes on this PR.
  • classifier_item_table pins the label, the three status lines, the step line and the causes. kvm_item_table pins the KVM cause.

The classifier item of min finalize-install --show rendered in design
vocabulary a reader cannot act on: "classifier", "host-address
boxes", "run unenforced", "egress verdict", "placement unit",
"runs unplaced", "delegation", "socket table lookup", "did not
read". Reword its label, its three today lines, its this-step line,
its eight cannot-do causes, and the matching KVM-item cause in plain
language that names the CLI words (--network host_ip with
--deny-all-egress), and update the six pinned unit-test assertions.
Wording only: no behaviour, flag, JSON key, item id or exit code
changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 9920ade)
@norrietaylor
norrietaylor requested a review from a team as a code owner October 12, 2026 03:01
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 285154d8-d76e-4bb9-be27-4bc4694993d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at b64acd28b802.

Nothing to do.

Clobber: none: git log --oneline on the file shows no recently shipped fix being silently reverted — the three head commits are the PR's own progressive rewordings.

…py cost

Without its systemd units a daemon restart leaves the daemon outside the
tree, so a deny-all box is refused, not run unenforced; only a reboot
loses the tree. The stale-copy state also covers a host with no copy at
all. The label becomes a noun phrase so a done line never reads as a claim
that deny-all egress is enforced on a host whose table is not refusing, and
drops the flag form, which named only one of the two ways to declare it.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 12, 2026
…label

The missing-units line fires when any one unit or wants link is absent, so
it says what a daemon restart and a reboot can cost, not what they always
cost. The label names the flag pair that declares the box and a unit test
pins it.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@norrietaylor
norrietaylor enabled auto-merge (squash) October 12, 2026 05:32
@norrietaylor
norrietaylor disabled auto-merge October 12, 2026 05:50
@norrietaylor
norrietaylor merged commit 69f2d32 into release/0.7.0 Oct 12, 2026
35 of 37 checks passed
@norrietaylor
norrietaylor deleted the fix/reword-finalize-install-egress-item-0.7.0 branch October 12, 2026 05:50
norrietaylor added a commit that referenced this pull request Oct 15, 2026
* fix(minimal): say the finalize-install egress item plainly

The classifier item of min finalize-install --show rendered in design
vocabulary a reader cannot act on: "classifier", "host-address
boxes", "run unenforced", "egress verdict", "placement unit",
"runs unplaced", "delegation", "socket table lookup", "did not
read". Reword its label, its three today lines, its this-step line,
its eight cannot-do causes, and the matching KVM-item cause in plain
language that names the CLI words (--network host_ip with
--deny-all-egress), and update the six pinned unit-test assertions.
Wording only: no behaviour, flag, JSON key, item id or exit code
changes.

(cherry picked from commit 9920ade)

* fix(minimal): state what the egress item's missing units and stale copy cost

Without its systemd units a daemon restart leaves the daemon outside the
tree, so a deny-all box is refused, not run unenforced; only a reboot
loses the tree. The stale-copy state also covers a host with no copy at
all. The label becomes a noun phrase so a done line never reads as a claim
that deny-all egress is enforced on a host whose table is not refusing, and
drops the flag form, which named only one of the two ways to declare it.

* fix(minimal): hedge the egress item's missing-units line and pin its label

The missing-units line fires when any one unit or wants link is absent, so
it says what a daemon restart and a reboot can cost, not what they always
cost. The label names the flag pair that declares the box and a unit test
pins it.

---------

(cherry picked from commit 69f2d32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant