Repository navigation
fix(minimal): reword the min ls header rows and list warnings in plain language - #2182
Merged
Merged
Conversation
…n language Rename the ZONE ANSWERER row label to DNS SERVICE and NAME SURFACE to BOX NAMES (17-column width kept), say what each port row is for instead of the unrunnable resolver instruction, and reword three list warnings: the skipped-VM warning names the consequence, the proxy-down warning drops the implementation words, and the still-starting duplicate-session warning points at `min ls` and `min session attach`. Comments, test pins and session-e2e.sh reads that name the old labels move with them. No behaviour, flag, JSON field or exit code changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 2a1ecb0)
Contributor
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: the commit is a cherry-picked single reword on top of release/0.7.0; nothing reverts recent work. |
The duplicate-session warning for a session still being created named a bare `min session attach`, which fails as printed; it now carries the same key the active arm prints. `min finalize-install` reads the same listings as `min ls` but lists no sessions, so the skipped-VM warning only says "its sessions are not listed" under `min ls`.
… the attach placeholder Restore the native DNS row body to the text the VM-host arms and `min session activate` still print, so one row has one wording. Name the proxy in the listener warning as the HOSTNAME PROXY row does, and pin the e2e patterns on the `warning: ` prefix so the row bodies cannot satisfy them. Show `min session attach <session>` in the still-being-created hint so no printed command names a session attach would refuse.
min ls names the row DNS SERVICE, so min session activate now prints "DNS service:" where it printed "zone answerer:". Both verbs name the same holder under the same label. The text after the label is unchanged. Comments that still named the old min ls rows, ZONE ANSWERER and NAME SURFACE, now say DNS SERVICE and BOX NAMES.
norrietaylor
enabled auto-merge (squash)
October 12, 2026 05:32
norrietaylor
disabled auto-merge
October 12, 2026 06:23
norrietaylor
added a commit
that referenced
this pull request
Oct 15, 2026
…n language (#2182) * fix(minimal): reword the min ls header rows and list warnings in plain language Rename the ZONE ANSWERER row label to DNS SERVICE and NAME SURFACE to BOX NAMES (17-column width kept), say what each port row is for instead of the unrunnable resolver instruction, and reword three list warnings: the skipped-VM warning names the consequence, the proxy-down warning drops the implementation words, and the still-starting duplicate-session warning points at `min ls` and `min session attach`. Comments, test pins and session-e2e.sh reads that name the old labels move with them. No behaviour, flag, JSON field or exit code changes. (cherry picked from commit 2a1ecb0) * fix(minimal): name the session in the wait-then-attach hint The duplicate-session warning for a session still being created named a bare `min session attach`, which fails as printed; it now carries the same key the active arm prints. `min finalize-install` reads the same listings as `min ls` but lists no sessions, so the skipped-VM warning only says "its sessions are not listed" under `min ls`. * fix(minimal): keep the DNS row body, name the hostname proxy and show the attach placeholder Restore the native DNS row body to the text the VM-host arms and `min session activate` still print, so one row has one wording. Name the proxy in the listener warning as the HOSTNAME PROXY row does, and pin the e2e patterns on the `warning: ` prefix so the row bodies cannot satisfy them. Show `min session attach <session>` in the still-being-created hint so no printed command names a session attach would refuse. * fix(minimal): print the DNS service label at session start min ls names the row DNS SERVICE, so min session activate now prints "DNS service:" where it printed "zone answerer:". Both verbs name the same holder under the same label. The text after the label is unchanged. Comments that still named the old min ls rows, ZONE ANSWERER and NAME SURFACE, now say DNS SERVICE and BOX NAMES. --------- (cherry picked from commit 89515db)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix commit from #2181, rebuilt as one commit on top of
release/0.7.0.#2181 was opened against main and its branch replays the release-branch commits on top of main, so it cannot land on either branch. This PR carries only the real change, cherry-picked from 2a1ecb0 with its original author.
What changes
min lsrow labelsZONE ANSWERER:andNAME SURFACE:becomeDNS SERVICE:andBOX NAMES:, at the same column width.min session activateprintsDNS service:where it printedzone answerer:, so both verbs name the row the same way.HOSTNAME PROXY:row drops "routes through it" and says it is the HTTP proxy for<box>.min.internalnames.warning: the hostname proxy is not serving: ..., naming the proxy as its row does. The still-being-created hint showsmin session attach <session>with a placeholder, because attach would refuse that session until it is active.What does not change
release/0.7.0in every form of the row and in both verbs, including "point the host's resolver at it for *.min.internal". A later PR changes every form together.HOSTNAME PROXY:label and thelistening on 127.0.0.1:<port>words stay, so scripts that read the port keep working.Spec 18 is stale on the two labels
docs/specs/18-spec-box-networking/18-spec-box-networking.mdline 262 (under NET-018) still saysmin lskeeps theZONE ANSWERER:andNAME SURFACE:labels, and its note on line 265 describes the rows in the old words. The maintainer decided to keep the rename and amend the spec separately, so this PR does not edit the spec. No spec fixes themin session activatelabel.Test plan
session_start_names_the_zone_answerer_at_every_startpins theDNS service:label on the activate line.Summary by CodeRabbit
min lsbefore attaching, and use the full UUID when attaching to unnamed sessions.