Skip to content

fix(minimal): reword the min ls header rows and list warnings in plain language - #2182

Merged
norrietaylor merged 4 commits into
release/0.7.0from
fix/reword-min-ls-header-rows-0.7.0
Oct 12, 2026
Merged

norrietaylor merged 4 commits into
release/0.7.0from
fix/reword-min-ls-header-rows-0.7.0

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

The fix commit from #2181, rebuilt as one commit on top of release/0.7.0.

#2181 was opened against main and its branch replays the release-branch commits on top of main, so it cannot land on either branch. This PR carries only the real change, cherry-picked from 2a1ecb0 with its original author.

What changes

  • The min ls row labels ZONE ANSWERER: and NAME SURFACE: become DNS SERVICE: and BOX NAMES:, at the same column width.
  • min session activate prints DNS service: where it printed zone answerer:, so both verbs name the row the same way.
  • The HOSTNAME PROXY: row drops "routes through it" and says it is the HTTP proxy for <box>.min.internal names.
  • Three list warnings say what happened in plain words. The listener warning now starts warning: the hostname proxy is not serving: ..., naming the proxy as its row does. The still-being-created hint shows min session attach <session> with a placeholder, because attach would refuse that session until it is active.

What does not change

  • The text after the DNS label is the same as on release/0.7.0 in every form of the row and in both verbs, including "point the host's resolver at it for *.min.internal". A later PR changes every form together.
  • The HOSTNAME PROXY: label and the listening on 127.0.0.1:<port> words stay, so scripts that read the port keep working.
  • No behaviour, flag, JSON or exit code changes.

Spec 18 is stale on the two labels

docs/specs/18-spec-box-networking/18-spec-box-networking.md line 262 (under NET-018) still says min ls keeps the ZONE ANSWERER: and NAME SURFACE: labels, and its note on line 265 describes the rows in the old words. The maintainer decided to keep the rename and amend the spec separately, so this PR does not edit the spec. No spec fixes the min session activate label.

Test plan

  • CI lanes on this PR; the CLI tests and the session e2e pin the new text.
  • session_start_names_the_zone_answerer_at_every_start pins the DNS service: label on the activate line.

Summary by CodeRabbit

  • Improvements
    • Updated session and VM listing labels to use “BOX NAMES” and “DNS SERVICE.”
    • Clarified duplicate-session guidance: wait for the session to appear in min ls before attaching, and use the full UUID when attaching to unnamed sessions.
    • Clarified warnings about unavailable hostname routing and sessions omitted from listings.

…n language

Rename the ZONE ANSWERER row label to DNS SERVICE and NAME SURFACE to
BOX NAMES (17-column width kept), say what each port row is for instead
of the unrunnable resolver instruction, and reword three list warnings:
the skipped-VM warning names the consequence, the proxy-down warning
drops the implementation words, and the still-starting duplicate-session
warning points at `min ls` and `min session attach`.

Comments, test pins and session-e2e.sh reads that name the old labels
move with them. No behaviour, flag, JSON field or exit code changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 2a1ecb0)
@norrietaylor
norrietaylor requested a review from a team as a code owner October 12, 2026 03:07
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: bd5ca2c2-b3c0-4c69-bf1a-3a16d44b1371

📥 Commits

Reviewing files that changed from the base of the PR and between 108f52a and 300b47b.


📒 Files selected for processing (7)
  • crates/minimal/src/cmd/list.rs
  • crates/minimal/src/cmd/session.rs
  • crates/minimal/src/resolver.rs
  • crates/minimal/src/tests.rs
  • crates/minimal/tests/cli.rs
  • crates/minimald/src/server.rs
  • scripts/session-e2e.sh

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The CLI updates pending-session guidance and skipped-VM warnings. Listing labels change to BOX NAMES and DNS SERVICE, with revised hostname-proxy wording. Unit tests, CLI integration tests, and E2E script checks use the updated text.

Changes

Listing guidance and output

Layer / File(s) Summary
Session and VM listing warnings
crates/minimal/src/cmd/list.rs, crates/minimal/src/tests.rs
Pending-session guidance now tells users to check min ls until the session is active, then attach with a session placeholder. Strict-mode warnings explicitly state that the skipped VM’s sessions are not listed.
Listing labels and proxy wording
crates/minimal/src/cmd/list.rs, crates/minimal/src/cmd/session.rs, crates/minimal/src/resolver.rs, crates/minimal/src/tests.rs, crates/minimal/tests/cli.rs, crates/minimald/src/server.rs, scripts/session-e2e.sh
Listing labels change to BOX NAMES and DNS SERVICE. Hostname-proxy descriptions and warnings use updated wording. Related unit, CLI integration, and E2E expectations are updated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Suggested reviewers: 0chroma


Merge Risk: 🟡 Moderate · up to 300b4

min ls changes its specified row labels without updating the binding contract. Align the output and specification before merging.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: rewording min ls headers and warnings. It uses a valid Conventional Commit format and an imperative verb.
Description check Passed The description provides a detailed change summary, scope, testing plan, compatibility notes, and an explanation for the stale specification. It does not include the template's literal ## Summary, `…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 28 functions across 6 files. (1 skipped: 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit reads the listing lines,
“BOX NAMES” shines where labels changed.
“DNS SERVICE” hops into view,
Pending sessions wait for green,
Then off I bound to attach anew!

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 300b47b0cb34.

Nothing to do.

Clobber: none: the commit is a cherry-picked single reword on top of release/0.7.0; nothing reverts recent work.

The duplicate-session warning for a session still being created named a
bare `min session attach`, which fails as printed; it now carries the
same key the active arm prints.

`min finalize-install` reads the same listings as `min ls` but lists no
sessions, so the skipped-VM warning only says "its sessions are not
listed" under `min ls`.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Comment thread crates/minimal/src/cmd/list.rs Resolved
… the attach placeholder

Restore the native DNS row body to the text the VM-host arms and
`min session activate` still print, so one row has one wording.
Name the proxy in the listener warning as the HOSTNAME PROXY row does,
and pin the e2e patterns on the `warning: ` prefix so the row bodies
cannot satisfy them. Show `min session attach <session>` in the
still-being-created hint so no printed command names a session attach
would refuse.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Comment thread crates/minimal/src/cmd/list.rs Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Comment thread crates/minimal/src/cmd/list.rs Resolved
min ls names the row DNS SERVICE, so min session activate now prints
"DNS service:" where it printed "zone answerer:". Both verbs name the
same holder under the same label. The text after the label is unchanged.

Comments that still named the old min ls rows, ZONE ANSWERER and
NAME SURFACE, now say DNS SERVICE and BOX NAMES.
@norrietaylor norrietaylor reopened this Oct 12, 2026
@norrietaylor
norrietaylor enabled auto-merge (squash) October 12, 2026 05:32

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@norrietaylor
norrietaylor disabled auto-merge October 12, 2026 06:23
@norrietaylor
norrietaylor merged commit 89515db into release/0.7.0 Oct 12, 2026
32 checks passed
@norrietaylor
norrietaylor deleted the fix/reword-min-ls-header-rows-0.7.0 branch October 12, 2026 06:23
norrietaylor added a commit that referenced this pull request Oct 15, 2026
…n language (#2182)

* fix(minimal): reword the min ls header rows and list warnings in plain language

Rename the ZONE ANSWERER row label to DNS SERVICE and NAME SURFACE to
BOX NAMES (17-column width kept), say what each port row is for instead
of the unrunnable resolver instruction, and reword three list warnings:
the skipped-VM warning names the consequence, the proxy-down warning
drops the implementation words, and the still-starting duplicate-session
warning points at `min ls` and `min session attach`.

Comments, test pins and session-e2e.sh reads that name the old labels
move with them. No behaviour, flag, JSON field or exit code changes.

(cherry picked from commit 2a1ecb0)

* fix(minimal): name the session in the wait-then-attach hint

The duplicate-session warning for a session still being created named a
bare `min session attach`, which fails as printed; it now carries the
same key the active arm prints.

`min finalize-install` reads the same listings as `min ls` but lists no
sessions, so the skipped-VM warning only says "its sessions are not
listed" under `min ls`.

* fix(minimal): keep the DNS row body, name the hostname proxy and show the attach placeholder

Restore the native DNS row body to the text the VM-host arms and
`min session activate` still print, so one row has one wording.
Name the proxy in the listener warning as the HOSTNAME PROXY row does,
and pin the e2e patterns on the `warning: ` prefix so the row bodies
cannot satisfy them. Show `min session attach <session>` in the
still-being-created hint so no printed command names a session attach
would refuse.

* fix(minimal): print the DNS service label at session start

min ls names the row DNS SERVICE, so min session activate now prints
"DNS service:" where it printed "zone answerer:". Both verbs name the
same holder under the same label. The text after the label is unchanged.

Comments that still named the old min ls rows, ZONE ANSWERER and
NAME SURFACE, now say DNS SERVICE and BOX NAMES.

---------

(cherry picked from commit 89515db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant