Repository navigation
fix(minimal): skip the port-prompt subscription for a box with no host row - #2187
Merged
norrietaylor merged 3 commits intoOct 12, 2026
Merged
Conversation
…t row On a VM-backed host every interactive attach to a box on the default network mode printed two warnings before the shell took over. The attach subscribed to port prompts for every box, but only an own_ip box registers a row with the VM host daemon, so the row read answered "no row" for a feature the box does not have. Subscribe only when the session's record carries box_addresses. A subscription that was attempted and failed now says so once: the logged event drops to debug and the printed line stays.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
|
Reading This comment updates when the review finishes. |
…rt-prompt-subscribe-0.7.0
…cord cannot be read A record that could not be read does not say the box registered no row, so the attach still subscribes by name and warns once if that fails. A record that was read and carries no address pair still skips silently. The session e2e now fails if a default-mode attach prints the port-prompt warning.
norrietaylor
added a commit
that referenced
this pull request
Oct 15, 2026
…t row (#2187) * fix(minimal): skip the port-prompt subscription for a box with no host row On a VM-backed host every interactive attach to a box on the default network mode printed two warnings before the shell took over. The attach subscribed to port prompts for every box, but only an own_ip box registers a row with the VM host daemon, so the row read answered "no row" for a feature the box does not have. Subscribe only when the session's record carries box_addresses. A subscription that was attempted and failed now says so once: the logged event drops to debug and the printed line stays. * fix(minimal): keep the port-prompt subscription when the session's record cannot be read A record that could not be read does not say the box registered no row, so the attach still subscribes by name and warns once if that fails. A record that was read and carries no address pair still skips silently. The session e2e now fails if a default-mode attach prints the port-prompt warning. --------- (cherry picked from commit 22bf27a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a VM-backed host, every interactive attach to a box on the default network mode printed two warnings just before the shell took over:
Nothing was wrong when they printed. The attach subscribed to port prompts for every box on a VM-backed host, but only an
own_ipbox registers a row with the VM host daemon, and only anown_ipbox can ask to publish a port.What changes
host_asks_target.own_ipbox keeps its port prompts, and a failed attempt prints the one warning.crates/minimal/src/cmd/session.rs;scripts/session-e2e.shgains one assertion.Test plan
host_asks_target: a read record with no address pair gives no target; an address pair with a box name and a control socket gives one; an unreadable record gives the by-name target.scripts/session-e2e.sh: the sandbox proof's default-mode attach fails if its terminal shows the port-prompt warning. It runs in this PR's e2e lanes; not run locally.just clippyand the threehost_asks_targettests pass. The fulljust testlast ran at 683f643 (3725 passed, 24 skipped).