Repository navigation
fix(net): gloss the classifier hint's two address placeholders - #2120
gominimal-aw-bot[bot] wants to merge 3 commits into
Conversation
The NET-079 advisory a step-missing host prints at activate ships `<cohort address>` and `<node-plane address>` in its install line, two placeholders no host operator can fill: the daemon cannot know either value (the install records only the ct-mark mask beside the marker, no `min net` surface prints them, and the installer itself refuses to guess), so a person running `min` in $HOME with an empty box has no way to know what goes there. Replace each bare placeholder with the installer's own gloss of the value it stands for -- what the boxes cohort leaves as, what the rest of the slice leaves as -- the words `require_identities` already uses for the two identities the classification rests on, so the hint names what each value is instead of leaving angle brackets that read as an error. Add the scoping sentence the same advisory owes a first-time reader: only a host-address box with an egress section is affected, and a box with none behaves the same with or without the step. It rides the existing "whatever the boxes' declarations say" clause, so it is carried only while that clause is -- the native step and mount causes, where the claim holds -- and never over a refusal, where it would be false. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A host-address box with no egress section keeps the allow verdict whether or not the host decides per box, but on a deciding host its traffic leaves as the cohort's identity, and the mount's cause is not ended by the step. Say it keeps its allow-all verdict either way, and pin that the sentence rides only with the unenforced clause.
|
/review |
| // Over a refusal the | ||
| // sentence would be false — a deny-all declaration is the one |
There was a problem hiding this comment.
NIT · style · confidence 0.80 · in classifier_advisory_text
In the added comment, the sentence "Over a refusal the sentence would be false" is soft-wrapped mid-phrase: // Over a refusal the is followed by // sentence would be false, splitting "the sentence" across two comment lines. The wrap reads awkwardly and could be reflowed so the phrase stays together, e.g. // Over a refusal the sentence would be false — ... on one line.
| // Over a refusal the | |
| // sentence would be false — a deny-all declaration is the one | |
| // Over a refusal the sentence would be false — a deny-all declaration is the one |
What the reviewer checked
rpc.rs:554-555 // Over a refusal the
// sentence would be false — a deny-all declaration is the one
Hand this to an agent
Act on a code-review finding.
File: crates/minimald/src/rpc.rs
Lines: 554-555
Category: style
Severity: nit (reviewer confidence 0.80)
Finding:
In the added comment, the sentence "Over a refusal the sentence would be false" is soft-wrapped mid-phrase: `// Over a refusal the` is followed by `// sentence would be false`, splitting "the sentence" across two comment lines. The wrap reads awkwardly and could be reflowed so the phrase stays together, e.g. `// Over a refusal the sentence would be false — ...` on one line.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
|
Closing as superseded. The |
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABWKn67w
The NET-079 advisory a step-missing host prints at activate ships
<cohort address>and<node-plane address>in its install line --placeholders no operator can fill, because the daemon cannot know
either value: the install records only the ct-mark mask, no
min netsurface prints them, and the installer itself refuses to guess. Each
placeholder now carries the installer's own gloss of the value it
stands for (what the boxes cohort leaves as, what the rest of the
slice leaves as), and the advisory gains the scoping sentence a first
activate owes: only a host-address box with an egress section is
affected; a box with none behaves the same with or without the step.
Verification
cargo fmt --all --check --manifest-path target/Cargo.toml-- cleancargo clippy --workspace --all-targets --locked --manifest-path target/Cargo.toml-- zero warningscargo test --locked --manifest-path target/Cargo.toml -p sandbox2-- 63 passedcargo test --locked --manifest-path target/Cargo.toml -p minimald-rpc-- 65 passedcargo test --locked --manifest-path target/Cargo.toml -p minimald --lib rpc::tests-- 63 passedcargo test --locked --manifest-path target/Cargo.toml -p minimald --lib session_host-- 84 passedcargo test --locked --manifest-path target/Cargo.toml -p minimald --lib net::classifier-- 41 passedcargo test --locked --manifest-path target/Cargo.toml -p minimal --lib cmd::session-- 39 passedThe full minimald suite shows 11 failures in net::switch/connection
that are pre-existing on clean main (verified by stash and re-run):
they need netns/relay machinery this sandbox lacks, and none touch the
advisory. scripts/install_test.sh could not be executed under the
sandbox allowlist; the diff leaves that script and the installer
untouched, so their pins are unaffected. The wording defect is not
runtime-reproducible here (it needs a step-missing native host), so
the proof is the pure-function suites above.
Summary by CodeRabbit