Skip to content

fix(net): gloss the classifier hint's two address placeholders - #2120

Closed
gominimal-aw-bot[bot] wants to merge 3 commits into
mainfrom
inbox-patch/fix/classifier-advisory-placeholder-glosses-a86a93beef3e5df4
Closed

gominimal-aw-bot[bot] wants to merge 3 commits into
mainfrom
inbox-patch/fix/classifier-advisory-placeholder-glosses-a86a93beef3e5df4

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Routing-Key: inbox-route/I_kwDOSUhdos8AAAABWKn67w

The NET-079 advisory a step-missing host prints at activate ships
<cohort address> and <node-plane address> in its install line --
placeholders no operator can fill, because the daemon cannot know
either value: the install records only the ct-mark mask, no min net
surface prints them, and the installer itself refuses to guess. Each
placeholder now carries the installer's own gloss of the value it
stands for (what the boxes cohort leaves as, what the rest of the
slice leaves as), and the advisory gains the scoping sentence a first
activate owes: only a host-address box with an egress section is
affected; a box with none behaves the same with or without the step.

Verification

  • cargo fmt --all --check --manifest-path target/Cargo.toml -- clean
  • cargo clippy --workspace --all-targets --locked --manifest-path target/Cargo.toml -- zero warnings
  • cargo test --locked --manifest-path target/Cargo.toml -p sandbox2 -- 63 passed
  • cargo test --locked --manifest-path target/Cargo.toml -p minimald-rpc -- 65 passed
  • cargo test --locked --manifest-path target/Cargo.toml -p minimald --lib rpc::tests -- 63 passed
  • cargo test --locked --manifest-path target/Cargo.toml -p minimald --lib session_host -- 84 passed
  • cargo test --locked --manifest-path target/Cargo.toml -p minimald --lib net::classifier -- 41 passed
  • cargo test --locked --manifest-path target/Cargo.toml -p minimal --lib cmd::session -- 39 passed

The full minimald suite shows 11 failures in net::switch/connection
that are pre-existing on clean main (verified by stash and re-run):
they need netns/relay machinery this sandbox lacks, and none touch the
advisory. scripts/install_test.sh could not be executed under the
sandbox allowlist; the diff leaves that script and the installer
untouched, so their pins are unaffected. The wording defect is not
runtime-reproducible here (it needs a step-missing native host), so
the proof is the pure-function suites above.

Summary by CodeRabbit

  • Documentation
    • Clarified that classifier advisories apply only to host-address boxes with an egress section. Boxes without one behave the same whether or not the classifier step is installed.
    • Updated installation guidance to clarify that the cohort and node-plane addresses are host-specific choices and must be distinct.

The NET-079 advisory a step-missing host prints at activate ships
`<cohort address>` and `<node-plane address>` in its install line, two
placeholders no host operator can fill: the daemon cannot know either
value (the install records only the ct-mark mask beside the marker, no
`min net` surface prints them, and the installer itself refuses to
guess), so a person running `min` in $HOME with an empty box has no way
to know what goes there. Replace each bare placeholder with the
installer's own gloss of the value it stands for -- what the boxes
cohort leaves as, what the rest of the slice leaves as -- the words
`require_identities` already uses for the two identities the
classification rests on, so the hint names what each value is instead
of leaving angle brackets that read as an error.

Add the scoping sentence the same advisory owes a first-time reader:
only a host-address box with an egress section is affected, and a box
with none behaves the same with or without the step. It rides the
existing "whatever the boxes' declarations say" clause, so it is
carried only while that clause is -- the native step and mount causes,
where the claim holds -- and never over a refusal, where it would be
false.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gominimal-aw-bot
gominimal-aw-bot Bot requested a review from a team as a code owner October 9, 2026 19:22
@gominimal-aw-bot gominimal-aw-bot Bot added the agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. label Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

Or wait 9 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 24 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: bab3099f-7d37-4234-8df8-6f44d1ddb3ea

📥 Commits

Reviewing files that changed from the base of the PR and between 60b07d1 and 9c8704f.


📒 Files selected for processing (4)
  • crates/minimal/src/cmd/session.rs
  • crates/minimald-rpc/src/lib.rs
  • crates/minimald/src/rpc.rs
  • crates/sandbox2/src/lib.rs


No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2bcb48ad-6026-4788-b3d7-4e1847e147f0

📥 Commits

Reviewing files that changed from the base of the PR and between ea1b015 and 60b07d1.


📒 Files selected for processing (4)
  • crates/minimal/src/cmd/session.rs
  • crates/minimald-rpc/src/lib.rs
  • crates/minimald/src/rpc.rs
  • crates/sandbox2/src/lib.rs

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.



📝 Walkthrough

Walkthrough

Classifier advisories now state that only host-address boxes with an egress section are affected. Related test fixtures and installer guidance use the same scope and clarify the two distinct host-specific address choices.

Changes

Classifier guidance

Layer / File(s) Summary
Advisory scope and install guidance
crates/minimald/src/rpc.rs, crates/minimal/src/cmd/session.rs, crates/minimald-rpc/src/lib.rs, crates/sandbox2/src/lib.rs
Advisory text and test fixtures specify that boxes without an egress section behave the same with or without the classifier step. The installer hint describes two distinct host-specific identities and labels their address placeholders.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: norrietaylor


Merge Risk: ⚪ Minimal · up to 60b07

The advisory and address labels match the implementation; no material installation or runtime risk remains established.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the main change: adding meaningful descriptions for the classifier hint's two address placeholders. It is concise and follows the required Conventional Commit format.
Description check Passed The description clearly explains the change and its rationale, and it provides detailed verification results, known environment limitations, and test failures. It does not use the template's exact Sum…


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit reads the hints with care,
Two distinct addresses wait there.
No egress? The text says what to expect,
The fixtures now reflect that check.
I hop away, my notes all neat.

Comment @coderabbitai help to get the list of available commands.

@gominimal-aw-bot gominimal-aw-bot Bot added the agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch label Oct 9, 2026
A host-address box with no egress section keeps the allow verdict whether
or not the host decides per box, but on a deciding host its traffic leaves
as the cohort's identity, and the mount's cause is not ended by the step.
Say it keeps its allow-all verdict either way, and pin that the sentence
rides only with the unenforced clause.
@norrietaylor norrietaylor changed the title fix: fix(net): gloss the classifier hint's two address placeholders fix(net): gloss the classifier hint's two address placeholders Oct 9, 2026
@norrietaylor

Copy link
Copy Markdown
Member

/review

@minimal-foundry

minimal-foundry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Approved: 1 finding, none above this repo's threshold at 9c8704f09a61.

Nothing to do.

Clobber: none: git log on the touched files shows the branch's own prior advisory commits (6b717f6, 60b07d1) continuing; nothing reverted.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — 1 finding, 1 inline.

Comment on lines +554 to +555
// Over a refusal the
// sentence would be false — a deny-all declaration is the one

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT · style · confidence 0.80 · in classifier_advisory_text

In the added comment, the sentence "Over a refusal the sentence would be false" is soft-wrapped mid-phrase: // Over a refusal the is followed by // sentence would be false, splitting "the sentence" across two comment lines. The wrap reads awkwardly and could be reflowed so the phrase stays together, e.g. // Over a refusal the sentence would be false — ... on one line.

Suggested change
// Over a refusal the
// sentence would be false — a deny-all declaration is the one
// Over a refusal the sentence would be false — a deny-all declaration is the one
What the reviewer checked

rpc.rs:554-555 // Over a refusal the
// sentence would be false — a deny-all declaration is the one

Hand this to an agent
Act on a code-review finding.

File:       crates/minimald/src/rpc.rs
Lines:      554-555
Category:   style
Severity:   nit (reviewer confidence 0.80)

Finding:
In the added comment, the sentence "Over a refusal the sentence would be false" is soft-wrapped mid-phrase: `// Over a refusal the` is followed by `// sentence would be false`, splitting "the sentence" across two comment lines. The wrap reads awkwardly and could be reflowed so the phrase stays together, e.g. `// Over a refusal the sentence would be false — ...` on one line.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 9, 2026
@norrietaylor

Copy link
Copy Markdown
Member

Closing as superseded. The <cohort address> / <node-plane address> placeholders this explains are being removed: #2137 amends NET-079's advisory so the command is min finalize-install, and #2128/#2142 replace the install line. A native host with no association also needs neither value (NET-078). The new scoping sentence would also be wrong for a box that declares egress with a flag (--deny-all-egress, an allow or deny flag) and has no egress section.

@norrietaylor
norrietaylor deleted the inbox-patch/fix/classifier-advisory-placeholder-glosses-a86a93beef3e5df4 branch October 12, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:fix Agentic fix PR eligible for review iteration; min-aw's worker-iterate gates on it. agent:resolve Consent gate: pr-conflict-resolver may rewrite this branch review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants