Repository navigation
fix(orchestrator): carry the current span into spawned deliverable tasks - #2123
Closed
bryan-minimal wants to merge 1 commit into
Closed
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
JoinSet::spawn does not inherit the caller's tracing span, so every build, cache-fill and subset task (and the source downloads and materialize spans inside it) started a new root trace. In build-servers' Cloud Trace that is ~740 orphan roots a day from res-server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
norrietaylor
approved these changes
Oct 10, 2026
norrietaylor
left a comment
Member
There was a problem hiding this comment.
Architecture review: span propagation only; conforms to architecture.md and the arch specs. Approved.
Member
Author
|
Superseded by #1995 (98dbe05, 2026-10-13), which wraps each spawned deliverable in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JoinSet::spawndoesn't inherit the caller's tracing span. So each build, cache-fill and subset task the orchestrator spawns starts outside the request's trace, and so does every span inside it (download_with_verification_and_caching,download_web_with_verification_and_caching,materialize).Seen in build-servers' Cloud Trace: over 24 h, about 740 root spans from res-server with no parent (454 + 244 downloads, 45 materialize), so a run's trace stops at
grpc.server. build-servers#309 fixed the same thing for res-server's own spawns; this is the layer below.Fix:
.in_current_span()on the three spawned futures. No behaviour change otherwise.🤖 Generated with Claude Code
Summary by CodeRabbit