Repository navigation
fix(cargo): remove the committed buf registry token - #2204
Merged
Merged
Conversation
.cargo/config.toml held one thing: a `[registries.buf]` entry whose `token` line was a bearer credential in plain text, tracked since the initial commit. No dependency resolves through that registry (Cargo.lock has no buf.build source), no crate names `registry = "buf"`, and no workflow or script reads it, so the whole file goes rather than the one line. The token is still in history. Rotate it at buf.build; a later need for the registry goes through `CARGO_REGISTRIES_BUF_TOKEN` or a gitignored `.cargo/credentials.toml`, never a tracked file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
mitodrummer
approved these changes
Oct 14, 2026
norrietaylor
added a commit
that referenced
this pull request
Nov 4, 2026
.cargo/config.toml held one thing: a [registries.buf] entry whose token line was a bearer credential in plain text. No dependency resolves through that registry, no crate names registry = "buf", and no workflow or script reads it, so the whole file goes rather than the one line. The token is still in history and needs rotating at buf.build. Backport of #2204. Applied unchanged; the line's file matched main's. (cherry picked from commit 813e4e5)
Merged
norrietaylor
added a commit
that referenced
this pull request
Nov 5, 2026
.cargo/config.toml held one thing: a [registries.buf] entry whose token line was a bearer credential in plain text. No dependency resolves through that registry, no crate names registry = "buf", and no workflow or script reads it, so the whole file goes rather than the one line. The token is still in history and needs rotating at buf.build. Backport of #2204. Applied unchanged; the line's file matched main's. (cherry picked from commit 813e4e5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
.cargo/config.toml. Its only content was a[registries.buf]entry whosetokenline was a bearer credential in plain text, tracked since the initial commit.Why the whole file
Cargo.lockhas nobuf.buildsource.registry = "buf".Follow-up for the owner
The token remains in git history. Rotate it at buf.build. If the registry is needed later, supply the credential through
CARGO_REGISTRIES_BUF_TOKENor a gitignored.cargo/credentials.toml, never a tracked file.Found while surveying the tree for the quality-metrics work (spec 30).
🤖 Generated with Claude Code
Summary by CodeRabbit