Repository navigation
ci(release): drop distro packages from the 0.7.0 release - #2214
Conversation
Remove the nfpm packaging step, the packages artifact, the package attachments on the draft release, the versions/<semver>/pkg/ staging and the .deb install smoke from release.yml. Remove publish-packages.yml and the publish_packages input from promote.yml; the draft-release publish job that lived in publish-packages.yml moves into promote.yml unchanged in behaviour, so a stable promotion still creates the v<semver> tag. stage-release.sh loses --pkg-dir/--pkg-only and its harness the matching cases. The curl|sh installer is the only install path for 0.7.0.
Delete the AUR and Homebrew templates, the nfpm config and its vendored lock, and the scripts that rendered, built, smoked and published the packages, with their harnesses and justfile recipes. packaging/macos/ and packaging/apparmor/ stay: the minzoned app bundle and min finalize-install use them. Comments that pointed at the removed files are reworded. The /usr/bin/gvproxy-min probe in the switch crate stays, since hosts that installed an earlier distro package still have the binary there.
Drop the AUR and Homebrew publish step, its secrets, the pkg/ folder, the .deb smoke and publish-packages.yml from the release pipeline doc, and describe the draft-release publish as a promote.yml job.
|
Approved: no findings at Nothing to do. Clobber: none: |
There was a problem hiding this comment.
correctness
minimal-review — approved
Verdict APPROVE — No findings.
security
minimal-review — approved
Verdict APPROVE — No findings.
supply-chain
minimal-review — approved
Verdict APPROVE — No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
msample
left a comment
There was a problem hiding this comment.
LGTM. This removes the .deb/.rpm/.apk, AUR and Homebrew outputs and nothing else. The inlined promote.yml publish job behaves the same as publish-packages.yml's publish-release. Applied on release/0.7.0, the release-related shell harnesses and just lint-shell pass, and there are no leftover packaging references.
A few things worth knowing before or after merge:
- This only covers
release/0.7.0.mainstill carries all the packaging (packaging/nfpm.yaml, the publishers, thepublish_packagesinput), so the next release cut frommainbrings it back. If the removal is meant to be permanent,mainneeds the same change. - Check the infra repo. The deleted workflow says the apt/dnf/apk repo trees are built in the infra repo from
versions/<semver>/pkg/. 0.7.0 won't stage that folder, so make sure that job won't fail on 0.7.0. - Existing AUR/Homebrew users stay on 0.6.x.
minimal-binon the AUR and thegominimal/homebrew-minimaltap won't get updates. Consider a deprecation notice or archiving them. Once nothing usesAUR_SSH_PRIVATE_KEYandBREW_TAP_TOKEN, those secrets can be deleted. - Needs CODEOWNER sign-off. This edits
.github/workflows/, which is frozen and CODEOWNER-gated. - Nit (non-blocking):
stage-release.shkeeps thesmoked_invalidatedguard ininvalidate_smoked(). It existed to stop a second call when both the row and--pkg-dirpaths ran. There's only one call site now, so it's dead code. Harmless, but it could go.
mitodrummer
left a comment
There was a problem hiding this comment.
Checked the head for anything still pointing at the removed packaging and found nothing; the inlined publish job does the same thing the deleted publish-release job did, and CI is green. Two questions, neither blocking: main still has the packaging (packaging/arch, packaging/homebrew, nfpm.yaml, publish-packages.yml), so is 0.8.0 keeping it, and if not, will a matching PR go to main? Also, the existing v0.7.0-rc2 draft already has the .deb/.rpm/.apk files attached and versions/0.7.0-rc2/pkg/ is staged, so 0.7.0 needs a new versioned cut from this branch rather than a promotion of rc2.
We will merge back
The final staged release will override those when we push to stable. |
* ci(release): drop distro packages from the 0.7.0 release Remove the nfpm packaging step, the packages artifact, the package attachments on the draft release, the versions/<semver>/pkg/ staging and the .deb install smoke from release.yml. Remove publish-packages.yml and the publish_packages input from promote.yml; the draft-release publish job that lived in publish-packages.yml moves into promote.yml unchanged in behaviour, so a stable promotion still creates the v<semver> tag. stage-release.sh loses --pkg-dir/--pkg-only and its harness the matching cases. The curl|sh installer is the only install path for 0.7.0. * chore(packaging): remove the aur, homebrew and nfpm packaging Delete the AUR and Homebrew templates, the nfpm config and its vendored lock, and the scripts that rendered, built, smoked and published the packages, with their harnesses and justfile recipes. packaging/macos/ and packaging/apparmor/ stay: the minzoned app bundle and min finalize-install use them. Comments that pointed at the removed files are reworded. The /usr/bin/gvproxy-min probe in the switch crate stays, since hosts that installed an earlier distro package still have the binary there. * docs(release): describe the installer-only release pipeline Drop the AUR and Homebrew publish step, its secrets, the pkg/ folder, the .deb smoke and publish-packages.yml from the release pipeline doc, and describe the draft-release publish as a promote.yml job. * chore(release): drop the package publishers from the version-check rationale (cherry picked from commit d7ed0b0)
) #2214 deleted vendor/nfpm when the release dropped distro packages, and the merge-back brought that into main. #1875 then merged a pin table that still listed vendor/nfpm/nfpm.lock, so the real-tree check in the deps-freshness harness fails with "pin unreadable" and reds ci-linux-native on main. Drop the nfpm row and its fixture lines.
Summary
0.7.0 ships with the curl|sh installer as its only install path. This removes all distro packaging (AUR, Homebrew, and the nfpm-built
.deb/.rpm/.apk) fromrelease/0.7.0.Removed
packaging/arch/,packaging/homebrew/,packaging/nfpm.yaml,vendor/nfpm/.scripts/publish-aur.sh,publish-brew.sh,render-packaging.sh,package-nfpm.sh,pkg-smoke.sh, and their*_test.shharnesses.pkg-nfpmandpkg-smokejustfile recipes, and the/dist/.gitignoreentry that only servedpkg-nfpm..github/workflows/publish-packages.yml.promote.yml: thepublish_packagesinput, its line in the approval issue, and the reusable-workflow call (with itssecrets: inherit) that ran the AUR/Homebrew jobs.release.yml: the nfpm packaging step, thepackagesartifact upload/downloads, copying packages into the draft release, the--pkg-dirstaging ofversions/<semver>/pkg/, and the "Install the .deb and check the version it reports" smoke step.smoke-linux-amd64no longer needsassert-version, since only the deb step used it.stage-release.sh:--pkg-dir/--pkg-onlyand theupload_pkg_dirpath, plus the matchingstage-release_test.shcases and fixture.docs/internal/release-pipeline.md: step 7 (publish_packages=true), the AUR/tap secret prerequisites, the rollback warning about packages, the.deb/package rows in the test table and the nightly-vs-versioned table,pkg/, and thepublish-packages.ymlsection.There were no nfpm entries in
Cargo.toml,Cargo.lock, or.tool-versions..tool-versionspins only shellcheck, so it stays.Kept, and why
promote.yml.publish-packages.ymlheld three jobs, and the first one (publish-release) is not packaging: it publishes the draft GitHub Release, which creates thev<semver>tag. Deleting the file alone would leave stable promotions unable to tag. The job is now inlined aspromote.yml'spublishjob with the same gate (target == stable && !dry_run), the same checks (missing release fails; an already public release is left alone only if its tag sits on the release commit; the 0.5.x branch-target case), and--latestfor non-prereleases. It drops thesemveroutput and the AUR/Homebrew notices.packaging/macos/(the minzoned app bundle and icon from #2125 and #2188), and minzoned shipping as flat binaries and in the bundle.packaging/apparmor/:min finalize-installembeds it (crates/minimal/src/cmd/finalize_install.rs), and the installer's AppArmor step uses it.scripts/install.shand its tests). Only its packaging hooks went, along with the files they lived in.scripts/dist-build.sh: release.yml's Linux build jobs call it.scripts/latest-staged-version.sh: promote.yml uses it.scripts/assert-release-version.sh: no workflow calls it, but it is the tag-vs-package.versioncheck for builds outside the pipeline, and the release doc andCargo.tomlpoint at it. It is not packaging.scripts/backfill-version-row.shand its recipe: it was written for the packagers, but the semver row it backfills is also whatinstall.sh --version <semver>reads. Its header and recipe comment now say that.resolve-release-version.shwas already gone (#1375)./usr/bin/gvproxy-minprobe, and the session-e2e half that exercises it. Hosts that installed an earlier distro package still have the binary there. Only the comments that pointed at the deleted packaging files changed.Why this is not a literal revert
#1313 (8e7e72c) introduced the packaging, but later commits on this branch build on it and mix packaging with non-packaging changes:
release.yml/promote.ymlaround a build-once versioned release and addedpublish-packages.yml, which also carries the draft-release publish that creates the tag.publish_packages).minzonedand touchednfpm.yaml,package-nfpm.sh,dist-build.shandstage-release.sh.min finalize-installhooks to the AUR install script,nfpm.yamlandpackage-nfpm.sh, alongside the installer change that stays.packaging/macos/, which stays.Reverting #1313 would also drop
dist-build.sh,assert-release-version.sh,latest-staged-version.shand the shell-harness runner, and would conflict with all of the above.Commits
ci(release): drop distro packages from the 0.7.0 release: workflows,stage-release.sh, and its harness.chore(packaging): remove the aur, homebrew and nfpm packaging: packaging files, scripts, recipes,.gitignore, and stale comments.docs(release): describe the installer-only release pipelinechore(release): drop the package publishers from the version-check rationale: a comment innext-version.sh.Test plan
Run on macOS arm64 in a clean worktree of this branch:
Not verified here:
just ciandjust test-crosswere not run. The Rust changes are comment-only (crates/switch/src/lib.rs,crates/common/tests/shell_harnesses.rs).Left as is
docs/specs/07-spec-installer/07-spec-installer.mdstill describes native packages as the intended primary path. It is a design spec, not install instructions.docs/internal/macos-runner-setup.mdmentions a nightlybrew-install-nightlyjob. That job does not exist on this branch.Summary by CodeRabbit