Skip to content

ci(release): drop distro packages from the 0.7.0 release - #2214

Merged
norrietaylor merged 4 commits into
release/0.7.0from
chore/drop-distro-packages-from-0.7.0
Oct 15, 2026
Merged

norrietaylor merged 4 commits into
release/0.7.0from
chore/drop-distro-packages-from-0.7.0

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Summary

0.7.0 ships with the curl|sh installer as its only install path. This removes all distro packaging (AUR, Homebrew, and the nfpm-built .deb/.rpm/.apk) from release/0.7.0.

Removed

  • packaging/arch/, packaging/homebrew/, packaging/nfpm.yaml, vendor/nfpm/.
  • scripts/publish-aur.sh, publish-brew.sh, render-packaging.sh, package-nfpm.sh, pkg-smoke.sh, and their *_test.sh harnesses.
  • The pkg-nfpm and pkg-smoke justfile recipes, and the /dist/ .gitignore entry that only served pkg-nfpm.
  • .github/workflows/publish-packages.yml.
  • promote.yml: the publish_packages input, its line in the approval issue, and the reusable-workflow call (with its secrets: inherit) that ran the AUR/Homebrew jobs.
  • release.yml: the nfpm packaging step, the packages artifact upload/downloads, copying packages into the draft release, the --pkg-dir staging of versions/<semver>/pkg/, and the "Install the .deb and check the version it reports" smoke step. smoke-linux-amd64 no longer needs assert-version, since only the deb step used it.
  • stage-release.sh: --pkg-dir/--pkg-only and the upload_pkg_dir path, plus the matching stage-release_test.sh cases and fixture.
  • docs/internal/release-pipeline.md: step 7 (publish_packages=true), the AUR/tap secret prerequisites, the rollback warning about packages, the .deb/package rows in the test table and the nightly-vs-versioned table, pkg/, and the publish-packages.yml section.

There were no nfpm entries in Cargo.toml, Cargo.lock, or .tool-versions. .tool-versions pins only shellcheck, so it stays.

Kept, and why

  • The draft-release publish job moved into promote.yml. publish-packages.yml held three jobs, and the first one (publish-release) is not packaging: it publishes the draft GitHub Release, which creates the v<semver> tag. Deleting the file alone would leave stable promotions unable to tag. The job is now inlined as promote.yml's publish job with the same gate (target == stable && !dry_run), the same checks (missing release fails; an already public release is left alone only if its tag sits on the release commit; the 0.5.x branch-target case), and --latest for non-prereleases. It drops the semver output and the AUR/Homebrew notices.
  • packaging/macos/ (the minzoned app bundle and icon from #2125 and #2188), and minzoned shipping as flat binaries and in the bundle.
  • packaging/apparmor/: min finalize-install embeds it (crates/minimal/src/cmd/finalize_install.rs), and the installer's AppArmor step uses it.
  • The installer side of #2143 (scripts/install.sh and its tests). Only its packaging hooks went, along with the files they lived in.
  • scripts/dist-build.sh: release.yml's Linux build jobs call it.
  • scripts/latest-staged-version.sh: promote.yml uses it.
  • scripts/assert-release-version.sh: no workflow calls it, but it is the tag-vs-package.version check for builds outside the pipeline, and the release doc and Cargo.toml point at it. It is not packaging.
  • scripts/backfill-version-row.sh and its recipe: it was written for the packagers, but the semver row it backfills is also what install.sh --version <semver> reads. Its header and recipe comment now say that.
  • resolve-release-version.sh was already gone (#1375).
  • The switch crate's /usr/bin/gvproxy-min probe, and the session-e2e half that exercises it. Hosts that installed an earlier distro package still have the binary there. Only the comments that pointed at the deleted packaging files changed.

Why this is not a literal revert

#1313 (8e7e72c) introduced the packaging, but later commits on this branch build on it and mix packaging with non-packaging changes:

  • #1375 (23929a6) restructured release.yml/promote.yml around a build-once versioned release and added publish-packages.yml, which also carries the draft-release publish that creates the tag.
  • #1695 (e5b0b89) made AUR/Homebrew publishing opt-in (publish_packages).
  • #1971 (66bdb90), #2002 (95dcab8) and #2188 (6c6a33f) ship minzoned and touched nfpm.yaml, package-nfpm.sh, dist-build.sh and stage-release.sh.
  • #2143 (a6357c2) added min finalize-install hooks to the AUR install script, nfpm.yaml and package-nfpm.sh, alongside the installer change that stays.
  • #2125 (d626cc6) and #2188 added packaging/macos/, which stays.

Reverting #1313 would also drop dist-build.sh, assert-release-version.sh, latest-staged-version.sh and the shell-harness runner, and would conflict with all of the above.

Commits

  • ci(release): drop distro packages from the 0.7.0 release: workflows, stage-release.sh, and its harness.
  • chore(packaging): remove the aur, homebrew and nfpm packaging: packaging files, scripts, recipes, .gitignore, and stale comments.
  • docs(release): describe the installer-only release pipeline
  • chore(release): drop the package publishers from the version-check rationale: a comment in next-version.sh.

Test plan

Run on macOS arm64 in a clean worktree of this branch:

$ just test-shell            # shellcheck scripts/*_test.sh, then every harness
== running scripts/assert-release-version_test.sh ==   14 passed, 0 failed
== running scripts/check-zoned-links_test.sh ==        18 passed, 0 failed, 1 skipped
== running scripts/install_test.sh ==                  # 756 passed, 0 failed
== running scripts/latest-staged-version_test.sh ==    6 passed, 0 failed
== running scripts/next-version_test.sh ==             62 passed, 0 failed
== running scripts/smoked_test.sh ==                   22 passed, 0 failed
== running scripts/stage-release_test.sh ==            69 passed, 0 failed
(exit 0)

$ just check-version
next-version: package.version 0.7.0-rc2 satisfies the 370 commit(s) since v0.6.0 (minor bump, at least 0.7.0) and is greater than the newest tag v0.6.0

$ just lint-shell
lint-shell: 44 script(s) passed shellcheck

$ actionlint .github/workflows/release.yml .github/workflows/promote.yml
(no output, exit 0)

$ python3 -c 'import yaml; ...'   # both workflows parse
ok .github/workflows/release.yml
ok .github/workflows/promote.yml

$ just fmt-check
cargo fmt --all -- --check   (exit 0)

$ just lint-prose docs/internal/release-pipeline.md
✔ 0 errors, 0 warnings and 0 suggestions in 1 file.

$ git grep -n -I -i -E 'nfpm|package-nfpm|pkg-smoke|publish-aur|publish-brew|publish-packages|render-packaging|PKGBUILD|publish_packages|homebrew-minimal|BREW_TAP|AUR_SSH'
(no hits)

Not verified here:

  • The workflows' runtime behaviour. No workflow was dispatched; the release dry run is a separate step.
  • just ci and just test-cross were not run. The Rust changes are comment-only (crates/switch/src/lib.rs, crates/common/tests/shell_harnesses.rs).

Left as is

  • docs/specs/07-spec-installer/07-spec-installer.md still describes native packages as the intended primary path. It is a design spec, not install instructions.
  • docs/internal/macos-runner-setup.md mentions a nightly brew-install-nightly job. That job does not exist on this branch.

Summary by CodeRabbit

  • Changes
    • Versioned releases no longer include Debian, RPM, or APK packages. Linux users will need to use another installation method.
    • Arch Linux and Homebrew packages are no longer published through the release process.
    • Releases continue to provide binaries, guest artifacts, and shell completions.

Remove the nfpm packaging step, the packages artifact, the package
attachments on the draft release, the versions/<semver>/pkg/ staging and
the .deb install smoke from release.yml. Remove publish-packages.yml and
the publish_packages input from promote.yml; the draft-release publish
job that lived in publish-packages.yml moves into promote.yml unchanged
in behaviour, so a stable promotion still creates the v<semver> tag.

stage-release.sh loses --pkg-dir/--pkg-only and its harness the matching
cases. The curl|sh installer is the only install path for 0.7.0.
Delete the AUR and Homebrew templates, the nfpm config and its vendored
lock, and the scripts that rendered, built, smoked and published the
packages, with their harnesses and justfile recipes. packaging/macos/
and packaging/apparmor/ stay: the minzoned app bundle and
min finalize-install use them.

Comments that pointed at the removed files are reworded. The
/usr/bin/gvproxy-min probe in the switch crate stays, since hosts that
installed an earlier distro package still have the binary there.
Drop the AUR and Homebrew publish step, its secrets, the pkg/ folder,
the .deb smoke and publish-packages.yml from the release pipeline doc,
and describe the draft-release publish as a promote.yml job.
@norrietaylor
norrietaylor requested a review from a team as a code owner October 14, 2026 23:45
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5df214cc-f0ae-4938-ae81-b8fda4525994
📥 Commits

Reviewing files that changed from the base of the PR and between 6fc7894 and 9dffcb8.

⛔ Files ignored due to path filters: 1
  • vendor/nfpm/nfpm.lock is excluded by !**/*.lock
📒 Files selected for processing: 27
  • .github/workflows/promote.yml
  • .github/workflows/publish-packages.yml
  • .github/workflows/release.yml
  • .gitignore
  • crates/common/tests/shell_harnesses.rs
  • crates/switch/src/lib.rs
  • docs/internal/release-pipeline.md
  • justfile
  • packaging/arch/PKGBUILD-bin.tmpl
  • packaging/arch/minimal-bin.install
  • packaging/homebrew/minimal.rb.tmpl
  • packaging/nfpm.yaml
  • scripts/backfill-version-row.sh
  • scripts/dist-build.sh
  • scripts/next-version.sh
  • scripts/package-nfpm.sh
  • scripts/pkg-smoke.sh
  • scripts/pkg-smoke_test.sh
  • scripts/publish-aur.sh
  • scripts/publish-aur_test.sh
  • scripts/publish-brew.sh
  • scripts/publish-brew_test.sh
  • scripts/render-packaging.sh
  • scripts/render-packaging_test.sh
  • scripts/session-e2e.sh
  • scripts/stage-release.sh
  • scripts/stage-release_test.sh
💤 Files with no reviewable changes: 15
  • scripts/render-packaging.sh
  • scripts/publish-aur_test.sh
  • packaging/nfpm.yaml
  • scripts/pkg-smoke_test.sh
  • scripts/publish-brew.sh
  • scripts/render-packaging_test.sh
  • .gitignore
  • packaging/homebrew/minimal.rb.tmpl
  • packaging/arch/PKGBUILD-bin.tmpl
  • scripts/package-nfpm.sh
  • packaging/arch/minimal-bin.install
  • scripts/publish-aur.sh
  • scripts/publish-brew_test.sh
  • scripts/pkg-smoke.sh
  • .github/workflows/publish-packages.yml

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The promotion workflow now publishes stable GitHub Releases directly. The release pipeline no longer builds or stages distro packages, and the package definitions, smoke tests, and AUR and Homebrew publishing tools are removed.

Changes: Release distribution

Layer / File(s) Summary
Publish releases during promotion
.github/workflows/promote.yml, .github/workflows/publish-packages.yml
The promotion workflow removes the publish_packages input and handles release publication directly. It checks versioned releases and existing tags, publishes drafts, and applies the Latest setting based on prerelease status. The reusable publishing workflow is deleted.
Remove package artifacts from release staging
.github/workflows/release.yml, scripts/stage-release.sh, scripts/stage-release_test.sh
The release workflow no longer builds, attaches, stages, or smoke-tests distro packages. Staging no longer supports package-specific options, and its test fixture now covers artifacts only.
Remove package and repository tooling
packaging/*, scripts/package-nfpm.sh, scripts/pkg-smoke*, scripts/publish-*, scripts/render-packaging*, justfile, .gitignore
Package definitions, generation and smoke-test scripts, AUR and Homebrew publishing tools, related just recipes, and the packaging output ignore rule are removed.
Update release documentation and references
docs/internal/release-pipeline.md, crates/common/tests/shell_harnesses.rs, crates/switch/src/lib.rs, scripts/backfill-version-row.sh, scripts/dist-build.sh, scripts/next-version.sh, scripts/session-e2e.sh, justfile
The release guide no longer describes distro packages or AUR and Homebrew publishing. Related descriptions and comments use updated release and installer terminology, including references to package paths used by earlier releases.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant Promotion as promote.yml
  participant Release as GitHub Release
  participant Tag as Version tag
  Promotion->>Release: Look up the versioned release
  Release-->>Promotion: Return release status and target
  Promotion->>Tag: Check tag existence and target
  Promotion->>Release: Publish the draft with the applicable Latest setting
Loading

Suggested reviewers: 0chroma

Merge Risk: ⚪ Minimal · up to 9dffc

No actionable merge-blocking issue was identified. Normal release checks remain appropriate.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Docstring Coverage Inconclusive Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files. (5 skipped: 4… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: removing distro packages from the 0.7.0 release. It follows the repository's Conventional Commit format.
Description check Passed The description is detailed and on topic. It includes a complete summary, implementation scope, retained behavior, rationale, test results, unverified items, and documentation impact. The literal Chec…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files. (5 skipped: 4 unsupported, 1 too large.)

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Vale (3.23.0)

{
"Line": 0,
"Path": "",
"Text": "E100 [loadStyles] Runtime error\n\nstyle 'ste' does not exist on StylesPath\n\nExecution stopped with code 1.",
"Code": "E100",
"Span": 0
}

A rabbit checks the release tag,
Then watches drafts go live.
No package bundles cross the path,
No tap or AUR scripts arrive.
The changelog rests beneath the moon,
While carrots mark the drive.

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 9dffcb8399de.

Nothing to do.

Clobber: none: git log on release.yml/promote.yml shows the head commit as the only new change; everything deleted traces to the packaging commits this PR explicitly intends to revert (#1313, #1375, #1695). No unrelated recent fix is silently reverted.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness

minimal-review — approved

Verdict APPROVE — No findings.

security

minimal-review — approved

Verdict APPROVE — No findings.

supply-chain

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 14, 2026

@msample msample left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This removes the .deb/.rpm/.apk, AUR and Homebrew outputs and nothing else. The inlined promote.yml publish job behaves the same as publish-packages.yml's publish-release. Applied on release/0.7.0, the release-related shell harnesses and just lint-shell pass, and there are no leftover packaging references.

A few things worth knowing before or after merge:

  1. This only covers release/0.7.0. main still carries all the packaging (packaging/nfpm.yaml, the publishers, the publish_packages input), so the next release cut from main brings it back. If the removal is meant to be permanent, main needs the same change.
  2. Check the infra repo. The deleted workflow says the apt/dnf/apk repo trees are built in the infra repo from versions/<semver>/pkg/. 0.7.0 won't stage that folder, so make sure that job won't fail on 0.7.0.
  3. Existing AUR/Homebrew users stay on 0.6.x. minimal-bin on the AUR and the gominimal/homebrew-minimal tap won't get updates. Consider a deprecation notice or archiving them. Once nothing uses AUR_SSH_PRIVATE_KEY and BREW_TAP_TOKEN, those secrets can be deleted.
  4. Needs CODEOWNER sign-off. This edits .github/workflows/, which is frozen and CODEOWNER-gated.
  5. Nit (non-blocking): stage-release.sh keeps the smoked_invalidated guard in invalidate_smoked(). It existed to stop a second call when both the row and --pkg-dir paths ran. There's only one call site now, so it's dead code. Harmless, but it could go.

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the head for anything still pointing at the removed packaging and found nothing; the inlined publish job does the same thing the deleted publish-release job did, and CI is green. Two questions, neither blocking: main still has the packaging (packaging/arch, packaging/homebrew, nfpm.yaml, publish-packages.yml), so is 0.8.0 keeping it, and if not, will a matching PR go to main? Also, the existing v0.7.0-rc2 draft already has the .deb/.rpm/.apk files attached and versions/0.7.0-rc2/pkg/ is staged, so 0.7.0 needs a new versioned cut from this branch rather than a promotion of rc2.

@norrietaylor

norrietaylor commented Oct 15, 2026 •

Copy link
Copy Markdown
Member Author

so is 0.8.0 keeping it, and if not, will a matching PR go to main?

We will merge back

Also, the existing v0.7.0-rc2 draft already has the .deb/.rpm/.apk files attached and versions/0.7.0-rc2/pkg/ is staged, so 0.7.0 needs a new versioned cut from this branch rather than a promotion of rc2

The final staged release will override those when we push to stable.

@norrietaylor
norrietaylor merged commit d7ed0b0 into release/0.7.0 Oct 15, 2026
32 checks passed
@norrietaylor
norrietaylor deleted the chore/drop-distro-packages-from-0.7.0 branch October 15, 2026 00:31
norrietaylor added a commit that referenced this pull request Oct 15, 2026
* ci(release): drop distro packages from the 0.7.0 release

Remove the nfpm packaging step, the packages artifact, the package
attachments on the draft release, the versions/<semver>/pkg/ staging and
the .deb install smoke from release.yml. Remove publish-packages.yml and
the publish_packages input from promote.yml; the draft-release publish
job that lived in publish-packages.yml moves into promote.yml unchanged
in behaviour, so a stable promotion still creates the v<semver> tag.

stage-release.sh loses --pkg-dir/--pkg-only and its harness the matching
cases. The curl|sh installer is the only install path for 0.7.0.

* chore(packaging): remove the aur, homebrew and nfpm packaging

Delete the AUR and Homebrew templates, the nfpm config and its vendored
lock, and the scripts that rendered, built, smoked and published the
packages, with their harnesses and justfile recipes. packaging/macos/
and packaging/apparmor/ stay: the minzoned app bundle and
min finalize-install use them.

Comments that pointed at the removed files are reworded. The
/usr/bin/gvproxy-min probe in the switch crate stays, since hosts that
installed an earlier distro package still have the binary there.

* docs(release): describe the installer-only release pipeline

Drop the AUR and Homebrew publish step, its secrets, the pkg/ folder,
the .deb smoke and publish-packages.yml from the release pipeline doc,
and describe the draft-release publish as a promote.yml job.

* chore(release): drop the package publishers from the version-check rationale

(cherry picked from commit d7ed0b0)
norrietaylor added a commit that referenced this pull request Oct 17, 2026
)

#2214 deleted vendor/nfpm when the release dropped distro packages, and the
merge-back brought that into main. #1875 then merged a pin table that still
listed vendor/nfpm/nfpm.lock, so the real-tree check in the deps-freshness
harness fails with "pin unreadable" and reds ci-linux-native on main.

Drop the nfpm row and its fixture lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants