Repository navigation
feat(min): add min box spec with root fingerprint, upstream set, steering and full marker - #2443
Conversation
…dgement A GitHub grant with github:repo:* scopes narrower than full is refused with exit 3 on an un-enrolled host unless the client configuration acknowledges full-breadth minting. A project file that sets the acknowledgement in [session.secrets] has it ignored with a warning. Quic443 gains the resolved stance.
min box spec reads the project's minimal.toml and prints the proxy's root CA fingerprint, each broker grant with its GitHub hosts and the full marker, store references, the steering mode, and the quic443 stance when HTTP/3 bypasses the proxy. The client config.toml [secrets] acknowledge_full_breadth_unenrolled is read from the user and organization configuration; without it a narrower grant exits 3.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Approved: no findings at Nothing to do. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: CONDITIONS · 4 conditions · the full ruling
The refusal and the rows conform, but the acknowledged path that Gatehouse §6.10 line 853 requires does not work. The [secrets] key that the refusal tells the operator to set breaks read_client_config(), because Config is deny_unknown_fields (C2). Activation still ignores the acknowledgement, so min session refuses what min box spec shows as full (C3). The positional PATH takes the <entry|box|self> slot that architecture.md line 472 defines (C1). off steering with a broker grant is not flagged as networking §5.4 line 172 requires (C4).
Outside the diff
crates/minimal/src/cmd/session.rs:669: C3 · PassHostFacts { full_breadth_acknowledged: crate::config::full_breadth_acknowledged(global)?, ..HostFacts::LOCAL }here. Gatehouse §6.10 line 853 mints an acknowledged narrower grantfull. It does not refuse it.
Ruled at 161bbbb against gominimal/arch@3dab1097cda1 by claude-opus-5-5.
The box start path passed HostFacts::LOCAL to check_activation, so a narrow GitHub grant was refused even with acknowledge_full_breadth_unenrolled set, while min box spec accepted it. Start now reads the same client configuration when a grant needs it. The min box spec root row now says it shows the key thumbprint, because the proxy issues no root certificate yet.
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The BEP-057 refusal and the min box spec rows conform to Gatehouse §6.10 line 853. The acknowledged path does not work. The exit-3 message tells the operator to add [secrets] to config.toml. boxes::client::config::Config refuses that unknown table, so after that edit the box does not start and min ls fails. Add the [secrets] section to the client Config, and read the acknowledgement through it (C1). Also file an issue for each of the two interims in min box spec, and name the issues (C2).
Ruled at 5f50795 against gominimal/arch@3dab1097cda1 by claude-opus-5-5.
|
Round 1 of 10 on the runtime's review findings, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Notes from the agent: Out of layers: crates/minimal/src/cmd/session.rs. Threads 1 and 3 need it. The BEP-057 refusal that this pull request added to check_activation also runs at box start (refuse_unhonourable_grants). That path passed HostFacts::LOCAL, so with the acknowledgement set, box start still refused a narrow grant. I added a full_breadth_acknowledged argument. Start reads config::full_breadth_acknowledged only when a grant is narrower than full, so a malformed config.toml cannot block other boxes. I also added the test start_honours_full_breadth_acknowledgement. Thread 2: the proxy issues no root certificate yet (crates/bep/src/publish.rs), so a certificate fingerprint does not exist to print. The row now says |
|
/revise minimal-arch ruled CONDITIONS on 5f50795 (check run on the head, arch_rulings 72): two conditions, and the steering warning the 161bbbb ruling asked for (its C4) is still missing from
The Generated by Claude Code |
…oot-fingerprint-the-upstream-set-steer
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The compare meets the open conditions from the ruling on 5f50795. The [secrets] acknowledgement is now part of the client Config, so min session can read a config.toml that carries it. Gatehouse §6.10 line 853 puts the acknowledgement in the client configuration, and this head does that. min box spec now writes the steering off warning with exit 0, as Networking §5.4 line 172 requires. The two interims name #2445 and #2446. The change to crates/boxes/src/client/config.rs is outside the task layers, but the design places the client configuration there.
Ruled at 19b84d4 against gominimal/arch@3dab1097cda1 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 10 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:419, minimal-arch[bot] crates/minimal/src/config.rs, minimal-arch[bot] crates/minimal/src/cmd/box_spec.rs:123, minimal-foundry[bot] crates/boxes/src/core/bep.rs:201, minimal-foundry[bot] crates/minimal/src/cmd/box_spec.rs:193, …. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
|
Round 2 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Notes from the agent: Round 2 does only the three items in the /revise note, in commit 6538d8d. (1) crates/boxes/src/client/config.rs is outside the task layers. The note asks for this change by name: Config gains |
norrietaylor
left a comment
There was a problem hiding this comment.
Own review of 19b84d4 (round 2 on the arch directive).
- Arch C1 (client config reader): verified.
SecretsConfigon the typedConfig,acknowledged_inthroughread_config_or_default, private parser deleted, tests in both crates. - Arch C2 (interims): verified. #2445 and #2446 named at both sites and in the body.
- Steering
offwith a grant (§5.4 line 172): verified inrender(), exit 0, covered by the test. - Start path (
refuse_unhonourable_grants): reads the acknowledgement lazily and passes it intoHostFacts;start_honours_full_breadth_acknowledgementproves both branches. - Layers:
crates/boxes/src/client/config.rsis outside the task's layers; recorded as a Layer exception in the body on the same basis assession.rs(arch required the placement). - Threads: nine resolved with the verification above. One stays open for the epic owner: the HIGH security finding on
narrow_scopestreating onlygithub:repo:*as narrow. BEP-057 is worded exactly that way, so the code is spec-faithful; whether anothergithub:scope should count is a spec question.
minimal-arch ruled PASS on this head. Approval follows the owner's ruling on the open thread and the macOS lane.
Generated by Claude Code
…oot-fingerprint-the-upstream-set-steer # Conflicts: # crates/minimal/src/cmd/mod.rs
There was a problem hiding this comment.
arch-review: PASS · the full ruling
This head merges main into the head that got a PASS (19b84d4e). The PR's own changes did not change. The one conflict in crates/minimal/src/cmd/mod.rs keeps both mod auth; and mod box_spec;. The new min auth code does not read the full-breadth acknowledgement. BEP-038 and BEP-057 still conform to Gatehouse §6.10 line 853.
Ruled at 99f9067 against gominimal/arch@3dab1097cda1 by claude-opus-5-5.
|
A merge of main before round 3, not counted against the cap (1 of 3), pushed as Resolved conflicts in:
Verify Outside the task's
Converted to a draft: something above needs a person before review. On this branch, merged with main, Notes from the agent: Conflict round only. crates/minimal/src/cmd/mod.rs had one conflict: HEAD added |
norrietaylor
left a comment
There was a problem hiding this comment.
Own review carried to 99f9067. This head is the runtime's merge of main (5919d28) before round 3, resolving crates/minimal/src/cmd/mod.rs; the branch's own diff against main is the same 8 files as at 19b84d4, and the runtime review carried its approval ("Already reviewed at 19b84d4, which this head only merged the base onto"). minimal-arch ruled PASS on this head. The review of 19b84d4 stands. The HIGH thread on narrow_scopes is re-opened: a security thread closes on the epic owner's ruling, not on a base merge.
Generated by Claude Code
norrietaylor
left a comment
There was a problem hiding this comment.
Approving for merge: T15 on 99f9067 after the epic owner ruled on the HIGH scope thread (dispute accepted, gominimal/arch#136 filed). Gate passes (arch PASS, review approved, no open threads, lanes green, squash subject lint-clean).
Generated by Claude Code
T15 — Show the root fingerprint, the upstream set, steering and the full marker in min box spec
slice: S0
kind: task
covers: BEP-038, BEP-057
size: L
est: 400 code, 360 tests
executor: agent
difficulty: routine
model: standard
diagnostics:
min box specprintsroot CA <sha256 fingerprint>, onegrant github:user-token fullrow per grant with its upstream hosts,steering proxy_env, and, where the stance is allowed on a grant box,quic443 allowed (HTTP/3 bypasses the proxy), pinned by box_spec_renders_ca_upstreams_steering_and_referencesobservability: one debug log line per render naming the box and whether the published root was found
layers:
- cli:
- crates/minimal/src/cli.rs: the
min boxnoun withspec- crates/minimal/src/cmd/mod.rs: dispatch and module line
- crates/minimal/src/cmd/box_spec.rs (new): the BEP-038 rows: root fingerprint, upstreams with the
fullmarker, steering, store references, the QUIC flag- crates/minimal/src/config.rs: reads
[secrets] acknowledge_full_breadth_unenrolledfrom the user and organization client configurationtest: cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_references
test: cargo nextest run -p minimal box_spec_marks_full_breadth_member
test: cargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_box
test: cargo nextest run -p minimal acknowledged_narrow_grant_renders_full
- spec:
- crates/boxes/src/core/bep.rs: the BEP-057 refusal and the
quic443stance- crates/mfile/src/lib.rs: ignores a project's acknowledgement with a warning
test: cargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgement
test: cargo nextest run -p boxes project_acknowledgement_is_ignored_with_warning
produces:
- crates/minimal/src/cmd/box_spec.rs (entry point)
consumes:
- crates/boxes/src/core/bep.rs
- crates/bep/src/publish.rs
proof:
min box specon the demo box shows the root fingerprint, the four GitHub hosts marked full, and proxy_env steering.depends on:
- blocked by #2259
- blocked by #2264
Proof
min box spec <project>on the demo box (steering = "proxy_env", GH_TOKEN with github:user-token) printsroot CA SHA256:<fingerprint>(or says that the proxy has not published it yet),grant github:user-token full GH_TOKEN hosts github.com, api.github.com, uploads.github.com, codeload.github.com,steering proxy_envandquic443 allowed (HTTP/3 bypasses the proxy). I ran the built binary on that demo project and saw these rows. No identity file was published, so the root CA row said that it is not published yet. A github:repo:read grant exits 3 and names acknowledge_full_breadth_unenrolled. With that key set in config.toml, the grant renders as full with the acknowledgement line.Notes from the agent: Wiring outside the layers that later work needs: (1) boxes::client::config::Config has deny_unknown_fields, so a [secrets] table in the user config.toml makes the other readers of that file (read_client_config, for example
min session activate) fail to parse it. crates/boxes/src/client/config.rs must learn the [secrets] section. That file is not in this task's layers, so I did not change it. (2) crates/minimal/src/cmd/session.rs still passes HostFacts::LOCAL to check_activation. Activation now refuses a narrower GitHub grant (BEP-057) but does not read the acknowledgement yet. To let an acknowledged spec activate, passHostFacts { full_breadth_acknowledged: config::full_breadth_acknowledged(global)?, ..HostFacts::LOCAL }there. The result is strict, never a silent widening. Design choices: the organization configuration is /etc/minimal/config.toml (config::ORGANIZATION_CONFIG_PATH), because the tree had no organization config before. A scope is narrower than full when it is github:repo: with x other thanfull.min box specrefuses only on BEP-057. It does not run the other activation checks. No store has registered hosts in this tree yet (the [secret-store-rules] slice adds them), so a non-GitHub broker scope prints `store …[truncated]Tests
cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_referencescargo nextest run -p minimal box_spec_marks_full_breadth_membercargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_boxcargo nextest run -p minimal acknowledged_narrow_grant_renders_fullcargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgementcargo nextest run -p boxes project_acknowledgement_is_ignored_with_warningVerify
min task run agent-verifyexited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.Closes #2267
Layer exception
Round 1 changed
crates/minimal/src/cmd/session.rs(refuse_unhonourable_grantstakes the acknowledgement intoHostFacts), outside the task's layers. Accepted by the epic owner on 2026-10-20: minimal-arch condition C3 (161bbbb) and the runtime review's MEDIUM finding both required the start path to read the same acknowledgement thatmin box specshows.Round 2 changed
crates/boxes/src/client/config.rs(the[secrets]section of the clientConfig), outside the task's layers. minimal-arch condition C1 on 5f50795 required it: that crate owns the client configuration, and the private parser incrates/minimal/src/config.rsbrokemin session. Accepted on the same basis as thesession.rsexception above (arch-required placement, recorded for the epic owner on 2026-10-20).Residuals
min box specpreviews only the BEP-057 refusal, not the start's full exit-3 set (arch C2(a) on 5f50795).rootrow prints the root key thumbprint until T43 — Issue and publish the un-enrolled host root certificate and hand it to each grant box #2437's root certificate exists (arch C2(b) on 5f50795).github:scope outside the vocabulary (user-token, repo-token, repo:*) is refused or counts as narrow under BEP-057 on an un-enrolled host;narrow_scopeskeeps the spec-faithful reading until ruled (HIGH review thread, dispute accepted by the epic owner).Generated by Claude Code