Skip to content

feat(min): add min box spec with root fingerprint, upstream set, steering and full marker - #2443

Merged
norrietaylor merged 6 commits into
mainfrom
agent/2267-show-the-root-fingerprint-the-upstream-set-steer
Oct 20, 2026
Merged

norrietaylor merged 6 commits into
mainfrom
agent/2267-show-the-root-fingerprint-the-upstream-set-steer

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

T15 — Show the root fingerprint, the upstream set, steering and the full marker in min box spec

slice: S0
kind: task
covers: BEP-038, BEP-057
size: L
est: 400 code, 360 tests
executor: agent
difficulty: routine
model: standard
diagnostics: min box spec prints root CA <sha256 fingerprint>, one grant github:user-token full row per grant with its upstream hosts, steering proxy_env, and, where the stance is allowed on a grant box, quic443 allowed (HTTP/3 bypasses the proxy), pinned by box_spec_renders_ca_upstreams_steering_and_references
observability: one debug log line per render naming the box and whether the published root was found
layers:
- cli:
- crates/minimal/src/cli.rs: the min box noun with spec
- crates/minimal/src/cmd/mod.rs: dispatch and module line
- crates/minimal/src/cmd/box_spec.rs (new): the BEP-038 rows: root fingerprint, upstreams with the full marker, steering, store references, the QUIC flag
- crates/minimal/src/config.rs: reads [secrets] acknowledge_full_breadth_unenrolled from the user and organization client configuration
test: cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_references
test: cargo nextest run -p minimal box_spec_marks_full_breadth_member
test: cargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_box
test: cargo nextest run -p minimal acknowledged_narrow_grant_renders_full
- spec:
- crates/boxes/src/core/bep.rs: the BEP-057 refusal and the quic443 stance
- crates/mfile/src/lib.rs: ignores a project's acknowledgement with a warning
test: cargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgement
test: cargo nextest run -p boxes project_acknowledgement_is_ignored_with_warning
produces:
- crates/minimal/src/cmd/box_spec.rs (entry point)
consumes:
- crates/boxes/src/core/bep.rs
- crates/bep/src/publish.rs
proof: min box spec on the demo box shows the root fingerprint, the four GitHub hosts marked full, and proxy_env steering.
depends on:
- blocked by #2259
- blocked by #2264

Proof

min box spec <project> on the demo box (steering = "proxy_env", GH_TOKEN with github:user-token) prints root CA SHA256:<fingerprint> (or says that the proxy has not published it yet), grant github:user-token full GH_TOKEN hosts github.com, api.github.com, uploads.github.com, codeload.github.com, steering proxy_env and quic443 allowed (HTTP/3 bypasses the proxy). I ran the built binary on that demo project and saw these rows. No identity file was published, so the root CA row said that it is not published yet. A github:repo:read grant exits 3 and names acknowledge_full_breadth_unenrolled. With that key set in config.toml, the grant renders as full with the acknowledgement line.

Notes from the agent: Wiring outside the layers that later work needs: (1) boxes::client::config::Config has deny_unknown_fields, so a [secrets] table in the user config.toml makes the other readers of that file (read_client_config, for example min session activate) fail to parse it. crates/boxes/src/client/config.rs must learn the [secrets] section. That file is not in this task's layers, so I did not change it. (2) crates/minimal/src/cmd/session.rs still passes HostFacts::LOCAL to check_activation. Activation now refuses a narrower GitHub grant (BEP-057) but does not read the acknowledgement yet. To let an acknowledged spec activate, pass HostFacts { full_breadth_acknowledged: config::full_breadth_acknowledged(global)?, ..HostFacts::LOCAL } there. The result is strict, never a silent widening. Design choices: the organization configuration is /etc/minimal/config.toml (config::ORGANIZATION_CONFIG_PATH), because the tree had no organization config before. A scope is narrower than full when it is github:repo: with x other than full. min box spec refuses only on BEP-057. It does not run the other activation checks. No store has registered hosts in this tree yet (the [secret-store-rules] slice adds them), so a non-GitHub broker scope prints `store …[truncated]

Tests

line exit tail
cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_references 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-ed7c... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal box_spec_marks_full_breadth_member 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-b380... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_box 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-4108... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal acknowledged_narrow_grant_renders_full 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-3ac8... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgement 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-c1a8... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling common v0.0.1 (/workbench
cargo nextest run -p boxes project_acknowledgement_is_ignored_with_warning 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-b591... Finished 'test' profile [unoptimized] target(s) in 0.51s ──────────── Nextest run ID bef2e243-d496-4a88-8891-d9483635fd88 with nextest profile: default Starting 1 test across 3

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-8d5f...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking wait-timeout v0.2.1
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking quick-error v1.2.3
    Checking bit-vec v0.8.0
    Checking rand_xorshift v0.4.0
    Checking rusty-fork v0.3.1
    Checking unarray v0.1.4
    Checking bit-set v0.8.0
    Checking proptest v1.11.0
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Closes #2267

Layer exception

Round 1 changed crates/minimal/src/cmd/session.rs (refuse_unhonourable_grants takes the acknowledgement into HostFacts), outside the task's layers. Accepted by the epic owner on 2026-10-20: minimal-arch condition C3 (161bbbb) and the runtime review's MEDIUM finding both required the start path to read the same acknowledgement that min box spec shows.

Round 2 changed crates/boxes/src/client/config.rs (the [secrets] section of the client Config), outside the task's layers. minimal-arch condition C1 on 5f50795 required it: that crate owns the client configuration, and the private parser in crates/minimal/src/config.rs broke min session. Accepted on the same basis as the session.rs exception above (arch-required placement, recorded for the epic owner on 2026-10-20).

Residuals


Generated by Claude Code

…dgement

A GitHub grant with github:repo:* scopes narrower than full is refused
with exit 3 on an un-enrolled host unless the client configuration
acknowledges full-breadth minting. A project file that sets the
acknowledgement in [session.secrets] has it ignored with a warning.
Quic443 gains the resolved stance.
min box spec reads the project's minimal.toml and prints the proxy's
root CA fingerprint, each broker grant with its GitHub hosts and the
full marker, store references, the steering mode, and the quic443
stance when HTTP/3 bypasses the proxy. The client config.toml [secrets]
acknowledge_full_breadth_unenrolled is read from the user and
organization configuration; without it a narrower grant exits 3.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f924aab-4dab-4d04-a8b8-5a509354402e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at 99f9067f266f.

Nothing to do.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 3 findings, 3 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/boxes/src/core/bep.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 4 conditions · the full ruling

The refusal and the rows conform, but the acknowledged path that Gatehouse §6.10 line 853 requires does not work. The [secrets] key that the refusal tells the operator to set breaks read_client_config(), because Config is deny_unknown_fields (C2). Activation still ignores the acknowledgement, so min session refuses what min box spec shows as full (C3). The positional PATH takes the <entry|box|self> slot that architecture.md line 472 defines (C1). off steering with a broker grant is not flagged as networking §5.4 line 172 requires (C4).

Outside the diff

  • crates/minimal/src/cmd/session.rs:669: C3 · Pass HostFacts { full_breadth_acknowledged: crate::config::full_breadth_acknowledged(global)?, ..HostFacts::LOCAL } here. Gatehouse §6.10 line 853 mints an acknowledged narrower grant full. It does not refuse it.

Ruled at 161bbbb against gominimal/arch@3dab1097cda1 by claude-opus-5-5.

Comment thread crates/minimal/src/cli.rs Resolved
Comment thread crates/minimal/src/config.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
The box start path passed HostFacts::LOCAL to check_activation, so a
narrow GitHub grant was refused even with
acknowledge_full_breadth_unenrolled set, while min box spec accepted
it. Start now reads the same client configuration when a grant needs
it. The min box spec root row now says it shows the key thumbprint,
because the proxy issues no root certificate yet.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 3 findings, 3 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/boxes/src/core/bep.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
Comment thread crates/minimal/src/config.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The BEP-057 refusal and the min box spec rows conform to Gatehouse §6.10 line 853. The acknowledged path does not work. The exit-3 message tells the operator to add [secrets] to config.toml. boxes::client::config::Config refuses that unknown table, so after that edit the box does not start and min ls fails. Add the [secrets] section to the client Config, and read the acknowledgement through it (C1). Also file an issue for each of the two interims in min box spec, and name the issues (C2).

Ruled at 5f50795 against gominimal/arch@3dab1097cda1 by claude-opus-5-5.

Comment thread crates/minimal/src/config.rs Resolved
Comment thread crates/minimal/src/cmd/session.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as 5f50795f7e87.

line exit tail
cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_references 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-9b3d... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal box_spec_marks_full_breadth_member 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-ed0d... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_box 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-f091... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal acknowledged_narrow_grant_renders_full 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-802e... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgement 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-be61... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling common v0.0.1 (/workbench
cargo nextest run -p boxes project_acknowledgement_is_ignored_with_warning 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-2840... Finished 'test' profile [unoptimized] target(s) in 0.44s ──────────── Nextest run ID 647a86e1-12ff-4c02-b49e-f66e17eb5dee with nextest profile: default Starting 1 test across 3

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-b3dd...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking wait-timeout v0.2.1
    Checking quick-error v1.2.3
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking bit-vec v0.8.0
    Checking bit-set v0.8.0
    Checking rusty-fork v0.3.1
    Checking rand_xorshift v0.4.0
    Checking unarray v0.1.4
    Checking proptest v1.11.0
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM6uL9T-: Box start (refuse_unhonourable_grants in session.rs) now reads the client config acknowledgement and passes it to check_activation. Test: start_honours_full_breadth_acknowledgement. session.rs is outside the task's layers. (not posted on the thread: not an open thread on the pull request)
  • 👍 valid — PRRT_kwDOPdfcxM6uL9UB: The proxy issues no root certificate yet, so the row now says root CA key thumbprint SHA256:<kid>. It no longer looks like a certificate fingerprint. (not posted on the thread: not an open thread on the pull request)
  • 👍 valid — PRRT_kwDOPdfcxM6uL9UC: Same fix as the BEP-057 start-path thread. Box start now reads the acknowledgement too, so min box spec and box start agree. (not posted on the thread: not an open thread on the pull request)

min box spec on the demo box shows the root CA row (now labelled as the key thumbprint), the four GitHub hosts marked full, and steering proxy_env. A box with a narrow GitHub grant and the acknowledgement set in config.toml now also starts, so the preview and the start agree.

Notes from the agent: Out of layers: crates/minimal/src/cmd/session.rs. Threads 1 and 3 need it. The BEP-057 refusal that this pull request added to check_activation also runs at box start (refuse_unhonourable_grants). That path passed HostFacts::LOCAL, so with the acknowledgement set, box start still refused a narrow grant. I added a full_breadth_acknowledged argument. Start reads config::full_breadth_acknowledged only when a grant is narrower than full, so a malformed config.toml cannot block other boxes. I also added the test start_honours_full_breadth_acknowledgement. Thread 2: the proxy issues no root certificate yet (crates/bep/src/publish.rs), so a certificate fingerprint does not exist to print. The row now says root CA key thumbprint SHA256:<kid>. It still carries the SHA-256 value that the task's diagnostics line asks for. Clippy on -p minimal reports no warnings in crates/minimal. I did not run just clippy-strict.

Copy link
Copy Markdown
Member

/revise minimal-arch ruled CONDITIONS on 5f50795 (check run on the head, arch_rulings 72): two conditions, and the steering warning the 161bbbb ruling asked for (its C4) is still missing from render(). Take these three and nothing else:

  1. Arch C1, the client config reader. crates/boxes/src/client/config.rs: Config gains #[serde(default)] pub secrets: SecretsConfig, where SecretsConfig is #[serde(deny_unknown_fields)] with #[serde(default)] pub acknowledge_full_breadth_unenrolled: bool. Today read_client_config is deny_unknown_fields, so the [secrets] table that the BEP-057 refusal text tells the operator to write makes activate_session fail at session.rs line 826 after reading the acknowledgement at line 782. crates/minimal/src/config.rs full_breadth_acknowledged() reads the user file through boxes::client::config::Config (read_config_or_default()), not through the private ClientSecretsFile; delete that struct and ClientSecrets. Keep the organization file read (/etc/minimal/config.toml) and the fail-closed parse errors. Add the test arch names in crates/minimal/src/config.rs: write [secrets]\nacknowledge_full_breadth_unenrolled = true to a temporary config.toml, assert read_client_config returns Ok and full_breadth_acknowledged returns true. Add the parse test in crates/boxes/src/client/config.rs for a file with both [loadouts] and [secrets].
  2. Arch C2, the two interims are filed. Name them in the code comment at each site: at render() where only the BEP-057 refusal runs (egress = None, NetworkMode::OwnIp), // Interim: only BEP-057 is previewed here; the full exit-3 set is gominimal/minimal#2445. At the root row, // Interim: the root key's RFC 7638 thumbprint until the root certificate exists (#2437); the certificate fingerprint is gominimal/minimal#2446. The PR body already carries a "## Residuals" section with both.
  3. Steering off with a grant (networking §5.4 line 172; arch C4 on 161bbbb). In render(), when the resolved steering is Steering::Off and the spec has a GitHub grant, write one row warning <text> after the steering row, where <text> is the Display of BepWarning::SteeringOffWithGrant { grants } from crates/boxes/src/core/bep.rs. Exit stays 0. Add a case to box_spec_renders_ca_upstreams_steering_and_references with steering = Some(Steering::Off) that asserts the row.

The session.rs change from round 1 stays: the epic owner accepted it as a layer exception (see the PR body). Reply on the three runtime threads with the commit that answers each.


Generated by Claude Code

Config gains a [secrets] section, so the table the BEP-057 refusal names
no longer breaks read_client_config. min box spec writes the steering-off
warning row and names the interim issues #2445 and #2446.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The compare meets the open conditions from the ruling on 5f50795. The [secrets] acknowledgement is now part of the client Config, so min session can read a config.toml that carries it. Gatehouse §6.10 line 853 puts the acknowledgement in the client configuration, and this head does that. min box spec now writes the steering off warning with exit 0, as Networking §5.4 line 172 requires. The two interims name #2445 and #2446. The change to crates/boxes/src/client/config.rs is outside the task layers, but the design places the client configuration there.

Ruled at 19b84d4 against gominimal/arch@3dab1097cda1 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 10 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:419, minimal-arch[bot] crates/minimal/src/config.rs, minimal-arch[bot] crates/minimal/src/cmd/box_spec.rs:123, minimal-foundry[bot] crates/boxes/src/core/bep.rs:201, minimal-foundry[bot] crates/minimal/src/cmd/box_spec.rs:193, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 19b84d4ed517.

line exit tail
cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_references 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-7a09... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal box_spec_marks_full_breadth_member 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-69a1... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_box 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-25cd... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal acknowledged_narrow_grant_renders_full 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-a87e... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgement 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-d806... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling common v0.0.1 (/workbench
cargo nextest run -p boxes project_acknowledgement_is_ignored_with_warning 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-0a54... Finished 'test' profile [unoptimized] target(s) in 1.24s ──────────── Nextest run ID ee37bb52-c4e8-4fb1-ae94-2d19d802ac5b with nextest profile: default Starting 1 test across 3

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-4ba2...
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking wait-timeout v0.2.1
    Checking quick-error v1.2.3
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking bit-vec v0.8.0
    Checking bit-set v0.8.0
    Checking rusty-fork v0.3.1
    Checking rand_xorshift v0.4.0
    Checking unarray v0.1.4
    Checking proptest v1.11.0
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/boxes/src/client/config.rs
  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👎 invalid — crates/minimal/src/cli.rs:419: Not changed this round. The /revise note limits round 2 to arch C1, C2 and C4 from the 5f50795 ruling, and that ruling does not repeat this item. The [PATH] positional is still in BoxSpecArgs. A later round can remove it if arch still asks.
  • 👍 valid — crates/minimal/src/config.rs: 6538d8d: Config gains a [secrets] section. The acknowledgement now reads through read_config_or_default, and ClientSecretsFile is deleted.
  • 👍 valid — crates/minimal/src/cmd/box_spec.rs:123: 6538d8d: render() writes warning <SteeringOffWithGrant text> after the steering row when steering is off and a GitHub grant exists. Exit stays 0. The test covers it.
  • 👎 invalid — crates/boxes/src/core/bep.rs:201: BEP-057 is scoped to github:repo:* scopes narrower than full, and narrow_scopes implements that wording. A wider scope vocabulary or rejection of unknown github: scopes is a spec change, and the /revise note excludes it from this round.
  • 👎 invalid — crates/minimal/src/cmd/box_spec.rs:193: Not changed this round: the /revise note limits it to three items. The impact is also small. After 6538d8d, a config.toml that does not parse already fails every min command that calls read_client_config, so the eager read in box spec adds no new failure for the user file.
  • 👍 valid — crates/minimal/src/config.rs:59: 6538d8d: added SecretsConfig to boxes::client::config::Config, so the [secrets] table parses. The key is read in one place.
  • 👍 valid — crates/minimal/src/config.rs: 6538d8d: Config has secrets, and full_breadth_acknowledged reads it through read_config_or_default. The acknowledged member still renders full.
  • 👍 valid — crates/minimal/src/cmd/session.rs:782: 6538d8d: read_client_config now accepts [secrets]. secrets_table_reads_through_client_config writes a real config.toml with the key and asserts both read_client_config and full_breadth_acknowledged.
  • 👍 valid — crates/minimal/src/cmd/box_spec.rs:70: 6538d8d: the comment at render() names min box spec previews only the BEP-057 refusal, not the start's full exit-3 set #2445 as the interim for the full exit-3 set.
  • 👍 valid — crates/minimal/src/cmd/box_spec.rs:82: 6538d8d: the root row comment names T43 — Issue and publish the un-enrolled host root certificate and hand it to each grant box #2437 and min box spec root row prints the key thumbprint, not the root certificate fingerprint #2446 for the certificate fingerprint.

min box spec on the demo box shows the root CA key thumbprint, the four GitHub hosts marked full, and proxy_env steering. With steering = "off" and a GitHub grant, it also writes a warning row and exits 0. A config.toml with [secrets] acknowledge_full_breadth_unenrolled = true now parses for every min command, so min session starts after the user follows the BEP-057 message.

Notes from the agent: Round 2 does only the three items in the /revise note, in commit 6538d8d. (1) crates/boxes/src/client/config.rs is outside the task layers. The note asks for this change by name: Config gains secrets: SecretsConfig. full_breadth_acknowledged reads the user and organization files through read_config_or_default. The private ClientSecretsFile and ClientSecrets are deleted. Parse errors still fail closed. New tests: boxes read_config_file_loadouts_and_secrets and secrets_unknown_field_errors, and minimal secrets_table_reads_through_client_config. (2) The two interim comments are added word for word. (3) render() writes warning <SteeringOffWithGrant text> after the steering row. The message text is the existing BepWarning Display, not changed here. clippy -p minimal --all-targets shows only warnings that were there before, in minimald-rpc and minimald. just clippy-strict was not run.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 20, 2026 04:22
@norrietaylor
norrietaylor marked this pull request as ready for review October 20, 2026 04:35

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Own review of 19b84d4 (round 2 on the arch directive).

  • Arch C1 (client config reader): verified. SecretsConfig on the typed Config, acknowledged_in through read_config_or_default, private parser deleted, tests in both crates.
  • Arch C2 (interims): verified. #2445 and #2446 named at both sites and in the body.
  • Steering off with a grant (§5.4 line 172): verified in render(), exit 0, covered by the test.
  • Start path (refuse_unhonourable_grants): reads the acknowledgement lazily and passes it into HostFacts; start_honours_full_breadth_acknowledgement proves both branches.
  • Layers: crates/boxes/src/client/config.rs is outside the task's layers; recorded as a Layer exception in the body on the same basis as session.rs (arch required the placement).
  • Threads: nine resolved with the verification above. One stays open for the epic owner: the HIGH security finding on narrow_scopes treating only github:repo:* as narrow. BEP-057 is worded exactly that way, so the code is spec-faithful; whether another github: scope should count is a spec question.

minimal-arch ruled PASS on this head. Approval follows the owner's ruling on the open thread and the macOS lane.


Generated by Claude Code

…oot-fingerprint-the-upstream-set-steer

# Conflicts:
#	crates/minimal/src/cmd/mod.rs

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head merges main into the head that got a PASS (19b84d4e). The PR's own changes did not change. The one conflict in crates/minimal/src/cmd/mod.rs keeps both mod auth; and mod box_spec;. The new min auth code does not read the full-breadth acknowledgement. BEP-038 and BEP-057 still conform to Gatehouse §6.10 line 853.

Ruled at 99f9067 against gominimal/arch@3dab1097cda1 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 20, 2026
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

A merge of main before round 3, not counted against the cap (1 of 3), pushed as 99f9067f266f.

Resolved conflicts in: crates/minimal/src/cmd/mod.rs

line exit tail
cargo nextest run -p minimal box_spec_renders_ca_upstreams_steering_and_references 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-6ef8... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal box_spec_marks_full_breadth_member 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-d0d7... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_spec_flags_allowed_quic_stance_on_grant_box 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-1854... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal acknowledged_narrow_grant_renders_full 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-30dc... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p boxes prop_narrow_scopes_unenrolled_need_acknowledgement 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-925b... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling common v0.0.1 (/workbench
cargo nextest run -p boxes project_acknowledgement_is_ignored_with_warning 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-1ce9... Finished 'test' profile [unoptimized] target(s) in 0.48s ──────────── Nextest run ID 539e7ac4-7968-4314-9b8a-0ea091ad452d with nextest profile: default Starting 1 test across 3

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-6d38...
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking wait-timeout v0.2.1
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking quick-error v1.2.3
    Checking bit-vec v0.8.0
    Checking bit-set v0.8.0
    Checking rusty-fork v0.3.1
    Checking rand_xorshift v0.4.0
    Checking unarray v0.1.4
    Checking proptest v1.11.0
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/boxes/src/client/config.rs
  • crates/minimal/src/cmd/session.rs

Converted to a draft: something above needs a person before review.

On this branch, merged with main, min box spec still prints the root CA fingerprint, one full-marked row per GitHub grant with its upstream hosts, steering proxy_env, and the quic443 allowed flag on a grant box. The new min auth commands from main stay available beside it.

Notes from the agent: Conflict round only. crates/minimal/src/cmd/mod.rs had one conflict: HEAD added mod box_spec; and main added mod auth;. The resolution keeps both lines. The merge commit has no other change. cargo clippy -p minimal --all-targets gives no warnings in crates/minimal. The 3 clippy warnings it prints are in minimald and come from main. No unresolved threads were listed, and no earlier verdict changes.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 20, 2026 06:37
@norrietaylor
norrietaylor marked this pull request as ready for review October 20, 2026 06:54

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Own review carried to 99f9067. This head is the runtime's merge of main (5919d28) before round 3, resolving crates/minimal/src/cmd/mod.rs; the branch's own diff against main is the same 8 files as at 19b84d4, and the runtime review carried its approval ("Already reviewed at 19b84d4, which this head only merged the base onto"). minimal-arch ruled PASS on this head. The review of 19b84d4 stands. The HIGH thread on narrow_scopes is re-opened: a security thread closes on the epic owner's ruling, not on a base merge.


Generated by Claude Code

@norrietaylor norrietaylor changed the title T15 — Show the root fingerprint, the upstream set, steering and the full marker in min box spec feat(min): add min box spec with root fingerprint, upstream set, steering and full marker Oct 20, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for merge: T15 on 99f9067 after the epic owner ruled on the HIGH scope thread (dispute accepted, gominimal/arch#136 filed). Gate passes (arch PASS, review approved, no open threads, lanes green, squash subject lint-clean).


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 0c33a45 Oct 20, 2026
37 checks passed
@norrietaylor
norrietaylor deleted the agent/2267-show-the-root-fingerprint-the-upstream-set-steer branch October 20, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T15 — Show the root fingerprint, the upstream set, steering and the full marker in min box spec

1 participant