Skip to content

T36 — Name the CLI's operations after the box - #2479

Merged
mitodrummer merged 2 commits into
mainfrom
agent/2383-name-the-cli-s-operations-after-the-box
Oct 21, 2026
Merged

mitodrummer merged 2 commits into
mainfrom
agent/2383-name-the-cli-s-operations-after-the-box

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

T36 — Name the CLI's operations after the box

slice: S0
kind: enablement
covers: none
size: L
est: 480 code, 60 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none: a rename, nothing printed changes
observability: none: a rename, no new signal
layers:
- cli:
- crates/minimal/src/cmd/boxes.rs: box operation names
- crates/minimal/src/cmd/boxes/create.rs: create takes a box name
- crates/minimal/src/cmd/boxes/vm_host.rs: registration takes a box name
- crates/minimal/src/cmd/boxes/attach.rs: attach takes a box name
- crates/minimal/src/cmd/boxes/exec.rs: exec takes a box name
- crates/minimal/src/cmd/boxes/policy.rs: policy takes a box name
- crates/minimal/src/cmd/boxes/lifecycle.rs: stop, remove take box names
- crates/minimal/src/cmd/boxes/hooks.rs: hooks take a box name
- crates/minimal/src/cmd/session.rs: handlers map onto box operations
- crates/minimal/src/task.rs: calls the box operations
test: cargo nextest run -p minimal run_alias_message_names_both_canonical_forms
produces: none
consumes: none
proof: Output and wire unchanged; the code says box.
depends on:
- blocked by #2380

Proof

A reader of crates/minimal sees the box operations named after the box: destroy_box, destroy_all_boxes, box_delta, box_policy_as_json, box_policy_json_inputs, attached_box_record, should_announce_box and task_box_name, and their parameters take box_name or box_id. No printed text, RPC or wire name changed, and the full minimal test suite passes.

Notes from the agent: Four session-named functions keep their names: activate_session, session_via_ssh, session_announce_label and session_record_by. Callers or source-scanning tests outside the layers name them: cmd/list.rs, cmd/net.rs, cmd/mod.rs and cmd/project.rs (doc links), and src/tests.rs (the connect-site and create-site inventories, and the function_body checks on activate_session). A follow-up task with those files in its layers can rename them. cmd/boxes.rs, cmd/boxes/exec.rs and cmd/boxes/hooks.rs need no change: they have no session-named operation or parameter. Clap fields such as args.session stay, because they live in the argument definitions outside the layers and their names reach --help. Wire and RPC types (DestroySession, SessionId, session_id struct fields) stay, as the task requires. The test task_session_name_sanitizes_the_task_stem in task.rs is now task_box_name_sanitizes_the_task_stem.

Tests

line exit tail
cargo nextest run -p minimal run_alias_message_names_both_canonical_forms 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-f5ea... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-a1c0...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Closes #2383


Undrafted 2026-10-21. The edits outside the layers are callers of the renamed operations (cmd/list.rs, cmd/mod.rs, cmd/net.rs, cmd/project.rs) and the source-scan lists in crates/minimal/src/tests.rs, which name those functions. A maintainer asked for the full rename and accepts them. Output and wire format are unchanged.

Rename the session-named helpers whose callers all sit in the box
verb modules, session.rs and task.rs (destroy_box, destroy_all_boxes,
box_delta, box_policy_as_json, attached_box_record and others), and
their session parameters to box_name or box_id. Output and wire are
unchanged.
@minimal-foundry

minimal-foundry Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at a7b55e9408b3.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The design of record is silent on Rust identifier names in crates/minimal. This is a PASS by absence. The diff renames functions, constants and locals only. The printed text and the RPC names stay the same. No condition applies.

Ruled at 2bf7778 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dc468b6b-ba0b-45de-aa5c-4302c76588c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mitodrummer

Copy link
Copy Markdown
Member

/revise Finish T36's rename. The proof is "the code says box". Four non-test operations in this task's files still carry session names:

  • activate_session in crates/minimal/src/cmd/boxes/create.rs:296 → activate_box
  • session_via_ssh in crates/minimal/src/cmd/boxes/attach.rs:203 → box_via_ssh
  • session_announce_label in crates/minimal/src/cmd/boxes/attach.rs:20 → box_announce_label
  • session_record_by in crates/minimal/src/cmd/boxes/vm_host.rs:241 → box_record_by

Rename each one with all of its callers. Keep the cmd_session_* clap handlers in cmd/session.rs as they are: they name the min session verbs.

A maintainer accepts one edit outside the layers: crates/minimal/src/tests.rs names three of these functions in its source-scan lists (activate_session 4 times, session_announce_label 3, session_record_by 1). Update those strings to the new names so the scans keep reading the same functions. Also rename the tests whose names quote activate_session, for example steps_in_activate_session and activation_steps_run_in_order_and_name_the_failing_step_in_activate_session.

Output and wire stay unchanged. Every string a person sees still says "session". Run cargo nextest run -p minimal run_alias_message_names_both_canonical_forms, plus the crates/minimal/src/tests.rs scans (cargo nextest run -p minimal every_daemon_connection_is_classified).

Rename activate_session to activate_box, session_via_ssh to
box_via_ssh, session_announce_label to box_announce_label and
session_record_by to box_record_by, with their callers, the
source-scan lists in tests.rs and the tests that quote the names.
Output and wire are unchanged.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This change renames Rust functions in crates/minimal from session names to box names. The design of record does not govern Rust identifier names, so the ruling is a PASS by absence. The ruling is the same as the ruling on the earlier head 2bf77784. No printed text, RPC or wire name changes. No old name remains in the tree.

Ruled at a7b55e9 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a /revise note, pushed as a7b55e9408b3.

line exit tail
cargo nextest run -p minimal run_alias_message_names_both_canonical_forms 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-69e9... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-20fe...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking common v0.0.1 (/workbench/crates/common)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/minimal/src/cmd/list.rs
  • crates/minimal/src/cmd/mod.rs
  • crates/minimal/src/cmd/net.rs
  • crates/minimal/src/cmd/project.rs
  • crates/minimal/src/tests.rs

Converted to a draft: something above needs a person before review.

The CLI's box operations now say box in the code: activate_box, box_via_ssh, box_announce_label and box_record_by replace the session names. Every printed string and the wire are unchanged, and the cmd_session_* clap handlers keep their names.

Notes from the agent: Revise round 1: renamed the four functions from the directive with all their callers. Files outside the layers: crates/minimal/src/tests.rs (accepted by the maintainer; the scan strings now name the new functions, and the test session_announce_label_prefers_name_with_short_id is now box_announce_label_prefers_name_with_short_id). crates/minimal/src/cmd/list.rs and crates/minimal/src/cmd/net.rs call the renamed functions, so the crate does not compile without the edit. crates/minimal/src/cmd/mod.rs and crates/minimal/src/cmd/project.rs carry doc links to the old names, which became broken links, so they now name the new functions. Tests renamed in create.rs: steps_in_activate_box and activation_steps_run_in_order_and_name_the_failing_step_in_activate_box. cargo clippy -p minimal --all-targets shows no warnings in minimal. just clippy-strict was not run.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 21, 2026 16:53

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@mitodrummer
mitodrummer marked this pull request as ready for review October 21, 2026 17:04

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysit review on a7b55e9 against T36's plan block. The CLI's box operations now carry box names: activate_box, box_via_ssh, box_announce_label, box_record_by, box_delta, destroy_box / destroy_all_boxes, box_policy_as_json and task_box_name, with their locals and callers. The cmd_session_* handlers keep the min session verb names. Every string a person sees and every wire type is unchanged. The edits outside the layers are callers (list.rs, mod.rs, net.rs, project.rs) and the scan-list strings in src/tests.rs, which a maintainer accepted. arch-review PASS on this head.

@mitodrummer
mitodrummer added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 3c4b691 Oct 21, 2026
37 checks passed
@mitodrummer
mitodrummer deleted the agent/2383-name-the-cli-s-operations-after-the-box branch October 21, 2026 18:40
bryan-minimal added a commit that referenced this pull request Oct 23, 2026
…an attach or an exec

The native daemon's control socket answers only the answerer verbs, so
asking it to re-hold a name was a refusal warned on every native attach
and exec's stderr (#2213). The re-hold is for Minvmd alone, as the
activation's hold is; every caller of box_via_ssh passes the daemon's
provider kind. Re-applied onto main's split CLI files (#2479, #2480).
bryan-minimal added a commit that referenced this pull request Oct 25, 2026
…an attach or an exec

The native daemon's control socket answers only the answerer verbs, so
asking it to re-hold a name was a refusal warned on every native attach
and exec's stderr (#2213). The re-hold is for Minvmd alone, as the
activation's hold is; every caller of box_via_ssh passes the daemon's
provider kind. Re-applied onto main's split CLI files (#2479, #2480).
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Oct 26, 2026
…an attach or an exec (gominimal#2225)

The native daemon's control socket answers only the answerer verbs, so
asking it to re-hold a name was a refusal warned on every native attach
and exec's stderr (gominimal#2213). The re-hold is for Minvmd alone, as the
activation's hold is; every caller of box_via_ssh passes the daemon's
provider kind. Re-applied onto main's split CLI files (gominimal#2479, gominimal#2480).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T36 — Name the CLI's operations after the box

1 participant