Repository navigation
T36 — Name the CLI's operations after the box - #2479
Conversation
Rename the session-named helpers whose callers all sit in the box verb modules, session.rs and task.rs (destroy_box, destroy_all_boxes, box_delta, box_policy_as_json, attached_box_record and others), and their session parameters to box_name or box_id. Output and wire are unchanged.
|
Approved: no findings at Nothing to do. Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The design of record is silent on Rust identifier names in crates/minimal. This is a PASS by absence. The diff renames functions, constants and locals only. The printed text and the RPC names stay the same. No condition applies.
Ruled at 2bf7778 against gominimal/arch@109541a48c31 by claude-opus-5-5.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/revise Finish T36's rename. The proof is "the code says box". Four non-test operations in this task's files still carry session names:
Rename each one with all of its callers. Keep the A maintainer accepts one edit outside the layers: Output and wire stay unchanged. Every string a person sees still says "session". Run |
Rename activate_session to activate_box, session_via_ssh to box_via_ssh, session_announce_label to box_announce_label and session_record_by to box_record_by, with their callers, the source-scan lists in tests.rs and the tests that quote the names. Output and wire are unchanged.
There was a problem hiding this comment.
arch-review: PASS · the full ruling
This change renames Rust functions in crates/minimal from session names to box names. The design of record does not govern Rust identifier names, so the ruling is a PASS by absence. The ruling is the same as the ruling on the earlier head 2bf77784. No printed text, RPC or wire name changes. No old name remains in the tree.
Ruled at a7b55e9 against gominimal/arch@109541a48c31 by claude-opus-5-5.
|
Round 1 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. The CLI's box operations now say box in the code: activate_box, box_via_ssh, box_announce_label and box_record_by replace the session names. Every printed string and the wire are unchanged, and the cmd_session_* clap handlers keep their names. Notes from the agent: Revise round 1: renamed the four functions from the directive with all their callers. Files outside the layers: crates/minimal/src/tests.rs (accepted by the maintainer; the scan strings now name the new functions, and the test session_announce_label_prefers_name_with_short_id is now box_announce_label_prefers_name_with_short_id). crates/minimal/src/cmd/list.rs and crates/minimal/src/cmd/net.rs call the renamed functions, so the crate does not compile without the edit. crates/minimal/src/cmd/mod.rs and crates/minimal/src/cmd/project.rs carry doc links to the old names, which became broken links, so they now name the new functions. Tests renamed in create.rs: steps_in_activate_box and activation_steps_run_in_order_and_name_the_failing_step_in_activate_box. cargo clippy -p minimal --all-targets shows no warnings in minimal. just clippy-strict was not run. |
mitodrummer
left a comment
There was a problem hiding this comment.
Babysit review on a7b55e9 against T36's plan block. The CLI's box operations now carry box names: activate_box, box_via_ssh, box_announce_label, box_record_by, box_delta, destroy_box / destroy_all_boxes, box_policy_as_json and task_box_name, with their locals and callers. The cmd_session_* handlers keep the min session verb names. Every string a person sees and every wire type is unchanged. The edits outside the layers are callers (list.rs, mod.rs, net.rs, project.rs) and the scan-list strings in src/tests.rs, which a maintainer accepted. arch-review PASS on this head.
…an attach or an exec The native daemon's control socket answers only the answerer verbs, so asking it to re-hold a name was a refusal warned on every native attach and exec's stderr (#2213). The re-hold is for Minvmd alone, as the activation's hold is; every caller of box_via_ssh passes the daemon's provider kind. Re-applied onto main's split CLI files (#2479, #2480).
…an attach or an exec The native daemon's control socket answers only the answerer verbs, so asking it to re-hold a name was a refusal warned on every native attach and exec's stderr (#2213). The re-hold is for Minvmd alone, as the activation's hold is; every caller of box_via_ssh passes the daemon's provider kind. Re-applied onto main's split CLI files (#2479, #2480).
…an attach or an exec (gominimal#2225) The native daemon's control socket answers only the answerer verbs, so asking it to re-hold a name was a refusal warned on every native attach and exec's stderr (gominimal#2213). The re-hold is for Minvmd alone, as the activation's hold is; every caller of box_via_ssh passes the daemon's provider kind. Re-applied onto main's split CLI files (gominimal#2479, gominimal#2480).
T36 — Name the CLI's operations after the box
slice: S0
kind: enablement
covers: none
size: L
est: 480 code, 60 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none: a rename, nothing printed changes
observability: none: a rename, no new signal
layers:
- cli:
- crates/minimal/src/cmd/boxes.rs: box operation names
- crates/minimal/src/cmd/boxes/create.rs: create takes a box name
- crates/minimal/src/cmd/boxes/vm_host.rs: registration takes a box name
- crates/minimal/src/cmd/boxes/attach.rs: attach takes a box name
- crates/minimal/src/cmd/boxes/exec.rs: exec takes a box name
- crates/minimal/src/cmd/boxes/policy.rs: policy takes a box name
- crates/minimal/src/cmd/boxes/lifecycle.rs: stop, remove take box names
- crates/minimal/src/cmd/boxes/hooks.rs: hooks take a box name
- crates/minimal/src/cmd/session.rs: handlers map onto box operations
- crates/minimal/src/task.rs: calls the box operations
test: cargo nextest run -p minimal run_alias_message_names_both_canonical_forms
produces: none
consumes: none
proof: Output and wire unchanged; the code says box.
depends on:
- blocked by #2380
Proof
A reader of crates/minimal sees the box operations named after the box: destroy_box, destroy_all_boxes, box_delta, box_policy_as_json, box_policy_json_inputs, attached_box_record, should_announce_box and task_box_name, and their parameters take box_name or box_id. No printed text, RPC or wire name changed, and the full minimal test suite passes.
Notes from the agent: Four session-named functions keep their names: activate_session, session_via_ssh, session_announce_label and session_record_by. Callers or source-scanning tests outside the layers name them: cmd/list.rs, cmd/net.rs, cmd/mod.rs and cmd/project.rs (doc links), and src/tests.rs (the connect-site and create-site inventories, and the function_body checks on activate_session). A follow-up task with those files in its layers can rename them. cmd/boxes.rs, cmd/boxes/exec.rs and cmd/boxes/hooks.rs need no change: they have no session-named operation or parameter. Clap fields such as args.session stay, because they live in the argument definitions outside the layers and their names reach --help. Wire and RPC types (DestroySession, SessionId, session_id struct fields) stay, as the task requires. The test task_session_name_sanitizes_the_task_stem in task.rs is now task_box_name_sanitizes_the_task_stem.
Tests
cargo nextest run -p minimal run_alias_message_names_both_canonical_formsVerify
min task run agent-verifyexited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.Closes #2383
Undrafted 2026-10-21. The edits outside the layers are callers of the renamed operations (
cmd/list.rs,cmd/mod.rs,cmd/net.rs,cmd/project.rs) and the source-scan lists incrates/minimal/src/tests.rs, which name those functions. A maintainer asked for the full rename and accepts them. Output and wire format are unchanged.