Skip to content

feat(minimald): point a proxy_env box's environment at the proxy - #2492

Merged
norrietaylor merged 7 commits into
mainfrom
agent/2334-point-the-box-at-the-proxy
Oct 22, 2026
Merged

norrietaylor merged 7 commits into
mainfrom
agent/2334-point-the-box-at-the-proxy

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

T40 — Point the box at the proxy

slice: S0
kind: task
covers: BEP-012
size: M
est: 60 code, 200 tests
executor: agent
difficulty: routine
model: standard
diagnostics: min box spec <box> shows the box's steering, which decides whether the proxy variables are set
observability: one debug log line per box naming the proxy variables set
layers:
- env:
- crates/minimald/src/box_runtime.rs: HTTPS_PROXY, HTTP_PROXY, NO_PROXY and NODE_USE_ENV_PROXY under proxy_env or both
- scripts/session-e2e.sh: adds two cases
test: ./scripts/session-e2e.sh bep_proxy_env_and_no_proxy_are_set
test: ./scripts/session-e2e.sh bep_proxy_env_sets_node_use_env_proxy
produces: none
consumes:
- crates/boxes/src/core/bep.rs
proof: A proxy_env box has the proxy address, the no-proxy list and NODE_USE_ENV_PROXY=1 in its environment.
depends on:
- blocked by #2264
- blocked by #2273
- blocked by #2488

Layer exception

crates/minimald/src/box_actor/host.rs is outside T40's layers:. The change is the call site that wires the layer's two functions into the launch: eight lines that read the switch subnet from the box actor, which alone holds the switch, and call launch_proxy_env and place_launch_proxy_env before the sealed deliveries join the connection layer. No logic lives there. Accepted under the epic's layer-exception rule of 2026-10-19; the babysitter undrafted the PR on it.

docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md is outside the layers too. Round 1 amends the BEP-012 requirement line to state the credentialed-lane gate, which the arch review's C1 asked for. Accepted under the same rule as an arch-required one-liner.

Evidence from a lane with a switch

The Linux KVM lane (test-kvm, run 39845921561, job 120063123094) at 9352bc55 ran both cases with MINVMD_GVPROXY_BIN set, and both passed:

proxy_env box: HTTPS_PROXY, HTTP_PROXY and NO_PROXY (BEP-012)
proxy_env box: HTTPS_PROXY=HTTP_PROXY=http://100.64.255.252:8118, NO_PROXY=.min.internal,host.min.internal,localhost,127.0.0.1,e2e-direct.example,10.0.0.0/8
proxy_env box: NODE_USE_ENV_PROXY (BEP-012)
proxy_env box: NODE_USE_ENV_PROXY=1
session e2e OK

Recorded by the babysitter for the arch review's C2.

Proof

A box whose [session.network.bep] steering is proxy_env or both, or whose proxy_env is true, and that has a credentialed lane in effect (own_ip with --credentialed-upstream or a broker grant), has HTTPS_PROXY and HTTP_PROXY set to http://<proxy address on the daemon's switch>:8118, NO_PROXY set to .min.internal,host.min.internal,localhost,127.0.0.1 followed by its no_proxy entries, and NODE_USE_ENV_PROXY=1. min session exec <box> env shows them. The unit tests prove this. The e2e cases that prove it end to end did not run on this box.

Notes from the agent: Outside the layers: crates/minimald/src/box_actor/host.rs got a 7-line change at the launch_host call site. The proxy address depends on the daemon's switch subnet, and only the box actor holds the switch, so box_runtime.rs could not reach the subnet without this call. Both e2e cases record NOT RUN when MINVMD_GVPROXY_BIN is not set, as the other switch cases do. This sandbox has no gvproxy, tun or kvm, so the real evidence must come from a lane with a switch (Linux native with gvproxy, KVM, or macOS). The cases do not need a sign-in or a running proxy: they activate with --network own_ip --credentialed-upstream and read env. Design decisions: (1) The variables are set only when the box declares a credentialed upstream and CredentialedUpstream::in_effect(network) is true. A box without the lane cannot reach the proxy's address, so the variables would break all of its HTTP traffic. The spec text does not state this condition. (2) Only the uppercase names that the spec gives are set. curl reads only lowercase http_proxy for plain HTTP, so a later task can add the lowercase variants. (3) The proxy values replace a value with the same name in the connection layer, the same as the sealed deliveries do. (4) Only the HTTPS_PROXY format and port are checked by the e2e case, not the exact address, because a native daemon uses a /24 of its own and the VM lane uses the default /16. `cargo clippy -p minimald …[truncated]

Tests

line exit tail
./scripts/session-e2e.sh bep_proxy_env_and_no_proxy_are_set 0 ::group::proxy_env box: HTTPS_PROXY, HTTP_PROXY and NO_PROXY (BEP-012) bep_proxy_env_and_no_proxy_are_set: NOT RUN (no MINVMD_GVPROXY_BIN: this target has no switch, so no box has a credentialed lane) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_proxy_env_and_no_proxy_are_set session e2e OK Appl
./scripts/session-e2e.sh bep_proxy_env_sets_node_use_env_proxy 0 ::group::proxy_env box: NODE_USE_ENV_PROXY (BEP-012) bep_proxy_env_sets_node_use_env_proxy: NOT RUN (no MINVMD_GVPROXY_BIN: this target has no switch, so no box has a credentialed lane) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_proxy_env_sets_node_use_env_proxy session e2e OK Applying loadout

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-1ede...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimald/src/box_actor/host.rs

Closes #2334


Generated by Claude Code

BEP-012: a box whose steering is proxy_env or both, or whose
[network.bep] proxy_env is true, gets HTTPS_PROXY and HTTP_PROXY at the
Box Egress Proxy's listener on the daemon's switch subnet, NO_PROXY with
the local zone, loopback and its no_proxy entries, and
NODE_USE_ENV_PROXY=1. A box without a credentialed lane in effect gets
none of them. One debug line per box names the variables set.
BEP-012: an own-address box with steering = "proxy_env" and a
credentialed lane has HTTPS_PROXY and HTTP_PROXY at the proxy's address
on port 8118, NO_PROXY with the local zone, loopback and its no_proxy
entries, and NODE_USE_ENV_PROXY=1. A target with no switch records
both cases as NOT RUN.
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c33fcc3b-e03f-40e5-97b7-d175f0ef813f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review of T40 against its plan block, at 9352bc55.

Layer env. crates/minimald/src/box_runtime.rs sets HTTPS_PROXY, HTTP_PROXY, NO_PROXY and NODE_USE_ENV_PROXY for a box whose steering is proxy_env or both, or whose [network.bep] proxy_env is true, at the proxy's listener on the daemon's switch subnet. The variables join the connection layer before the sealed deliveries do, over any value with the same name. NO_PROXY carries the four local entries first and the box's no_proxy entries after, in the order BEP-012 writes them. Three unit tests pin the values, the gating and the placement. scripts/session-e2e.sh adds the two cases the plan names, wired into the full run, the single-case dispatcher and the usage text. Each records NOT RUN on a target with no switch.

Consumes. crates/boxes/src/core/bep.rs (Steering, BepSettings.proxy_env, BepSettings.no_proxy, resolved_steering): read, not changed.

Out of the layers. crates/minimald/src/box_actor/host.rs carries the call site: the box actor alone holds the switch, so it reads the subnet and calls the two layer functions before the deliveries join the layer. Eight lines, no logic. The babysitter accepts it under the epic's layer-exception rule and undrafts this PR; the body's "Layer exception" section records it.

For the arch review. The variables are set only when the box declares a credentialed upstream and CredentialedUpstream::in_effect(network) holds. BEP-012's WHERE clause names steering and proxy_env alone. The agent's reason, that an unlaned box cannot reach the proxy's address, is sound. The ruling on whether the narrower condition conforms is the arch review's.

Evidence. The Linux native lane ran both cases as NOT RUN (no MINVMD_GVPROXY_BIN). The KVM and macOS lanes are the ones with a switch; their results decide the proof.

No blocking findings of my own.


Generated by Claude Code

@norrietaylor
norrietaylor marked this pull request as ready for review October 22, 2026 20:23
@norrietaylor
norrietaylor requested a review from a team as a code owner October 22, 2026 20:23
@minimal-foundry

minimal-foundry Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at 6c6a4d88b7fd.

@norrietaylor resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The proxy variables conform to networking §5.4 and §7.1, and the call site in host.rs is in the right owner. Two items remain open. The spec line for BEP-012 does not state the credentialed-lane gate or NODE_USE_ENV_PROXY that the code applies. Amend the spec as C1 says. Both e2e cases recorded NOT RUN, and a NOT RUN case is not a pass. Run them on a lane with a switch and record the result, as C2 says.

Ruled at 9352bc5 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread crates/minimald/src/box_runtime.rs Resolved
Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 3 unresolved threads — minimal-arch[bot] crates/minimald/src/box_runtime.rs:362, minimal-arch[bot] scripts/session-e2e.sh:11704, minimal-arch[bot] scripts/session-e2e.sh:11736.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

Copy link
Copy Markdown
Member

/revise Act on the arch review's C1 at 9352bc55 (thread 4353170017): BEP-012 in docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md does not state the credentialed-lane gate that launch_proxy_env applies. Amend the BEP-012 line so its WHERE clause also requires that the box declares a credentialed upstream that is in effect for its network mode, in the same EARS form, and say in a one-line HTML comment under it why: a box with no lane cannot reach the proxy's address (networking §7.1). Do not add NODE_USE_ENV_PROXY to the main line: the sub-requirement under BEP-012 already names it. Keep the change to that spec line and its comment. C2 (the two NOT RUN cases) needs a lane with a switch; the babysitter records the CI evidence from the KVM lane in the PR body, so do nothing for C2.


Generated by Claude Code

The proxy variables are set only for a box whose credentialed lane is in
effect for its network mode, as launch_proxy_env does. A box without a
lane cannot reach the proxy's address (networking section 7.1).
@github-actions

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md — 35 finding(s)

docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:113: P004 BEP-003 names test 'bep_second_box_needs_no_sign_in', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:129: P004 BEP-069 names test 'an_expiring_sign_in_is_renewed_at_the_proxy', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:170: P004 BEP-007 names test 'bep_box_env_holds_sealed_value_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:214: P004 BEP-011 names test 'bep_root_ca_present_in_box_trust_store', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:230: P004 BEP-012 names test 'bep_proxy_env_and_no_proxy_are_set', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:279: P004 BEP-061 names test 'signing_ca_rotation_invisible_to_boxes', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:283: P004 BEP-015 names test 'bep_git_and_gh_against_private_repo', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:297: P004 BEP-018 names test 'quic443_blocked_rejects_udp_443', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:315: P004 BEP-078 names test 'steered_name_aaaa_https_svcb_are_nodata', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:320: P004 BEP-062 names test 'steered_name_servfail_while_proxy_down', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:437: P004 BEP-028 names test 'host_ip_redemption_is_cohort_attributed', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:458: P004 BEP-032 names test 'store_reference_injects_in_registered_form', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:463: P004 BEP-033 names test 'store_value_read_per_request_never_written', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:467: P004 BEP-063 names test 'store_handle_signed_and_key_registered', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:499: P004 BEP-034 names test 'store_rule_in_deny_set_is_refused', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:507: P004 BEP-065 names test 'injected_value_is_exactly_prefix_plus_value', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:512: P004 BEP-066 names test 'crlf_in_value_or_prefix_refuses_injection', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:516: P004 BEP-035 names test 'ask_rule_without_tty_denies', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:520: P004 BEP-036 names test 'prop_store_upstream_outside_egress_is_exit_3', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:525: P004 BEP-037 names test 'project_store_rules_are_ignored_with_warning', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:548: P004 BEP-067 names test 'mint_and_destroy_append_audit_records', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:562: P004 BEP-068 names test 'segment_rotation_continues_chain', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:599: P004 BEP-043 names test 'bep_destroyed_box_values_refused_within_60s', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:608: P004 BEP-044 names test 'bep_logout_refuses_every_reference_at_next_request', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:621: P004 BEP-070 names test 'box_id_is_a_csprng_uuidv7_per_creation', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:632: P004 BEP-071 names test 'prop_revocation_covers_exactly_its_box', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:642: P004 BEP-045 names test 'deleted_keychain_item_refuses_next_injection', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:651: P004 BEP-047 names test 'bep_and_gvproxy_are_separate_processes_and_users', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:660: P004 BEP-049 names test 'prop_audit_chain_detects_unrecomputed_edit', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:669: P004 BEP-050 names test 'secret_set_stores_in_keychain_and_prints_id_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:683: P004 BEP-051 names test 'secret_item_acl_admits_proxy_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:691: P004 BEP-052 names test 'secret_list_shows_metadata_without_values', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:695: P004 BEP-053 names test 'secret_rm_removes_item', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:699: P004 BEP-054 names test 'replaced_secret_is_injected_on_next_request', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:703: P004 BEP-079 names test 'secret_set_writes_user_level_store_rule', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@fb5932b8, spec format: How Minimal Writes Specs.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The code conforms to networking §5.4 and §7.1. It sets the proxy variables only for a box with a credentialed lane in effect. The spec amendment at line 228 states that gate for HTTPS_PROXY, HTTP_PROXY and NO_PROXY. The NODE_USE_ENV_PROXY sub-requirement at line 232 still has no lane gate. As written, it requires a steering variable on a box that §7.1 line 244 says is never steered. Make the spec edit in C1. Do not change the code.

Ruled at 33b57a5 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-arch[bot] crates/minimald/src/box_runtime.rs:362, minimal-arch[bot] docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:232. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review of T40 at 33b57a57 (round 1).

The round changes one spec line and adds one comment under it: BEP-012's main requirement now gates on a credentialed upstream in effect for the box's network mode, which is what launch_proxy_env applies, and the comment names networking §7.1 as the reason. The rest of the diff is main merged in. The code and the e2e cases are as reviewed at 9352bc55; the KVM lane's passing output for both cases stands in the body.

The spec file is outside the task's layers. The change is the arch review's own ask, one requirement line, so the babysitter accepts it under the epic's layer-exception rule.

The spec-lint comment's findings are all P004, a test name the linter did not find in the repository. The two names this PR adds are shell cases in scripts/session-e2e.sh, the same form as the landed bep_second_box_needs_no_sign_in, which the linter also reports. Advisory, and not this PR's.

Open: the arch review's C1 at this head asks for the same gate on the NODE_USE_ENV_PROXY sub-requirement, since the code sets that variable behind the lane gate too. That is the next round.

No blocking findings of my own.


Generated by Claude Code

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a /revise note, pushed as 33b57a57b419.

line exit tail
./scripts/session-e2e.sh bep_proxy_env_and_no_proxy_are_set 0 no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/build-cache/target/debug/min and /work/build-cache/target/debug/minimald ::group::proxy_env box: HTTPS_PROXY, H
./scripts/session-e2e.sh bep_proxy_env_sets_node_use_env_proxy 0 ::group::proxy_env box: NODE_USE_ENV_PROXY (BEP-012) bep_proxy_env_sets_node_use_env_proxy: NOT RUN (no MINVMD_GVPROXY_BIN: this target has no switch, so no box has a credentialed lane) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_proxy_env_sets_node_use_env_proxy session e2e OK Applying loadout

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

og v0.0.1 (/workbench/crates/mlog)
    Checking bcrypt-pbkdf v0.11.0
    Checking ssh-cipher v0.3.0
    Checking ed25519-dalek v3.0.0
    Checking generic-array v0.14.7
    Checking sha3 v0.11.0
    Checking p256 v0.14.0
    Checking p384 v0.14.0
    Checking p521 v0.14.0
    Checking module-lattice v0.2.3
    Checking kem v0.3.0
    Checking object v0.40.0
    Checking hashbrown v0.14.5
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking sponge-cursor v0.1.0
    Checking tinyvec_macros v0.1.1
    Checking data-encoding v2.11.1
    Checking tinyvec v1.12.0
    Checking sha3 v0.12.0
    Checking dashmap v6.2.1
    Checking ml-kem v0.3.2
    Checking ssh-key v0.7.0-rc.11
    Checking generic-array v1.4.4
    Checking async-compression v0.4.50
    Checking russh-cryptovec v0.62.0
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking async-tar v0.6.1
    Checking num-bigint v0.5.1
    Checking russh-util v0.52.0
    Checking serde_bytes v0.11.19
    Checking hex-literal v1.1.0
    Checking constcat v0.6.1
    Checking russh-sftp v2.4.0
    Checking russh v0.63.3
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking hickory-proto v0.26.3
    Checking clap_complete v4.6.11
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking sysinfo v0.39.6
    Checking wait-timeout v0.2.1
    Checking bit-vec v0.8.0
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking quick-error v1.2.3
    Checking rusty-fork v0.3.1
    Checking bit-set v0.8.0
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking rand_xorshift v0.4.0
   Compiling serial_test_derive v4.0.1
    Checking unarray v0.1.4
    Checking proptest v1.11.0
    Checking serial_test v4.0.1
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/minimald/src/box_actor/host.rs
  • docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_runtime.rs:362: Amended BEP-012 so its WHERE clause also requires a credentialed upstream in effect for the box's network mode, with a comment citing networking §7.1. NODE_USE_ENV_PROXY was already named in the sub-requirement under BEP-012.
  • 👍 valid — PRRT_kwDOPdfcxM6vXZ4t: No code change: the case needs a lane that sets MINVMD_GVPROXY_BIN. The passing output from the KVM lane is to be recorded in the PR body, outside this coder round. (not posted on the thread: not an open thread on the pull request)
  • 👍 valid — PRRT_kwDOPdfcxM6vXZ4z: No code change: the case needs a lane with a switch. The passing result from the KVM lane is to be recorded in the PR body, outside this coder round. (not posted on the thread: not an open thread on the pull request)

A proxy_env box with a credentialed upstream in effect has HTTPS_PROXY, HTTP_PROXY, the NO_PROXY list and NODE_USE_ENV_PROXY=1 in its environment (code from earlier rounds). BEP-012 in the spec now states the same credentialed-lane gate that launch_proxy_env applies, with a comment that gives the reason.

Notes from the agent: This round changes only docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md. That file is outside the task's layers, but the /revise note asks for this change explicitly. The BEP-012 WHERE clause now also requires a credentialed upstream that is in effect for the box's network mode. A one-line HTML comment under it gives the reason (networking section 7.1). The NODE_USE_ENV_PROXY sub-requirement stays as it was, as the note directs. I did not run the two session-e2e test lines this round. They need a VM lane with a switch (MINVMD_GVPROXY_BIN), and this round changes no code or script. just lint-prose did not run because vale is not installed on this box.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 22, 2026 20:45
@norrietaylor
norrietaylor marked this pull request as ready for review October 22, 2026 20:54

Copy link
Copy Markdown
Member

/revise Act on the arch review's C1 at 33b57a57 (thread 4353310185): the NODE_USE_ENV_PROXY sub-requirement under BEP-012 in docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md still has no lane gate, and the code sets that variable behind the same gate as the other three. Copy the gate from the main BEP-012 line into the sub-requirement's WHERE clause, word for word: "WHERE a box declares a credentialed upstream that is in effect for its network mode, and its steering is proxy_env or both or its [network.bep] proxy_env is true". Keep its tier and verify lines and the HTML comment under them. Change nothing in the code.


Generated by Claude Code

The NODE_USE_ENV_PROXY sub-requirement under BEP-012 now carries the
same lane gate as the main line, matching the code in box_runtime.rs.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-arch[bot] crates/minimald/src/box_runtime.rs:362, minimal-arch[bot] docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

BEP-012 conforms to the design at this head. The new commit adds the credentialed-lane gate to the NODE_USE_ENV_PROXY sub-line, so both spec lines now match the code. Networking §7.1 line 248 is the source of that gate: only a credentialed-lane box can reach the node-local proxy address. The variables and the NO_PROXY order follow §5.4 lines 170–173 and box.toml lines 142–143. The KVM-lane evidence at 9352bc55 still covers the proxy path, because the compare since then does not touch it.

Ruled at 6c6a4d8 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 6c6a4d88b7fd.

line exit tail
./scripts/session-e2e.sh bep_proxy_env_and_no_proxy_are_set 0 no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/build-cache/target/debug/min and /work/build-cache/target/debug/minimald ::group::proxy_env box: HTTPS_PROXY, H
./scripts/session-e2e.sh bep_proxy_env_sets_node_use_env_proxy 0 ::group::proxy_env box: NODE_USE_ENV_PROXY (BEP-012) bep_proxy_env_sets_node_use_env_proxy: NOT RUN (no MINVMD_GVPROXY_BIN: this target has no switch, so no box has a credentialed lane) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_proxy_env_sets_node_use_env_proxy session e2e OK Applying loadout

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

g moka v0.12.16
    Checking compression-codecs v0.4.45
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking bcrypt-pbkdf v0.11.0
    Checking ed25519-dalek v3.0.0
    Checking ssh-cipher v0.3.0
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking generic-array v0.14.7
    Checking sha3 v0.11.0
    Checking p256 v0.14.0
    Checking p521 v0.14.0
    Checking p384 v0.14.0
    Checking module-lattice v0.2.3
    Checking kem v0.3.0
    Checking object v0.40.0
    Checking hashbrown v0.14.5
    Checking data-encoding v2.11.1
    Checking sponge-cursor v0.1.0
    Checking tinyvec_macros v0.1.1
    Checking sha3 v0.12.0
    Checking dashmap v6.2.1
    Checking tinyvec v1.12.0
    Checking ml-kem v0.3.2
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking ssh-key v0.7.0-rc.11
    Checking generic-array v1.4.4
    Checking async-compression v0.4.50
    Checking russh-cryptovec v0.62.0
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking async-tar v0.6.1
    Checking num-bigint v0.5.1
    Checking russh-util v0.52.0
    Checking serde_bytes v0.11.19
    Checking hex-literal v1.1.0
    Checking constcat v0.6.1
    Checking russh-sftp v2.4.0
    Checking russh v0.64.1
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking hickory-proto v0.26.3
    Checking clap_complete v4.6.11
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking sysinfo v0.39.6
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking wait-timeout v0.2.1
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking bit-vec v0.10.1
    Checking quick-error v1.2.3
    Checking rusty-fork v0.3.1
    Checking bit-set v0.11.1
    Checking rand_xorshift v0.5.0
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/minimald/src/box_actor/host.rs
  • docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md: Copied the BEP-012 lane gate word for word into the NODE_USE_ENV_PROXY sub-requirement's WHERE clause. The tier and verify lines are unchanged.

A proxy_env box with a credentialed upstream in effect has HTTPS_PROXY and HTTP_PROXY at the proxy address, the NO_PROXY list and NODE_USE_ENV_PROXY=1 in its environment. The spec's NODE_USE_ENV_PROXY sub-requirement now states the same lane gate that the code applies.

Notes from the agent: Revise round 2 changes only the spec. The WHERE clause of the NODE_USE_ENV_PROXY sub-requirement under BEP-012 now copies the main line's gate word for word. Its tier and verify lines and its HTML comment are unchanged. No code changed, because launch_proxy_env in box_runtime.rs already returns no variables unless a credentialed upstream is in effect. The spec file is outside the task's layers; the directive asked for this edit. I did not run the two session-e2e.sh test lines: this round changes no code, and they need a VM. just lint-prose did not run because vale is not installed on this box.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 22, 2026 21:03
@norrietaylor
norrietaylor marked this pull request as ready for review October 22, 2026 21:06

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review of T40 at 6c6a4d88 (round 2).

The round changes one spec line: the NODE_USE_ENV_PROXY sub-requirement under BEP-012 now carries the same credentialed-lane gate as the main line, word for word, with its tier, verify and comment kept. The rest of the compare is main merged in. The arch review ruled PASS at this head, and its earlier conditions are answered: C1 by the two spec lines, C2 by the KVM lane's passing run of both cases at 9352bc55, which the compare since then does not touch. The code reviewer ran all three personas with no findings.

The spec file is outside the task's layers; both of its edits are the arch review's own asks, one requirement line each, accepted under the epic's layer-exception rule as the body records.

No blocking findings of my own. Ready for the merge gate once CI finishes at this head.


Generated by Claude Code

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 6c6a4d88b7fd withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 22, 2026
@norrietaylor norrietaylor changed the title T40 — Point the box at the proxy feat(minimald): point a proxy_env box's environment at the proxy Oct 22, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the babysitter at 6c6a4d88 after the merge gate passed: own reviews at every head, arch-review PASS at 6c6a4d88, the code reviewer's approval released, every review thread resolved, every CI lane green including macOS, both e2e cases proved on the KVM lane, and the squash subject lint-clean. The two out-of-layer edits (the host.rs call site and the BEP-012 spec lines) are recorded in the body's "Layer exception" section. Enqueued for a squash merge.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit e8feee2 Oct 22, 2026
38 checks passed
@norrietaylor
norrietaylor deleted the agent/2334-point-the-box-at-the-proxy branch October 22, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T40 — Point the box at the proxy

1 participant