Skip to content

feat(minimald): ship a git credential helper in grant boxes (T50) - #2547

Merged
norrietaylor merged 11 commits into
mainfrom
agent/2531-ship-a-git-credential-helper-in-grant-boxes-so-g
Oct 25, 2026
Merged

norrietaylor merged 11 commits into
mainfrom
agent/2531-ship-a-git-credential-helper-in-grant-boxes-so-g

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

T50 — Ship a git credential helper in grant boxes so git sends a header the proxy substitutes

slice: S9
kind: task
covers: BEP-015
size: M
est: 160 code, 180 tests
executor: agent
difficulty: needs care
model: standard
diagnostics: git credential fill inside a grant box answers for the grant's hosts with the placeholder, and min box spec lists the helper under the grant
observability: one debug log line per helper answer naming the host, never the value
layers:
- spec:
- docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md: adds the requirement for the git credential helper a grant box carries (Gatehouse §6.4 line 718), under BEP-015
- box:
- crates/minimald/src/box_actor.rs: declares the new module
- crates/minimald/src/box_actor/tests.rs: the helper's tests
- crates/minimald/src/box_actor/bep_git_helper.rs (new): writes the helper and its git config credential.helper line into a grant box at creation, for the grant's hosts only, with the sealed value as the placeholder the proxy substitutes
test: cargo nextest run -p minimald grant_box_git_credential_helper_answers_for_grant_hosts
- e2e:
- scripts/session-e2e.sh: a case that clones and pushes from a grant box with the shipped helper and no helper of its own; records NOT RUN off macOS, without a sign-in or without E2E_BEP_PRIVATE_REPO (#2500)
test: ./scripts/session-e2e.sh bep_git_credential_helper_sends_header
produces: none
consumes:
- crates/bep/src/forward.rs
proof: From a grant box with no git configuration of its own, git clone and git push send an Authorization header the proxy substitutes.
depends on:
- blocked by T11
- blocked by T18

Proof

A GitHub grant box now carries a git credential helper from its start, written by minimald into the box home. In the box, git credential fill for github.com, api.github.com, uploads.github.com or codeload.github.com answers username=x-access-token and the box's sealed value as the password. No other host gets an answer. So git clone and git push send a Basic Authorization header that holds the sealed value, and the proxy substitutes it. The minimald test proves this with a real git. The live clone and push against a private repository are in the e2e case bep_git_credential_helper_sends_header, which this Linux box records as NOT RUN. The macOS lane in #2500 owes that evidence.

Notes from the agent: Design: the helper is a POSIX sh script at ~/.local/state/minimal/git-credential-minimal (mode 0700, because it holds the sealed value). Its config is ~/.local/state/minimal/git-credential.gitconfig, with one [credential "https://"] section for each GitHub host. minimald adds one [include] line to ~/.config/git/config and does not touch ~/.gitconfig, so a .gitconfig patch from a composition stays. BoxActor::run writes the helper on every actor start, after create_dirs, so a resumed box gets it too. A write failure is logged as a warning and does not stop the box. A sealed value with characters outside base64url and dots is refused, and no helper is written.

Known limits: (1) minimald does not depend on the bep crate, and Cargo.toml is not in this task's layers. So bep_git_helper.rs repeats the four hosts of bep::module::GITHUB. A change to the host set must change both places. (2) If XDG_CONFIG_HOME is set inside the box, git does not read ~/.config/git/config, and the helper is not found. The box baseline environment does not set it today. (3) A composition patch that writes ~/.config/git/config after the actor starts replaces the include line until the next start.

Observability: the helper adds one line to ~/.local/state/minimal/git-credential.log…[truncated]

Tests

line exit tail
cargo nextest run -p minimald grant_box_git_credential_helper_answers_for_grant_hosts 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-fd06... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
./scripts/session-e2e.sh bep_git_credential_helper_sends_header 0 the 'min' and 'minimald' under /work/build-cache/target/debug report different versions; rebuilding the pair no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/bu

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-90a3...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

Residuals

Closes #2531


Generated by Claude Code

BEP-015: git sends an Authorization header only when a credential helper
answers. A grant box now carries a helper that answers for the GitHub hosts
with the box's sealed value, which the Box Egress Proxy substitutes. The
helper's configuration is included from the box's XDG git config, so the
box's own ~/.gitconfig stays as it is.
BEP-015 gains the requirement for the helper that Gatehouse 6.4 names:
it answers git for the GitHub module's hosts with the sealed value.
bep_git_credential_helper_sends_header runs git from a grant box with no
helper of its own. It records NOT RUN off macOS, without a sign-in or
without E2E_BEP_PRIVATE_REPO (#2500).
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 317a87e3-d22e-4ab6-ab40-16fd172ec22d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md — 24 finding(s)

docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:113: P004 BEP-003 names test 'bep_second_box_needs_no_sign_in', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:170: P004 BEP-007 names test 'bep_box_env_holds_sealed_value_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:214: P004 BEP-011 names test 'bep_root_ca_present_in_box_trust_store', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:230: P004 BEP-012 names test 'bep_proxy_env_and_no_proxy_are_set', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:283: P004 BEP-015 names test 'bep_git_and_gh_against_private_repo', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:467: P004 BEP-032 names test 'store_reference_injects_in_registered_form', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:472: P004 BEP-033 names test 'store_value_read_per_request_never_written', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:516: P004 BEP-065 names test 'injected_value_is_exactly_prefix_plus_value', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:521: P004 BEP-066 names test 'crlf_in_value_or_prefix_refuses_injection', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:557: P004 BEP-067 names test 'mint_and_destroy_append_audit_records', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:571: P004 BEP-068 names test 'segment_rotation_continues_chain', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:608: P004 BEP-043 names test 'bep_destroyed_box_values_refused_within_60s', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:617: P004 BEP-044 names test 'bep_logout_refuses_every_reference_at_next_request', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:630: P004 BEP-070 names test 'box_id_is_a_csprng_uuidv7_per_creation', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:641: P004 BEP-071 names test 'prop_revocation_covers_exactly_its_box', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:651: P004 BEP-045 names test 'deleted_keychain_item_refuses_next_injection', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:660: P004 BEP-047 names test 'bep_and_gvproxy_are_separate_processes_and_users', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:669: P004 BEP-049 names test 'prop_audit_chain_detects_unrecomputed_edit', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:678: P004 BEP-050 names test 'secret_set_stores_in_keychain_and_prints_id_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:692: P004 BEP-051 names test 'secret_item_acl_admits_proxy_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:700: P004 BEP-052 names test 'secret_list_shows_metadata_without_values', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:704: P004 BEP-053 names test 'secret_rm_removes_item', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:708: P004 BEP-054 names test 'replaced_secret_is_injected_on_next_request', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:712: P004 BEP-079 names test 'secret_set_writes_user_level_store_rule', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@fb5932b8, spec format: How Minimal Writes Specs.

@minimal-foundry

minimal-foundry Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at 50caf4605cf7.

@norrietaylor resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 4 findings, 4 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 3 conditions · the full ruling

The helper answers with the sealed value for the GitHub hosts only, and that part conforms. Gatehouse §6.4 line 718 also says that the helper must be git's sole helper, with store and cache disabled. The change does not do this. Git reads the included config before ~/.gitconfig and the repository config. A store helper in either one writes the sealed value to ~/.git-credentials. C1 moves the helper to git's command scope with an empty reset, and adds a test. C2 adds the rule to the spec. C3 files an issue for the copied host set.

Ruled at cfa1ae9 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread crates/minimald/src/box_actor/tests.rs Resolved
The box user owns its home, so each directory the helper writes is checked
for a symbolic link, and files open with O_NOFOLLOW. A start without a
usable grant now removes a helper an earlier start wrote.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 9 unresolved threads — minimal-foundry[bot] crates/minimald/src/box_actor/bep_git_helper.rs:218, minimal-foundry[bot] crates/minimald/src/box_actor/bep_git_helper.rs, minimal-foundry[bot] crates/minimald/src/box_actor/bep_git_helper.rs:203, minimal-foundry[bot] crates/minimald/src/box_actor/bep_git_helper.rs, minimal-arch[bot] crates/minimald/src/box_actor/bep_git_helper.rs:245, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as f5a38054eb98.

line exit tail
cargo nextest run -p minimald grant_box_git_credential_helper_answers_for_grant_hosts 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-c303... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
./scripts/session-e2e.sh bep_git_credential_helper_sends_header 0 the 'min' and 'minimald' under /work/build-cache/target/debug report different versions; rebuilding the pair no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/bu

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-f5ef...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking check v0.0.1 (/workbench/crates/check)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs:218: install now refuses a symlinked directory under the home (real_dir checks each component with symlink_metadata), and opens the git config with O_NOFOLLOW and requires a regular file. A test covers each case.
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: write_atomically removes any file at the temp name, creates it with create_new and O_NOFOLLOW, and renames it over the target, which replaces a symlink and does not follow it. The parent directories are checked for symlinks.
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs:203: The NoGrant and Refused paths now remove the helper and its config file (remove_helper). The include line stays, because git ignores an include of a missing file. A test covers both paths.
  • 👎 invalid — crates/minimald/src/box_actor/bep_git_helper.rs: The client builds every SealedDelivery from a GitHub grant (sealed_deliveries in crates/minimal/src/cmd/boxes/create.rs), and GitHub is the one module today. The record has no module field to pick by. Adding one changes crates/boxes, which is outside this task's layers. The doc comment now names whe

In a grant box with no git configuration of its own, git credential fill answers for the GitHub hosts with the sealed value, so git clone and git push send an Authorization header that the proxy substitutes. A symbolic link that the box puts in its home no longer makes the daemon write outside the home.

Notes from the agent: Revise round 1. The helper now checks each directory it writes under the box home for a symbolic link and refuses one. It makes temporary files with O_EXCL and O_NOFOLLOW, and it opens the XDG git config with O_NOFOLLOW and requires a regular file. A start with no grant, or with a refused value, removes the helper and its config file. The include line stays, because git ignores an include of a missing file. A small race between the symbolic link check and the write on a directory is still possible. A full fix needs openat-relative writes. The e2e case recorded NOT RUN, because this box has no sign-in and no E2E_BEP_PRIVATE_REPO, so the clone and push proof is not observed. I did not run just clippy-strict.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 3 conditions · the full ruling

The helper is not git's sole credential helper. Gatehouse §6.4 line 718 requires that, with store and cache disabled. A credential.helper = store in ~/.gitconfig still runs and writes the sealed value to ~/.git-credentials. I checked this with a real git. A reset in the XDG include does not fix it, because git reads ~/.gitconfig later. C1 sets the helper at command scope through the box environment, and C3 puts the rule in the spec. C2 reads the host set from bep::module::GITHUB, because §6.10 line 851 makes the host set versioned BEP code.

Ruled at f5a3805 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Copy link
Copy Markdown
Member

/revise

Round 2 of #2547, on the arch ruling at f5a3805. No round is in flight. T50's layers were widened on 2026-10-25 for this ruling: crates/minimald/src/box_runtime/launcher.rs and crates/minimald/Cargo.toml are in the task now (the issue body carries the new lines), so none of this is out of layers.

  1. Arch C1 (threads 4369553981, 4369553985, 4369553987, 4369575400): make the shipped helper git's sole helper for each grant host, with store and cache disabled, at a scope git reads after ~/.gitconfig and the repository config. In the env build of SandboxLauncher (crates/minimald/src/box_runtime/launcher.rs, at the layer_session_env(...) call) add GIT_CONFIG_COUNT, GIT_CONFIG_KEY_<n> and GIT_CONFIG_VALUE_<n> to the connection layer when the box record holds sealed_deliveries: for each host, credential.https://<host>.helper with an empty value (the reset) and then the shipped helper. Remove the include in ~/.config/git/config (it is read before ~/.gitconfig). Add the test arch describes: a store helper in ~/.gitconfig and in a repository config, then git credential fill and git credential approve for a grant host must run only the shipped helper and write nothing to ~/.git-credentials.
  2. Arch C2 (threads 4369553991, 4369575401): remove the hard-coded GRANT_HOSTS; add bep = { path = "../bep" } to [dependencies] in crates/minimald/Cargo.toml as crates/minimal/Cargo.toml does, and read the host set from bep::module::GITHUB.hosts in helper_script(), helper_config() and the C1 environment, each Authority's host and its port when it is not 443. Residual Read the GitHub module's host set from one owner in the git credential helper (BEP-015) #2549 is closed as superseded by this.
  3. Arch C3 (threads 4369553989, 4369575403): in docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md line 285 (BEP-015), add the design's rule: the helper is git's sole credential helper for each host in the GitHub module's host set, and store and cache do not run for those hosts; add the C1 test as a verify: line.
  4. The disputed review thread 4369550726 (every sealed delivery is a GitHub grant today): the reasoning stands; reply with it once more under the new host-set source and resolve.
  5. Reply on each thread naming the commit and resolve the ones the commit fixes.

One or two commits, Conventional Commits subjects, body lines at most 100 characters.


Generated by Claude Code

The launch now sets GIT_CONFIG_COUNT, GIT_CONFIG_KEY_<n> and GIT_CONFIG_VALUE_<n> for a box
whose grant gave it the helper. For each host there is an empty helper, which clears the list,
and then the shipped helper. git reads command scope after ~/.gitconfig and the repository
config, so a store or cache helper there does not run for a grant host (Gatehouse §6.4).

The include in ~/.config/git/config is gone. The host set now comes from bep::module::GITHUB,
so minimald depends on bep. Cargo.lock records the new edge.
BEP-015 gains the design's rule from Gatehouse §6.4 line 718. The shipped helper is git's sole
credential helper for each host in the GitHub module's host set, and store and cache do not
run for those hosts. The minimald test that pins the rule is its verify line. The e2e case now
accepts only helpers that git reads at command scope.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 3 findings, 3 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/box_actor.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 97259d3e3679.

line exit tail
cargo nextest run -p minimald grant_box_git_credential_helper_answers_for_grant_hosts 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-ea61... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
./scripts/session-e2e.sh bep_git_credential_helper_sends_header 0 the 'min' and 'minimald' under /work/build-cache/target/debug report different versions; rebuilding the pair no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/bu

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-f07a...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: c3b970a: the launch sets an empty credential.https://.helper and then the shipped helper through GIT_CONFIG_COUNT, so git reads them after ~/.gitconfig and the repo config.
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: c3b970a: removed the include in ~/.config/git/config. The entries now go in the launch connection layer in box_runtime/launcher.rs.
  • 👍 valid — crates/minimald/src/box_actor/tests.rs: c3b970a: the test puts a store helper in ~/.gitconfig and in a repo config. fill and approve for each grant host leave no ~/.git-credentials. As a control, approve for example.com writes one.
  • 👍 valid — docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:285: 97259d3: BEP-015 now requires the helper to be git's sole helper for the host set, with store and cache not run (Gatehouse §6.4 line 718).
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: c3b970a: removed GRANT_HOSTS. minimald depends on bep and reads bep::module::GITHUB.hosts, so no issue for one owner is needed (Read the GitHub module's host set from one owner in the git credential helper (BEP-015) #2549 is superseded).
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: c3b970a: each grant host gets an empty helper then the shipped one, at command scope via GIT_CONFIG_COUNT in the launch environment. No config file is written for git to read.
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: c3b970a: helper_script(), helper_config() and the launch env read bep::module::GITHUB.hosts. The port is added when it is not 443. bep is in minimald's dependencies.
  • 👍 valid — docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:285: 97259d3: added the sole-helper rule (store and cache do not run for the host set) under BEP-015, with the minimald test as its verify line.

A grant box with no git configuration of its own gets the shipped helper as git's sole credential helper for each GitHub host. The launch sets it at command scope (GIT_CONFIG_COUNT), so git clone and git push send an Authorization header with the sealed value for the proxy to substitute. A store helper in ~/.gitconfig or in a repository config does not run for those hosts. The unit test shows this with git credential fill and approve. The live clone and push case is in scripts/session-e2e.sh, but it did not run on this box (NOT RUN, #2500 owns the lane).

Notes from the agent: Cargo.lock changed because minimald now depends on bep. It is not in the layers, but the Cargo.toml change needs it. The launcher sets the GIT_CONFIG_* pairs when the box home holds the helper that install() wrote from record.sealed_deliveries. It does not read the record directly, because SandboxLauncher is built in crates/minimald/src/box_actor/launcher.rs, which is outside the layers. This also skips the reset for a box whose sealed value was refused, so that box keeps its own helpers. The pairs start after any GIT_CONFIG_COUNT that the composition sets. I assume that min box exec processes get the pairs through the launch environment (Env::command_environment), and the e2e case checks this. The readable copy at ~/.local/state/minimal/git-credential.gitconfig stays, and its header says that git does not read it. Directive item 4 (thread 4369550726): my verdict is still invalid. Every sealed delivery comes from a GitHub grant, and the host set now comes from bep::module::GITHUB. That thread is under 'already answered', so it has no new entry. just lint-prose did not run: vale is not installed on this box. just clippy-strict did not run.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change now conforms to Gatehouse §6.4 line 718 and §6.10 line 851. The helper reads its hosts from bep::module::GITHUB. The launch makes it git's sole helper for those hosts with command-scope GIT_CONFIG_COUNT entries. The minimald test proves that a store helper writes nothing for a grant host. The live clone and push leg is NOT RUN. C1 keeps it open until the macOS lane in #2500 records PASS.

Ruled at 97259d3 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Each directory under the box home is opened relative to the one before
it with O_NOFOLLOW. Every file operation then uses that descriptor
(openat, renameat, unlinkat), so a symlink that the box swaps in after
the check is not followed.

A failed write now removes the helper from an earlier start, so the
launch does not make a stale helper git's sole helper. The helper log
moves to git-credential.log.1 when it is larger than 64 KiB.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The new commit makes the helper writes safe from symbolic links. It also removes an old helper when a write fails, so a failed write leaves no stale helper. This conforms to Gatehouse §6.4 line 718. The rest of the change keeps the status of the ruling on 97259d3e. One item stays open: the e2e clone and push case records NOT RUN on this lane. C1 records a pass on the macOS lane that #2500 owns.

Ruled at be96fe4 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as be96fe4a4808.

line exit tail
cargo nextest run -p minimald grant_box_git_credential_helper_answers_for_grant_hosts 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-df79... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
./scripts/session-e2e.sh bep_git_credential_helper_sends_header 0 the 'min' and 'minimald' under /work/build-cache/target/debug report different versions; rebuilding the pair no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/bu

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-727b...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: real_dir now opens each component with openat(O_DIRECTORY|O_NOFOLLOW) relative to the one before it and returns the open directory. The temp file, rename and unlink use openat, renameat and unlinkat on that descriptor, so a swap after the walk is not followed.
  • 👍 valid — crates/minimald/src/box_actor.rs:713: install now removes the helper from an earlier start when a write fails, so launch_git_config_env finds no helper. A refused directory also makes is_installed false. The comment in box_actor.rs now says this, and the test covers a failed write after a good one.
  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs: The helper moves git-credential.log to git-credential.log.1 before it appends when the log is larger than HELPER_LOG_MAX_BYTES (64 KiB), so the two files stay near 128 KiB. The test covers the move.

2 threads were already answered in earlier rounds, with nothing new on them since.

In a grant box with no git configuration of its own, git uses the shipped helper as its sole helper for the GitHub hosts. git credential fill answers with the sealed value, so git clone and git push send an Authorization header that the proxy substitutes. The minimald test proves the helper and its sole-helper rule. The live clone and push through the proxy is not proved on this box: the e2e case recorded NOT RUN.

Notes from the agent: Round 3. The two minimal-arch threads (C2 host set from bep::module::GITHUB, C3 sole-helper rule in BEP-015) were already fixed by commits c3b970a and 97259d3 at the branch head. This round changed nothing for them. The three minimal-foundry findings are fixed in be96fe4. The file work in the helper module now uses directory descriptors through libc, because the nix 0.31 sources were not on this box to check its API. The e2e case still owes its evidence on the macOS lane with a sign-in and E2E_BEP_PRIVATE_REPO. just clippy-strict was not run.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a failed check suite: the coder changed nothing. Revise round 4. I changed nothing and made no commit.

Failed check tests: the log excerpt does not name a failing test. On this branch head, the test line passes. The full minimald suite passes (1116 passed). The suites of bep, minimal, minimal-client and minvmd pass (1613 passed). cargo fmt --check is clean. clippy -p minimald --all-targets -D warnings is clean, except for two lints that this box's rustc 1.98.1 adds over the pinned 1.97.0. They are clippy::chunks_exact_to_as_chunks in minimald-rpc and clippy::result_unit_err in minimald/src/box_runtime/handle.rs, and this branch changes neither file. I did not run the workspace suite. The failure can be flaky, or it can be in a crate this branch does not touch. A person must read the full job log (run 40162069589, job 121075565785) to find the failing test. ci-linux-native-success only aggregates tests.

Failed check commitlint: the errors are in commits already on the branch. be96fe4 has a body line over 100 cha…[truncated]

Review threads the coder judged:

  • 👎 invalid — scripts/session-e2e.sh:11800: No code change on this branch can close this. The case records NOT RUN off macOS and without E2E_BEP_PRIVATE_REPO, as the task's e2e layer specifies. The PASS is evidence that the macOS lane of T82 — Run the Box Egress Proxy legs on the macOS lane #2500 must record with a sign-in and E2E_BEP_PRIVATE_REPO set. This Linux coder box cannot run it.
  • 👎 invalid — scripts/session-e2e.sh:11795: The same as the thread on line 11800. The clone and push case is complete in scripts/session-e2e.sh. It records NOT RUN here because this box is Linux and has no sign-in or E2E_BEP_PRIVATE_REPO. Only a run on the macOS lane of T82 — Run the Box Egress Proxy legs on the macOS lane #2500 can record the PASS. No change to the script can do that.

Copy link
Copy Markdown
Member

/revise

Round 5 of #2547, on the red native lane at be96fe4. No round is in flight. Round 4 found no failing test in the excerpt it saw; the full job log names it.

  1. ci-linux-native fails in common::shell_lint all_scripts_pass_shellcheck: scripts/lint-shell.sh reports scripts/session-e2e.sh line 11875, SC2016 (info): "Expressions don't expand in single quotes, use double quotes for that." That line is in this PR's new proof_bep_git_credential_helper_sends_header case. Fix the quoting on that line (or, if the single quotes are deliberate, the # shellcheck disable=SC2016 directive the other cases use), run scripts/lint-shell.sh and cargo nextest run -p common all_scripts_pass_shellcheck, and push.
  2. Arch C1 (threads 4369632923 and 4369653354): the macOS end-to-end case bep_git_credential_helper_sends_header stays NOT RUN off macOS; it needs a sign-in and E2E_BEP_PRIVATE_REPO on the Apple Silicon runner, which the epic owner runs by hand. Leave those two threads open and keep the NOT RUN row with that reason.
  3. Reply on the lint thread, if the review bot opens one, naming the commit.

One commit, Conventional Commits subject, body lines at most 100 characters.


Generated by Claude Code

The launch now names the git credential helper only when the helper file
answers with a sealed value that this launch places in the box environment.
A helper from an earlier start that a failed removal left behind no longer
becomes git's sole helper.

A GIT_CONFIG_COUNT that is not a number now adds no helper pairs and logs a
warning, so the pairs the box set are not replaced.

The e2e case reads the helper log with $HOME in single quotes on purpose, so
it carries the SC2016 directive that the other cases use.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 4 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh:11800, minimal-arch[bot] scripts/session-e2e.sh:11795, minimal-foundry[bot] crates/minimald/src/box_actor/bep_git_helper.rs:249, minimal-foundry[bot] crates/minimald/src/box_runtime/launcher.rs. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The new commit names the git helper only when the helper file answers with a sealed value that this launch places. A stale helper from an earlier start no longer becomes git's sole helper. That conforms to Gatehouse §6.4 line 718. The host set still comes from bep::module::GITHUB. One item stays open: the live e2e case records NOT RUN, and #2500 owns it (C1).

Ruled at aa9a161 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a /revise note, pushed as aa9a161f71e4.

line exit tail
cargo nextest run -p minimald grant_box_git_credential_helper_answers_for_grant_hosts 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-23cc... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
./scripts/session-e2e.sh bep_git_credential_helper_sends_header 0 the 'min' and 'minimald' under /work/build-cache/target/debug report different versions; rebuilding the pair no usable 'min' and 'minimald' pair on PATH or under target/; building the pair this run drives (cargo build --locked -p minimal --bin min -p minimald --bin minimald) built the pair: /work/bu

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-e1e6...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking check v0.0.1 (/workbench/crates/check)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_actor/bep_git_helper.rs:249: launch_git_config_env now reads the helper file (O_NOFOLLOW, regular files only) and names it only when it matches the helper for a sealed value this launch places. A stale helper that a failed removal left behind is ignored. The test covers this case.
  • 👍 valid — crates/minimald/src/box_runtime/launcher.rs: A GIT_CONFIG_COUNT that does not parse now adds no helper pairs and logs a warning, so the box's GIT_CONFIG_KEY_0/VALUE_0 are not replaced.

A grant box with no git configuration of its own gets the shipped helper as git's sole helper for the GitHub hosts, and the helper answers with the sealed value, which the proxy substitutes. The unit test shows this. A person still cannot see a live git clone and git push through the proxy on this branch. The e2e case records NOT RUN here, and it needs a sign-in and E2E_BEP_PRIVATE_REPO on the macOS lane of #2500.

Notes from the agent: Round 5, one commit (aa9a161). Item 1: the SC2016 hit on the helper-log read in proof_bep_git_credential_helper_sends_header now carries the '# shellcheck disable=SC2016' directive. The single quotes are deliberate, because $HOME must expand in the box. Item 2: the NOT RUN row and its reason stay, and the C1 threads stay open. Item 3: the review bot opened no lint thread, so there is nothing to reply on. The fix commit is aa9a161. The commitlint check fails on two earlier commits: 7de1cc4 (footer-leading-blank warning) and be96fe4 (a body line over 100 characters). The rules forbid a rewrite of commits already on the branch, so those stay. The new commit keeps its body lines under 100 characters. The removed DirFd::is_file had no other caller. I did not run just clippy-strict.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of aa9a161f71e4 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 25, 2026
@norrietaylor norrietaylor changed the title T50 — Ship a git credential helper in grant boxes so git sends a header the proxy substitutes feat(minimald): ship a git credential helper in grant boxes (T50) Oct 25, 2026
@norrietaylor
norrietaylor force-pushed the agent/2531-ship-a-git-credential-helper-in-grant-boxes-so-g branch from aa9a161 to 50caf46 Compare October 25, 2026 16:51

Copy link
Copy Markdown
Member

Reworded be96fe4a as 9cce209 under the epic owner's standing rule that a commit message failing commitlint is reworded and pushed rather than left to block the merge. Its body had two lines of 198 and 235 characters; they are now wrapped at 72 columns. The later commits on the branch were rewritten only to carry the new parent: the tree at the head is unchanged (46258d2d), main's commits are untouched, and every commit and the squash message the queue will build now pass commitlint. No code changed. The head moves from aa9a161f to 50caf460.


Generated by Claude Code

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

This head has the same tree as aa9a161f, so the earlier PASS_WITH_CONDITIONS stands. The shipped helper answers only for the GitHub module's hosts. It is git's sole helper for those hosts, as Gatehouse §6.4 line 718 requires. One condition stays open. The e2e leg bep_git_credential_helper_sends_header is NOT RUN on this lane. C1 keeps it open until the macOS lane records PASS on #2563.

Ruled at 50caf46 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-arch[bot] scripts/session-e2e.sh:11795. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Oct 25, 2026

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 50caf4605cf7 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 25, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter approval at 50caf46: every merge gate passes at this head (arch PASS at 50caf46, zero open threads, every lane aggregator green). Squash title feat(minimald): ship a git credential helper in grant boxes (T50) and the squashed message pass commitlint. Queued for squash merge.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 853a4f6 Oct 25, 2026
38 checks passed
@norrietaylor
norrietaylor deleted the agent/2531-ship-a-git-credential-helper-in-grant-boxes-so-g branch October 25, 2026 18:41
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Oct 31, 2026
…ring (gominimal#2765)

* test(e2e): give the BEP grant seeds a GitHub scope and proxy_env steering

Five live Box Egress Proxy cases declared `source = "broker"` with no
`github:` scope. SecretGrant::is_github needs that scope, so these boxes were
credentialed upstreams but not GitHub grants: nothing was minted, and with no
steering declared they resolved to `dns`, which has no box-zone resolver yet.
None of them could pass on a lane that runs them.

- bep_second_box_needs_no_sign_in, bep_box_env_holds_sealed_value_only:
  add the scope and proxy_env, and start the boxes own_ip with
  --credentialed-upstream as bep_first_slice_end_to_end does.
- bep_git_and_gh_against_private_repo, bep_git_credential_helper_sends_header:
  add the scope, and admit uploads.github.com, which a GitHub grant's egress
  must admit (BEP-008).
- bep_trust_box_files (the trust-store cases): add the scope and proxy_env.

Also corrects two comments that said no box ships a git credential helper;
gominimal#2547 shipped it.

* test(e2e): start the trust-store grant box with its own IP and a credentialed upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T50 — Ship a git credential helper in grant boxes so git sends a header the proxy substitutes

1 participant