Skip to content

feat(minimal): sign store handles under one host-keychain client key (T59) - #2557

Merged
norrietaylor merged 3 commits into
mainfrom
agent/2539-sign-store-handles-under-the-client-s-one-local
Oct 25, 2026
Merged

norrietaylor merged 3 commits into
mainfrom
agent/2539-sign-store-handles-under-the-client-s-one-local

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

T59 — Sign store handles under the client's one local key from a host-keychain ClientKeyStore

slice: S9
kind: task
covers: BEP-063
size: L
est: 260 code, 240 tests
executor: agent
difficulty: needs care
model: strongest
diagnostics: min box spec names the client key's identifier under the grant, and the proxy log records one registration per client, not one per box
observability: one info line at first use naming the registered key identifier
layers:
- key-store:
- crates/minimal/src/mint.rs: a host-keychain ClientKeyStore backend behind the existing key-store seam holds the client's one local signing key (macOS Keychain; the Linux host behind the same seam), and the Interim: notes and expect(dead_code) reasons that name #2524 go
- crates/minimal/src/cmd/boxes/create.rs: mint_grants reads local_client_key over that store and signs the store handle and the grant registrations with it, never ClientKey::generate() per box
- crates/bep/src/control.rs: the module doc stops naming #2524; the registry keeps one key per client
test: cargo nextest run -p minimal two_creations_register_one_client_key
test: cargo nextest run -p minimal a_refused_client_key_is_replaced_and_registered_before_the_mint
produces: none
consumes: none
proof: Two box creations register one client key with the proxy, and a key the proxy refuses is replaced and registered before the mint.
depends on:
- blocked by T27
- assumes OQ3

Proof

Two box creations now sign under the one key that the host keychain keeps. The proxy registers that key once, and its registrations file holds one line for the client. When the keychain refuses this program the kept key, creation makes a replacement, keeps it, and registers it with the proxy before the mint gives any sealed value.

Notes from the agent: Interpretation: the proof says 'a key the proxy refuses'. The spec and the existing seam describe a key that the keychain refuses this program, and the code now replaces that key. When the proxy itself refuses a key, creation still stops with the existing fixed message. The proxy refuses only a malformed key or a failed registrations-file write, and a new key does not fix either case. Store handles: mint_grants signs the grant registrations under the kept key. It does not mint store handles yet, because bep::seal::MemberKind has no store kind to carry a handle to the box (#2525). store_claims, StoreHandle and mint_store_handle keep an expect(dead_code) attribute, and its reason now names #2525, not #2524. Diagnostics: min box spec does not show the client key identifier under the grant. That surface is outside this task's layers (#2526). Observability: the client logs one info line with the kid when it makes a key, and logs each registration at debug level. The proxy logs a new key at info and a known key at debug. HostClientKeyStore uses /usr/bin/security on macOS and secret-tool on Linux. It has no automated test, because this box has no keychain. The macOS refusal exit codes (51, 101, 128) are the low bytes of the statuses that bep::keys treats as denied. Nothing tested them on a Mac. Runs: clippy -p bep -p minimal --all-targets is clean for these crates, and nextest -p minimal mint (14) and nextest -p bep control (6) pass. I did not run just ci or clippy-strict.

Tests

line exit tail
cargo nextest run -p minimal two_creations_register_one_client_key 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-4d5e... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal a_refused_client_key_is_replaced_and_registered_before_the_mint 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-7036... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-0f80...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking bep v0.0.1 (/workbench/crates/bep)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Layer exception

crates/minimal/src/tests.rs is outside T59's layers. The change adds two lines to the every_daemon_connection_is_classified inventory, classifying the two new test-only connections in mint.rs as ungated, and rewords the comment above them. The inventory test fails without them, and arch's ruling at b9a1c13 names them. Accepted under the epic owner's layer-exception rule.

Closes #2539


Generated by Claude Code

Box creation reads the client's signing key from the host keychain
(macOS login keychain through /usr/bin/security, the Secret Service
through secret-tool on Linux) and no longer generates a key per box.
A key the keychain refuses this program is replaced, kept, and
registered with the proxy before any sealed value leaves the mint.

The proxy logs a new client key at info and a known one at debug, so
its log holds one registration line for each client, not for each box.
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: caae3a36-7ab7-4464-b7d9-e3cd12a9b95c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviewed: 1 finding, none blocking at b9a1c13d1e64.

Address the comments on the diff.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 4 findings, 3 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/mint.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/mint.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to Gatehouse §6.10 line 842. Box creation now signs under one local key that the host keychain keeps. The client registers that key over the control socket before a sealed value leaves the process. A keychain refusal gives a replacement key, and the client registers it before the mint. Other store failures stop the creation. The store-handle caller (#2525) and the min box spec key identifier (#2526) stay open as residuals.

Ruled at d50ede2 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Take secret-tool from a fixed system directory, never through PATH,
because it sees the client signing key. Kill a keychain tool that runs
past 60 seconds, as one waiting on an unanswered unlock prompt does,
and reap the child when its stdin write fails.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This push conforms to the design, as the earlier head did. The keychain tool now has a deadline, and secret-tool comes only from system directories. A timeout or a missing tool stops box creation with MintError::KeyStore. It does not make a new key. Section 6.10 line 842 is still met: one kept local key signs the handles. Store-handle minting (#2525) and the kid in min box spec (#2526) stay open as filed residuals.

Ruled at a8bcf69 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/mint.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as a8bcf69edb86.

line exit tail
cargo nextest run -p minimal two_creations_register_one_client_key 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-3f4c... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal a_refused_client_key_is_replaced_and_registered_before_the_mint 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-35fe... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

.1 (/workbench/crates/args)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking rustls v0.23.46
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking wait-timeout v0.2.1
    Checking tokio-rustls v0.26.5
    Checking rustls-platform-verifier v0.7.0
    Checking hyper-rustls v0.27.9
    Checking tonic v0.14.6
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking quick-error v1.2.3
    Checking reqwest v0.13.5
    Checking bit-vec v0.10.1
    Checking tonic-prost v0.14.6
    Checking bit-set v0.11.1
    Checking google-cloud-auth v1.17.0
    Checking opentelemetry-http v0.33.1
    Checking rusty-fork v0.3.1
    Checking rand_xorshift v0.5.0
    Checking opentelemetry-otlp v0.33.0
    Checking core_detect v1.0.0
    Checking unarray v0.1.4
    Checking google-cloud-gax-internal v0.7.20
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking proptest v1.12.0
    Checking google-cloud-longrunning v1.14.0
    Checking google-cloud-iam-v1 v1.13.0
    Checking google-cloud-lro v1.11.0
    Checking google-cloud-storage v1.20.0
    Checking common v0.0.1 (/workbench/crates/common)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM6wA3Ql: secret-tool now resolves only from fixed system directories (/usr/bin, /bin, /run/current-system/sw/bin), never through PATH. When it is in none of them, the store fails and names the directories. (not posted on the thread: not an open thread on the pull request)
  • 👎 invalid — crates/minimal/src/cmd/boxes/create.rs:745: The task requires every creation to sign under the one kept key, and never to call ClientKey::generate() per box. The proxy keeps every registered key on disk for good. A per-process fallback would add one registration per box again, with no record of it, which is the behaviour this change removes.
  • 👍 valid — crates/minimal/src/mint.rs: run_key_tool now kills a tool after 60 seconds and returns a Store error that says the keychain can be locked or waiting on a prompt. A failed stdin write now kills and reaps the child. The pipes are read on threads, so a full pipe cannot stall the wait.

Two box creations sign under one kept client key, and the proxy holds one registration for it. A key the keychain refuses is replaced, kept and registered before the mint gives a sealed value. On Linux the keychain tool now comes from a system directory, and a tool that hangs on a prompt ends with an error after 60 seconds.

Notes from the agent: Revise round 1. Fixed two of the three findings in crates/minimal/src/mint.rs. secret-tool now comes from /usr/bin, /bin or /run/current-system/sw/bin, never through PATH. run_key_tool now kills a tool after 60 seconds, reads its pipes on threads, and reaps the child when the stdin write fails. The create.rs fallback finding was not changed, for the reason in its thread entry. The secret_tool test runs only off macOS. The macOS backend was not built or run on this Linux box.

On macOS, an item whose access list refuses this program can refuse
an in-place update as well. The replacement now deletes the old item
before it adds the new one. No item to delete is not an error.

Record the two new test connections of the mint tests in the daemon
connection inventory. They reach a test proxy control socket, not
the daemon.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This push changes only how the macOS keychain item is replaced. The old item is deleted first, and then the new item is added. Gatehouse §6.10 line 842 asks for one local key, registered before use. The change keeps that. A failed delete stops creation, so the flow still fails closed. The new tests.rs lines classify two test-only connections. The PASS on the earlier head stands.

Ruled at b9a1c13 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a failed check suite, pushed as b9a1c13d1e64.

line exit tail
cargo nextest run -p minimal two_creations_register_one_client_key 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-4211... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling stdlib v0.0.22 (/workbenc
cargo nextest run -p minimal a_refused_client_key_is_replaced_and_registered_before_the_mint 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-61b1... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

.1 (/workbench/crates/args)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking rustls v0.23.46
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking tokio-rustls v0.26.5
    Checking rustls-platform-verifier v0.7.0
    Checking hyper-rustls v0.27.9
    Checking tonic v0.14.6
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking wait-timeout v0.2.1
    Checking reqwest v0.13.5
    Checking tonic-prost v0.14.6
    Checking quick-error v1.2.3
    Checking bit-vec v0.10.1
    Checking rand_xorshift v0.5.0
    Checking rusty-fork v0.3.1
    Checking google-cloud-auth v1.17.0
    Checking opentelemetry-http v0.33.1
    Checking bit-set v0.11.1
    Checking unarray v0.1.4
    Checking core_detect v1.0.0
    Checking opentelemetry-otlp v0.33.0
    Checking proptest v1.12.0
    Checking google-cloud-gax-internal v0.7.20
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking google-cloud-longrunning v1.14.0
    Checking google-cloud-lro v1.11.0
    Checking google-cloud-iam-v1 v1.13.0
    Checking google-cloud-storage v1.20.0
    Checking common v0.0.1 (/workbench/crates/common)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking check v0.0.1 (/workbench/crates/check)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Outside the task's layers::

  • crates/minimal/src/tests.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👎 invalid — crates/minimal/src/cmd/boxes/create.rs:745: A grant box already needs the host keychain: mint_and_register reads the GitHub sign-in through bep::signin::HostKeychain, which on Linux is the same secret-tool and Secret Service. A host with no keychain has no sign-in, and store grants read their values from that keychain. So before this change,
  • 👍 valid — PRRT_kwDOPdfcxM6wA841: host_key::store on macOS now runs security delete-generic-password first (not-found is no error), then adds the item without -U. A refused item is then not updated in place. (not posted on the thread: not an open thread on the pull request)

Two box creations register one client key with the proxy, and a key the proxy refuses is replaced and registered before the mint. Both test lines pass, and the crate's connection inventory test passes again.

Notes from the agent: The CI tests failure was minimal tests::every_daemon_connection_is_classified. The mint.rs tests from the earlier round add two proxy control-socket connections (create and a_refused_client_key_is_replaced_and_registered_before_the_mint). I recorded them in the inventory in crates/minimal/src/tests.rs. That file is outside the layers. It is the test that records each connection site, so the new sites must be listed there. ci-linux-native-success is the lane aggregator and failed only because tests failed. The macOS delete-before-add change in host_key::store compiles only on macOS. This Linux box did not compile or run it, so just ci on macOS or the macOS lane must prove it. I did not run a full minimal suite again after the fix. I ran only the test that failed.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 25, 2026 12:00
@norrietaylor
norrietaylor marked this pull request as ready for review October 25, 2026 13:40
@norrietaylor norrietaylor changed the title T59 — Sign store handles under the client's one local key from a host-keychain ClientKeyStore feat(minimal): sign store handles under one host-keychain client key (T59) Oct 25, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter approval at b9a1c13: every merge gate passes at this head (arch PASS at b9a1c13, zero open threads, every lane aggregator green including ci-macos-success). The out-of-layer inventory lines in crates/minimal/src/tests.rs are accepted under the epic owner's layer-exception rule. Squash title feat(minimal): sign store handles under one host-keychain client key (T59) and the squashed message pass commitlint. Queued for squash merge.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 4180736 Oct 25, 2026
37 checks passed
@norrietaylor
norrietaylor deleted the agent/2539-sign-store-handles-under-the-client-s-one-local branch October 25, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T59 — Sign store handles under the client's one local key from a host-keychain ClientKeyStore

1 participant