Skip to content

feat(minimald): steer the credentialed names of dns and both boxes through the gate (T58) - #2567

Merged
norrietaylor merged 8 commits into
mainfrom
agent/2538-steer-a-dns-or-both-box-s-credentialed-names-thr
Oct 26, 2026
Merged

norrietaylor merged 8 commits into
mainfrom
agent/2538-steer-a-dns-or-both-box-s-credentialed-names-thr

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

T58 — Steer a dns or both box's credentialed names through the relay's gate in production

slice: S9
kind: task
covers: BEP-062, BEP-078
size: L
est: 260 code, 300 tests
executor: agent
difficulty: needs care
model: standard
diagnostics: with the proxy stopped, a dns-steered box resolving github.com gets SERVFAIL, and the daemon log names the box and the name once per minute
observability: one info line when the proxy's listener is reported live and the steered names resolve to it again
layers:
- host:
- crates/minimald-rpc/src/lib.rs: a BoxControlRequest::ProxyListening ask and its BoxControlReply::ProxyListening { listening } answer, admitted on the guest reports door beside RowStanding (re-planned 2026-10-25 by the epic owner: the listener state lives in minvmd on the host and the guest relay cannot link bep_host, so it asks over the report door)
- crates/minvmd/src/control.rs: the guest reports door answers ProxyListening from the proxy's listening flag, and answers false when no proxy runs
- crates/minvmd/src/cmd/run.rs: hands BepProxy::listening to the control server so the guest door can read it
test: cargo nextest run -p minvmd guest_door_answers_proxy_listening
- relay:
- crates/minimald/src/net/listeners.rs: proxy_listening asks over the report door the way host_row_standing does; None (a native host, which runs no proxy, or a door that does not answer within its deadline) reads as not live, so steered names fail closed with SERVFAIL
- crates/minimald/src/net/dns.rs: ProxyListenerState refreshes from proxy_listening with a short cached answer; the allow(dead_code) interim goes
- crates/minimald/src/net/dns_gate.rs: the allow(dead_code) interims on with_steering go, and the comment stops naming #2523
- crates/minimald/src/net/switch.rs: BoxGate::for_session calls DnsGate::with_steering(policy, <credential module hosts>, <proxy address on the switch>, <shared ProxyListenerState>) for every box whose steering resolves to dns or both
- crates/minimald/src/net/gvproxy_network.rs: passes the shared ProxyListenerState and the control channel it asks over into BoxGate::for_session
- scripts/session-e2e.sh: in bep_dns_steering_fails_closed_end_to_end, leg 1's known_gap for the steered A lookup becomes an ::error:: line and ds_fail, and ds_a_gap with its known-gap branch goes, so the leg is a hard assertion of Networking §5.3 line 147 once steering is wired (arch C1 on #2550, widened 2026-10-25)
test: cargo nextest run -p minimald a_dns_steered_box_gets_servfail_while_the_proxy_is_down
test: cargo nextest run -p minimald a_steered_name_resolves_to_the_proxy_once_its_listener_is_live
test: cargo nextest run -p minimald a_native_host_steered_name_gets_servfail
produces: none
consumes: none
proof: In a running daemon with the proxy stopped, a dns-steered box resolving github.com gets SERVFAIL and never a real address; once the listener is live the same lookup gets the proxy's address; on a native host, which runs no proxy, a steered name always gets SERVFAIL.
depends on:
- blocked by T30

Proof

A daemon now builds every dns or both box's DNS gate with the GitHub module's names steered to the proxy. The switch shares one listener state, which asks minvmd over the guest report door whether the proxy listens and caches the answer for 2 s. With the proxy stopped, a lookup of github.com from such a box gets SERVFAIL and never a real address, and the daemon log names the box and the name once per minute. When minvmd reports the listener live, the same lookup gets the proxy's switch address, and one info line says so. On a native host there is no door to ask, so a steered name always gets SERVFAIL. The unit tests show this through BoxGate and a stand-in door. The VM e2e leg in session-e2e.sh is now a hard assertion, but I did not run it here.

Notes from the agent: Files touched outside the layers: (1) crates/minimald/src/rpc.rs and crates/minimal-client/src/box_registration.rs. They match BoxControlRequest and BoxControlReply exhaustively, so the new ProxyListening variants needed one arm in each. The native control socket refuses the verb, and registration bails on the reply. (2) crates/minimald/Cargo.toml and Cargo.lock. minimald now depends on bep (path dependency) for bep::module::GITHUB, which is the credential module host set that with_steering takes. The other option was to copy the list into minimald, and a copy can drift. Design choices: BoxGate::for_session keeps its signature, because many test call sites in box_actor, box_runtime and proxy.rs use it. It delegates to a new BoxGate::for_session_steered with ProxyListenerState::down(), so a gate built without a switch state fails steered names closed. gvproxy_network calls for_session_steered with ProxyListenerState::for_switch(&control): one state per control channel, held in a process-wide map. ProxyListenerState::is_live never blocks. A read that finds the answer older than PROXY_LISTENER_CACHE (2 s) spawns one ask, with at most one ask in flight. So after the proxy stops, up to about 2 s…[truncated]

Tests

line exit tail
cargo nextest run -p minvmd guest_door_answers_proxy_listening 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-96b0... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling version v0.8.0 (/workbenc
cargo nextest run -p minimald a_dns_steered_box_gets_servfail_while_the_proxy_is_down 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-9a77... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workb
cargo nextest run -p minimald a_steered_name_resolves_to_the_proxy_once_its_listener_is_live 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-9589... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimald a_native_host_steered_name_gets_servfail 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-24f9... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-1104...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling nix v0.31.3
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking russh-cryptovec v0.62.0
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking tun-rs v2.8.8
    Checking russh v0.64.1
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking hakoniwa v1.7.2 (https://github.com/souk4711/hakoniwa.git?rev=0810ffa37620ef5c57de263c8eaa1f4d7633c14a#0810ffa3)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking vsock v0.5.4
    Checking tokio-vsock v0.7.2
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Layer exception

The epic owner's rule accepts out-of-layer changes a task needs. The babysitter accepted these on 2026-10-25:

  • crates/minimald/src/rpc.rs and crates/minimal-client/src/box_registration.rs: both match BoxControlRequest and BoxControlReply exhaustively, so the new ProxyListening variants need one arm in each.
  • crates/minimald/Cargo.toml and Cargo.lock: minimald now depends on bep for bep::module::GITHUB, the host set the DNS gate steers, so the list is not copied. The arch review rules on the new dependency.

Residuals

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimal-client/src/box_registration.rs
  • crates/minimald/Cargo.toml
  • crates/minimald/src/rpc.rs

Closes #2538


Generated by Claude Code

The in-VM daemon cannot see the Box Egress Proxy, which runs on the
host. Add a ProxyListening verb to the box control wire, served on the
guest report door from the proxy's own listening flag, and false when
the boot runs no proxy. The DNS gate of a dns or both box reads it
before it answers a steered name (BEP-062).

minimald's native control socket and minimal-client's registration
reply match the new variants so the workspace still compiles.
…roxy

BoxGate now builds every box's DNS gate with the GitHub module's names
steered to the Box Egress Proxy's switch address when the box's
steering resolves to dns or both. The switch shares one listener
state, which asks the VM host daemon over the report door whether the
proxy listens and caches the answer for two seconds. A native host has
no one to ask, so its steered names always get SERVFAIL (BEP-062).

minimald now depends on bep for the module host set, so Cargo.toml and
Cargo.lock change.
The relay's DNS gate now steers dns and both boxes' credentialed names,
so leg 1 of bep_dns_steering_fails_closed_end_to_end is a hard
assertion: a lookup that is not SERVFAIL while the proxy is down fails
the case. The known-gap branch goes.
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b7fbebf-6a36-4fb2-add1-d5bafb6e3dab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at c8aec36cb950.

@norrietaylor resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/net/dns.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change wires the DNS steering into production and it fails closed on every path that cannot decide. That conforms to Networking §5.3 lines 147 and 151. The guest-door read and the bep dependency follow the design's owners. The steered set is the GitHub module only. Section 5.3 line 151 steers every declared credentialed hostname, and store-rule authorities are credentialed hostnames too. Admission refuses dns steering for those boxes today, so the gap is not yet reachable. Do C1: file the issue and link it from credential_module_hosts.

Ruled at fda7934 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread crates/minimald/src/net/switch.rs Resolved
A drop guard clears asking however the ask ends, and an ask that ends
without an answer records the proxy listener as down.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change since the last ruling is one commit. It adds a drop guard to the proxy-listener ask in dns.rs. A cancelled ask now records the listener down and lets a later read ask again. Section 5.3 line 147 requires this fail-closed behaviour. The baseline ruling on fda7934 stands. C1 stays open as the filed residual #2575, and the change can merge with it open.

Ruled at 70b1245 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread crates/minimald/src/net/switch.rs Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/net/dns.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as 70b1245638fd.

line exit tail
cargo nextest run -p minvmd guest_door_answers_proxy_listening 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-06e4... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling version v0.8.0 (/workbenc
cargo nextest run -p minimald a_dns_steered_box_gets_servfail_while_the_proxy_is_down 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-497b... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workb
cargo nextest run -p minimald a_steered_name_resolves_to_the_proxy_once_its_listener_is_live 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-c18c... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimald a_native_host_steered_name_gets_servfail 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-14fe... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.97.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.98.1), the repository pins 1.97.0 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
Applying loadouts: default
Running task runtime-implement-verify in session task-runtime-implement-verify-c803...
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking paths v0.0.1 (/workbench/crates/paths)
   Compiling nix v0.31.3
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking hash32 v0.3.1
    Checking heapless v0.9.3
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking bitflags v1.3.2
    Checking managed v0.8.0
    Checking smoltcp v0.14.0
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking russh-cryptovec v0.62.0
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking russh v0.64.1
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking tun-rs v2.8.8
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking vsock v0.5.4
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking hakoniwa v1.7.2 (https://github.com/souk4711/hakoniwa.git?rev=0810ffa37620ef5c57de263c8eaa1f4d7633c14a#0810ffa3)
    Checking tokio-vsock v0.7.2
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
error: using `chunks_exact` with a constant chunk size
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    |
help: consider using `as_chunks::<2>()` instead
   --> crates/minimald-rpc/src/trace.rs:199:46
    |
199 |     for (byte, pair) in out.iter_mut().zip(s.chunks_exact(2)) {
    |                                              ^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#chunks_exact_to_as_chunks
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`

error: could not compile `minimald-rpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `minimald-rpc` (lib test) due to 1 previous error

Outside the task's layers::

  • crates/minimal-client/src/box_registration.rs
  • crates/minimald/Cargo.toml
  • crates/minimald/src/rpc.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM6wDhY3: refresh now holds a drop guard that clears asking on any exit, and records down when the ask ends without an answer; a_dropped_listener_ask_clears_asking_and_reads_down pins it. (not posted on the thread: not an open thread on the pull request)

In a running daemon with the proxy stopped, a dns-steered box that resolves github.com gets SERVFAIL and never a real address. When the listener is live, the same lookup gets the proxy's address. On a native host, which runs no proxy, a steered name always gets SERVFAIL. This round also makes sure that an ask about the listener that is dropped or panics cannot freeze the last answer: the state reads down and the next read asks again.

Notes from the agent: Revise round 1. One finding, judged valid. ProxyListenerState::refresh now holds a drop guard (AskGuard) that clears asking however the ask ends. An ask that ends without an answer also records the listener as down, so steered names fail closed. The new unit test a_dropped_listener_ask_clears_asking_and_reads_down is in dns.rs, a file the layers name. cargo clippy -p minimald --all-targets shows no warning in dns.rs. Its remaining warnings are in files this round did not change.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 25, 2026 18:14
@norrietaylor
norrietaylor marked this pull request as ready for review October 25, 2026 18:28
@norrietaylor norrietaylor changed the title T58 — Steer a dns or both box's credentialed names through the relay's gate in production feat(minimald): steer the credentialed names of dns and both boxes through the gate (T58) Oct 25, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter approval at 70b1245: every merge gate passes at this head (arch PASS at 70b1245, zero open threads, every lane aggregator green). Squash title feat(minimald): steer the credentialed names of dns and both boxes through the gate (T58) and the squashed message pass commitlint. Queued for squash merge.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 25, 2026

Copy link
Copy Markdown
Member

/revise

Round 2 of #2567. The merge queue removed it at 23:04, because CI on the queue branch failed. No round is in flight. Every Rust job stopped at the manifest:

error: duplicate key
  --> crates/minimald/Cargo.toml:91:1
91 | bep = { path = "../bep" }

#2547 (T50) landed on main with its own bep dependency in crates/minimald/Cargo.toml (the git credential helper reads bep::module::GITHUB). This PR adds a second bep = { path = "../bep" } line. Git merges the two lines without a conflict, but Cargo refuses the duplicate key.

  1. Merge origin/main into this branch.
  2. In crates/minimald/Cargo.toml, keep exactly one bep dependency: the line already on main. Fold this PR's comment (the DNS gate's steered host set, BEP-062) into the existing comment above that line, so both uses are named. Remove this PR's duplicate line. Cargo.lock must not change for this.
  3. Run cargo metadata --format-version 1 --locked >/dev/null, cargo clippy -p minimald --all-targets --locked -- -D warnings and the task's tests, and report them.

Change nothing else. One commit for the manifest fix (the merge commit is separate), Conventional Commits subject, every body line at most 72 characters.


Generated by Claude Code

main's T50 added its own bep line, and this branch added a second one.
Cargo refuses the duplicate key. Keep main's line and name both uses
in its comment: the git credential helper and the DNS gate's steered
host set (BEP-062). Cargo.lock does not change.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

This push merges main and keeps main's bep dependency line in crates/minimald/Cargo.toml. The PR's code is the same as at 70b12456, so the earlier ruling stands. Steered names fail closed while the proxy is down, as Networking §5.3 line 147 requires. C1 stays open as the filed residual #2575. The steered set must also hold the store-rule authorities once the BEP-017 refusal lifts.

Ruled at c8aec36 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread crates/minimald/src/net/switch.rs Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-arch[bot] crates/minimald/src/net/switch.rs:1461. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as c8aec36cb950.

line exit tail
cargo nextest run -p minvmd guest_door_answers_proxy_listening 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-047b... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling version v0.8.0 (/workbenc
cargo nextest run -p minimald a_dns_steered_box_gets_servfail_while_the_proxy_is_down 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-d8fb... Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workb
cargo nextest run -p minimald a_steered_name_resolves_to_the_proxy_once_its_listener_is_live 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-10c7... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimald a_native_host_steered_name_gets_servfail 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-e2c4... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.99.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

re/compose.rs:402:8
    |
402 | pub fn deferring_env() -> StoredEnv {
    |        ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
    |
402 + #[must_use]
403 | pub fn deferring_env() -> StoredEnv {
    |

error: this method could have a `#[must_use]` attribute
    --> crates/boxes/src/core/compose.rs:1019:12
     |
1019 |     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
     |
1019 ~     #[must_use]
1020 ~     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1085:5
     |
1085 |     pub fn as_sandbox_path(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1084:5
     |
1084 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use
     = note: `-D clippy::double-must-use` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_must_use)]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1302:5
     |
1302 |     pub fn host_path(&self) -> &HostAbsPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1301:5
     |
1301 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1309:5
     |
1309 |     pub fn destination(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1308:5
     |
1308 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: could not compile `boxes` (lib) due to 6 previous errors

Outside the task's layers::

  • crates/minimal-client/src/box_registration.rs
  • crates/minimald/Cargo.toml
  • crates/minimald/src/rpc.rs

Converted to a draft: something above needs a person before review.

In a running daemon with the proxy stopped, a dns-steered box that resolves github.com gets SERVFAIL and never a real address. Once the listener is live, the same lookup gets the proxy's address. On a native host, which runs no proxy, a steered name always gets SERVFAIL. This round, the branch manifest parses again: crates/minimald/Cargo.toml has one bep dependency, so the Rust jobs get past the manifest.

Notes from the agent: Step 1: origin/main was already merged at the branch head (dabc165). git log HEAD..origin/main was empty after a fetch, so no new merge commit was needed. Step 2: one commit (c8aec36) removes this PR's duplicate bep line and folds its BEP-062 comment into a new comment above main's line. That comment names both uses. Cargo.lock did not change. Step 3: clippy with -D warnings fails only in crates/boxes (compose.rs 390, 402, 1019 and primitives.rs 1085, 1302, 1309: must_use lints). This branch does not change crates/boxes. This box runs rustc/clippy 1.98.1, but rust-toolchain.toml pins 1.99.0, so the lint set can differ from CI. Without -D warnings, clippy exits 0 and reports no warning in minimald. I changed nothing else.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 25, 2026 23:41
@norrietaylor
norrietaylor marked this pull request as ready for review October 26, 2026 01:23

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of c8aec36cb950 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 26, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter approval at c8aec36: every merge gate passes at this head (arch PASS at c8aec36, zero open threads, every lane aggregator green). Squash title feat(minimald): steer the credentialed names of dns and both boxes through the gate (T58) and the squashed message pass commitlint. Queued for squash merge.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 3061ef1 Oct 26, 2026
37 checks passed
@norrietaylor
norrietaylor deleted the agent/2538-steer-a-dns-or-both-box-s-credentialed-names-thr branch October 26, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T58 — Steer a dns or both box's credentialed names through the relay's gate in production

1 participant