Skip to content

build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385 - #2503

Merged
bryan-minimal merged 2 commits into
mainfrom
deps/ctutils-rustsec-2026-0385
Oct 23, 2026
Merged

bryan-minimal merged 2 commits into
mainfrom
deps/ctutils-rustsec-2026-0385

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

RUSTSEC-2026-0385 (ctutils 0.4.2: non-constant-time mask generation and u128 comparisons) was published this morning and fails cargo-deny on every pull request's CI, so nothing merges until the lock moves. ctutils is transitive here, through p256 → ecdsa → elliptic-curve → crypto-bigint.

One lock line: ctutils 0.4.2 → 0.4.5 (patched in 0.4.4). On the box, cargo deny check advisories is clean again and the workspace checks --locked.

🤖 Generated with Claude Code

A new advisory on ctutils 0.4.2 (non-constant-time mask generation and
u128 comparisons; a transitive dependency through p256, ecdsa,
elliptic-curve and crypto-bigint) fails cargo-deny on every pull request
since this morning, so nothing can merge until the lock moves. Patched in
0.4.4; the lock takes 0.4.5. cargo deny check advisories is clean again
and the workspace checks --locked.
@bryan-minimal
bryan-minimal requested a review from a team as a code owner October 23, 2026 16:10
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at b03ee91e1d4f.

Nothing to do.

Clobber: none.

norrietaylor added a commit that referenced this pull request Oct 23, 2026
Port of #2503 so cargo-deny's advisories check passes on this branch.
The same Cargo.lock change; it becomes a no-op once #2503 lands on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 23, 2026

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit c9114e1 Oct 23, 2026
36 checks passed
@bryan-minimal
bryan-minimal deleted the deps/ctutils-rustsec-2026-0385 branch October 23, 2026 18:36
norrietaylor added a commit that referenced this pull request Oct 24, 2026
Port of #2503 so cargo-deny's advisories check passes on this branch.
The same Cargo.lock change; it becomes a no-op once #2503 lands on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc
norrietaylor added a commit that referenced this pull request Oct 24, 2026
…0387 and -0385

Port of #2517 and #2503 so cargo-deny's advisories check passes on this
branch. The same Cargo.lock changes; they become no-ops once both are on
main.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc
norrietaylor added a commit that referenced this pull request Oct 24, 2026
…0387 and -0385

Port of #2517 and #2503 so cargo-deny's advisories check passes on this
branch. The same Cargo.lock changes; they become no-ops once both are on
main.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Oct 26, 2026
…ominimal#2504)

* feat(minimal): collect the proxy log and audit segments in min bug

The support bundle now carries providers/<name>/bep.log, beside the VM
host daemon's run.log, and the newest segments of the Box Egress
Proxy's audit log under bep/audit/.

* feat(minvmd): start bep serve beside gvproxy with the per-boot token

A production macOS boot now starts the Box Egress Proxy on the socket
the switch peer dials. The token goes to its standard input, its output
to bep.log beside the socket, and the pool binds the boxes' shares once
the proxy is started. The stand-in stays behind MINVMD_BEP_STUB.

* build(just): build and sign bep beside minvmd on macOS

minvmd starts bep serve from its own directory, so minvmd-build now
builds bep there and signs it before minvmd's own codesign.

* test(e2e): run the BEP grant legs against the live proxy

Adds bep_git_and_gh_against_private_repo. The T14 and T16 grant legs
now share one gate: off macOS, without gvproxy or without a sign-in
they record NOT RUN. On macOS the proxy that minvmd starts must answer
on its control socket, or the case fails with the proxy's log.

* fix(minvmd): bind proxy shares only while bep listens, for lane rows

The pool now reads a listening flag the watcher keeps: set while bep
runs and its listener socket is new, cleared when it exits. Shares go
only to rows that declare a credentialed upstream, the same rows the
gate's proxy_lane_admits lets reach the proxy address. The comments name
that gate and say the installer does not ship bep yet.

* test(e2e): record the missing git credential helper in the BEP case

git sends no Authorization header without a credential helper, and no
box ships one yet. The comment names the gap so the clone step's failure
on a live lane is not read as a proxy fault.

* test(minvmd): pin which rows CredentialedBoxes gives a share

A row with no credentialed upstream gets no share while bep listens, a
declaring row gets its share, and no row gets one while bep does not
listen. The BEP_BIN_ENV and BepProxy docs now name gominimal#2498 and gominimal#2285 (T38).

* docs(e2e): name the issues that own the BEP-015 residuals

The private-repo case names gominimal#2499 (git credential helper) and gominimal#2500
(macOS lane with bep, a sign-in and E2E_BEP_PRIVATE_REPO). switch's
bep_host comments name the T45 gate, egress::proxy_lane_admits (gominimal#1885).

* docs(switch): say which box source a boot wires for the proxy

A boot with no listening acceptor wires NoBoxes. A boot whose bep serve
listens wires CredentialedBoxes, which shares only the rows that declare
a credentialed upstream.

* fix(minvmd): stop the proxy when its watcher cannot own it

When the watcher thread cannot start, kill and reap bep serve before
the error returns. When try_wait fails, the watcher stops the child
before it ends, because the handle's drop reaches the child only
through the watcher.

* fix(minvmd): stop bep serve when the supervisor dies without unwinding

Arm PR_SET_PDEATHSIG(SIGTERM) in the proxy child on Linux, so a
SIGKILL'd or crashed supervisor leaves no proxy holding the old boot
token and its socket. macOS has no parent-death signal; gominimal#2501 owns it.

* fix(minvmd): move a full proxy log aside when the proxy starts

bep.log is appended across boots and nothing capped it, so a long-lived
host could fill its state dir. A start now moves a log past 8 MiB to
bep.log.old. The support bundle legend says so.

* test(minimal): inject the audit dir so the bundle test stays hermetic

* fix(minvmd): stop or reap a bep serve left behind by a minvmd crash

When minvmd died without unwinding (SIGKILL, a crash), nothing stopped
the `bep serve` it started on macOS: the proxy ran on with the dead
boot's token and held its listener socket, and `just reap` did not
match it.

minvmd now starts the proxy with `--exit-on-stdin-close` and keeps the
write end of the token pipe open after the token, inside the child
the watcher owns. `bep serve` with that flag reads its standard input
to the end on a thread of its own (`bep::supervisor`) and stops serving
when it closes. Linux keeps PR_SET_PDEATHSIG as it was; the pipe backs
it up there.

Why a pipe at end of file over polling getppid() for reparenting:
- The kernel closes a dead process's descriptors whatever killed it,
  so end of file arrives at once, with no polling interval to tune and
  no window in which the proxy serves a dead boot.
- It tracks the supervisor process itself. getppid() answers whether
  the parent pid changed, which a reparent to a subreaper or launchd
  shows only after the fact, and never if the proxy was started
  through an intermediate process.
- It needs no platform code, so the same mechanism runs on macOS and
  Linux, and its tests run on Linux: a SIGKILL'd child holding the only
  write end proves the end of file this design depends on.
The flag keeps it opt-in, so a person who pipes the token in by hand
still gets a proxy that outlives the pipe.

scripts/reap-vms.sh gains a pattern for this checkout's `bep serve`,
pinned to the ERE-quoted checkout root and to the VM's
`gvproxy-bep.sock` (in the per-name directory under `--vm`), sent with
`pkill -9`, user-side and through `sudo -n` like the others. AGENTS.md's
leaked-VMM footgun names the proxy too.

Closes gominimal#2501

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* build(deps): crypto-bigint 0.7.7 and ctutils 0.4.5, for RUSTSEC-2026-0387 and -0385

Port of gominimal#2517 and gominimal#2503 so cargo-deny's advisories check passes on this
branch. The same Cargo.lock changes; they become no-ops once both are on
main.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(scripts): reap only a VM's own bep serve in the bare reap

The bare proxy pattern matched this checkout's `bep serve` on any
listener named gvproxy-bep.sock, so `just reap` also SIGKILLed one
started by hand on another path. It now requires the listener under a
VM's `local-minvmd<N>/` directory, directly or one name below, as the
comment above it already says. reap_scoped_per_checkout gains the case
of a listener outside every VM's directory.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

---------

Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
mitodrummer pushed a commit that referenced this pull request Oct 26, 2026
* build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385

A new advisory on ctutils 0.4.2 (non-constant-time mask generation and
u128 comparisons; a transitive dependency through p256, ecdsa,
elliptic-curve and crypto-bigint) fails cargo-deny on every pull request
since this morning, so nothing can merge until the lock moves. Patched in
0.4.4; the lock takes 0.4.5. cargo deny check advisories is clean again
and the workspace checks --locked.

* chore(ci): re-run the cla status

(cherry picked from commit c9114e1)
mitodrummer added a commit that referenced this pull request Oct 26, 2026
…-bigint, tokio) (#2630)

* build(deps): zstd 0.14.3, zstd-safe 8.2.0, zstd-sys 2.1.2, for RUSTSEC-2026-0391, -0398 and -0403 (#2627)

Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 468a859)

* build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385 (#2503)

* build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385

A new advisory on ctutils 0.4.2 (non-constant-time mask generation and
u128 comparisons; a transitive dependency through p256, ecdsa,
elliptic-curve and crypto-bigint) fails cargo-deny on every pull request
since this morning, so nothing can merge until the lock moves. Patched in
0.4.4; the lock takes 0.4.5. cargo deny check advisories is clean again
and the workspace checks --locked.

* chore(ci): re-run the cla status

(cherry picked from commit c9114e1)

* build(deps): crypto-bigint 0.7.7, for RUSTSEC-2026-0387 (#2517)

(cherry picked from commit 20e25e4)

* build(deps): tokio 1.53.3, for RUSTSEC-2026-0386

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

* fix(minimald): build AsyncFd with tokio's unsafe register

tokio 1.53.3 deprecates AsyncFd::new as unsound (tokio-rs/tokio#8587),
and clippy's -D warnings fails the build on it. Port main's fix from
#2326 to both call sites, the PTY master and the tap device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

* chore(release): bump version to 0.7.2

Hotfix release carrying the zstd, ctutils, crypto-bigint and tokio bumps
(RUSTSEC-2026-0385, -0386, -0387, -0391, -0398, -0403) onto 0.7.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bryan-minimal <bryan@minimal.dev>
Co-authored-by: Norrie Taylor <91171431+norrietaylor@users.noreply.github.com>
norrietaylor added a commit that referenced this pull request Nov 12, 2026
…flow (#2339)

* feat(metrics): snapshot pipeline with clippy, coverage, size, modules, shear and layer gates

The first slice of spec 30. `just metrics` runs the collectors and writes a
schema-v1 snapshot: whole-tree counts of every strict lint and the three
complexity lints, line coverage through nextest under a coverage profile,
tokei size per crate, module cycles and orphans per crate, unused
dependencies, the crate-layer check over cargo metadata, and hotspots
ranked by churn times findings. Gates come from metrics/thresholds.toml;
the verdict is the worst gate. A collector that cannot run is recorded as
not measured and the run exits non-zero, never clean.

`just metrics-layers` is the no-compile layer check and joins `just ci`.
metrics/layers.toml carries the layer table derived from
docs/architecture.md and the edges the tree still carries as dated
exceptions. architecture.md §3 gains minzoned in the session plane and a
pointer to the enforced table.

scripts/metrics_test.sh is the fixture harness the spec's verify lines
name; crates/common/tests/shell_harnesses.rs picks it up. lint-shell.sh now
recurses so scripts/metrics/ is shellchecked.

Measured here with the sandbox's rustc 1.98 (the tree pins 1.97): the
strict pass completes with exit 0 and five diagnostics outside the strict
set, all from lints newer than the pin. CI measures with the pin.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(metrics): module cycles from the DOT graph, orphans per target, profiler check

The first full run over the tree showed three collector faults. cargo-modules
runs its --acyclic check before its filters, so every type owning a method
that uses the type read as a cycle; the module graph is now dumped as DOT per
target and the collector finds the strongly connected components itself,
leaving out edges through the crate root and test modules, which are
structure. Orphans were the union over a crate's targets, so every
binary-only module read as an orphan of the library; they are now the
intersection. And a toolchain built without the profiler runtime cannot
compile under -C instrument-coverage; the run says so before paying for a
cold instrumented build.

modules.cycles moves from a zero ceiling to a down ratchet: the tree carries
sibling-module cycles today, the largest in sessions and minimald.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* feat(metrics): static SVG dashboard and history pruning

Third change of the quality-metrics work (spec 30): the history side of
the snapshot pipeline.

scripts/metrics/dashboard.py renders a snapshot history into one
self-contained index.html (QM-016): inline SVG, a style block, no script,
nothing fetched, light and dark via prefers-color-scheme. It charts
coverage, strict and complexity lint totals, unused dependencies, code
size and layer edges over snapshot date, with a heading and a table of
the drawn values under every chart; from the newest snapshot it lists the
gates, the top hotspots and the promotable strict lints. A metric a
snapshot did not measure is a gap in the line, not a zero. Files that
fail schema.py are skipped and named on the page. The page carries no
timestamp, so the same history renders the same bytes.

scripts/metrics/prune.py keeps every snapshot within ninety days of the
newest and the earliest of each month beyond that, decided from the file
names alone (QM-015); keep() is a pure function the harness checks the
spec's property against. --dry-run lists without deleting.

The justfile gains metrics-dashboard and metrics-prune over a
.scratch/metrics/history checkout of the metrics-data branch. A synthetic
fixture history under scripts/metrics/testdata/history, one snapshot with
coverage null, backs the new harness cases prune_keeps_daily_then_monthly
and dashboard_renders_offline_with_tables. metrics/README.md documents the
dashboard and the retention rule.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* feat(metrics): experimental rustqual and cargo-anatomy sections

Full mode gains an `experimental` step (skipped by `--no-experimental` and
in static mode) that runs rustqual per in-scope crate over its `src/`,
leaving remote-proto out because its code is generated into OUT_DIR, and
cargo-anatomy once over the workspace. collect.py records them under
`crates.<name>.experimental.{rustqual,anatomy}` and
`workspace.experimental`; the whole block is null only when neither tool
ran. Nothing in `metric()` or `evaluate_gates` reads the block, and the
harness asserts that from the source as well as from the verdict (QM-005).
A missing tool is a not_measured entry, a tool failing on one crate is an
`error` in that crate's block, and neither fails the run.

install-tools.sh gets an `experimental_pins` array installed only with
`--experimental`; `--check` lists those pins as optional. The schema
requires the `rustqual` and `anatomy` keys when the block is present.

Both collectors are fixture-verified only: neither rustqual nor
cargo-anatomy installs in this sandbox (crates.io downloads are blocked
and there are no prebuilt binaries), so the fixtures follow the tools'
published docs, every lookup is a `.get`, and testdata/SHAPES.md records
which shapes are unverified against a run. The run.sh branch was
exercised end to end with shims standing in for the two binaries.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* feat(metrics): cargo-mutants in-diff and weekday shards, cargo-crap

Coverage says a line ran, not that a test would notice it being wrong.
Two collectors fill the `mutants` and `crap` blocks the snapshot schema
already reserved (spec 30, QM-017).

`run.sh mutants [BASE]` diffs the working tree against the merge-base
with BASE (origin/main by default), the way clippy-strict.sh does, and
hands the hunks to `cargo mutants --in-diff` under nextest; the scope is
recorded as `in-diff`. An untracked `*.rs` file is not in that diff, so
it is listed under `untracked_outside_scope` rather than silently left
out. `full` tests one of seven workspace shards chosen by the weekday
and records the shard; `--no-mutants` skips it. The baseline suite is
green only on Linux, so mutants mode refuses to start on Darwin and the
nightly records the collector as not measured there. A diff that reaches
no mutant, and a baseline that fails, are told apart by the presence of
outcomes.json and the baseline's own outcome in it.

collect.py attributes each mutant by its file to a crate and reports
tested, caught, missed, timeout and unviable with the score as caught
over caught + missed + timeout; an unviable mutant never compiled and
says nothing about the tests. A crate the run generated no mutants for
stays null, not a perfect score. cargo-crap runs after coverage on the
lcov.info it wrote, through one `run_crap <lcov> <out>` hook so the diff
mode can reuse it; functions strictly over `[crap] threshold` are
counted per crate and in the workspace.

Gates: `mutants.score_pct` is an unseeded floor until the shards have
gone round the week once; `crap.over_threshold` is a ratchet down,
because the tree carries such functions today and a ceiling of zero
would be red from the start.

The `.minimal` task `mutants` (graph wire.rs only) becomes
`metrics-mutants`, pinned to the same cargo-mutants the install script
pins. Fixtures outcomes.json and crap.json follow the shapes of
cargo-mutants 27.1.0 and cargo-crap 0.7.0 as run on a throwaway
workspace; the harness cases named by QM-017 drive run.sh with a fake
cargo that logs its argv.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* feat(metrics): metrics-diff grading, quality-gate task, shared changed-lines helper

Grade a change against its base ref (spec 30, QM-009 to QM-013, QM-N01),
on top of the snapshot pipeline.

scripts/metrics/diff.py reads two things the change cannot write: the
thresholds at the merge-base with the base ref and the newest snapshot on
the history ref (origin/metrics-data). Each gate is evaluated against the
stricter of the base's threshold and the head's (floors take the max,
ceilings and ratchet tolerances the min, a gate only one side declares is
kept), so a pull request may tighten the bar at once and loosen it only
after review has merged the loosening. The gates are re-evaluated with
collect.py's own evaluate_gates, never a copy. With no baseline every
ratchet is not_evaluated and the report says so. report.md and
report.json carry no times (meta.json does), so identical inputs give
identical bytes; report.md is appended to GITHUB_STEP_SUMMARY when that
names a writable file. When head's compiling collectors covered a subset
of the workspace, the baseline's clippy and coverage totals are re-summed
over the same crates before the ratchets compare them.

run.sh grows two modes. `gate` is the no-compiler grade: the review
runtime runs a declared task as a probe with a 300 s budget, no arguments
and the sha256 of its output recorded as evidence, so the task takes no
parameters, derives its base ref itself, runs nothing that reaches rustc
(cargo metadata --no-deps only; cargo-shear is skipped and recorded as not
measured because its full cargo metadata probes rustc -vV) and ends stdout
with `quality-gate: <verdict> report=<path> sha256=<hex>`. It takes well
under a second on this tree. `diff` adds clippy over the crates the change
touched, scoped the way clippy-strict.sh scopes itself; --coverage adds
llvm-cov. `just metrics-diff [BASE]` drives it. .minimal/minimal.toml
declares the quality-gate task and ends agent-verify with the same run.

The base-ref resolution and changed-range extraction move out of
clippy-strict.sh into scripts/lib/changed-lines.sh, and the range parsing
into scripts/metrics/changed_lines.py, so the two gates agree on which
lines are the branch's own. clippy-strict.sh keeps its output and exit
codes; a harness case drives it against a fixture repo with a canned
cargo and checks the seeded hit (2), the clean run (0) and the no-change
run.

Harness cases: base_thresholds_win_when_stricter (with a randomised
property check over stricter()), no_baseline_means_not_evaluated,
report_carries_every_section, step_summary_is_appended,
gate_runs_without_rustc (fake rustc and cargo-clippy exit 99 and log
every call; the log must stay empty),
darwin_scope_lists_uncovered_crates_in_report, gate_fits_probe_budget,
clippy_strict_unchanged, and report_is_byte_stable now covers the report.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* ci(nightly): metrics job publishing snapshots to metrics-data

The nightly `metrics` job runs `just metrics`, renders the dashboard from
the fetched history plus the new snapshot, uploads both as an artifact, and
on main hands the snapshot to scripts/metrics/publish-snapshot.sh. That
script keeps the history on the orphan `metrics-data` branch: it fetches or
creates the branch in a temporary worktree, adds history/<date>-<sha7>.json,
prunes, commits as the Actions bot and pushes with a refspec that names the
branch on both sides, so it cannot reach main. It refuses a snapshot whose
mode is not full or whose tree was dirty. Non-blocking while it beds in;
`notify` is untouched.

Verified here: the harness pushes to a bare fixture remote and asserts main
is untouched, the branch is an orphan, and refusals exit 2; zizmor 1.30.1
reports no findings on the workflow. actionlint is not packaged for this
sandbox and did not run.

This touches .github/workflows/, which is CODEOWNER-gated.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(metrics): name the failing collector when the experimental case sees exit 3

The case ran green alone and red once inside the full suite while a cargo
build held the checkout; the message now carries run.sh's FAILED line so a
recurrence says which collector it was.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* chore(toolchain): pin 1.99.0

1.99.0 is current stable (2026-09-28). The metrics snapshot is measured
with the pin, so a pin two releases old would record lint counts that no
developer's clippy agrees with. Comments that state the pin follow it.

Not built here: the sandbox packages rustc 1.98.1 and nothing newer, so
`just clippy -D warnings` under 1.99 is proved by the lanes, not locally.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* feat(metrics): snapshot summary on the run's step summary

`full` and `static` runs now write summary.md beside the snapshot (the
verdict, every gate, the workspace totals, module cycles, promotable lints
and the top hotspots) and append it to GITHUB_STEP_SUMMARY when set, so the
nightly's summary page shows the snapshot without opening the artifact. The
grading modes keep appending their report instead.

The experimental harness case failed once more with the collector now
named: cargo shear could not load a git dependency while another cargo
held the same CARGO_HOME. Concurrent use of one cargo home, not the
collector; green alone and in a serial suite run.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(clippy): clean under 1.99; nightly mutants test the lines since the last snapshot

Clippy 1.99 under -D warnings found: needless borrows of a Copy closure in
args; double_must_use on tonic-generated async_trait code in remote-proto
(expected at the include, generated code); the new pedantic assert_is_empty
in sessions and paths, allowed in their hand-kept tables since the rewrite
says less at the site; must_use on functions returning types already
must_use, and three accessors without it, in sessions; a single-element
loop in mfile; chunks_exact(2) over a byte slice in minimald-rpc and the
switch checksum, now as_chunks; Result<_, ()> on three session-host methods
whose only error is a dead host, expected with that reason; and the
fetch_update deprecation in a minvmd test helper, expected until the MSRV
floor reaches the rename.

The nightly's mutation scope changes. A weekday shard of the workspace is
about 2,500 mutants (cargo mutants --list), which no 120-minute job can
run; run #112 was in that phase when this was written. The nightly now
tests the lines changed since the newest snapshot in the history (or the
merge-base with origin/main on a branch), under a wall-clock budget
(MINIMAL_METRICS_MUTANTS_BUDGET_SECS, 2700 by default); a run that hits the
budget reports what it tested with `partial` set, since cargo-mutants
rewrites outcomes.json after every mutant. The snapshot records the
reference under `mutants.since`.

Verified with a standalone 1.99.0 toolchain: workspace clippy clean, fmt
clean, clippy-strict clean on the changed lines, the touched crates' tests
green except minvmd's port_holder_is_none_when_the_lookup_fails, which
reads the host socket table and fails in this sandbox on main as well.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* ci(nightly): cap the metrics job's mutation run at 25 minutes

Coverage is a cold instrumented build and the module graphs load every
crate; the mutation run takes what is left of the 120-minute job.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(metrics): no colon in the module graph file names

actions/upload-artifact refuses a path with a colon, and the per-target DOT
files were named crate.bin:<name>.dot. The target label is now bin-<name>.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(metrics): fetch before cargo-shear; coverage survives failing tests

On a fresh runner cargo-shear ran before anything had fetched the git
dependencies, so its --offline metadata failed. run.sh now fetches once
before it. cargo llvm-cov exited 100 (nextest: tests failed under the
instrumented build) and took the whole coverage result with it; it now
runs with --ignore-run-fail, and the failing tests are counted from
nextest's junit and recorded under workspace.coverage, on the summary page
too, so the number is read with its caveat beside it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* ci(nightly): install the experimental metrics tools, best effort

rustqual and cargo-anatomy have no prebuilt binaries, so the job compiles
them from crates.io and goes on without them when that fails; the snapshot
records the two collectors as not measured in that case.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(metrics): the harness never writes the job's step summary

Run inside the nightly's coverage pass, the gate cases inherited
GITHUB_STEP_SUMMARY and wrote a grading report of HEAD against itself
above the snapshot on the metrics job's summary page. The harness unsets
the variable; the cases that check the append set their own file.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(metrics): drop minimal-tui and rename sessions to boxes in the layer table

minimal-tui folded into the minimal crate and the sessions crate became
boxes on main, so the table named two crates that no longer exist and
left boxes unassigned. The metadata fixture is regenerated from the
merged tree.

* ci(metrics): give the metrics job its own workflow, called by nightly-tests

metrics.yml takes the job unchanged and runs on workflow_dispatch as well
as workflow_call, so a snapshot can be taken without the rest of the
nightly. continue-on-error moves inside the called job, since a job that
calls a reusable workflow cannot set it.

* test(metrics): read the metrics job from metrics.yml

The job moved out of nightly-tests.yml, so the budget case read an empty

block there and failed the shell-harness test. It now checks metrics.yml

and that the nightly calls it.

* fix(metrics): place main's bep crate in the session layer

Main added the bep crate (Box Egress Proxy). It has no internal
dependencies and only session and product crates use it, so it joins
the session layer. Without it the layer check, which `just ci` runs,
fails on an unassigned crate. The metadata fixture is regenerated from
`cargo metadata --no-deps` with the same trimmed keys; it differs only
by bep and its users. docs/architecture.md lists bep in the session
plane and rewrites the layers paragraph to clear its prose alerts.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(metrics): address review findings on the layer check and snapshot

- layers.py fails on a stale exception, so an exception that no longer
  names a forbidden edge has to be removed rather than left to let the
  edge back in.
- layers.py places only `workspace_members`, so full `cargo metadata`
  given through --metadata does not report dependencies as unassigned
  crates. small-metadata.json now lists its members, as cargo does.
- run.sh passes --coverage-tests only when nextest's junit parsed; a
  truncated junit no longer makes collect.py crash and drop the
  nightly snapshot (QM-001).
- collect.py records a null mutation score when no mutant was tested,
  not 0 %, so an all-unviable change cannot fail a seeded floor.
- crates/minimald/clippy.toml, added on main, restates the complexity
  thresholds: clippy reads only the nearest clippy.toml. The agreement
  test now checks every per-crate clippy.toml.

Each fix has a case in scripts/metrics_test.sh.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* ci(metrics): publish from a separate job; the collector holds no write token

The metrics job builds and tests the checked-out tree and installs tools
from crates.io, and it held `contents: write` with the token persisted in
.git/config. Any build script or tool could push to the unprotected
metrics-data branch the gate grades against, and a dispatch on any ref
got the same token.

The collector now runs at `contents: read` with persist-credentials off
and checks out metrics-data without keeping credentials. A `publish` job,
on main only and only for a complete snapshot (status 0 or 2), holds the
write token. It downloads the `metrics` artifact and runs main's
publish-snapshot.sh, and builds and installs nothing. nightly-tests still
grants `contents: write` because the called workflow's publish job needs
it. `just` and `cargo-binstall` are pinned to 1.58.0 and 1.24.0.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(metrics): address the second review round on the harness

- Same-day snapshots: diff.py's baseline and the mutants `auto`
  reference took the last name in sort order, so two snapshots of one
  day were ordered by sha7. prune.py's new `newest` keeps the date
  order and breaks a tie by the committer time of the commit each
  snapshot measured (the snapshot itself holds no time, QM-006).
- Grading exit: in gate and diff modes a failed gate (2) now outranks
  an incomplete snapshot (3). Full mode keeps 3 first, because the
  nightly publishes only on 0 or 2; run.sh's header says so.
- metrics-mutants: run.sh mutants mode now fails (exit 3) when
  cargo-mutants or cargo-nextest is missing, instead of passing with no
  run. The task installs both through `install-tools.sh --only`, which
  owns the pins, so it drops its own copy of the cargo-mutants pin.
- layers.py matched dependency edges by name, so a registry or
  out-of-tree crate named like a member counted as an internal edge. It
  now needs a path dependency into that member's directory. The metadata
  fixture is regenerated with each dependency's `source` and `path`.
- run.sh is reachable by macOS's stock bash 3.2 (`#!/usr/bin/env bash`,
  called straight from the justfile). Empty-array expansions now use
  `${a[@]+"${a[@]}"}`, and a read loop replaces `mapfile`.

Each behaviour change has a case in scripts/metrics_test.sh that fails
against the previous scripts.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385

Port of #2503 so cargo-deny's advisories check passes on this branch.
The same Cargo.lock change; it becomes a no-op once #2503 lands on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(metrics): validate the snapshot fields publish-snapshot.sh puts in paths

The publish job holds the write token and runs publish-snapshot.sh over
an artifact the collector job wrote after running the tree's build
scripts and crates.io tools, so the snapshot is untrusted input.
`git.sha7` went into the history file name unchecked: a value of `../x`
wrote outside history/, and malformed values were pushed under names
prune.py does not recognise.

The script now reads the fields in one Python step. It requires `mode`
to be the string "full", `dirty` the boolean false and `sha7` seven
lowercase hex digits, and it checks `--date` against YYYY-MM-DD over the
whole string. Nothing is written or pushed for a refused snapshot.
These are the only artifact fields that reach a path or a git command;
prune.py reads only the history branch's file names.

The harness feeds bad sha7, dirty and date values through and checks
that each is refused and nothing reaches metrics-data. It also asserts
that only the `publish` job holds the write token, on main only.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(metrics): refuse a publish date that is not on the calendar

publish-snapshot.sh checked only the YYYY-MM-DD shape, so --date
2026-02-30 published a snapshot whose name prune.py later skips. The
date now also has to parse as a real date. The publish test adds
2026-02-30 and 2026-13-01 to its refused dates.

The non-blocking assertion in nightly_budget_is_declared now reads only
the metrics job's lines, so continue-on-error on publish alone no longer
satisfies it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(metrics): publish only a snapshot of the checkout's own commit

publish-snapshot.sh checked the shape of git.sha7 but not that it named
the commit being published. The publish job checks out the run's own
commit, so a snapshot whose sha7 is not a prefix of HEAD was not made by
this run's collector; it is now refused with exit 2 before anything is
written. The publish test builds its snapshot from the test repo's HEAD
and adds a case for a well-formed sha7 of another commit, which the
previous script published.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* docs(metrics): the quality-metrics spec is 31

#1586 (PKV) holds docs/specs/30-spec-pkg-verify, so this one moves to 31.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* build(deps): crypto-bigint 0.7.7, for RUSTSEC-2026-0387

Port of #2517 so cargo-deny's advisories check passes on this branch.
The same Cargo.lock change; it becomes a no-op once #2517 lands on main.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* ci(metrics): build the metrics tools from source, cached on main

The collector installed cargo-binstall, so install-tools.sh ran each
tool's prebuilt release binary with nothing checking a digest of it,
inside the job whose snapshot the gate takes as its baseline. Without
binstall the script builds every tool with `cargo install --locked`,
from crates.io sources checked against the index.

The built binaries are cached on the pins and the toolchain, so a run
compiles only what a pin change moved. Only main saves the cache, so a
branch's build is never what main restores. The harness asserts both.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* test(metrics): require the main-only guard on every cache save

The check passed when any one save step in the collector carried the
guard, so a second, unguarded save would have slipped past it. It now
counts the save steps and the guarded ones, and they must match.

Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

* fix(metrics): place client-config in the leaf layer and the metadata fixture

* chore(toolchain): correct the pin named in the MSRV comment

rust-toolchain.toml pins 1.99.1, not 1.99.0.

* docs(metrics): remove references to the unpublished spec 31

The spec and its QM requirement ids exist on no branch, so the links and
ids pointed nowhere. Comments keep what the ids meant; the docs point at
metrics/README.md.

* ci(metrics): make the quality gate non-blocking in agent-verify

The gate still runs and prints its report, but a failed (2) or incomplete
(3) verdict is logged instead of failing the task until the gate has soaked.

* fix(metrics): refuse to publish a snapshot that fails the schema

* fix(metrics): cap the published snapshot's size and name the renamed task

publish-snapshot.sh refuses a snapshot over 8 MiB before parsing it, so an
artifact cannot bloat the history branch every later run fetches.
docs/fuzzing.md names the task this branch renamed, metrics-mutants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WhCC5TEBNzPeWgytRsU4rc

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants