Skip to content

test(e2e): prove Keychain secrets by reference end to end - #2612

Merged
norrietaylor merged 26 commits into
mainfrom
agent/2294-keychain-secrets-by-reference-end-to-end
Oct 30, 2026
Merged

norrietaylor merged 26 commits into
mainfrom
agent/2294-keychain-secrets-by-reference-end-to-end

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

T29 — Keychain secrets by reference, end to end

slice: S3
kind: integration
covers: none
size: M
est: 80 code, 120 tests
executor: agent
difficulty: needs care
model: standard
diagnostics: min box audit <box> shows each injection of the run by store and identifier
observability: one connection span per injected request, with the store and identifier, never the value
layers:
- e2e:
- scripts/session-e2e.sh: one case: set a secret, add a rule, reference it in a box spec, see the upstream receive it, and find it nowhere in the box
test: ./scripts/session-e2e.sh bep_store_reference_end_to_end
produces: none
consumes: none
proof: Store an API key with min secret, reference it in a box spec, and the box's requests to its upstream carry it while the key never enters the box.
depends on:
- blocked by #2280
- blocked by #2287
- blocked by #2288
- blocked by #2292
- blocked by #2325

Proof

On a macOS lane with the Box Egress Proxy, ./scripts/session-e2e.sh bep_store_reference_end_to_end does these steps. It stores a random value with min secret set <id> --upstream httpbin.org --header X-Minimal-E2E-Probe and references <id> in a box spec. It shows that min box spec lists the reference with its upstream. It shows that the upstream receives the stored value (the box compares only hashes), and it finds the value in no variable and no file in the box. It also shows that min box audit records the admitted injection by store and identifier, and that neither the audit nor bep.log holds the value. On this Linux box the case reports NOT RUN, so the end-to-end proof is not delivered here.

Notes from the agent: The proof is not delivered on this box. The case needs macOS, the Keychain, a live bep and MINVMD_GVPROXY_BIN, so here it reported NOT RUN. The macOS lane must run it before anyone takes the proof as shown. Design choices: (1) The upstream is an HTTPS echo service, E2E_BEP_STORE_ECHO_URL, with https://httpbin.org/headers as the default. This is the only way to see the upstream receive the value without a real third-party key. The echo returns the value to the box, but only inside a shell pipe. The box prints only a hash and writes the echo to no file and to no exported variable. The case then searches the box files for the value's shape, not for the value, so the search does not bring the value into the box. (2) bep_live_gate takes an optional no_sign_in second argument, because a store reference needs no GitHub sign-in. Every other caller keeps its current behaviour. (3) The box declares packages base, coreutils and ca-certificates, and the case expects curl from the shell stack. The case fails with 'no curl in the box' if curl is not there. (4) Observability gap: the box_connection span in crates/bep/src/proxy.rs has no store or identifier field. Only a DEBUG line 'store value injection' in crates/bep/src/forward.rs names them. Th…[truncated]

Layer exception

The epic owner accepted these files outside T29's layers on 2026-10-27, for arch condition C3 (round 5):

  • crates/bep/src/proxy.rs: the box_connection span records store and identifier, never the value.
  • crates/bep/src/forward.rs: passes the store and identifier of a redeemed store reference to that span.

Tests

line exit tail
./scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::group::Box Egress Proxy: a Keychain secret by reference reaches its upstream and never enters the box bep_store_reference_end_to_end: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_store_reference_end_to_end session e2e OK Applying loadouts: defa

Deferred: the epic owner ruled on 2026-10-29 that #2657 carries the macOS leg of bep_store_reference_end_to_end. #2657 stages bep in the macOS CI testbed. The lane run there must print Keychain secret by reference OK, not NOT RUN, and is recorded on #2657.

Verify

min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.99.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

toredEnv {
    |        ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
    |
402 + #[must_use]
403 | pub fn deferring_env() -> StoredEnv {
    |

error: this method could have a `#[must_use]` attribute
    --> crates/boxes/src/core/compose.rs:1019:12
     |
1019 |     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
     |
1019 ~     #[must_use]
1020 ~     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1085:5
     |
1085 |     pub fn as_sandbox_path(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1084:5
     |
1084 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use
     = note: `-D clippy::double-must-use` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_must_use)]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1302:5
     |
1302 |     pub fn host_path(&self) -> &HostAbsPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1301:5
     |
1301 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1309:5
     |
1309 |     pub fn destination(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1308:5
     |
1308 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: could not compile `boxes` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...

Closes #2294


Generated by Claude Code

Add the bep_store_reference_end_to_end case to session-e2e.sh. It
stores a value with min secret set, references it in a box spec, checks
that an HTTPS echo upstream receives the stored value, and checks that
no box file or variable holds it. The live proxy gate takes no_sign_in
for cases that need no GitHub sign-in.
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 83e368a4-56dc-4c47-9642-da09005b3770

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviewed: 1 finding, none blocking at 6f6121008550.

Address the comments on the diff.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 26, 2026

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The new e2e case follows Gatehouse §6.10, but two things are open. The audit check accepts a record without the store, and §6.10 line 849 says the record carries store and id. C1 makes the check require keychain:<id> exactly. The leg reported NOT RUN, and a NOT RUN leg is not a pass. C2 asks for a macOS run on this head. The --upstream flags on a host-store set conflict with architecture.md line 513. That question is an escalation, not a condition on this change.

Ruled at 51654d5 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
The audit check accepted a bare identifier or any <store>:<id>. It now
takes the store as an argument and requires <store>:<id> exactly, as
StoreAdmit::identifier() writes it.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a failed check suite, pushed as cc15f9f52b3e.

line exit tail
./scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::group::Box Egress Proxy: a Keychain secret by reference reaches its upstream and never enters the box bep_store_reference_end_to_end: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_store_reference_end_to_end session e2e OK Applying loadouts: defa

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.99.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

toredEnv {
    |        ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
    |
402 + #[must_use]
403 | pub fn deferring_env() -> StoredEnv {
    |

error: this method could have a `#[must_use]` attribute
    --> crates/boxes/src/core/compose.rs:1019:12
     |
1019 |     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
     |
1019 ~     #[must_use]
1020 ~     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1085:5
     |
1085 |     pub fn as_sandbox_path(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1084:5
     |
1084 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use
     = note: `-D clippy::double-must-use` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_must_use)]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1302:5
     |
1302 |     pub fn host_path(&self) -> &HostAbsPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1301:5
     |
1301 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1309:5
     |
1309 |     pub fn destination(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1308:5
     |
1308 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: could not compile `boxes` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — scripts/session-e2e.sh: bep_store_jsonl_check takes the store as an argument and admits only a record whose identifier is exactly :.
  • 👍 valid — scripts/session-e2e.sh: The audit check call passes keychain as the store, to match StoreAdmit::identifier() in crates/bep/src/forward.rs.
  • 👎 invalid — scripts/session-e2e.sh:12178: This asks for a run, not a change to the code. The coder box is Linux and has no macOS runner, so the case reports NOT RUN here too. The macOS e2e lane runs it when the runner pushes this head. Its group output must come from that lane's log.

Not shown on this box. The case stores an API key with min secret set, references it in a box spec, checks that the upstream receives it, checks that the key is in no box file or variable, and checks that min box audit shows the injection as keychain:. It runs only on macOS with the Box Egress Proxy. Here it reported NOT RUN, so the proof is still owed by the macOS e2e lane.

Notes from the agent: bep_store_jsonl_check now takes the store as $3 and requires identifier == store + ':' + id exactly. I checked the helper against sample records: keychain:abc passes, and a bare abc fails. The failed checks in the directive: the ci-macos-success log shows only the aggregator's 'exit 1'. The e2e job excerpt shows other cases (net expose) and does not show this case's output, so I cannot find a cause in this case from the excerpt. A person must read the full macOS e2e log for the bep_store_reference_end_to_end group. I cannot run the macOS lane from this Linux box.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The audit check now requires keychain:<id>, as §6.10 line 849 and StoreAdmit::identifier() require. That resolves the baseline point. Two points stay open. The only e2e leg reported NOT RUN, so the proof is not shown yet. Run the case on the macOS lane at this head (C1). The PR body states a span gap but names no issue. File the issue and name it in the PR body (C2).

Ruled at cc15f9f against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Oct 26, 2026
An interrupted run left the case's Keychain item in the developer's
real Keychain, because only the case's own paths called sr_cleanup.
The EXIT trap now runs `min secret rm` for SR_ID. The rule needs no
step there: it lives under $WORK, which teardown removes.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on the runtime's review findings, pushed as 1ec9e152cec9.

line exit tail
./scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::group::Box Egress Proxy: a Keychain secret by reference reaches its upstream and never enters the box bep_store_reference_end_to_end: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_store_reference_end_to_end session e2e OK Applying loadouts: defa

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.99.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

toredEnv {
    |        ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
    |
402 + #[must_use]
403 | pub fn deferring_env() -> StoredEnv {
    |

error: this method could have a `#[must_use]` attribute
    --> crates/boxes/src/core/compose.rs:1019:12
     |
1019 |     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
     |
1019 ~     #[must_use]
1020 ~     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1085:5
     |
1085 |     pub fn as_sandbox_path(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1084:5
     |
1084 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use
     = note: `-D clippy::double-must-use` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_must_use)]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1302:5
     |
1302 |     pub fn host_path(&self) -> &HostAbsPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1301:5
     |
1301 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1309:5
     |
1309 |     pub fn destination(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1308:5
     |
1308 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: could not compile `boxes` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👎 invalid — scripts/session-e2e.sh:12184: No code change can satisfy this. The case is correct, and the gate reports NOT RUN off macOS on purpose. The open leg needs a macOS-lane run at the new head, with its OK line in the PR body. This Linux box cannot make that run, so a person or the runner must make it.
  • 👎 invalid — scripts/session-e2e.sh:12351: The gap is real. But the fix is crates/bep/src/proxy.rs, which is outside this task's layers, and the thread itself says not to change it here. Filing the issue needs gh, which this session does not have. The gap is recorded in the result notes, so the PR body can name the issue.
  • 👍 valid — scripts/session-e2e.sh:12195: teardown now runs min secret rm "$SR_ID" (host store only, so no daemon), and SR_ID has a global default for set -u. The rule is not in the user's real config.toml: it is under $WORK/config, which teardown removes.

On the macOS lane, a person can run ./scripts/session-e2e.sh bep_store_reference_end_to_end. The case stores an API key with min secret set, references it in a box spec, and sees the HTTPS echo upstream receive it. It finds the key in no box file or variable. It also finds a keychain:<id> admit record in the audit. An interrupted run now also removes its Keychain item on exit. This round did not run the case: on this Linux box it reports NOT RUN.

Notes from the agent: Thread C3: teardown now runs mnl secret rm "$SR_ID" after the daemon stop, and SR_ID has a global empty default, because the script runs under set -u. The finding also names the rule in user config.toml. That part does not hold: XDG_CONFIG_HOME is $WORK/config, and teardown removes $WORK. Owed by people, not by code: (1) a macOS-lane run of this case at the new head, with its Keychain secret by reference OK line in the PR body. (2) An issue for the gap in the box_connection span in crates/bep/src/proxy.rs, which carries no store and no identifier. This task's observability line asks for both. Name that issue in the PR body. I have no gh credential and no macOS host, so I did neither.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 3 conditions · the full ruling

The teardown fix conforms. The case checks the redemption that Gatehouse §6.10 lines 844 and 849 require. The case is NOT RUN at this head, and it is the task's only proof. Run it on the macOS lane and record the pass (C1). The box spec writes the store reference as a broker scope, but §6.10 line 842 and BEP-032 write source = "store". File the tree gap and mark the case as an interim (C2). File the span gap that the PR body declares, or amend the plan line (C3).

Ruled at 1ec9e15 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
grep -r exits 2 on an unreadable file even after it lists matches. The
case now fails on a match first, and reports grep's exit status and
errors when the search does not finish. The comment also says that the
default echo service is a public third-party host.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as e1774c616899.

line exit tail
./scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::group::Box Egress Proxy: a Keychain secret by reference reaches its upstream and never enters the box bep_store_reference_end_to_end: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_store_reference_end_to_end session e2e OK Applying loadouts: defa

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.99.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

toredEnv {
    |        ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
    |
402 + #[must_use]
403 | pub fn deferring_env() -> StoredEnv {
    |

error: this method could have a `#[must_use]` attribute
    --> crates/boxes/src/core/compose.rs:1019:12
     |
1019 |     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
     |
1019 ~     #[must_use]
1020 ~     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1085:5
     |
1085 |     pub fn as_sandbox_path(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1084:5
     |
1084 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use
     = note: `-D clippy::double-must-use` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_must_use)]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1302:5
     |
1302 |     pub fn host_path(&self) -> &HostAbsPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1301:5
     |
1301 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1309:5
     |
1309 |     pub fn destination(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1308:5
     |
1308 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: could not compile `boxes` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👍 valid — scripts/session-e2e.sh: The box scan no longer drops its matches on grep exit 2. The host keeps the match list whatever the exit status and fails on a match first. When the search does not finish, it prints the exit status and the tail of grep's errors.
  • 👍 valid — scripts/session-e2e.sh:12179: The case comment now says the default https://httpbin.org/headers is a public third-party service that sees the request and that the case depends on. The value is a random throwaway. Set E2E_BEP_STORE_ECHO_URL to use your own echo service. The default stays, so the macOS lane runs the case with no e

On macOS, a person can run ./scripts/session-e2e.sh bep_store_reference_end_to_end. It stores an API key with min secret set and references it in a box spec. The upstream receives the stored value from the box, the key is in no file or variable in the box, and min box audit names keychain:. This box ran the case as NOT RUN, so the macOS lane still owes the evidence.

Notes from the agent: Revise round 3. On Linux the case reports NOT RUN, because the Box Egress Proxy runs on macOS only. The macOS lane must run it, and the PR needs its 'Keychain secret by reference OK' line. bash -n and shellcheck -S warning pass on the script.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 2 conditions · the full ruling

The case conforms to §6.10 lines 844 and 849 and architecture.md line 501. This head fixes the last code point: the box scan reports matches when grep exits 2, and it still fails closed. Two points stay open. C1: the case reported NOT RUN, so the proof is open until the ci-macos lane reports it OK on this head. C2: file an issue for the missing store and identifier fields on the box_connection span, and name it in the PR body.

Ruled at e1774c6 against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 13 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh:12188, minimal-arch[bot] scripts/session-e2e.sh:12188, minimal-arch[bot] scripts/session-e2e.sh:12361, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

The tests lane shellchecks every script. The store-reference box scan
passes $? and $s in single quotes to the box shell, so it needs the
directive. The comments also say that the seed spells the store reference
as a broker scope for now, and that the connection spans carry no store
or identifier.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a failed check suite, pushed as 1a6585ae5bd1.

line exit tail
./scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::group::Box Egress Proxy: a Keychain secret by reference reaches its upstream and never enters the box bep_store_reference_end_to_end: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_store_reference_end_to_end session e2e OK Applying loadouts: defa

Verify min task run agent-verify exited 101 under rustc 1.98.1, which the repository does not pin (1.99.0 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

toredEnv {
    |        ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
    |
402 + #[must_use]
403 | pub fn deferring_env() -> StoredEnv {
    |

error: this method could have a `#[must_use]` attribute
    --> crates/boxes/src/core/compose.rs:1019:12
     |
1019 |     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#must_use_candidate
help: add the attribute
     |
1019 ~     #[must_use]
1020 ~     pub fn lifecycle_hooks_teardown(&self) -> impl DoubleEndedIterator<Item = &ProvenancedHook> {
     |

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1085:5
     |
1085 |     pub fn as_sandbox_path(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1084:5
     |
1084 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use
     = note: `-D clippy::double-must-use` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::double_must_use)]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1302:5
     |
1302 |     pub fn host_path(&self) -> &HostAbsPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1301:5
     |
1301 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
    --> crates/boxes/src/core/primitives.rs:1309:5
     |
1309 |     pub fn destination(&self) -> &SandboxRelPath {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: remove `must_use`
    --> crates/boxes/src/core/primitives.rs:1308:5
     |
1308 |     #[must_use]
     |     ^^^^^^^^^^^
     = note: alternatively, you may add an explicit reason to the `must_use` attribute
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.98.0/index.html#double_must_use

error: could not compile `boxes` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...

Review threads the coder judged:

  • 👎 invalid — scripts/session-e2e.sh:12188: The finding is about evidence, not code. This round cannot run the macOS lane: the coder box is Linux, where the case reports NOT RUN. The ci-macos lane must run the case at this head. This round fixed the shellcheck failure that made the Linux lanes red.
  • 👍 valid — scripts/session-e2e.sh:12263: The comment above the seed in step 2 now says that the broker-scope spelling is an interim, because GrantSource refuses store. It also gives the source = "store" form that replaces it. I have no credential to file the issue, so a person must file it and link it.
  • 👍 valid — scripts/session-e2e.sh:12202: The sr_fail comment now says that the box_connection span in crates/bep/src/proxy.rs has no store or identifier field, and that the audit record carries both. The span fix is in crates/bep, outside this task's layers. I cannot file the issue without a credential, so a person must file it and name it
  • 👎 invalid — scripts/session-e2e.sh:12188: This is the same as the C1 thread at this line. Only the ci-macos lane can run the case, and this Linux box reports NOT RUN. The case is not relaxed. This round fixed only the SC2016 shellcheck finding that failed the tests lane.
  • 👍 valid — scripts/session-e2e.sh:12202: The comment now says that the spans name no value, and also no store or identifier yet, because proxy.rs has no field for them. The span fields are in crates/bep, outside the layers. A person must file the issue, because I have no gh credential.

On macOS, a person can run ./scripts/session-e2e.sh bep_store_reference_end_to_end. The case stores an API key with min secret set, references it in a box spec, and sees the upstream receive the stored value while the box holds only a sealed value. It ends with 'Keychain secret by reference OK'. This proof is not observed yet: the case is NOT RUN on Linux, and no macOS run at this head exists.

Notes from the agent: The failed tests lane came from shellcheck SC2016 on the box scan line. all_scripts_pass_shellcheck runs scripts/lint-shell.sh. A shellcheck directive fixes it, and lint-shell.sh now passes. ci-linux-native-success is the aggregator of that lane. The case is still NOT RUN off macOS. This box has no macOS lane, so the macOS evidence is still owed by ci-macos. I cannot file issues because I have no gh credential. A person must file two issues: (1) GrantSource in crates/boxes/src/core/bep.rs must accept source = "store" with store and id, per BEP-032. (2) The box_connection span in crates/bep/src/proxy.rs must carry the store and the identifier, as the task's observability line asks. Name both issues in the PR body as residuals. The script comments now describe both gaps, without issue numbers.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 13 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh:12188, minimal-arch[bot] scripts/session-e2e.sh:12188, minimal-arch[bot] scripts/session-e2e.sh:12369, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 3 conditions · the full ruling

The case checks what Gatehouse §6.10 asks for a Keychain store reference. Three points stay open. The seed writes the reference as a broker scope, and line 842 spells it source = "store". The comment calls it an interim but links no issue. C1 fixes that. The e2e leg reported NOT RUN, and NOT RUN is not a pass. C2 asks for the macOS-lane result. The span gap in the comment also needs a linked issue (C3).

Ruled at 1a6585a against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved

Copy link
Copy Markdown
Member

/revise

Round 5 of #2612, on the arch conditions at 1a6585ae. No round is in flight. The size cap is lifted for this epic. The epic owner ruled on 2026-10-27 that bep_store_reference_end_to_end stays strict: a missing proxy stays a failure, and the macOS lane gets bep through #2657 (a CODEOWNER workflow change). Do not change the case's gate to NOT RUN. The owner accepts the one file outside T29's layers that step 3 needs, as a layer exception. Add a "Layer exception" section to the PR body that names it.

  1. Merge main. This branch is about 10 commits behind.
  2. C1. In proof_bep_store_reference_end_to_end() in scripts/session-e2e.sh, add T97 — Accept source = "store" with store and id in a box spec's grant #2656 to the # Interim spelling: comment. That issue makes GrantSource accept source = "store" and changes the seed. Leave the seed as it is in this PR.
  3. C3, done here rather than filed. In crates/bep/src/proxy.rs, add the store and identifier fields to the box_connection span. Never add the value. Use the field names of the audit record, so the span records what the audit records. Record them when a store reference is redeemed, and leave them empty otherwise. Then make the comment above sr_fail() say that the span carries them, in place of the open gap. Add a unit test in bep that a redeemed store reference's span carries store and identifier and no value.
  4. C2. In the PR body's ## Proof, say that the macOS leg waits on Stage bep in the macOS CI testbed so the Box Egress Proxy cases run on the e2e lane #2657, which stages bep on the e2e lane, and that the lane's tail ending in Keychain secret by reference OK (...) will be posted there.
  5. Change nothing else. Run cargo clippy --workspace --all-targets --locked -- -D warnings with the toolchain rust-toolchain.toml pins, cargo nextest run -p bep, and just test-one all_scripts_pass_shellcheck.

Generated by Claude Code

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 29, 2026 12:31

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The compare scopes the bep binary check to the no_sign_in case and the proxy stop to this run's listener socket. Signed-in BEP cases fail again when no proxy comes up. Both changes conform. The store case proves §6.10 lines 844 and 849 by hard failures, but its macOS leg still reports NOT RUN. C1 stays open until the lane in #2657 prints Keychain secret by reference OK.

Ruled at 06f522a against gominimal/arch@109541a48c31 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/bep/src/forward.rs Resolved
A refused store reference no longer records store and identifier on
the connection span, so the span does not read as an injection that
did not happen. The span test now covers a refused reference.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on the runtime's review findings, pushed as c7e45a7f3398.

line exit tail
./scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::group::Box Egress Proxy: a Keychain secret by reference reaches its upstream and never enters the box bep_store_reference_end_to_end: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_store_reference_end_to_end session e2e OK Applying loadouts: defa

Verify min task run agent-verify passed.

Outside the task's layers::

  • crates/bep/src/forward.rs
  • crates/bep/src/proxy.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

On the macOS lane, a person stores an API key with min secret, references it in a box spec, and the box's requests to the upstream carry the key while the key never enters the box. This round also makes the box_connection span name the store and identifier only for an injection that happened. That part is proved by the bep unit test. The e2e case printed NOT RUN on this Linux box, so the end-to-end proof still waits for a macOS run.

Notes from the agent: crates/bep/src/forward.rs is outside the task's layers. Earlier rounds on this branch changed it already (commit 00f7b06), and this round fixes a finding in that change. The e2e test line ran and printed NOT RUN, because the case runs on macOS only. The macOS leg of bep_store_reference_end_to_end is still owed by the lane that #2657 stages. just clippy-strict was not run.

Copy link
Copy Markdown
Member

@cla-assistant check


Generated by Claude Code

@norrietaylor
norrietaylor marked this pull request as ready for review October 29, 2026 14:28

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The compare conforms. The box_connection span now names the store and the identifier only after an injection. The audit record still names the reference and the decision on admit and on refusal, as Gatehouse §6.10 line 849 requires. The new test reaches inject_store and proves the refusal span. One item stays open: the macOS end-to-end leg reports NOT RUN. C1 keeps it open until the run on #2657 prints Keychain secret by reference OK.

Ruled at c7e45a7 against gominimal/arch@109541a48c31 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/bep/src/forward.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 7 of 10 on the runtime's review findings: the coder changed nothing. Revise round 7: the one open thread is judged invalid, so this round changes no file (noop). I did not run ./scripts/session-e2e.sh bep_store_reference_end_to_end. This box has no /dev/kvm and no microVM, so the session e2e cannot run here. The thread points at crates/bep/src/forward.rs, which is outside this task's layers (only scripts/session-e2e.sh). Earlier rounds already changed that file.

Review threads the coder judged:

  • 👎 invalid — crates/bep/src/forward.rs:886: The span is per connection by design, and its fields are sticky. cohort_attributed (forward.rs:888, 1035) is never cleared either. connection_span in proxy.rs documents that the span carries store and identifier when a store reference is redeemed. On a kept-alive connection they name the ref

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

This head merges main into the head that the last ruling covered, and the PR content does not change. The connection span names the store and the identifier only after an injection, as AT25 requires. The macOS leg of bep_store_reference_end_to_end is still NOT RUN. C1 keeps it open until the run on #2657 prints Keychain secret by reference OK. There is one new escalation. Step 1 of the case uses min secret set --upstream --header on the Keychain, and the architecture min secret reference refuses those flags for a host store. A person must decide which document changes.

Ruled at b4c5dc1 against gominimal/arch@42d214dc8ac8 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Revise round 8 ran against ci-macos-success, e2e and left it red; a coder round cannot clear it, a person should look. No round was started for the failed suite on b4c5dc115567.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change conforms to AT25 and the min box audit field names. The span names the store and the identifier and never the value. The macOS leg of bep_store_reference_end_to_end is NOT RUN. C1 keeps the proof open until that lane prints Keychain secret by reference OK on #2657. One escalation is open: design line 517 and spec BEP-079 disagree about min secret set --upstream for a host store. That question is not this PR's to fix.

Ruled at 363ad7e against gominimal/arch@42d214dc8ac8 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Revise round 8 ran against ci-macos-success, e2e and left it red; a coder round cannot clear it, a person should look. No round was started for the failed suite on 363ad7e7b517.

Copy link
Copy Markdown
Member

Owner ruling on the arch review's design question: spec 24 BEP-079 wins. min secret set <id> on a host store may take --upstream with an injection form (or --preset) and writes the [secret-store-rules] rule to the user-level client configuration, as this PR does.

The conflicting min secret paragraph in gominimal/arch architecture.md (around lines 512–517: "for a host store, set takes no upstream and registers nothing", "refused for a host store") is being changed to match in a separate gominimal/arch PR. Nothing changes in this PR for it.

Arch condition C1 stays carried on #2657, as before.


Generated by Claude Code

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change conforms to AT25 and Gatehouse §6.10. The box_connection span names the store and the identifier only after an injection, and never the value. The e2e case for this proof reports NOT RUN on this head. A NOT RUN leg is open, so C1 stays a condition. Run the case on the macOS lane of #2657, and record the Keychain secret by reference OK line there. This head is a clean merge of main, and the ruling on 363ad7e7 stands.

Ruled at 6f61210 against gominimal/arch@42d214dc8ac8 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 6f612100.

  • The e2e case bep_store_reference_end_to_end checks each AT25 mitigation that a box-side test can show. The value never enters the box, and the audit record names the store, the id and the authority, never the value.
  • inject_store records store and identifier on the box_connection span only after an injection that happened.
  • The script labels its three interims (broker-scope spelling, proxy restart, the no_sign_in gate) and links #2656 and #2746.
  • arch-review rules PASS_WITH_CONDITIONS at this head. Its only condition, C1, is the macOS run of this case. By the owner's ruling, C1 is deferred to #2657.
  • The base merge of main at bea4ea72 is clean and touches none of this PR's files. Every lane is green, including the macOS e2e.

Generated by Claude Code

@norrietaylor norrietaylor changed the title T29 — Keychain secrets by reference, end to end test(e2e): prove Keychain secrets by reference end to end Oct 30, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter approval at 6f61210: every merge gate passes at this head (arch PASS at 6f61210, zero open threads, every lane aggregator green). Squash title test(e2e): prove Keychain secrets by reference end to end and the squashed message pass commitlint. Queued for squash merge.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit f3a4506 Oct 30, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the agent/2294-keychain-secrets-by-reference-end-to-end branch October 30, 2026 23:13
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Oct 31, 2026
…anges (gominimal#2767)

* feat(bep): re-certify the published root on a control request

bep serve takes recertify_root on its control socket. It re-issues the
root for the current store rules, publishes it to the identity file,
and replies only after both, with ok or the reason. The CONNECT path
stays the fallback for a rule file edited by hand.

* feat(minimal): ask a running proxy to re-certify after secret set

min secret set sends recertify_root on the proxy's control socket after
it writes a store rule. When the proxy did not re-issue or publish its
root, it says the rule is saved and names the upstream that a box
created before then does not reach. With no proxy running it prints
nothing new.

* test(e2e): activate the store-reference box against the running proxy

min secret set now re-certifies the running proxy's root, so the case
drops the bep stop and daemon restart that gominimal#2612 kept for gominimal#2746. It
checks that the same proxy serves before and after the set.

* test(minimal): classify the re-certify control connection

min secret set now opens the egress proxy's control socket, so the
connection inventory records that site as ungated.

---------

Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T29 — Keychain secrets by reference, end to end

1 participant