Repository navigation
build(deps): bump the github-actions group across 1 directory with 4 updates - #2619
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Reviewed: 1 finding, none blocking at Address the comments on the diff. Clobber: none seen. |
| # Trailing slash is required (`Url::join`). Rollback = delete | ||
| # this `env` block. | ||
| uses: gominimal/run-task@a5ed123f612b9774e3d6eaa7af45370e33aa1116 # v1 | ||
| uses: gominimal/run-task@edf3484d540eccbaf1ee4bda10bd913bb474cc47 # v2.0.0 |
There was a problem hiding this comment.
LOW · correctness · confidence 0.50 · in run-task
This is a major bump of gominimal/run-task (v1 to v2). The v2.0.0 commit changes the runner from mip run to min task run. The build-smoke task, with MINIMAL_REMOTE_CACHE_URL and channel: unstable, now runs through a different command. Confirm in a CI run that the task and the cache env still work. Only this one call site uses the action.
What the reviewer checked
PR body: 'edf3484 Run tasks with min task run instead of mip run (#3)'; ci.yml:158 uses run-task@edf3484... # v2.0.0
Hand this to an agent
Act on a code-review finding.
File: .github/workflows/ci.yml
Lines: 158-158
Category: correctness
Severity: low (reviewer confidence 0.50)
Finding:
This is a major bump of `gominimal/run-task` (v1 to v2). The v2.0.0 commit changes the runner from `mip run` to `min task run`. The `build-smoke` task, with `MINIMAL_REMOTE_CACHE_URL` and `channel: unstable`, now runs through a different command. Confirm in a CI run that the task and the cache env still work. Only this one call site uses the action.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
f5cc650 to
c7ba049
Compare
|
@dependabot rebase |
…updates Bumps the github-actions group with 4 updates in the / directory: [taiki-e/install-action](https://github.com/taiki-e/install-action), [Swatinem/rust-cache](https://github.com/swatinem/rust-cache), [gominimal/run-task](https://github.com/gominimal/run-task) and [actions/create-github-app-token](https://github.com/actions/create-github-app-token). Updates `taiki-e/install-action` from 2.87.29 to 2.88.1 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@8cca091...68a389c) Updates `Swatinem/rust-cache` from 2.9.2 to 2.9.3 - [Release notes](https://github.com/swatinem/rust-cache/releases) - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md) - [Commits](Swatinem/rust-cache@6323deb...d1527c8) Updates `gominimal/run-task` from 1 to 2 - [Commits](gominimal/run-task@a5ed123...edf3484) Updates `actions/create-github-app-token` from 3.2.0 to 3.3.0 - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Changelog](https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md) - [Commits](actions/create-github-app-token@v3.2.0...64ab729) --- updated-dependencies: - dependency-name: actions/create-github-app-token dependency-version: 3.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: gominimal/run-task dependency-version: '2' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: Swatinem/rust-cache dependency-version: 2.9.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: taiki-e/install-action dependency-version: 2.87.31 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
c7ba049 to
8fc0646
Compare
| # Trailing slash is required (`Url::join`). Rollback = delete | ||
| # this `env` block. | ||
| uses: gominimal/run-task@a5ed123f612b9774e3d6eaa7af45370e33aa1116 # v1 | ||
| uses: gominimal/run-task@edf3484d540eccbaf1ee4bda10bd913bb474cc47 # v2.0.0 |
There was a problem hiding this comment.
LOW · correctness · confidence 0.55 · in build-smoke
This is a major bump of gominimal/run-task from v1 to v2.0.0. The v2 commit edf3484 changes the executed command from mip run to min task run. The build-smoke job now runs different code, and it uses the channel: unstable input and a remote cache URL. Check that build-smoke still passes and that the inputs still exist in v2. Do not merge on the grouped Dependabot bump alone.
What the reviewer checked
ci.yml:158 uses: gominimal/run-task@edf3484 # v2.0.0 ; PR body: 'Run tasks with min task run instead of mip run (#3)'
Hand this to an agent
Act on a code-review finding.
File: .github/workflows/ci.yml
Lines: 158-158
Category: correctness
Severity: low (reviewer confidence 0.55)
Finding:
This is a major bump of `gominimal/run-task` from v1 to v2.0.0. The v2 commit edf3484 changes the executed command from `mip run` to `min task run`. The build-smoke job now runs different code, and it uses the `channel: unstable` input and a remote cache URL. Check that `build-smoke` still passes and that the inputs still exist in v2. Do not merge on the grouped Dependabot bump alone.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
norrietaylor
left a comment
There was a problem hiding this comment.
Green after the rebase onto #2846. The bumps keep the repo's SHA pins with version comments, and the gominimal/run-task v1 → v2 inputs we pass (task, channel, env) are unchanged. Nit: create-github-app-token is commented # v3 in one place and # v3.3.0 in another.
Bumps the github-actions group with 4 updates in the / directory: taiki-e/install-action, Swatinem/rust-cache, gominimal/run-task and actions/create-github-app-token.
Updates
taiki-e/install-actionfrom 2.87.29 to 2.88.1Release notes
Sourced from taiki-e/install-action's releases.
... (truncated)
Changelog
Sourced from taiki-e/install-action's changelog.
... (truncated)
Commits
68a389cRelease 2.88.1e31c3b8Update wasmtime manifeste30a869Updatewasmtime@latestto 50.0.1bca7759Updatetombi@latestto 1.9.853e7fa7ci: Mark deepsource as glibc_pre_2_34_incompat8f5b3baUpdate wasmtime manifestc6e228dUpdate wasm-pack manifest46c9dcfUpdate wasm-bindgen manifest4136a69Updatevacuum@latestto 0.36.0bf9426fUpdatetombi@latestto 1.9.7Updates
Swatinem/rust-cachefrom 2.9.2 to 2.9.3Release notes
Sourced from Swatinem/rust-cache's releases.
Changelog
Sourced from Swatinem/rust-cache's changelog.
... (truncated)
Commits
d1527c82.9.3f0fca6fupdate dependencies and rebuildb49b17fadd missing awaits6a7bc3eBump the dev-minor group across 1 directory with 2 updates (#383)4ece996Bump the actions group across 1 directory with 6 updates (#392)8103affBump the prd-minor group across 1 directory with 2 updates (#389)0e361f3fix: log rustup toolchain list failure as info instead of warning (#393) (#394)f0d9c38Merge pull request #380 from Swatinem/dependabot/github_actions/actions-8ff58...ccd9742Bump the actions group with 2 updates258712bfix: stop cleanup timestamp pruning after the first entry (#377)Updates
gominimal/run-taskfrom 1 to 2Commits
edf3484Run tasks with min task run instead of mip run (#3)e95aa1afeat(readme): use stable channel in example9658282feat(CI): matrix tests over release channels77f3854ci: add least-privilege permissions to test workflow (#1)Updates
actions/create-github-app-tokenfrom 3.2.0 to 3.3.0Release notes
Sourced from actions/create-github-app-token's releases.
Changelog
Sourced from actions/create-github-app-token's changelog.
Commits
64ab729chore(main): release 3.3.0 (#402)f3a828eci: create signed dist commits in release workflow (#404)655017fdocs: clarify when owner grants access to all repositories (#378)12461a3fix(deps): bump nested undici from 6.24.0 to 6.29.0 (#403)a47236ffeat: update permission inputs (#399)a69c19dfix(deps): bump the production-dependencies group across 1 directory with 3 u...d5cb7aebuild(deps): bump actions/checkout from 6 to 7 (#384)575da86build(deps): bump stefanzweifel/git-auto-commit-action from 7.1.0 to 7.2.0 in...e85f677test: omit stack traces from snapshots (#401)9419396build(deps-dev): bump c8 from 11.0.0 to 12.0.0 (#400)