Skip to content

build(deps): zstd 0.14.3, zstd-safe 8.2.0, zstd-sys 2.1.2, for RUSTSEC-2026-0391, -0398 and -0403 - #2627

Merged
norrietaylor merged 1 commit into
mainfrom
chore/zstd-advisories
Oct 26, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
chore/zstd-advisories

Conversation

@mitodrummer

Copy link
Copy Markdown
Member

Summary

cargo-deny fails its advisories check on RUSTSEC-2026-0391, RUSTSEC-2026-0398 and RUSTSEC-2026-0403, so every merge-queue run is red. This PR runs cargo update -p zstd -p zstd-safe -p zstd-sys. The change is to Cargo.lock only: zstd 0.14.0 → 0.14.3, zstd-safe 8.0.0 → 8.2.0, zstd-sys 2.1.0 → 2.1.2. No other package moves.

Merge to main first. It then needs a cherry-pick to release/0.7.0.

Testing

  • just deny: advisories ok, bans ok, licenses ok, sources ok.
  • cargo test -p common --locked: unit and integration tests pass. common is the only crate that uses zstd directly. The doctests did not run in this sandbox because rustdoc is missing. CI covers them.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

…C-2026-0391, -0398 and -0403

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw
@mitodrummer
mitodrummer requested a review from a team as a code owner October 26, 2026 16:36
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 3928ccf9-827e-474e-a6e0-1b688bcb87bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 99d99b8aa77e.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 26, 2026

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock-only, the three zstd crates and nothing else; cargo deny check advisories is clean with it on anvil too. Approving so the queue goes green again. The cherry-pick to release/0.7.0 after, as you say.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 26, 2026
@mitodrummer
mitodrummer removed this pull request from the merge queue due to a manual request Oct 26, 2026
@mitodrummer
mitodrummer added this pull request to the merge queue Oct 26, 2026
@mitodrummer
mitodrummer removed this pull request from the merge queue due to a manual request Oct 26, 2026
@mitodrummer
mitodrummer added this pull request to the merge queue Oct 26, 2026
@norrietaylor
norrietaylor removed this pull request from the merge queue due to a manual request Oct 26, 2026
@norrietaylor
norrietaylor merged commit 468a859 into main Oct 26, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the chore/zstd-advisories branch October 26, 2026 18:10
mitodrummer added a commit that referenced this pull request Oct 26, 2026
…-bigint, tokio) (#2630)

* build(deps): zstd 0.14.3, zstd-safe 8.2.0, zstd-sys 2.1.2, for RUSTSEC-2026-0391, -0398 and -0403 (#2627)

Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 468a859)

* build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385 (#2503)

* build(deps): ctutils 0.4.5, for RUSTSEC-2026-0385

A new advisory on ctutils 0.4.2 (non-constant-time mask generation and
u128 comparisons; a transitive dependency through p256, ecdsa,
elliptic-curve and crypto-bigint) fails cargo-deny on every pull request
since this morning, so nothing can merge until the lock moves. Patched in
0.4.4; the lock takes 0.4.5. cargo deny check advisories is clean again
and the workspace checks --locked.

* chore(ci): re-run the cla status

(cherry picked from commit c9114e1)

* build(deps): crypto-bigint 0.7.7, for RUSTSEC-2026-0387 (#2517)

(cherry picked from commit 20e25e4)

* build(deps): tokio 1.53.3, for RUSTSEC-2026-0386

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

* fix(minimald): build AsyncFd with tokio's unsafe register

tokio 1.53.3 deprecates AsyncFd::new as unsound (tokio-rs/tokio#8587),
and clippy's -D warnings fails the build on it. Port main's fix from
#2326 to both call sites, the PTY master and the tap device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

* chore(release): bump version to 0.7.2

Hotfix release carrying the zstd, ctutils, crypto-bigint and tokio bumps
(RUSTSEC-2026-0385, -0386, -0387, -0391, -0398, -0403) onto 0.7.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bryan-minimal <bryan@minimal.dev>
Co-authored-by: Norrie Taylor <91171431+norrietaylor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants