Skip to content

build: bump the pkgs locked_commit for the October security fixes - #2637

Merged
bryan-minimal merged 1 commit into
mainfrom
build/pkgs-pin-bd1feab5
Oct 26, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
build/pkgs-pin-bd1feab5

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Summary

Moves the pkgs locked_commit from bd62e6e2 (2026-10-04, #1962) to bd1feab5, the pkgs main HEAD as of 2026-10-26 18:10Z. Both nightlies and stable 0.7.1 still ship the guest image from the 10-04 pkgs commit. That image still trusts the distrusted emSign ECC Root CA - G3, and it carries musl 1.2.6-r2 and OpenSSL 3.5.8.

The range is 257 pkgs commits, all first-parent. I generated this changelog from git log bd62e6e2..bd1feab5 in a clean pkgs worktree and from the merged PR bodies. It names 83 CVE, 41 GHSA and 4 RUSTSEC ids.

Follow-up bump coming: a further guest-rootfs fix is in flight in pkgs. It moves microvm-rootfs's Alpine pin brotli-libs 1.2.0-r1 → 1.2.1-r0 (CVE-2026-111497; the guest's libcurl links brotli) and adds libcurl 8.23.0-r0. bd1feab5 does not contain it. A second pin bump follows once that pkgs PR merges.

What minimal itself ships (guest image, kernel, libkrun)

These are the packages that release.yml materializes from this pin: minvmd-rootfs = microvm-rootfs, virtio-kernel = virtio-kernel-raw, and libkrun.

Change pkgs PR Advisories
microvm-rootfs: ca-certificates-bundle 20260611-r0 → 20261020-r0. This drops emSign ECC Root CA - G3. #947 CVE-2026-111943
microvm-rootfs: musl, musl-utils 1.2.6-r2 → 1.2.6-r3 (regcomp overflows) #993 CVE-2026-107891
microvm-rootfs: libcrypto3/libssl3 3.5.8 → 3.5.9, libexpat 2.8.4 → 2.9.0, nghttp2-libs 1.69.0 → 1.70.0, pcre2 10.48 → 10.49 #933 CVE-2026-102633, CVE-2026-103111, CVE-2026-58055, CVE-2026-77214, CVE-2026-93990
virtio-linux / virtio-kernel-raw 6.12.111 → 6.12.114 #980 none cited (stable-tree update)
libkrun 1.19.4 → 1.19.7, libkrunfw 5.6.1 → 5.6.2 #835, #1018, #1019 none cited

just kernel-review 6.12.111 6.12.114 reports 7 core-subtree commits. The tool flags two of them, both in drivers/virtio: 1eaa83fd94ed "virtio: break and reset virtio devices on device_shutdown()" and 8e360ffa4aa6 "virtio-mmio: Remove virtqueue list from mmio device". The vsock changes are a vmci leak fix and vsock/virtio: account only unread bytes in read_skb(). There are no changes to virtio_console. The KVM and macOS lanes on this PR boot the new kernel.

emSign / eMudhra distrust across pkgs (CVE-2026-111943)

  • System store: ca-certificates rebuilt from the curl 2026-10-20 bundle (#948). Five more packages now declare it: ruby, typst, atuin, gws and skopeo (#957).
  • Runtimes with their own store: node and node-lts (#946), jdk-21/25/27 (#949), python's ensurepip pip 26.2.2 (#950), bun and plannotator (#951), httpie certifi (#952), and chromium-bin through the CADistrustedCertificates policy (#961).
  • These now read the system store: deno and claude-code (#956), and gcloud (#954).
  • rustls-webpki 0.103.16 / webpki-roots 1.0.10 (RUSTSEC-2026-0382, -0383) is locked in about 21 Rust tools: #953, #955, and the later upstream bumps (uv, prek, railway, tealdeer, biome, codex, nickel, nushell).

Other security fixes

Toolchain bumps

rust 1.98.1 → 1.99.0 (#810) · go 1.27.1 → 1.27.3 (#935, #945) · python 3.14.7 → 3.14.9 · node 26.12.1 / node-lts 24.22.1 · ocaml 5.5.1 → 5.5.2 (#1100) · cmake 4.4.2 → 4.4.4 · git 2.55.0 → 2.56.0 · new jdk-21, jdk-25 and jdk-27 (Temurin, #897, #898)

Not in this range: harfbuzz 15.0.0 (GHSA-r62p-jr5f-3mjm, pkgs#1001) is still open.

Stdlib compatibility

The newest pkgs stdlib feature in range is [stdlib] minimum_version = "0.0.18" in pkgs minimal.toml (bd1feab5). minimal's stdlib is 0.0.22 on main and 0.0.21 on 0.7.1. Every attrs key used across pkgs (upstream_version, license_spdx, source_provenance, build_cost_multiple, repology_project, binary_from, env_*, redistributable, closed_source, needed_for_internet) already exists in 0.7.1's attr_classes.ncl. No package declares revision or patches yet (#1277).

Testing

  • pkgs CI on bd1feab5: minimal build, minimal-check ×2, aggregate ×2, dispatch and CodeRabbit all pass.
  • https://cache.minimal.farm/github.com/gominimal/pkgs/bd1feab5….map.json exists. microvm-rootfs, virtio-kernel-raw, libkrun and libkrunfw each return HTTP 200 for amd64 and arm64, so materialize is a cache fetch, not a rebuild. So do the session packages this file declares.
  • The PR lanes test the pin end to end. dogfood and minimal-check evaluate it with the unstable channel. native-daemon-e2e (scripts/session-e2e.sh) seeds the repo's [upstream] pin into the binary this PR builds. ci-linux-kvm and ci-macos boot the new kernel and rootfs.

Merge timing: a push to .minimal/minimal.toml drops every in-flight coder's worktree (agent-runtime#273). Merge this only in a drain window, with no coder job running (same as #1962).

Checklist

  • Docs updated if behavior changed (no behavior change in minimal)
  • BREAKING CHANGE: footer present if this is a breaking change (not breaking)

🤖 Generated with Claude Code

Moves the pkgs locked_commit from bd62e6e2 (2026-10-04) to bd1feab5
(pkgs main, 2026-10-26). The guest image this pin materializes picks up
the emSign ECC Root CA - G3 distrust (CVE-2026-111943, pkgs#947), musl
1.2.6-r3 (CVE-2026-107891, pkgs#993), and OpenSSL 3.5.9, expat 2.9.0,
nghttp2 1.70.0 and pcre2 10.49 (pkgs#933). The guest kernel moves from
6.12.111 to 6.12.114, and libkrun moves to 1.19.7 with libkrunfw 5.6.2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner October 26, 2026 20:15
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 73819126-cbc4-445e-9fc1-e4f87ba634c5
Commits

Reviewing files that changed from the base of the PR and between 4152396 and 3a64117.

Files selected for processing: 1
  • .minimal/minimal.toml

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.

Walkthrough

The upstream commit recorded in .minimal/minimal.toml changes from bd62e6e271b891c48666cc47c13c542a23d14ffb to bd1feab54482457e8a32548f14ffe7f99ecc15b9.

Changes: Upstream revision lock

Layer / File(s) Summary
Update upstream lock
.minimal/minimal.toml
The configured upstream commit changes to a new revision.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

  • gominimal/inbox issue 1165: The issue describes a related upstream-pin path for guest kernel updates, but the provided diff does not identify the contents of the new revision.
  • gominimal/pkgmgr-rs issue 1022: The issue describes certificate-bundle fixes delivered through a pkgs pin, but the provided diff does not establish whether the new revision includes those fixes.

Suggested reviewers: norrietaylor

Merge Risk: Minimal · up to 3a641

No merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "build: bump the pkgs locked_commit for the October security fixes" follows the Conventional Commit format and names the main change: moving the pkgs locked_commit pin. The raw summary confi…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the repository template: it has a Summary section explaining the pin move (bd62e6e2 to bd1feab5), the reason (guest image still trusts the distrusted emSign ECC Root CA - G3, p…
Full details: Title check

Explanation

The title "build: bump the pkgs locked_commit for the October security fixes" follows the Conventional Commit format and names the main change: moving the pkgs locked_commit pin. The raw summary confirms that the only file changed is .minimal/minimal.toml, where locked_commit moves from bd62e6e2 to bd1feab5. "October security fixes" is a reasonable description of the motivation, since the description lists security advisories fixed by the new pin. The title is specific and scannable. It does not name the guest image or kernel bump, but it does not need to cover every detail.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description follows the repository template: it has a Summary section explaining the pin move (bd62e6e2 to bd1feab5), the reason (guest image still trusts the distrusted emSign ECC Root CA - G3, plus musl and OpenSSL versions), and a detailed changelog. It has a Testing section listing CI results, cache checks, and PR lanes. The Checklist is filled in. Gaps: the Summary does not link related issues with Refs or Closes, the PR title is not shown in the provided context so its Conventional Commit form cannot be checked, and the Testing section gives CI status and cache checks but no raw command output as the template asks. The description is thorough and mostly complete, so the check passes.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the revision line,
One old commit gives way to new.
The lock file keeps the change in view,
While carrot crumbs mark each review.
Hop by hop, the update’s through.

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry

minimal-foundry Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 3a64117c36b5.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 26, 2026
@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 26, 2026
bryan-minimal added a commit that referenced this pull request Oct 26, 2026
)

Moves the pkgs locked_commit from bd62e6e2 (2026-10-04) to bd1feab5
(pkgs main, 2026-10-26), the same pin as the main PR #2637, so 0.7.2
ships the current guest image. That image picks up the emSign ECC Root
CA - G3 distrust (CVE-2026-111943, pkgs#947), musl 1.2.6-r3
(CVE-2026-107891, pkgs#993), and OpenSSL 3.5.9, expat 2.9.0, nghttp2
1.70.0 and pcre2 10.49 (pkgs#933). The guest kernel moves from 6.12.111
to 6.12.114, and libkrun moves to 1.19.7 with libkrunfw 5.6.2.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merged via the queue into main with commit edd5d66 Oct 26, 2026
36 checks passed
@bryan-minimal
bryan-minimal deleted the build/pkgs-pin-bd1feab5 branch October 26, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants