Skip to content

T110 — min ls shows each box's address and egress posture, and states the naming surface as activate does - #2777

Merged
norrietaylor merged 22 commits into
mainfrom
agent/2696-min-ls-shows-each-box-s-address-and-egress-postu
Oct 31, 2026
Merged

norrietaylor merged 22 commits into
mainfrom
agent/2696-min-ls-shows-each-box-s-address-and-egress-postu

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

T110 — min ls shows each box's address and egress posture, and states the naming surface as activate does

slice: S17
kind: task
covers: NET-142, NET-146, NET-147
size: L
est: 340 code, 500 tests
executor: agent
difficulty: routine
model: standard
diagnostics: what a person reads is the listing itself: min ls and min ls --json show each box's address and egress posture, and the BOX NAMES row reads as the activate host line does; a box whose address or posture the daemon did not report shows - and its JSON omits the field, never an invented value
observability: the daemon's existing ListSessions trace span records how many boxes it reported with an address and with a posture, so a listing that shows - is visible in the trace
layers:
- listing-reply:
- crates/minimald-rpc/src/lib.rs: the ListSessions reply gains, per box and keyed by its id, the host loopback address its ports answer at (the NET-010 address, the 127.0.0.1 fallback where the range is absent, the node's address for a host-address box) and its effective egress posture in the words min session policy uses; both serde-defaulted so a daemon that predates them reads as unreported
- crates/minimald-rpc/src/tests.rs: round-trips the new reply fields and reads an older reply without them
- crates/minimald/src/rpc.rs: fills the address and posture from each box's record, using the same effective-egress resolution min session policy reads
- crates/minimald/src/rpc/tests.rs: the listing reports a box's address and posture for own-address, host-address and none boxes
test: cargo nextest run -p minimald-rpc list_sessions_reply_carries_box_address_and_posture
test: cargo nextest run -p minimald list_sessions_reports_box_address_and_posture
- min-ls:
- crates/minimal/src/cmd/list.rs: the table gains an ADDRESS column after NAME showing the box's address (127.0.64.2, or 127.0.0.1 where the range is absent, - when unreported); --json carries it per session as "loopback_address": "127.0.64.2"; the EGRESS column prints the posture in min session policy's words (deny-all (default), allow-all (default), deny-all, allow-all, declared rules), and for a host-address box whose rules this host cannot enforce per box it appends ; per-box enforcement none as the policy view does, never per_box or a bare - for a box whose egress is decided; the BOX NAMES row prints through the resolver's one surface statement below
- crates/minimal/src/cmd/boxes/policy.rs: the posture words move into one function that both min session policy and min ls call, so the two surfaces cannot drift
- crates/minimal/tests/cli.rs: builds the listing reply with the new fields wherever it spells the reply in full
- crates/minimal/src/tests.rs: pins the ADDRESS column, the JSON field and the EGRESS words against min session policy's rendering of the same box
test: cargo nextest run -p minimal ls_shows_box_loopback_address
test: cargo nextest run -p minimal ls_egress_matches_session_policy
- naming-surface:
- crates/minimal/src/resolver.rs: one function states how a box name opens on this host, and both host_line_beside (activate) and name_surface_line (min ls) print it; where the box's ports answer at its own address the activate line reads names: web.min.internal opens at its name on this machine; the HTTP proxy at 127.0.0.1:7654 opens it too and the BOX NAMES row reads <box>.min.internal opens at its name on this machine; the HTTP proxy at 127.0.0.1:7654 opens it too; where they answer only at the 127.0.0.1 fallback both read … resolves on this machine; open it through the HTTP proxy at 127.0.0.1:7654; the proxy-only and proxy-not-serving arms keep one wording across both; the finish-setup clause is unchanged
test: cargo nextest run -p minimal ls_name_surface_matches_activate_host_line
test: cargo nextest run -p minimal activate_prints_one_host_line_per_install_state
test: cargo nextest run -p minimal activate_host_line_names_native_dns_when_deployed
test: cargo nextest run -p minimal activate_host_line_carries_finish_setup_clause_while_items_missing
produces: none
consumes: none
proof: min ls shows each box's own address and the same egress posture min session policy shows, min ls --json carries the address, and the BOX NAMES row tells the reader how to open a box in the same words the activate line used.

Proof

min ls now has an ADDRESS column after NAME. It shows each box's own address (for example 127.0.64.2), 127.0.0.1 at the fallback, or - when the daemon did not report one. min ls --json carries the address on each session as "loopback_address". The EGRESS column shows the posture that min session policy shows for the same box (deny-all (default), allow-all (default), deny-all, declared rules), with ; per-box enforcement none for an unenforced host-address box. One resolver function writes both the BOX NAMES row and the activate host line, so they use the same words: <box>.min.internal opens at its name on this machine; the HTTP proxy at 127.0.0.1:<port> opens it too.

Notes from the agent: 1) The spec excerpt does not contain NET-146 or NET-147. I used the task text as the contract for them. 2) scripts/session-e2e.sh lines 9415-9430 (outside the layers) still expect the old BOX NAMES words "resolves through this machine's DNS" and "the hostname proxy also listens on 127.0.0.1:". The task changes that row, so that KVM-lane e2e check will fail until a follow-up updates those two patterns to "opens at its name on this machine" and "; the HTTP proxy at 127.0.0.1:". The spec file docs/specs/18-spec-box-networking also quotes the old row text. 3) The activate host line cannot tell where a single box's ports answer. To pass that fact, create.rs (outside the layers) must change. So host_line_beside reads the own-address form for every native verdict. This is correct because a native verdict already needs the reserved range on this host's loopback. The 127.0.0.1-fallback form (... resolves on this machine; open it through the HTTP proxy at ...) comes from box_name_opens(..., false). min ls uses it when every box address that the daemon reports is 127.0.0.1. 4) The task lists an unmarked allow-all posture. No effective-egress resolution produces one (a declared section that allows everything prints as rows in min session policy), so I did …[truncated]

Tests

line exit tail
cargo nextest run -p minimald-rpc list_sessions_reply_carries_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-a8e7... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimald list_sessions_reports_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-8a4d... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_shows_box_loopback_address 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-f2ba... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_egress_matches_session_policy 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-0718... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal ls_name_surface_matches_activate_host_line 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-5f8a... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_prints_one_host_line_per_install_state 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-e960... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_names_native_dns_when_deployed 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-9fe3... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_carries_finish_setup_clause_while_items_missing 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-69f3... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify

min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

           "parent_span_id": "82e49ebcbec4f2d7",
                "span_id": "013f496b1267df4e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "82e49ebcbec4f2d7",
                "span_id": "204dbf7ec58cd742",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "82e49ebcbec4f2d7",
                "span_id": "d7e76f49c8d5fb40",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "82e49ebcbec4f2d7",
                "queued_behind": "0",
                "span_id": "ec174241818d4f02",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "82e49ebcbec4f2d7",
                "queued_behind": "0",
                "span_id": "0a59799f4ef3939b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "0a59799f4ef3939b",
                "span_id": "0bb7defce6b72b84",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   2.281s] ( 843/2159) minimald box_actor::tests::a_box_nobody_handed_an_address_publishes_at_the_answerers_grant
        PASS [   2.290s] ( 844/2159) minimald box_actor::tests::a_box_re_registered_inside_the_landing_window_keeps_its_grant
        PASS [   2.281s] ( 845/2159) minimald box_actor::tests::a_contended_walk_never_replaces_a_present_verdict
────────────
     Summary [  34.836s] 845/2159 tests run: 844 passed, 1 failed, 24 skipped
        FAIL [   2.896s] ( 842/2159) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
warning: 1314/2159 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Closes #2696

The ListSessions reply gains a map keyed by box id. Each entry carries
the host loopback address the box's ports answer at and its effective
egress posture, resolved the way GetEffectiveSessionPolicy resolves it.
Both fields are serde-defaulted, so an older daemon reads as unreported.
min ls gains an ADDRESS column after NAME, and --json carries each
box's loopback_address. The EGRESS column prints the posture in the
words min session policy uses, from one shared function, with the
per-box enforcement note for an unenforced host-address box.

The activate host line and the BOX NAMES row now state how a box name
opens through one resolver function, so the two verbs use the same
words in every arm.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5fbcdcb4-2d9a-469a-9d85-db3382a10225

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at 11d3691f1363.

@norrietaylor resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 31, 2026

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 3 conditions · the full ruling

The daemon, wire and listing code conform to §7.1 lines 259-264. The address and the posture come from the owners the design names. Three text surfaces still carry the old naming words. The KVM e2e at scripts/session-e2e.sh lines 9416 and 9424 will fail, and the PR says so. Fix it in C1. The spec on main does not contain NET-146 or NET-147, and its NET-142 requires the old min ls row. Land the amendment in C2. Update the CLI reference in C3.

Outside the diff

  • scripts/session-e2e.sh:9416: C1 · This pattern pins the old BOX NAMES words. After this change the row says opens at its name on this machine. Change this pattern and the one at line 9424 to the new words. Otherwise the KVM lane fails.
  • docs/specs/18-spec-box-networking/18-spec-box-networking.md:262: C2 · On main, this requirement says min ls keeps its old row wording, and this change rewrites the row. Merge b15f1883 first, or bring its NET-142, NET-146 and NET-147 hunks into this PR.
  • docs/reference/cli-min.md:549: C3 · This quote is the old native clause. The next sentence says a browser opens the box only through the proxy. Replace both with the new behaviour: the box opens at its name, and the proxy opens it too.

Ruled at ac34f0a against gominimal/arch@8640f85e193d by claude-opus-5-5.

Comment thread crates/minimal/src/resolver.rs Resolved
activate and the min ls BOX NAMES row now say a box name opens at its
name on this machine, and name the HTTP proxy that opens it too. The
native-daemon e2e still grepped for the old phrases.
The negative checks looked for the old phrases, so the new own-address
wording would pass them. They now refuse any 'on this machine' claim.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/list.rs Resolved
@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Oct 31, 2026

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The listing work is in the right crates, and the address and posture follow §7.1 lines 259-261. Two items remain. C1: the spec on main still quotes the old NET-142 wording at lines 254 and 262, and NET-146 and NET-147 do not exist there. Land the text from b15f1883 first, or carry it in this PR. C2: boxes_at_own_address() treats every 127.0.0.1 as the fallback. Section 7.1 line 261 makes 127.0.0.1 a host-address box's real address on a native node. Report the fallback as a field from the daemon, and read the fallback form when any box is at the fallback.

Ruled at a151f39 against gominimal/arch@8640f85e193d by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/list.rs Resolved
Comment thread crates/minimald-rpc/src/lib.rs Resolved
Comment thread crates/minimald/src/rpc.rs Resolved
Comment thread crates/minimal/src/resolver.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a failed check suite, pushed as a151f393b3f7.

line exit tail
cargo nextest run -p minimald-rpc list_sessions_reply_carries_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-a731... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimald list_sessions_reports_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-36c9... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_shows_box_loopback_address 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-abb4... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_egress_matches_session_policy 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-0a55... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal ls_name_surface_matches_activate_host_line 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-efa3... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling mlog v0.0.1 (/workbench/crates/mlog) Compiling minimal-clie
cargo nextest run -p minimal activate_prints_one_host_line_per_install_state 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-d422... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_names_native_dns_when_deployed 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-f445... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_carries_finish_setup_clause_while_items_missing 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-3220... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

           "parent_span_id": "e5b2ee2196b517d7",
                "span_id": "c36e2e822a65ef8a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "e5b2ee2196b517d7",
                "span_id": "4cd23826d09abdcc",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "e5b2ee2196b517d7",
                "span_id": "e9c46e49573c66ee",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "e5b2ee2196b517d7",
                "queued_behind": "0",
                "span_id": "01ee5418f3ed3919",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "e5b2ee2196b517d7",
                "queued_behind": "0",
                "span_id": "f345b7e9cf408d6e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "f345b7e9cf408d6e",
                "span_id": "bbcc82ab3cc194ef",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   2.286s] ( 843/2159) minimald box_actor::tests::a_box_nobody_handed_an_address_publishes_at_the_answerers_grant
        PASS [   2.258s] ( 844/2159) minimald box_actor::tests::a_contended_walk_never_replaces_a_present_verdict
        PASS [   2.301s] ( 845/2159) minimald box_actor::tests::a_box_re_registered_inside_the_landing_window_keeps_its_grant
────────────
     Summary [  35.156s] 845/2159 tests run: 844 passed, 1 failed, 24 skipped
        FAIL [   2.877s] ( 842/2159) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
warning: 1314/2159 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Outside the task's layers::

  • scripts/session-e2e.sh

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/resolver.rs:5077: The wording stays as the task fixes it. The session-e2e.sh patterns that pinned the old text (the activate grep after the range step, the second box's activate grep and case, and the BOX NAMES row cases) now match the new string.

min ls shows each box's own address in an ADDRESS column and the same egress posture words that min session policy shows. min ls --json carries loopback_address. The BOX NAMES row and the activate host line state how a box name opens in the same words. The native-daemon e2e now checks for those words and no longer checks for the old ones.

Notes from the agent: Revise round 1. native-daemon-e2e failed because scripts/session-e2e.sh still grepped for the old wording: 'resolves on this machine' on the activate line, and 'resolves through this machine's DNS' and 'the hostname proxy also listens on 127.0.0.1:' on the BOX NAMES row. ci-linux-native-success is the aggregator and failed only because of that job. scripts/session-e2e.sh is OUTSIDE the task's layers. I changed it because the task changes text that it pins. The patterns now accept the own-address form and the 127.0.0.1-fallback form, and the BOX NAMES check looks for 'the HTTP proxy at 127.0.0.1:'. I did not run the e2e on this box. Its lane must prove it. In crates/minimal/tests/cli.rs, two negative checks looked for the old phrases. The new own-address wording passed them without effect, so they now refuse any 'on this machine' claim. Spec drift: NET-142's native-DNS sub-requirement still quotes 'names: .min.internal resolves on this machine; open it through the HTTP proxy at 127.0.0.1:' for every native host. The task fixes the own-address wording 'opens at its name on this machine; the HTTP proxy at 127.0.0.1: opens it too', and the code follows the task. The spec quote must change in follow-up work.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 31, 2026 05:18
@norrietaylor

Copy link
Copy Markdown
Member

/revise

native-daemon-e2e still fails on head a151f39 (run 41171014324, job 124448805811):

NET-074 OK: the bare box's external name fails fast at resolution and host.min.internal resolves
##[error]session gone after answering the exit prompt with 'keep'

main's native lane is green on its last five runs (642b738 back to b0e9263), so this comes from the branch. The branch changes the activate host line and the min ls rows. Check every string scripts/session-e2e.sh and scripts/e2e-attach-pty.py match while they drive the exit prompt and the 'keep' answer, and the box state they read afterwards from min ls (the new ADDRESS column shifts the columns a parser may index). Fix the code or the harness's matcher so the box survives 'keep', and run that e2e case before you push.

The daemon now marks a listed box at_fallback when it stands on the
127.0.0.1 fallback. A host-address box at the node address is not at
the fallback. min ls reads the fallback form when any box reports it,
so a mixed listing no longer claims every name opens at its name.
grep -q under pipefail can SIGPIPE min ls and read as a gone session.
On a miss the check now prints the listing, its exit status and stderr,
and the attach transcript, so the next failure names its cause.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as edefaf74e980.

line exit tail
cargo nextest run -p minimald-rpc list_sessions_reply_carries_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-c33f... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimald list_sessions_reports_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-995d... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_shows_box_loopback_address 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-7190... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_egress_matches_session_policy 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-979d... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal ls_name_surface_matches_activate_host_line 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-1ebd... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_prints_one_host_line_per_install_state 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-c7b3... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_names_native_dns_when_deployed 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-5347... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_carries_finish_setup_clause_while_items_missing 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-7125... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify timed out after 1800s.

g common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 47.08s
   Compiling opentelemetry v0.33.1
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling rusty-fork v0.3.1
   Compiling serial_test v4.0.1
   Compiling proptest v1.12.0
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • scripts/session-e2e.sh

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/list.rs:954: boxes_at_own_address now returns false when any box reports at_fallback true, so a mixed listing reads the fallback form. A host-address box at 127.0.0.1 no longer flips the row. Pinned by ls_shows_box_loopback_address_names_row_follows_any_fallback_box.
  • 👍 valid — crates/minimal/src/cmd/list.rs:949: boxes_at_own_address now returns false when any box reports at_fallback == Some(true), and true otherwise, as asked. A 127.0.0.1 address alone no longer counts as the fallback.
  • 👍 valid — crates/minimald-rpc/src/lib.rs:369: Added BoxNetworkFacts.at_fallback: Option, serde-defaulted and omitted when None. The round-trip test pins it on the wire.
  • 👍 valid — crates/minimald/src/rpc.rs:258: box_network_facts sets at_fallback to Some(false) for a HostNet box and Some(address == 127.0.0.1) for an own-address or none box that has an address. The daemon test now puts the none box at 127.0.0.1 and expects Some(true).
  • 👎 invalid — crates/minimal/src/resolver.rs:5077: The spec text is out of date, but the fix is outside this task's layers. It needs a change to the NET-142/146/147 text in the spec document, which this task does not touch. The task fixes this exact wording for the activate line and the BOX NAMES row, so the code keeps it. Carry the spec text from b

min ls shows each box's own address in an ADDRESS column and the same egress posture words min session policy prints. min ls --json carries loopback_address on each session. The BOX NAMES row uses the same words as the activate host line, and it now uses the fallback form ('resolves on this machine; open it through the HTTP proxy at ...') when any listed box is on the 127.0.0.1 fallback. A host-address box at 127.0.0.1 keeps the own-address form.

Notes from the agent: native-daemon-e2e: I could not run the hooks case here, and I did not find a proven root cause. This host has no /sys and no cgroup filesystem, and the sandbox's read-only remount of /etc fails with EPERM, so every box exits at launch (./scripts/session-e2e.sh hooks fails at activate, before the attach). Code reading: the pty driver matches only the exit-prompt and publish-ask strings, which this branch does not change. The failing check reads min ls --raw, and the branch does not change the --raw output or any activate stdout. The CI index tail still names the hook box, so the box probably survived and the listing check failed. In scripts/session-e2e.sh (outside the layers, as the directive asked for the harness), the check now captures min ls --raw before it matches, in place of mnl ls --raw | grep -q. The script itself warns that this pattern can SIGPIPE the CLI under pipefail. On a miss the check prints the listing, its exit status and stderr, and the attach transcript. If the lane still fails, that output names the cause. The lane must still run this case to prove it. Threads: I added BoxNetworkFacts.at_fallback (serde-defaulted, omitted when None). The daemon sets Some(false) for a host-address box and Some(address == 127.0.0.1) for the other boxes. min ls reads the fallback form when any box reports at_fallback true. The --json document does not carry at_fallback. The spec wording conflict (thread on resolver.rs) needs a change in the spec document, which is outs…[truncated]

@norrietaylor
norrietaylor marked this pull request as ready for review October 31, 2026 06:48

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of head edefaf7 against T110's plan block (#2696).

Blocking

  1. The min ls address assertion the epic owner carried here from #2749 (comment on #2696) is not restored. fresh_install_range_lands_on_macos in scripts/session-e2e.sh still ends after the two HTTP checks: no mnl ls | grep -qF -- "$frm_addr", no header bullet, and the OK line does not mention min ls. A min ls that prints - or 127.0.0.1 for a box the zone answers at 127.0.64.x keeps the macOS lane green.
  2. crates/minimal/src/resolver.rs:5048 calls box_name_opens(&name, surface, proxy_port, true) with at_own_address hard-coded, so the activate host line never prints the fallback form. With native DNS live and a box on the 127.0.0.1 interim, activate prints web.min.internal opens at its name on this machine; … while min ls (which reads each box's report) prints <box>.min.internal resolves on this machine; open it through …: the drift the task's proof forbids. ls_name_surface_matches_activate_host_line compares only the true arm; make it cover both.

Non-blocking

  1. docs/reference/cli-min.md:44-66 (session list) does not document the ADDRESS column, the EGRESS posture words, or the --json keys loopback_address and egress_posture.
  2. scripts/session-e2e.sh:7833, :9330, :9427-9428 accept either wording, so a native-range box regressing to the fallback form passes. Pin the form each state requires.
  3. The posture words live in two places: egress_posture_words (crates/minimal/src/cmd/boxes/policy.rs:83) for min session policy and min ls, and EffectiveEgress::summary_label() (crates/boxes/src/lib.rs:518) for min dash (dash/render.rs:532). Route the dashboard through the same function.

Checked: the listing reply's serde defaults and old-reply test, box_network_facts posture through the same path as min session policy, the ADDRESS column and --json placement for single- and multi-VM listings, every posture mode, the round-2 harness fix (legitimate: capture then grep -F under pipefail), and the new user-facing strings.

@norrietaylor

Copy link
Copy Markdown
Member

/revise

Fix the blocking findings in the review on edefaf7, and findings 3–5 as they fall inside the layers:

  1. The min ls address assertion the epic owner carried here from fix(minimald): move a box's forward to its range address when the range lands present #2749 (comment on T110 — min ls shows each box's address and egress posture, and states the naming surface as activate does #2696) is not restored. fresh_install_range_lands_on_macos in scripts/session-e2e.sh still ends after the two HTTP checks: no mnl ls | grep -qF -- "$frm_addr", no header bullet, and the OK line does not mention min ls. A min ls that prints - or 127.0.0.1 for a box the zone answers at 127.0.64.x keeps the macOS lane green.
  2. crates/minimal/src/resolver.rs:5048 calls box_name_opens(&name, surface, proxy_port, true) with at_own_address hard-coded, so the activate host line never prints the fallback form. With native DNS live and a box on the 127.0.0.1 interim, activate prints web.min.internal opens at its name on this machine; … while min ls (which reads each box's report) prints <box>.min.internal resolves on this machine; open it through …: the drift the task's proof forbids. ls_name_surface_matches_activate_host_line compares only the true arm; make it cover both.

Non-blocking

  1. docs/reference/cli-min.md:44-66 (session list) does not document the ADDRESS column, the EGRESS posture words, or the --json keys loopback_address and egress_posture.
  2. scripts/session-e2e.sh:7833, :9330, :9427-9428 accept either wording, so a native-range box regressing to the fallback form passes. Pin the form each state requires.
  3. The posture words live in two places: egress_posture_words (crates/minimal/src/cmd/boxes/policy.rs:83) for min session policy and min ls, and EffectiveEgress::summary_label() (crates/boxes/src/lib.rs:518) for min dash (dash/render.rs:532). Route the dashboard through the same function.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #2696. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/list.rs Resolved
Comment thread crates/minimal/src/resolver.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The change now reads the fallback form when any listed box is at the fallback. That fixes the mixed-listing claim. One code gap remains. In a microVM, box_network_facts reports 127.0.0.1 for a host-address box before the node's address is granted. Section 7.1 line 263 says such a box is never mirrored onto 127.0.0.1. Make the change in C1. The spec at NET-142 (lines 254 and 262) and docs/reference/cli-min.md still state the old wording. Amend them as C2 says.

Ruled at edefaf7 against gominimal/arch@8640f85e193d by claude-opus-5-5.

Comment thread crates/minimald/src/rpc.rs Resolved
Comment thread crates/minimal/src/resolver.rs Resolved
@norrietaylor

Copy link
Copy Markdown
Member

/revise

Arch review on edefaf7 (CONDITIONS), C2, for the same round as the review above:

docs/reference/cli-min.md:546-552 quotes the old native host line. Replace it with the two native forms: own address opens at its name on this machine; the HTTP proxy at 127.0.0.1:<port> opens it too, and the 127.0.0.1 fallback's resolve-and-proxy form. Delete "A browser opens the box through the hostname proxy, which keeps serving."; design §7.1 line 263 says a browser opens the box by name.

C1 (the spec's NET-142 text) waits on a decision about #2679; do not change the spec in this round.

The BOX NAMES row reads the own-address form only when a box reports it
is off the fallback. A withheld host-address box reads as the fallback,
and the activate line follows the interim flag for every network mode.
@github-actions

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/18-spec-box-networking/18-spec-box-networking.md — 10 finding(s)

docs/specs/18-spec-box-networking/18-spec-box-networking.md:159: P004 NET-009 names test 'native_resolution_without_proxy_env', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:344: P004 NET-040 names test 'fresh_install_own_ip_ingress_publishes_loopback', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:349: P004 NET-041 names test 'installer_switch_binary_executable', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:387: P004 NET-048 names test 'linux_amd64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:392: P004 NET-049 names test 'fresh_linux_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:397: P004 NET-050 names test 'linux_arm64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:402: P004 NET-051 names test 'fresh_arm64_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:762: P004 NET-132 names test 'proxy_sees_each_vm_box_by_its_switch_address', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:788: P004 NET-134 names test 'deny_all_box_reaches_proxy_and_no_other_host_port', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:812: P004 NET-107 names test 'session_outbound_request', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@fb5932b8, spec format: How Minimal Writes Specs.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a /revise note, pushed as a66544c8458f.

line exit tail
cargo nextest run -p minimald-rpc list_sessions_reply_carries_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-d5a7... Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling paths v0.0.1 (/workbench/crates/paths) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimald list_sessions_reports_box_address_and_posture 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-f028... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_shows_box_loopback_address 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-d075... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_egress_matches_session_policy 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-7915... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal ls_name_surface_matches_activate_host_line 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-9224... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_prints_one_host_line_per_install_state 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-8f52... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_names_native_dns_when_deployed 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-c143... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_carries_finish_setup_clause_while_items_missing 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-3dd1... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

           "parent_span_id": "7101ee26fce860ef",
                "span_id": "e19cd3a4196b09ab",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "7101ee26fce860ef",
                "span_id": "24fc0ff084cd25fe",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "7101ee26fce860ef",
                "span_id": "23ddd1477e1bd1da",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "7101ee26fce860ef",
                "queued_behind": "0",
                "span_id": "025d440c1c365d89",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "7101ee26fce860ef",
                "queued_behind": "0",
                "span_id": "f6954eb11f9a9d63",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "f6954eb11f9a9d63",
                "span_id": "2414e23000e3602b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   2.241s] ( 845/2161) minimald box_actor::tests::a_contended_walk_never_replaces_a_present_verdict
        PASS [   2.268s] ( 846/2161) minimald box_actor::tests::a_box_re_registered_inside_the_landing_window_keeps_its_grant
        PASS [   2.291s] ( 847/2161) minimald box_actor::tests::a_box_nobody_handed_an_address_publishes_at_the_answerers_grant
────────────
     Summary [  33.726s] 847/2161 tests run: 846 passed, 1 failed, 24 skipped
        FAIL [   2.841s] ( 844/2161) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
warning: 1314/2161 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/create.rs
  • scripts/session-e2e.sh

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/list.rs:957: boxes_at_own_address now returns true only when at least one box reports at_fallback == Some(false) and none reports Some(true). An older daemon or an empty listing reads the proxy form. Pinned in ls_shows_box_loopback_address_names_row_follows_any_fallback_box.
  • 👍 valid — crates/minimal/src/cmd/boxes/create.rs: The activate line now uses !created.interim_loopback for every mode, HostNet included. The client cannot tell a VM-backed daemon apart, and on a native node the interim flag means the range is absent, so the native arm does not apply there anyway.
  • 👍 valid — crates/minimald/src/rpc.rs: New box_at_fallback in minimald rpc.rs returns Some(true) for a host-address box whose address host_address_loopback withholds, so the BOX NAMES row reads the proxy form. Pinned in list_sessions_reports_box_address_and_posture.
  • 👍 valid — docs/reference/cli-min.md: Spec 18 NET-142 now carries the b15f188 text. It no longer quotes one form, and it says the line states whether the box opens at its name or through the proxy. cli-min.md is restored to main here because T125 (T125 — The CLI reference describes min ls and the activate host line as they print #2796) owns it.

min ls shows each box's own address in the ADDRESS column, and the EGRESS column uses the same posture words as min session policy. min ls --json carries loopback_address. The BOX NAMES row and the activate host line use the same words. Both read the own-address form only when the box is proved to be off the 127.0.0.1 fallback. In every other case, both read the proxy form.

Notes from the agent: Revise round 4. Directive items: (1) The min ls address assertion in fresh_install_range_lands_on_macos was already on the branch (commit 9c45075). It uses capture-then-match on the box's row, not a bare pipe into grep -q, because an early grep exit can SIGPIPE the CLI under pipefail. (2) Already on the branch in fa465cb. This round also drops the HostNet override, so the activate line follows interim_loopback for every network mode. (3) NET-142 and its sub-requirements now carry the b15f188 text, and NET-146 and NET-147 are added. No other hunk is in the change. I was not able to run just lint-prose because vale is not installed on this box. (4) scripts/session-e2e.sh now pins the own-address form at the range-step check, at the second box's activate line, and at the BOX NAMES row. Each of these cases has the range present and boxes at their own leased addresses. (5) Out of scope: crates/minimal/src/dash/render.rs is not in the layers, so min dash still has its own posture words and does not use egress_posture_words. Scope: create.rs and session-e2e.sh are outside the layers. Earlier rounds touched them, and the directive items 2 and 4 require them. docs/reference/cli-min.md is restored to main, because T125 (#2796) owns it, so the branch no longer changes it. I did not identify the failed ci-linux-native-success check, because the log excerpt shows no cause. The listing tests and the whole minimal suite pass here. The scripts/session-e2e.sh changes were checked with bash -n only. The e2e lanes did not run on this box.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a /revise note: the coder changed nothing. noop: this round's note is against head 0a46a2c. The commits after that head (834a370, f17fa99, b9136ef, 0c69610) already address items 1-4, and I found nothing more to change. (1) fresh_install_range_lands_on_macos in scripts/session-e2e.sh runs mnl ls after the two HTTP checks, matches " $frm_addr " on the box row, and its OK line names min ls. (2) create.rs passes at_own_address = !created.interim_loopback to host_line_beside. No production caller hard-codes true. Only the test helper host_line does. ls_name_surface_matches_activate_host_line loops at_own_address over [true, false] and pins both forms for the row and for the activate line. (3) The spec diff against main adds only lines that b15f188 also adds: NET-142 and its sub-requirements, NET-146 and NET-147. A comm check of the added lines found no line outside b15f188. I could not run just lint-prose on the file because vale is not installed on this box. (4) At the old :7833, :9330 and :9427 the …[truncated]

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review of a66544c against T110 (#2696). Each item of the last /revise is closed:

  • The min ls address assertion is back in fresh_install_range_lands_on_macos.
  • The activate host line follows the interim flag for every network mode. A withheld host-address box reads as the fallback (box_at_fallback), and min ls reads the own-address form only when a box proves it.
  • The spec carries only the NET-142, NET-146 and NET-147 hunks.
  • The e2e pins the wording that each state requires.
  • minimald-root-integration is green on this head.

Every lane aggregator is green. The PR no longer changes docs/reference/cli-min.md, so T125 (#2796) still owns that page.

@norrietaylor
norrietaylor marked this pull request as ready for review October 31, 2026 16:05

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to NET design §7.1. Each box reports the address its ports answer at, and a VM node's host-address box reports none until the node gets its address, as line 263 says. The BOX NAMES row and the activate line now read the own-address form only when a box proves it. Otherwise they read the proxy form. The spec amendment and the stricter e2e checks are in this head. Separately, docs/reference/cli-min.md still quotes the old host line. File an issue for it, because the PR names T125 but links no issue.

Ruled at a66544c against gominimal/arch@8640f85e193d by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/resolver.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This push merges main and corrects one doc comment. The merge has no conflict resolution, and its changes do not touch the listing or the host line. The new comment on name_surface_line_at now matches boxes_at_own_address. A listing that does not prove an own address reads the fallback form, as §7.1 line 259 requires. The PASS on a66544c8 stands for this head.

Ruled at 11d3691 against gominimal/arch@8640f85e193d by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 11 unresolved threads — minimal-arch[bot] crates/minimal/src/resolver.rs:5080, minimal-arch[bot] crates/minimal/src/cmd/list.rs:950, minimal-arch[bot] crates/minimald-rpc/src/lib.rs:369, minimal-arch[bot] crates/minimald/src/rpc.rs:284, minimal-arch[bot] crates/minimal/src/resolver.rs:5080, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review of 11d3691. It is a clean merge of main plus a doc-comment fix on name_surface_line_at: a listing that proves no box at its own address passes false. That matches boxes_at_own_address. Nothing else changed since my approval of a66544c.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on the runtime's review findings, pushed as 11d3691f1363.

line exit tail
cargo nextest run -p minimald-rpc list_sessions_reply_carries_box_address_and_posture 0 .2 Compiling hyper v1.11.0 Compiling sha2 v0.11.1 Compiling hashbrown v0.16.1 Compiling unicode-xid v0.2.6 Compiling hyper-util v0.1.20 Compiling crossbeam-epoch v0.9.20 Compiling lalrpop v0.23.1 Compiling malachite-base v0.9.2 Compiling rand_chacha v0.9.0 Compiling hyp
cargo nextest run -p minimald list_sessions_reports_box_address_and_posture 0 s v0.1.1 Compiling xattr v1.6.1 Compiling tonic-prost v0.14.6 Compiling google-cloud-auth v1.17.0 Compiling jaq-all v0.3.0 Compiling tar v0.4.46 Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/workbe
cargo nextest run -p minimal ls_shows_box_loopback_address 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-42aa... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal ls_egress_matches_session_policy 0 Applying loadouts: default Running task runtime-implement-test-3 in session task-runtime-implement-test-3-1c42... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal ls_name_surface_matches_activate_host_line 0 Applying loadouts: default Running task runtime-implement-test-4 in session task-runtime-implement-test-4-e92c... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_prints_one_host_line_per_install_state 0 Applying loadouts: default Running task runtime-implement-test-5 in session task-runtime-implement-test-5-3f26... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_names_native_dns_when_deployed 0 Applying loadouts: default Running task runtime-implement-test-6 in session task-runtime-implement-test-6-72a5... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal activate_host_line_carries_finish_setup_clause_while_items_missing 0 Applying loadouts: default Running task runtime-implement-test-7 in session task-runtime-implement-test-7-0000... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

           "parent_span_id": "4ac3dd218b3e19ed",
                "span_id": "659db162ae400b34",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "4ac3dd218b3e19ed",
                "span_id": "3f290910df36d021",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "4ac3dd218b3e19ed",
                "span_id": "6e2425778a05beed",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "4ac3dd218b3e19ed",
                "queued_behind": "0",
                "span_id": "fe72045884aa8eeb",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "4ac3dd218b3e19ed",
                "queued_behind": "0",
                "span_id": "f8052eb003f002d6",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "f8052eb003f002d6",
                "span_id": "0736f165ac1e4ea5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   2.288s] ( 847/2163) minimald box_actor::tests::a_box_nobody_handed_an_address_publishes_at_the_answerers_grant
        PASS [   2.344s] ( 848/2163) minimald box_actor::tests::a_contended_walk_never_replaces_a_present_verdict
        PASS [   2.350s] ( 849/2163) minimald box_actor::tests::a_box_re_registered_inside_the_landing_window_keeps_its_grant
────────────
     Summary [  36.314s] 849/2163 tests run: 848 passed, 1 failed, 24 skipped
        FAIL [   3.000s] ( 846/2163) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
warning: 1314/2163 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/create.rs
  • scripts/session-e2e.sh

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/resolver.rs:5188: Rewrote the name_surface_line_at doc: a listing with no fallback fact passes false and reads the fallback form, as boxes_at_own_address does. Only name_surface_line defaults to own-address.

min ls shows each box's own address and the same egress posture that min session policy shows. min ls --json carries the address as loopback_address. The BOX NAMES row tells the reader how to open a box in the same words as the activate host line. This round changes only a doc comment, so the proof from earlier rounds is unchanged.

Notes from the agent: Revise round 6 changes only the doc comment on name_surface_line_at. It now says that a listing passes true only when a box proves its own address and no box reports the fallback, and that a listing with no fallback fact passes false. This round did not run the two listing-reply test lines (minimald-rpc, minimald), because this round does not touch those crates.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft October 31, 2026 16:32

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 11d3691f1363 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 31, 2026
@norrietaylor
norrietaylor marked this pull request as ready for review October 31, 2026 17:10
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 08045bf Oct 31, 2026
37 checks passed
@norrietaylor
norrietaylor deleted the agent/2696-min-ls-shows-each-box-s-address-and-egress-postu branch October 31, 2026 18:00
norrietaylor pushed a commit that referenced this pull request Nov 4, 2026
…2777)

The ListSessions reply gains a map keyed by box id with the host loopback address the box's
ports answer at, its effective egress posture, and whether it stands on the 127.0.0.1 fallback.
All three are serde-defaulted, so an older daemon reads as unreported. min ls gains an ADDRESS
column and --json carries the same facts. The EGRESS column prints the posture in the words min
session policy uses, from one shared function, and the activate host line and the BOX NAMES row
state how a box name opens through one resolver function. A VM node's host-address box reports
no address until the node is granted one, since it is never mirrored onto 127.0.0.1.

Backport of #2777. Adapted to the line: the policy.rs and create.rs hunks land in
cmd/session.rs, and the minimald-rpc and minimald rpc tests land inline in lib.rs and rpc.rs,
with the line's names (SessionStatus, EffectiveSessionPolicy, a built CreateSessionRequest).

(cherry picked from commit 08045bf)
norrietaylor pushed a commit that referenced this pull request Nov 5, 2026
…2777)

The ListSessions reply gains a map keyed by box id with the host loopback address the box's
ports answer at, its effective egress posture, and whether it stands on the 127.0.0.1 fallback.
All three are serde-defaulted, so an older daemon reads as unreported. min ls gains an ADDRESS
column and --json carries the same facts. The EGRESS column prints the posture in the words min
session policy uses, from one shared function, and the activate host line and the BOX NAMES row
state how a box name opens through one resolver function. A VM node's host-address box reports
no address until the node is granted one, since it is never mirrored onto 127.0.0.1.

Backport of #2777. Adapted to the line: the policy.rs and create.rs hunks land in
cmd/session.rs, and the minimald-rpc and minimald rpc tests land inline in lib.rs and rpc.rs,
with the line's names (SessionStatus, EffectiveSessionPolicy, a built CreateSessionRequest).

(cherry picked from commit 08045bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T110 — min ls shows each box's address and egress posture, and states the naming surface as activate does

1 participant