Repository navigation
T108 — Say in control.rs that bep serve sets the client-key bound - #2788
norrietaylor merged 1 commit into
Conversation
The doc of Control::bind_with_key_bound now says bep serve calls it with the value of --max-client-keys, in place of the stale fixed-default note.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The design of record says nothing about the client-key bound or --max-client-keys, so this is a PASS by absence. The new doc sentence is true at this head. ServeArgs::key_bound() reads --max-client-keys, and bep serve passes that bound to Control::bind_with_key_bound. The module doc at lines 150-152 already names the flag, so no stale sentence remains. There are no conditions.
Ruled at 5febaec against gominimal/arch@8640f85e193d by claude-opus-5-5.
|
Approved: no findings at Nothing to do. Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it. Clobber: none. |
norrietaylor
left a comment
There was a problem hiding this comment.
Reviewed at 5febaec against T108's plan block. The doc of Control::bind_with_key_bound now says bep serve calls it with the value of --max-client-keys. That is true at this head: crates/bep/src/main.rs:1164 calls it with the bound ServeArgs builds from --max-client-keys (line 131). The stale sentence is gone. No code change, so the plan's test line the_registry_never_holds_more_keys_than_its_bound is unaffected. No findings.
T108 — Say in control.rs that bep serve sets the client-key bound
slice: S15
kind: task
covers: BEP-063
size: S
est: 5 code, 60 tests
executor: agent
difficulty: routine
model: light
diagnostics: none: the task changes a doc comment, so nothing prints anything new.
observability: none: the task changes a doc comment, so no trace, metric or log line changes.
layers:
- docs:
- crates/bep/src/control.rs: the doc of
Control::bind_with_key_boundsaysbep servecalls it with the value of--max-client-keys, in place of "The proxy binary does not call it, so its bound is the fixed default." (#2598)test: cargo nextest run -p bep the_registry_never_holds_more_keys_than_its_bound
produces: none
consumes: none
proof: The control socket's docs say that bep serve sets the client-key bound with --max-client-keys.
depends on:
- blocked by #2579
- assumes OQ3 (the mint reads the root certificate's own expiry, and the root is generated with a fixed default validity in one constant that gominimal/arch#85's ruling replaces)
Original issue text
Residual from T69 #2593, arch C1 (ruling), epic #1501.
#2593 adds
bep serve --max-client-keys, which passes aKeyBoundtoControl::bind_with_key_bound. Two doc comments incrates/bep/src/control.rsstill say the proxy binary has no setting for the bound.What closes this
Control::bind_with_key_boundsets another bound.") saysbep servesets the count with--max-client-keys.Control::bind_with_key_bounddoc (around lines 1044-1045: "The proxy binary does not call it, so its bound is the fixed default.") saysbep servecalls it with the flag's value.Generated by Claude Code
Proof
The doc of Control::bind_with_key_bound in crates/bep/src/control.rs now says that bep serve calls it with the value of --max-client-keys. The old sentence about a fixed default is gone.
Tests
cargo nextest run -p bep the_registry_never_holds_more_keys_than_its_boundVerify
min task run agent-verifypassed ([tasks.verify]).Closes #2598