Skip to content

T108 — Say in control.rs that bep serve sets the client-key bound - #2788

Merged
norrietaylor merged 1 commit into
mainfrom
agent/2598-say-in-control-rs-that-bep-serve-sets-the-client
Oct 31, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
agent/2598-say-in-control-rs-that-bep-serve-sets-the-client

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

T108 — Say in control.rs that bep serve sets the client-key bound

slice: S15
kind: task
covers: BEP-063
size: S
est: 5 code, 60 tests
executor: agent
difficulty: routine
model: light
diagnostics: none: the task changes a doc comment, so nothing prints anything new.
observability: none: the task changes a doc comment, so no trace, metric or log line changes.
layers:
- docs:
- crates/bep/src/control.rs: the doc of Control::bind_with_key_bound says bep serve calls it with the value of --max-client-keys, in place of "The proxy binary does not call it, so its bound is the fixed default." (#2598)
test: cargo nextest run -p bep the_registry_never_holds_more_keys_than_its_bound
produces: none
consumes: none
proof: The control socket's docs say that bep serve sets the client-key bound with --max-client-keys.
depends on:
- blocked by #2579
- assumes OQ3 (the mint reads the root certificate's own expiry, and the root is generated with a fixed default validity in one constant that gominimal/arch#85's ruling replaces)

Original issue text

Residual from T69 #2593, arch C1 (ruling), epic #1501.

#2593 adds bep serve --max-client-keys, which passes a KeyBound to Control::bind_with_key_bound. Two doc comments in crates/bep/src/control.rs still say the proxy binary has no setting for the bound.

What closes this

  • The module doc (around lines 101-103: "The proxy binary has no setting for the bound ... Only an embedder that calls Control::bind_with_key_bound sets another bound.") says bep serve sets the count with --max-client-keys.
  • The Control::bind_with_key_bound doc (around lines 1044-1045: "The proxy binary does not call it, so its bound is the fixed default.") says bep serve calls it with the flag's value.

Generated by Claude Code

Proof

The doc of Control::bind_with_key_bound in crates/bep/src/control.rs now says that bep serve calls it with the value of --max-client-keys. The old sentence about a fixed default is gone.

Tests

line exit tail
cargo nextest run -p bep the_registry_never_holds_more_keys_than_its_bound 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-0e23... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling client-config v0.0.1 (/workbench/crates/client-config) Compiling bep v0.0.1 (/workbench/crates/bep) Finished 'test

Verify

min task run agent-verify passed ([tasks.verify]).

Closes #2598

The doc of Control::bind_with_key_bound now says bep serve calls it with
the value of --max-client-keys, in place of the stale fixed-default note.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1514eb44-5f60-45f2-8bb7-bdfe2d666506

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The design of record says nothing about the client-key bound or --max-client-keys, so this is a PASS by absence. The new doc sentence is true at this head. ServeArgs::key_bound() reads --max-client-keys, and bep serve passes that bound to Control::bind_with_key_bound. The module doc at lines 150-152 already names the flag, so no stale sentence remains. There are no conditions.

Ruled at 5febaec against gominimal/arch@8640f85e193d by claude-opus-5-5.

@minimal-foundry

minimal-foundry Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at 5febaec3fdd6.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 31, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 5febaec against T108's plan block. The doc of Control::bind_with_key_bound now says bep serve calls it with the value of --max-client-keys. That is true at this head: crates/bep/src/main.rs:1164 calls it with the bound ServeArgs builds from --max-client-keys (line 131). The stale sentence is gone. No code change, so the plan's test line the_registry_never_holds_more_keys_than_its_bound is unaffected. No findings.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 5a652fe Oct 31, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the agent/2598-say-in-control-rs-that-bep-serve-sets-the-client branch October 31, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T108 — Say in control.rs that bep serve sets the client-key bound

1 participant