Skip to content

ci(kvm): raise the test-kvm job timeout to 45 minutes - #2870

Merged
norrietaylor merged 1 commit into
mainfrom
chore/test-kvm-timeout-45m
Nov 3, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
chore/test-kvm-timeout-45m

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

test-kvm in .github/workflows/ci-linux-kvm.yml now runs close to its 30-minute timeout-minutes. This PR raises it to 45.

Evidence

  • Main's own test-kvm took 28.5 minutes in the merge-queue run for #2824 (run 41673263055, 16:31:02Z to 16:59:34Z).
  • #2831 was dequeued with failed_checks (run 41672269471). test-kvm was cancelled at 30 minutes in the e2e leg "escapes and builds stay inside the box's rules". The e2e was still making progress; it did not hang.
  • #2819 was cancelled at the limit in the same way (run 41673515236).

Notes

  • The workflow is frozen and CODEOWNER-gated. This PR is the CODEOWNER's request.
  • The job comment above it still says a rerun costs about 15 minutes. That is no longer true, but this PR leaves the comment as it is.
  • A longer-term fix is to shorten or split scripts/session-e2e.sh, for example its repeated 61 s per-source line-window waits. That is not in this PR.

Summary by CodeRabbit

  • Chores
    • The time limit for Linux KVM test runs increased from 30 to 45 minutes. This change applies to automated validation and does not alter app functionality or user-facing behavior. No other changes are included in this update.

The session e2e now takes main's test-kvm to 28.5 of its 30 minutes
(merge-queue run 41673262055 for #2824). Queue runs for #2831 and #2819
were cancelled at the limit while the e2e still made progress, and
the queue dequeued both PRs.
@norrietaylor
norrietaylor requested a review from a team as a code owner November 3, 2026 18:53
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The test-kvm job in the Linux KVM workflow now has a 45-minute timeout, increased from 30 minutes.

Changes: KVM CI

Layer / File(s) Summary
Update KVM test timeout
.github/workflows/ci-linux-kvm.yml
The test-kvm job timeout changes from 30 to 45 minutes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • gominimal/minimal#2731: This PR removes the macOS await-kvm gate, which depends on the result of the KVM check.

Suggested reviewers: bryan-minimal

Merge Risk: Minimal · up to 9c72d

The change gives the KVM test job more time, since runs have been cancelled at 30 minutes while still progressing. Merging has no concrete risk beyond the normal CODEOWNER review that already applies to workflow edits.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description covers the change, the reason for it, and supporting evidence. It explains that test-kvm runs close to its 30-minute limit and gives run references from related PRs. It also notes what… Restructure the description to match the repository template. Add the section headings Summary, Testing, and Checklist. Under Summary, link related issues or PRs with Refs: or Closes: lines. Under Testing, state what was run and paste the r…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title "ci(kvm): raise the test-kvm job timeout to 45 minutes" states the single change in the changeset. The PR raises the test-kvm job timeout in ci-linux-kvm.yml from 30 to 45 minutes. It follow…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci(kvm): raise the test-kvm job timeout to 45 minutes" states the single change in the changeset. The PR raises the test-kvm job timeout in ci-linux-kvm.yml from 30 to 45 minutes. It follows the Conventional Commit form the template asks for, uses lower case, has no trailing period, and is imperative.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description covers the change, the reason for it, and supporting evidence. It explains that test-kvm runs close to its 30-minute limit and gives run references from related PRs. It also notes what is out of scope. It does not follow the repository template: the Summary section lacks an issue link (Refs/Closes), the Testing section has no commands or output for local runs, and the Checklist (docs update and BREAKING CHANGE footer) is missing. The evidence cites CI runs, which partly covers the Testing intent but is not the requested format.

Resolution

Restructure the description to match the repository template. Add the section headings Summary, Testing, and Checklist. Under Summary, link related issues or PRs with Refs: or Closes: lines. Under Testing, state what was run and paste the relevant CI output or log excerpt. Under Checklist, mark the docs item and the BREAKING CHANGE footer item. Mark them explicitly as not applicable if they do not apply.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the timer’s face,
The KVM tests get extra space.
Thirty minutes hop away,
Forty-five now mark the day.
The workflow rests; the carrots stay.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 38139a41-b8f6-437a-86c1-b394abee99f9
Commits

Reviewing files that changed from the base of the PR and between 687d2f3 and 9c72d69.

Files selected for processing: 1
  • .github/workflows/ci-linux-kvm.yml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@minimal-foundry

minimal-foundry Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 9c72d692442d.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 3, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit ed17603 Nov 3, 2026
35 checks passed
@norrietaylor
norrietaylor deleted the chore/test-kvm-timeout-45m branch November 3, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants