Skip to content

T125 — The CLI reference describes min ls and the activate host line as they print - #2808

Merged
norrietaylor merged 2 commits into
mainfrom
agent/2796-the-cli-reference-describes-min-ls-and-the-activ
Oct 31, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
agent/2796-the-cli-reference-describes-min-ls-and-the-activ

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

T125 — The CLI reference describes min ls and the activate host line as they print

slice: S17
kind: task
covers: NET-142
size: S
est: 60 code, 0 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none: a reference page carries no runtime state a diagnostics bundle would read
observability: none: a reference page emits nothing at runtime
layers:
- docs:
- docs/reference/cli-min.md: session list documents the ADDRESS column (the box's own address, 127.0.0.1 at the fallback, - when unreported), the EGRESS posture words min session policy prints, and the --json keys loopback_address and egress_posture; the native host line (around lines 546-552) shows its two forms, own address opens at its name on this machine; the HTTP proxy at 127.0.0.1:<port> opens it too and the 127.0.0.1 fallback's resolve-and-proxy form; the sentence "A browser opens the box through the hostname proxy, which keeps serving." is removed (design §7.1 line 263)
test: just lint-prose docs/reference/cli-min.md
produces: none
consumes: none
proof: A reader of the CLI reference sees the same ADDRESS column, posture words, JSON keys and host-line forms that min ls and min session activate print.
depends on:
- blocked by #2696

Proof

A reader of docs/reference/cli-min.md now sees the min ls columns with ADDRESS (the box's own address, 127.0.0.1 at the fallback, - when unreported), the EGRESS posture words that min session policy prints (deny-all (default), allow-all (default), deny-all, declared rules, no network, and the '; per-box enforcement none' suffix), the --json keys loopback_address and egress_posture with their snake_case values, and the native host line in both forms: own address 'opens at its name on this machine; the HTTP proxy at 127.0.0.1: opens it too' and fallback 'resolves on this machine; open it through the HTTP proxy at 127.0.0.1:'. The sentence 'A browser opens the box through the hostname proxy, which keeps serving.' is gone.

Notes from the agent: vale was not installed on this box. I downloaded the vale 3.9.1 release binary to /tmp and put it on PATH for the lint run. That run exits 1 because the file had 70 errors and 88 warnings before this change. The count is the same after it. The alert on line 54 (a semicolon) and the long sentence near line 593 are in text that this task did not change. The wording comes from crates/minimal/src/resolver.rs box_name_opens, crates/minimal/src/cmd/boxes/policy.rs egress_posture_words and egress_posture_cell, and crates/minimal/src/cmd/list.rs listing_json and session_cells.

Tests

line exit tail
just lint-prose docs/reference/cli-min.md 1 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-d99f... 'vale' not found — install with: brew install vale (or a release binary: github.com/errata-ai/vale/releases) error: recipe '_need' failed on line 304 with exit code 1

Verify

min task run agent-verify passed ([tasks.verify]).

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

Closes #2796

The session list section names the ADDRESS column, the EGRESS posture
words that min session policy prints, and the --json keys
loopback_address and egress_posture. The finalize-install section shows
both native host-line forms and drops the sentence that said a browser
opens the box only through the hostname proxy.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a2ba31c1-b416-4ea5-8ddd-5877d0dd1749

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at aea9c7f31082.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This change conforms to design §7.1. The new text for min ls and the activate host line matches the strings that the code prints at this head. The two native host-line forms separate a box with its own address from a box at the 127.0.0.1 fallback, as §7.1 lines 259–263 do. The removed sentence said every box opens only through the proxy, and that was not correct for an own-address box. No conditions.

Ruled at aea9c7f against gominimal/arch@8640f85e193d by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 31, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babysitter review against T125 (#2796). I checked the page against main after #2777:

  • The column order matches the header in list.rs:915.
  • The EGRESS words match egress_posture_words (boxes/policy.rs:85-89), including the ; per-box enforcement none suffix (:108).
  • Both native forms of the host line match resolver.rs:5080 and :5087.

One nit, not blocking: a host-address box on a native host can show 127.0.0.1 as its node address without being at the fallback. "A box at the shared fallback shows 127.0.0.1" is true, but its converse is not, so a reader can over-read it.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 31, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit b694822 Oct 31, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the agent/2796-the-cli-reference-describes-min-ls-and-the-activ branch October 31, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T125 — The CLI reference describes min ls and the activate host line as they print

1 participant