Skip to content

T115 — DNS steering through the box-zone resolver, end to end - #2829

Merged
norrietaylor merged 2 commits into
mainfrom
agent/2787-dns-steering-through-the-box-zone-resolver-end-t
Nov 1, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
agent/2787-dns-steering-through-the-box-zone-resolver-end-t

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

T115 — DNS steering through the box-zone resolver, end to end

slice: S16
kind: integration
covers: none
size: M
est: 0 code, 200 tests
executor: agent
difficulty: needs care
model: standard
diagnostics: each case prints PASS or NOT RUN with its gate
observability: none beyond the cases' own output
layers:
- e2e:
- scripts/session-e2e.sh: one walk over the slice on a VM host: a grant box with steering = "dns" and no proxy variables clones a private repository through the proxy, a store reference's upstream resolves to the proxy and its request carries the stored key, and with the proxy stopped both names get SERVFAIL; NOT RUN where its gate is missing
test: ./scripts/session-e2e.sh bep_dns_steering_through_the_box_zone_resolver
produces: none
consumes: none
proof: On a host whose switch resolves box names, a box with dns steering reaches GitHub and its stored-key upstreams through the proxy with no proxy variables, and those names fail closed while the proxy is down. Its tasks re-cover requirements whose first tasks merged with the steering wired and the refusal still in place; the owner planned them into this epic on 2026-10-31 so they dispatch as one slice.
depends on:
- blocked by #2523
- blocked by #2575

Proof

Not delivered on this branch. A person can now run './scripts/session-e2e.sh bep_dns_steering_through_the_box_zone_resolver'. On a macOS VM host with a live proxy, the case walks the slice: a box with steering = "dns" and a store reference resolves its upstream to the proxy address 100.64.255.252, and a plain curl with no proxy variable delivers the stored value. With a sign-in and E2E_BEP_PRIVATE_REPO, a dns-steered grant box resolves github.com to the proxy and clones the private repository. With the proxy stopped, both names get SERVFAIL. Each leg prints PASS or NOT RUN with its gate. Today admission still refuses steering = "dns" with a credentialed upstream, so on every host the case prints NOT RUN with that refusal as its gate. The proof becomes true when #2805 lifts the refusal.

Notes from the agent: The proof cannot be true at this branch head. crates/boxes/src/core/bep.rs still pushes BepRefusal::DnsWithoutDirectTls for steering = "dns" with a credentialed upstream on a host with the box-zone resolver (interim until #2805, from T113). The case detects that refusal text at activation and records NOT RUN with it as the gate, so it does not go red before #2805. It also maps the 'has no box DNS resolver' refusal to NOT RUN. Remove the refusal gate in the case when #2805 lands if the lane must fail on it. The git leg needs a GitHub sign-in and E2E_BEP_PRIVATE_REPO, and it records '/git' NOT RUN without them. The fail_closed leg then checks only the store upstream. The case hardcodes the proxy address 100.64.255.252, as the other BEP switch cases do. It kills bep serve at the end and clears BEP_LIVE_DAEMON, so the next live case restarts the pair. On this Linux box the test line ran to the macOS-only gate, so no leg ran. The case is added to the whole-lane order after bep_dns_steering_fails_closed_end_to_end, and to the dispatch and usage lists in the same file. shellcheck is clean.

Tests

line exit tail
./scripts/session-e2e.sh bep_dns_steering_through_the_box_zone_resolver 0 ::group::DNS steering through the box-zone resolver: store upstream and GitHub through the proxy, SERVFAIL while it is down bep_dns_steering_through_the_box_zone_resolver: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_dns_steering_through_the_box_

Verify

min task run agent-verify passed ([tasks.verify]).

Refs #2787

Residuals

A dns-steered store box and grant box resolve their upstreams to the
Box Egress Proxy and reach them with no proxy variables. With the proxy
stopped, both names get SERVFAIL. Each leg prints PASS or NOT RUN with its
gate, and the case is NOT RUN while admission refuses dns steering (#2805).
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4aa00f10-2690-4752-b71b-1d4837546b59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at 61066dd49c81.

@norrietaylor resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The case tests the right design lines, and it is in the right file. Two gates are soft. The #2805 admission refusal is a product gap against §5.4 line 169, but the case records it as NOT RUN. Record it with known_gap and cite #2805 (C1). The has no box DNS resolver refusal cannot occur on a host that passes bep_live_gate, so make it a failure (C2).

Ruled at d8ee5f4 against gominimal/arch@8640f85e193d by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh Resolved
The #2805 refusal of dns steering with a credentialed upstream is a
product gap, not a missing host gate, so record it as KNOWN GAP. Drop the
no-box-DNS-resolver branch: after bep_live_gate the host is minvmd and the
box is own_ip, so that refusal now fails the case. The git leg handles the
same refusal as the store leg does.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as 61066dd49c81.

line exit tail
./scripts/session-e2e.sh bep_dns_steering_through_the_box_zone_resolver 0 ::group::DNS steering through the box-zone resolver: store upstream and GitHub through the proxy, SERVFAIL while it is down bep_dns_steering_through_the_box_zone_resolver: NOT RUN (the Box Egress Proxy runs on macOS only) ::endgroup:: session e2e: 1 case(s) NOT RUN: bep_dns_steering_through_the_box_

Verify min task run agent-verify passed.

Review threads the coder judged:

On a macOS VM host with the live Box Egress Proxy, the case walks a dns-steered store box and grant box with no proxy variables through the proxy, and checks SERVFAIL for both names while the proxy is down. While admission still refuses dns steering with a credentialed upstream (#2805), the lane summary counts the case as KNOWN GAP with the refusal text, not as NOT RUN. Any other activation refusal fails the case.

Notes from the agent: The test line ran on Linux, so bep_live_gate recorded the case NOT RUN (macOS only). The live legs and the KNOWN GAP path did not run here. They need the macOS VM lane with a bep binary. bash -n and shellcheck -S warning pass on the script.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The compare fixes the items from the last ruling. The #2805 refusal is now a KNOWN GAP that cites its issue, and a host without the box resolver fails the case. One item stays open. On every host today the case ends KNOWN GAP, so the T115 proof is not true at this head, and the PR body still closes #2787. Section 5.4 line 169 is the behaviour the case must prove. Make the change in C1. Then the merge can go ahead, with #2805 as the residual.

Ruled at 61066dd against gominimal/arch@8640f85e193d by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 5 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh:13861, minimal-arch[bot] scripts/session-e2e.sh, minimal-foundry[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh:14044. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 61066dd49c81 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 1, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 61066dd. The case walks T115's three legs: the store upstream resolves to the proxy with the stored header, the git clone runs through the proxy, and both names fail closed with SERVFAIL while the proxy is down.

  • The #2805 admission refusal is recorded as a KNOWN GAP in both the store and git legs.
  • The 'no box DNS resolver' refusal now fails the case, because the gate already establishes a minvmd host with an own_ip box.
  • No stored value is printed.

The PR body says Refs #2787 per arch C1 and the owner's ruling, and #2805 carries the closing run. I checked all five threads against this head and resolved them.

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit a9c06ea Nov 1, 2026
36 checks passed
@norrietaylor
norrietaylor deleted the agent/2787-dns-steering-through-the-box-zone-resolver-end-t branch November 1, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant