Skip to content

docs(specs): mark spec 03's retired proxy requirements superseded - #2957

Merged
norrietaylor merged 2 commits into
mainfrom
docs/spec-03-marks-retired-proxy-superseded
Nov 4, 2026
Merged

norrietaylor merged 2 commits into
mainfrom
docs/spec-03-marks-retired-proxy-superseded

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Closes #2933 (T142 of #1437).

The runtime refused T142 because a docs-only task has no test: line, so this is written by hand.

  • 03-spec-networking.md: R4.4, R4.5, R4.9, the SSH fallback paragraph and Open Questions item 5 each gain a Superseded: note linking spec 18's NET-109, in the form the R2.1 note uses. R4.6 and R4.7 say they move to the mesh spec, MRF (#1420).
  • networking-with-diagrams.md: the mTLS client-certificate line gains the same note.

Docs only. The notes add no requirement.

Summary by CodeRabbit

  • Documentation
    • Updated networking specifications to mark HTTPS reverse proxy requirements, related authentication and mesh-status details, conditional compilation, SSH port forwarding, and TLS certificate management as superseded or covered elsewhere.
    • Clarified that Minimal does not provide an HTTPS reverse proxy and that minimal login does not issue a client certificate.

R4.4, R4.5 and R4.9, the SSH fallback paragraph and Open Questions item 5
now say what spec 18's NET-109 retired. R4.6 and R4.7 say they move to
the mesh spec, MRF. Closes #2933 (T142).
@norrietaylor
norrietaylor requested a review from a team as a code owner November 4, 2026 00:02
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/03-spec-networking/03-spec-networking.md — 3 finding(s)

docs/specs/03-spec-networking/03-spec-networking.md:1: F004 frontmatter is missing `owner:`, `epic:`, `arch:`, `updated:`
docs/specs/03-spec-networking/03-spec-networking.md:1: S002 missing 6 required section(s): `## Users and stories`, `## Requirements`, `## Non-goals`, `## Design reasoning`, `## Security considerations`, `## Open questions`
docs/specs/03-spec-networking/03-spec-networking.md:39: S003 11 section(s) are not part of the spec format: `## Introduction/Overview`, `## Goals`, `## User Stories`, `## Demoable Units of Work`, `## Non-Goals`, `## Design Considerations`, `## Repository Standards`, `## Open Questions`, `## Technical Considerations`, `## Security Considerations`, `## Verification`

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@fb5932b8, spec format: How Minimal Writes Specs.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

Spec 03 now marks HTTPS reverse-proxy, client-certificate, and SSH port-forwarding requirements as superseded. It marks mesh-status RPC and conditional-compilation requirements as moved to the mesh spec. The networking diagram document also notes the superseded proxy and certificate behavior.

Changes: Networking spec updates

Layer / File(s) Summary
Update networking requirement status
docs/specs/03-spec-networking/03-spec-networking.md, docs/specs/03-spec-networking/networking-with-diagrams.md
The spec marks HTTPS reverse-proxy, client-certificate, and SSH port-forwarding requirements as superseded. It marks mesh-status RPC and conditional-compilation requirements as moved to the mesh spec. The diagram document adds a superseded notice for the proxy and client certificate.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

Possibly related PRs

  • gominimal/minimal#2679: This PR updates spec 18’s networking requirements, including NET-109 referenced by this change.

Suggested reviewers: msample

Merge Risk: Low · up to 58ed6

This documentation-only change marks retired networking requirements as superseded. Two small inconsistencies remain in the specs: a proof artifact that cannot pass, and a superseded note wider than the line it annotates. Neither affects runtime behavior. They are worth tidying before merge but need not block it.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Vale (3.24.0)

{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}

A rabbit reads the network page,
And marks old proxy rules offstage.
The mesh notes find their proper place,
While SSH leaves the spec’s embrace.
A carrot waits beside the change.

@minimal-foundry

minimal-foundry Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 58ed6cea9217.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 4, 2026
@norrietaylor
norrietaylor merged commit fe474da into main Nov 4, 2026
34 of 35 checks passed
@norrietaylor
norrietaylor deleted the docs/spec-03-marks-retired-proxy-superseded branch November 4, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T142 — Spec 03 marks the retired proxy's requirements as superseded

1 participant