Skip to content

T1 — List and show every box with its provider and host - #2963

Merged
mitodrummer merged 7 commits into
mainfrom
agent/2889-list-and-show-every-box-with-its-provider-and-ho
Nov 4, 2026
Merged

mitodrummer merged 7 commits into
mainfrom
agent/2889-list-and-show-every-box-with-its-provider-and-ho

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

T1 — List and show every box with its provider and host

slice: S0
kind: task
covers: BCLI-001, BCLI-051, BCLI-003
size: M
est: 220 code, 180 tests
executor: agent
difficulty: routine
model: standard
diagnostics: when min box list cannot read one host, it still lists the others and prints "Could not reach host ; its boxes are not listed." on stderr, pinned by box_list_prints_columns_and_schema
observability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cli.rs: the verb's arguments and help in the one command model
- crates/minimal/src/cmd/boxes/list.rs: PROVIDER and HOST columns, the --all scope, and -o json objects with "schema": "min/v1/box"
- crates/minimal/src/cmd/list.rs: shares the walk over the local hosts that min ls already does
- crates/minimal/src/cmd/boxes/show.rs: renders provider and host beside the state and identity it shows
test: cargo nextest run -p minimal box_list_prints_columns_and_schema
test: cargo nextest run -p minimal list_shows_host_per_box
test: cargo nextest run -p minimal box_show_renders_state_and_identity
produces: none
consumes: none
proof: min box list shows each box's id, name, type, state, provider and host, and min box show shows one box's state and identity.

Proof

min box list prints ID, NAME, TYPE, PARENT, PROJECT, STATE, PROVIDER and HOST for each box on every local host (the native daemon local0, or each VM as local-minvmd0 / <vm>.local-minvmd0). It is scoped to the current project unless --all is given. min box list -o json writes only a JSON array of "schema": "min/v1/box" objects. min box show <box> prints the box's state, how it ended, its identity, and its provider and host.

Notes from the agent: Host names: the native daemon is provider local, host local<N>. A VM is provider local-minvmd, and its host name is the ssh host alias of its host dir: local-minvmd0 for the default VM, <vm>.local-minvmd0 for a named VM. BCLI-046 owns the final host naming, and its task can change it. The selected host is still strict: if it fails, the command fails, as min ls does. Another host that does not answer prints "Could not reach host ; its boxes are not listed." on stderr, and the listing continues. A VM that is not running has no daemon to read, so it contributes no rows. min ls shows such boxes from persisted records, but min box list does not. min box show still resolves the box on the selected host only. Cross-host addressing is BCLI-002. Printed text: the unreachable-host line is copied from the task and contains a semicolon, which the printed-text rule asks to avoid. The empty-listing lines changed: "...Run min box list --all to list the boxes of every project." and "No boxes on this machine.", because --all now spans every local host. Observability: the cmd span gets tracing::info! events with verb, box_id (show), host and outcome. The span is declared in cmd/mod.rs, which is outside the layers, so I added no span fields. -o json writes one pretty-printed array. Docs (docs/reference/cli-min.md) are not updated because they are outside the layers. I ran no whole-crate test run.

Tests

line exit tail
cargo nextest run -p minimal box_list_prints_columns_and_schema 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-bf87... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal list_shows_host_per_box 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-57ba... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_show_renders_state_and_identity 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-eed5... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify

min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

d = ungated", "cmd/mod.rs::resolve_box_on_any_vm = gated", "cmd/net.rs::cmd_net_forward = gated", "cmd/net.rs::poll_client_for = gated", "cmd/secret.rs::recertify = ungated", "cmd/session.rs::cmd_attach = gated", "cmd/session.rs::cmd_exec = gated", "cmd/session.rs::cmd_session_run = gated", "cmd/session.rs::cmd_session_setup_zed = gated", "dash/rpc.rs::activate = gated", "dash/rpc.rs::connect_missing = gated", "dash/rpc.rs::discover = gated", "diag/net.rs::probe_socket = ungated", "mint.rs::a_refused_client_key_is_replaced_and_registered_before_the_mint = ungated", "mint.rs::a_replaced_client_key_is_revoked_at_the_proxy_after_a_failed_revoke = ungated", "mint.rs::a_replaced_client_key_is_revoked_at_the_proxy_once_for_two_creations = ungated", "mint.rs::a_replaced_client_key_keeps_verifying_until_its_boxes_end = ungated", "mint.rs::a_replaced_client_key_keeps_verifying_until_its_boxes_end = ungated", "mint.rs::a_replaced_client_key_keeps_verifying_until_its_boxes_end = ungated", "mint.rs::a_replacement_past_a_bound_of_keys_in_use_fails_the_creation = ungated", "mint.rs::a_replacement_the_store_does_not_keep_revokes_no_key = ungated", "mint.rs::create = ungated", "mint.rs::local_client_key_at = ungated", "mint.rs::revoke_others = ungated", "mint.rs::store_handle_signed_and_key_registered = ungated", "mint.rs::store_handle_signed_and_key_registered = ungated", "task.rs::arm_task_run_interrupt = ungated", "tests.rs::a_failed_box_reply_forgets_the_box_again = ungated", "tests.rs::a_refused_client_key_forgets_the_box_again = ungated", "tests.rs::an_identity_with_no_root_validity_mints_nothing = ungated", "tests.rs::attach_fall_through_hands_off_the_owning_vm = gated", "tests.rs::attach_refuses_a_box_name_two_vms_know = gated", "tests.rs::exec_fall_through_hands_off_the_owning_vm = gated", "tests.rs::grant_box_registers_its_declared_egress_with_the_proxy = ungated", "tests.rs::grant_box_registers_its_declared_egress_with_the_proxy = ungated", "tests.rs::grant_box_registers_its_declared_egress_with_the_proxy_until_the_creation_fails = ungated", "tests.rs::local_member_is_a_sign_in_reference_expiring_with_the_root = ungated", "tests.rs::mint_and_destroy_append_audit_records = ungated", "tests.rs::selected_client = ungated"]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.928s] (607/851) minimal tests::box_name_resolves_vm_without_flag_refuses_a_name_two_vms_hold
        PASS [   1.558s] (608/851) minimal tests::box_name_resolves_vm_without_flag
        PASS [   1.776s] (609/851) minimal tests::box_on_stopped_vm_names_start_command
────────────
     Summary [  14.848s] 609/851 tests run: 608 passed, 1 failed, 1 skipped
        FAIL [   0.073s] (606/851) minimal tests::every_daemon_connection_is_classified
warning: 242/851 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Closes #2889

Out-of-layer edits accepted by the maintainer (2026-11-04): crates/minimal/src/tests.rs holds the in-process minimald test harness, and crates/minimal/src/main.rs (failure_exit_code) is where errors become exit codes. The plan should have named both.

Residuals

min box list reads each local host the walk of min ls finds, prints
PROVIDER and HOST columns, and takes -o json for min/v1/box objects.
A host that does not answer gets one stderr line, and the others still
list. min box show prints the provider and host of the box it shows.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a051c8e8-014f-44d2-8fe9-15cede680f21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at 9e9b8bb82610.

@mitodrummer resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/show.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

Two edits are necessary before this change conforms. min box list -o json is not in machine_output_mode in main.rs, so a failure prints prose. Output conventions line 383 requires one min/v1/error object on stderr. C1 fixes it. list_host_boxes mixes a gated connect with an ungated probe, and every_daemon_connection_is_classified fails on this head. C2 splits the function and records both halves. The host name of a named VM is an open design question, and I escalated it.

Ruled at 86f1839 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

Comment thread crates/minimal/src/cli.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/list.rs Resolved
min box list --all reads every local host, but min box show reads only
the selected one. With several hosts, the not-found refusal now names
the host it read and the --vm flag that selects another VM.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/list.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The listing, the min/v1/box objects and min box show conform to the design. One gap from the last head stays open. min box list -o json does not join the machine mode, so its failure prints a plain error: line. Line 383 of the architecture requires one min/v1/error object on stderr. C1 adds the BoxCommand::List arm to machine_output_mode in main.rs. C2 files the named-VM host name as a residual with an issue, because the PR body defers it to BCLI-046 with no owner.

Ruled at bdaf519 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/list.rs Resolved
Comment thread crates/minimal/src/cmd/list.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as bdaf519d0ee6.

line exit tail
cargo nextest run -p minimal box_list_prints_columns_and_schema 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-a4aa... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal list_shows_host_per_box 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-4246... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_show_renders_state_and_identity 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-9165... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

t_daemon_unchecked = ungated", "cmd/mod.rs::resolve_box_on_any_vm = gated", "cmd/net.rs::cmd_net_forward = gated", "cmd/net.rs::poll_client_for = gated", "cmd/secret.rs::recertify = ungated", "cmd/session.rs::cmd_attach = gated", "cmd/session.rs::cmd_exec = gated", "cmd/session.rs::cmd_session_run = gated", "cmd/session.rs::cmd_session_setup_zed = gated", "dash/rpc.rs::activate = gated", "dash/rpc.rs::connect_missing = gated", "dash/rpc.rs::discover = gated", "diag/net.rs::probe_socket = ungated", "mint.rs::a_refused_client_key_is_replaced_and_registered_before_the_mint = ungated", "mint.rs::a_replaced_client_key_is_revoked_at_the_proxy_after_a_failed_revoke = ungated", "mint.rs::a_replaced_client_key_is_revoked_at_the_proxy_once_for_two_creations = ungated", "mint.rs::a_replaced_client_key_keeps_verifying_until_its_boxes_end = ungated", "mint.rs::a_replaced_client_key_keeps_verifying_until_its_boxes_end = ungated", "mint.rs::a_replaced_client_key_keeps_verifying_until_its_boxes_end = ungated", "mint.rs::a_replacement_past_a_bound_of_keys_in_use_fails_the_creation = ungated", "mint.rs::a_replacement_the_store_does_not_keep_revokes_no_key = ungated", "mint.rs::create = ungated", "mint.rs::local_client_key_at = ungated", "mint.rs::revoke_others = ungated", "mint.rs::store_handle_signed_and_key_registered = ungated", "mint.rs::store_handle_signed_and_key_registered = ungated", "task.rs::arm_task_run_interrupt = ungated", "tests.rs::a_failed_box_reply_forgets_the_box_again = ungated", "tests.rs::a_refused_client_key_forgets_the_box_again = ungated", "tests.rs::an_identity_with_no_root_validity_mints_nothing = ungated", "tests.rs::attach_fall_through_hands_off_the_owning_vm = gated", "tests.rs::attach_refuses_a_box_name_two_vms_know = gated", "tests.rs::exec_fall_through_hands_off_the_owning_vm = gated", "tests.rs::grant_box_registers_its_declared_egress_with_the_proxy = ungated", "tests.rs::grant_box_registers_its_declared_egress_with_the_proxy = ungated", "tests.rs::grant_box_registers_its_declared_egress_with_the_proxy_until_the_creation_fails = ungated", "tests.rs::local_member_is_a_sign_in_reference_expiring_with_the_root = ungated", "tests.rs::mint_and_destroy_append_audit_records = ungated", "tests.rs::selected_client = ungated"]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.020s] (610/851) minimal tests::finalize_install_parses_ct_mark_mask
        PASS [   0.642s] (611/851) minimal tests::exec_fall_through_hands_off_the_owning_vm
        PASS [   1.303s] (612/851) minimal tests::box_on_stopped_vm_names_start_command
────────────
     Summary [  12.318s] 612/851 tests run: 611 passed, 1 failed, 1 skipped
        FAIL [   0.058s] (609/851) minimal tests::every_daemon_connection_is_classified
warning: 239/851 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM6zY_3l: The not-found refusals in min box show now name the host that was read. With several local hosts they say to run min box show again with --vm <name>. The test box_list_and_show_render_retained_records pins this text. (not posted on the thread: not an open thread on the pull request)

min box list shows each box's id, name, type, state, provider and host, and min box show shows one box's state and identity. When min box show finds no box on the selected host and other local hosts exist, the refusal names that host and tells the person to run min box show again with --vm <name>.

Notes from the agent: Revise round 1. Both not-found refusals in min box show now name the host that was read. With one local host they keep the old next step. With several hosts they read: "No box has the name or id <x> on host . Run min box list --all to see the boxes on every host. For a box on host .local-minvmd0, run min box show again with --vm <name>." Several hosts exist only on the minvmd backend, so --vm is valid there. find_listed_box takes the host and the next step as arguments now. The test box_list_and_show_render_retained_records pins both texts. cargo clippy -p minimal --all-targets was clean. I did not run just clippy-strict.

Split the per-host read of `min box list` into list_selected_host
(gated) and list_other_host (ungated probe), and record both in the
daemon connection inventory, which failed on the mixed function.

Add `min box list -o json` to the machine output mode, so a failure
writes one min/v1/error object. Note the named-VM host name residual
on host_name_for.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The compare closes two items from the ruling on bdaf519d. The selected host and the other hosts are now gated apart as min ls gates them. A min box list -o json failure is now one min/v1/error object, as architecture line 383 requires. One item stays open. A named VM still prints as <vm>.local-minvmd0, and the comment on host_name_for says that no issue tracks the fix. An interim with no issue has no owner. Make the change in C1.

Ruled at 9a9eeac against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/list.rs Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 6 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:449, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:83, minimal-foundry[bot] crates/minimal/src/cmd/boxes/list.rs:67, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:61, minimal-arch[bot] crates/minimal/src/cmd/list.rs:594, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a failed check suite, pushed as 9a9eeac4e95f.

line exit tail
cargo nextest run -p minimal box_list_prints_columns_and_schema 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-32f6... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal list_shows_host_per_box 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-2994... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_show_renders_state_and_identity 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-21e0... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "764cb2be61a08b0f",
                "span_id": "bbdcf6bf31bc6ed2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "764cb2be61a08b0f",
                "span_id": "5dcacece60fc6b4f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "764cb2be61a08b0f",
                "span_id": "71c05b8cf2ba0739",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "764cb2be61a08b0f",
                "queued_behind": "0",
                "span_id": "711ecd4bf35df5ef",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "764cb2be61a08b0f",
                "queued_behind": "0",
                "span_id": "b42cf27247e0cde2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "b42cf27247e0cde2",
                "span_id": "1cf43e8ecbfcea59",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "b42cf27247e0cde2",
                "queued_behind": "0",
                "span_id": "43454127bebb90f5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  62.097s] 851 tests run: 850 passed, 1 failed, 1 skipped
        FAIL [   4.479s] (851/851) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/main.rs
  • crates/minimal/src/tests.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cli.rs:449: Added the BoxCommand::List arm to machine_output_mode in main.rs, and a json/table case to machine_output_mode_keys_on_the_output_flag.
  • 👍 valid — crates/minimal/src/cmd/boxes/list.rs:83: Split list_host_boxes into list_selected_host (gated) and list_other_host (ungated probe), and recorded both in the inventory in tests.rs with the reason.
  • 👎 invalid — crates/minimal/src/cmd/boxes/list.rs:67: The tradeoff is deliberate. The task's diagnostics line requires the command to still list the other hosts and print the stderr line. The spec asks for no non-zero exit for a partial listing. A new exit code or flag needs a spec change first.
  • 👍 valid — crates/minimal/src/cmd/boxes/list.rs:61: Same fix as the cli.rs thread: machine_output_mode now matches box list -o json, with a test case.
  • 👍 valid — crates/minimal/src/cmd/list.rs:594: The doc comment on host_name_for now states the residual, BCLI-046 as owner and the flip condition. No issue exists that I can cite, so a person must add the number there and in the PR body.

min box list shows each box's id, name, type, state, provider and host, and min box show shows one box's state and identity. A min box list -o json failure now writes one min/v1/error object.

Notes from the agent: I ran the three test lines and the two extra tests in one nextest invocation. This round touched two files outside the layers. crates/minimal/src/tests.rs: the connection inventory test every_daemon_connection_is_classified failed in CI on list_host_boxes, so the split functions had to be added to it. crates/minimal/src/main.rs: machine_output_mode needed the BoxCommand::List arm, and its unit test needed the case. The named-VM host name residual (thread PRRT_kwDOPdfcxM6zZMs2) now has a doc comment on host_name_for. I know of no issue number for it, and the pull request body is the runner's. A person must open or name the issue for BCLI-046's VM host names, and add it to the body and the comment. The ci-linux-native-success failure is the aggregator. It failed because the tests job failed.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 4, 2026 01:35
@mitodrummer
mitodrummer marked this pull request as ready for review November 4, 2026 01:40
@mitodrummer

Copy link
Copy Markdown
Member

/revise

Arch's one condition on 9a9eeac4 (C1):

The maintainer accepted the out-of-layer edits to crates/minimal/src/tests.rs and crates/minimal/src/main.rs. Keep them, and don't draft the PR again for them.

The interim <vm>.local-minvmd0 host name now cites #2900 as the task
that flips it.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 6 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:449, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:83, minimal-foundry[bot] crates/minimal/src/cmd/boxes/list.rs:67, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:61, minimal-arch[bot] crates/minimal/src/cmd/list.rs:594, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head conforms to the design. min box list reads every local host over its own socket and adds the provider and host of each box (architecture line 53). It scopes to the project unless --all is given (line 489). -o json writes only min/v1/box objects, and a failure is one min/v1/error object (lines 381 and 383). min box show adds Provider and Host to the record it shows (line 475). The interim VM host name now links #2900, and I record it as a residual.

Ruled at 9e9b8bb against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on a /revise note, pushed as 9e9b8bb82610.

line exit tail
cargo nextest run -p minimal box_list_prints_columns_and_schema 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-d40f... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo
cargo nextest run -p minimal list_shows_host_per_box 0 Applying loadouts: default Running task runtime-implement-test-1 in session task-runtime-implement-test-1-4dbc... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.
cargo nextest run -p minimal box_show_renders_state_and_identity 0 Applying loadouts: default Running task runtime-implement-test-2 in session task-runtime-implement-test-2-912e... Compiling stdlib v0.0.22 (/workbench/crates/stdlib) Compiling version v0.8.0 (/workbench/crates/version) Compiling decode v0.0.1 (/workbench/crates/decode) Compiling mlog v0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "626ca7bda9ff8fe2",
                "span_id": "8f2571af06c51419",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "626ca7bda9ff8fe2",
                "span_id": "99f83dde70ee3fba",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "626ca7bda9ff8fe2",
                "span_id": "7480018b51d479d5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "626ca7bda9ff8fe2",
                "queued_behind": "0",
                "span_id": "dc819fe786fc5d61",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "626ca7bda9ff8fe2",
                "queued_behind": "0",
                "span_id": "6796c4fc181dc25e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "6796c4fc181dc25e",
                "span_id": "5eb98bf61e25d751",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "6796c4fc181dc25e",
                "queued_behind": "0",
                "span_id": "90b2f946b2c55ba8",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  43.828s] 851 tests run: 850 passed, 1 failed, 1 skipped
        FAIL [   2.984s] (851/851) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/main.rs
  • crates/minimal/src/tests.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

min box list shows each box's id, name, type, state, provider and host, and min box show shows one box's state and identity. The doc comment on host_name_for now links #2900 as the task that replaces the interim <vm>.local-minvmd0 host name.

Notes from the agent: This round changes only the doc comment on host_name_for in crates/minimal/src/cmd/list.rs. The comment keeps its flip condition. I cannot edit the PR body. The runner writes it. Add this section to the PR body:

Residuals

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @mitodrummer closed the last one. The review of 9e9b8bb82610 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 9e9b8bb8, on the tree merged with current main (T5 included).

  • Merge: git merge-tree is clean, with no new BoxCommand variant and no duplicate span fields.
  • Tests: 13 of 13 pass, including the three named tests and every_daemon_connection_is_classified.
  • Output: the columns are a superset of BCLI-001's floor. Host naming gives local<N>, local-minvmd0 and <vm>.local-minvmd0, the last an interim owned by #2900.
  • Unreachable hosts: one is probed with a timeout, and a single stderr line is printed per unreachable host. stdout stays pure.
  • box show: renders state, identity, provider and host (BCLI-003).
  • Residuals: #2900 (host naming) and #2980 (schema first, and the root-span box_id).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 4, 2026
@mitodrummer
mitodrummer added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 194b68e Nov 4, 2026
36 checks passed
@mitodrummer
mitodrummer deleted the agent/2889-list-and-show-every-box-with-its-provider-and-ho branch November 4, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T1 — List and show every box with its provider and host

1 participant