Repository navigation
T1 — List and show every box with its provider and host - #2963
mitodrummer merged 7 commits into
Conversation
min box list reads each local host the walk of min ls finds, prints PROVIDER and HOST columns, and takes -o json for min/v1/box objects. A host that does not answer gets one stderr line, and the others still list. min box show prints the provider and host of the box it shows.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Approved: every review thread resolved at @mitodrummer resolved the last thread, which releases the approval this review had withheld. Nothing to do. |
…how-every-box-with-its-provider-and-ho
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
Two edits are necessary before this change conforms. min box list -o json is not in machine_output_mode in main.rs, so a failure prints prose. Output conventions line 383 requires one min/v1/error object on stderr. C1 fixes it. list_host_boxes mixes a gated connect with an ungated probe, and every_daemon_connection_is_classified fails on this head. C2 splits the function and records both halves. The host name of a named VM is an open design question, and I escalated it.
Ruled at 86f1839 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.
min box list --all reads every local host, but min box show reads only the selected one. With several hosts, the not-found refusal now names the host it read and the --vm flag that selects another VM.
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The listing, the min/v1/box objects and min box show conform to the design. One gap from the last head stays open. min box list -o json does not join the machine mode, so its failure prints a plain error: line. Line 383 of the architecture requires one min/v1/error object on stderr. C1 adds the BoxCommand::List arm to machine_output_mode in main.rs. C2 files the named-VM host name as a residual with an issue, because the PR body defers it to BCLI-046 with no owner.
Ruled at bdaf519 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.
|
Round 1 of 10 on the runtime's review findings, pushed as
Verify Review threads the coder judged:
Notes from the agent: Revise round 1. Both not-found refusals in |
Split the per-host read of `min box list` into list_selected_host (gated) and list_other_host (ungated probe), and record both in the daemon connection inventory, which failed on the mixed function. Add `min box list -o json` to the machine output mode, so a failure writes one min/v1/error object. Note the named-VM host name residual on host_name_for.
There was a problem hiding this comment.
arch-review: CONDITIONS · 1 condition · the full ruling
The compare closes two items from the ruling on bdaf519d. The selected host and the other hosts are now gated apart as min ls gates them. A min box list -o json failure is now one min/v1/error object, as architecture line 383 requires. One item stays open. A named VM still prints as <vm>.local-minvmd0, and the comment on host_name_for says that no issue tracks the fix. An interim with no issue has no owner. Make the change in C1.
Ruled at 9a9eeac against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 6 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:449, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:83, minimal-foundry[bot] crates/minimal/src/cmd/boxes/list.rs:67, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:61, minimal-arch[bot] crates/minimal/src/cmd/list.rs:594, …. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
|
Round 2 of 10 on a failed check suite, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Notes from the agent: I ran the three test lines and the two extra tests in one nextest invocation. This round touched two files outside the layers. crates/minimal/src/tests.rs: the connection inventory test every_daemon_connection_is_classified failed in CI on list_host_boxes, so the split functions had to be added to it. crates/minimal/src/main.rs: machine_output_mode needed the BoxCommand::List arm, and its unit test needed the case. The named-VM host name residual (thread PRRT_kwDOPdfcxM6zZMs2) now has a doc comment on host_name_for. I know of no issue number for it, and the pull request body is the runner's. A person must open or name the issue for BCLI-046's VM host names, and add it to the body and the comment. The ci-linux-native-success failure is the aggregator. It failed because the tests job failed. |
|
/revise Arch's one condition on
The maintainer accepted the out-of-layer edits to |
…how-every-box-with-its-provider-and-ho
The interim <vm>.local-minvmd0 host name now cites #2900 as the task that flips it.
…how-every-box-with-its-provider-and-ho
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 6 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:449, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:83, minimal-foundry[bot] crates/minimal/src/cmd/boxes/list.rs:67, minimal-arch[bot] crates/minimal/src/cmd/boxes/list.rs:61, minimal-arch[bot] crates/minimal/src/cmd/list.rs:594, …. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
There was a problem hiding this comment.
arch-review: PASS · the full ruling
This head conforms to the design. min box list reads every local host over its own socket and adds the provider and host of each box (architecture line 53). It scopes to the project unless --all is given (line 489). -o json writes only min/v1/box objects, and a failure is one min/v1/error object (lines 381 and 383). min box show adds Provider and Host to the record it shows (line 475). The interim VM host name now links #2900, and I record it as a residual.
Ruled at 9e9b8bb against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.
|
Round 3 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Notes from the agent: This round changes only the doc comment on Residuals
|
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — every review thread is resolved; @mitodrummer closed the last one. The review of 9e9b8bb82610 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.
mitodrummer
left a comment
There was a problem hiding this comment.
Reviewed at 9e9b8bb8, on the tree merged with current main (T5 included).
- Merge:
git merge-treeis clean, with no newBoxCommandvariant and no duplicate span fields. - Tests: 13 of 13 pass, including the three named tests and
every_daemon_connection_is_classified. - Output: the columns are a superset of BCLI-001's floor. Host naming gives
local<N>,local-minvmd0and<vm>.local-minvmd0, the last an interim owned by #2900. - Unreachable hosts: one is probed with a timeout, and a single stderr line is printed per unreachable host. stdout stays pure.
box show: renders state, identity, provider and host (BCLI-003).- Residuals: #2900 (host naming) and #2980 (
schemafirst, and the root-spanbox_id).
T1 — List and show every box with its provider and host
slice: S0
kind: task
covers: BCLI-001, BCLI-051, BCLI-003
size: M
est: 220 code, 180 tests
executor: agent
difficulty: routine
model: standard
diagnostics: when
min box listcannot read one host, it still lists the others and prints "Could not reach host ; its boxes are not listed." on stderr, pinned by box_list_prints_columns_and_schemaobservability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cli.rs: the verb's arguments and help in the one command model
- crates/minimal/src/cmd/boxes/list.rs: PROVIDER and HOST columns, the
--allscope, and-o jsonobjects with"schema": "min/v1/box"- crates/minimal/src/cmd/list.rs: shares the walk over the local hosts that
min lsalready does- crates/minimal/src/cmd/boxes/show.rs: renders provider and host beside the state and identity it shows
test: cargo nextest run -p minimal box_list_prints_columns_and_schema
test: cargo nextest run -p minimal list_shows_host_per_box
test: cargo nextest run -p minimal box_show_renders_state_and_identity
produces: none
consumes: none
proof:
min box listshows each box's id, name, type, state, provider and host, andmin box showshows one box's state and identity.Proof
min box listprints ID, NAME, TYPE, PARENT, PROJECT, STATE, PROVIDER and HOST for each box on every local host (the native daemonlocal0, or each VM aslocal-minvmd0/<vm>.local-minvmd0). It is scoped to the current project unless--allis given.min box list -o jsonwrites only a JSON array of"schema": "min/v1/box"objects.min box show <box>prints the box's state, how it ended, its identity, and its provider and host.Notes from the agent: Host names: the native daemon is provider
local, hostlocal<N>. A VM is providerlocal-minvmd, and its host name is the ssh host alias of its host dir:local-minvmd0for the default VM,<vm>.local-minvmd0for a named VM. BCLI-046 owns the final host naming, and its task can change it. The selected host is still strict: if it fails, the command fails, asmin lsdoes. Another host that does not answer prints "Could not reach host ; its boxes are not listed." on stderr, and the listing continues. A VM that is not running has no daemon to read, so it contributes no rows.min lsshows such boxes from persisted records, butmin box listdoes not.min box showstill resolves the box on the selected host only. Cross-host addressing is BCLI-002. Printed text: the unreachable-host line is copied from the task and contains a semicolon, which the printed-text rule asks to avoid. The empty-listing lines changed: "...Runmin box list --allto list the boxes of every project." and "No boxes on this machine.", because--allnow spans every local host. Observability: thecmdspan getstracing::info!events with verb, box_id (show), host and outcome. The span is declared in cmd/mod.rs, which is outside the layers, so I added no span fields.-o jsonwrites one pretty-printed array. Docs (docs/reference/cli-min.md) are not updated because they are outside the layers. I ran no whole-crate test run.Tests
cargo nextest run -p minimal box_list_prints_columns_and_schemacargo nextest run -p minimal list_shows_host_per_boxcargo nextest run -p minimal box_show_renders_state_and_identityVerify
min task run agent-verifyexited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.Closes #2889
Out-of-layer edits accepted by the maintainer (2026-11-04):
crates/minimal/src/tests.rsholds the in-process minimald test harness, andcrates/minimal/src/main.rs(failure_exit_code) is where errors become exit codes. The plan should have named both.Residuals
<vm>.local-minvmd0, as cited inhost_name_for's doc comment.min box list/min box showontooutput::write_objects, which putsschemafirst and drops the hand-writtenBOX_SCHEMA.