Skip to content

T28 — Stop a host with its boxes, daemon and VM - #3022

Merged
agent-137 merged 14 commits into
mainfrom
agent/2910-stop-a-host-with-its-boxes-daemon-and-vm
Nov 5, 2026
Merged

agent-137 merged 14 commits into
mainfrom
agent/2910-stop-a-host-with-its-boxes-daemon-and-vm

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

T28 — Stop a host with its boxes, daemon and VM

slice: S7
kind: task
covers: BCLI-049
size: M
est: 200 code, 160 tests
executor: agent
difficulty: needs care
model: standard
diagnostics: min host stop <host> prints "Stopped boxes, the daemon and its VM on .", pinned by host_stop_force_forces_boxes_and_daemon
observability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cmd/hosts.rs: min host stop [--force] stops each running box, then the daemon and its VM
- crates/minimal/src/cmd/boxes/lifecycle.rs: shares the daemon shutdown
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon
- e2e:
- scripts/session-e2e.sh: adds the host_stop_stops_boxes_then_daemon_and_vm case to the VM-lane selector
test (deferred: vm): ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm
produces: none
consumes:
- crates/minimal/src/cmd/hosts.rs
proof: min host stop stops each box on the host, then its daemon and its VM.
depends on:
- blocked by #2900

Proof

A person can run min host stop <host> on a local host. It stops each running box on that host and prints Stopped <box>. for each one. Then it stops the daemon, and on a VM host also the VM, and prints "Stopped boxes, the daemon and its VM on ." ("Stopped boxes and the daemon on ." on a native host). With --force, each box gets the forced stop, and the daemon stops without a wait for its clean shutdown. The in-process test proves this for a native host. The VM half is in the deferred e2e case.

Notes from the agent: Out of layers: crates/minimal/src/cli.rs (adds HostCommand::Stop and HostStopArgs) and crates/minimal/src/cmd/mod.rs (the verb name host stop for the root span, and the dispatch). The tree had no host stop subcommand, so the command cannot exist without these two routes-table edits. I did not touch crates/minimal/src/cmd/session.rs: min stop keeps its own shutdown path. The shared part is the host-side VM stop (stop_vm_from_host_at), which min stop --force and min host stop now both use. shut_down_host_daemon in lifecycle.rs is new and only min host stop calls it. A follow-up can move min stop (the bare-stop alias of BCLI-042) onto it.

Wording: the task fixes "Stopped boxes, the daemon and its VM on ." I print that text on a VM host, with one deviation: n = 1 prints "1 box". A native host has no VM, so there the line is "Stopped boxes and the daemon on .". The pinned test checks the native line, because the in-process harness runs only a native daemon. host_stop_summary is unit-checked for the VM wording in the same test.

Other printed text I added: " is not running." (the daemon is already down, exit 0). Refusals: the daemon is still busy, the daemon does not answer, or the VM is still shutting down. Each one that has a remedy names min host stop <host> --force. For an unreachable VM host under --force, the VM is stopped from this machine, as min stop --force does…[truncated]

Tests

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-9d83... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo

Verify

min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "69f2ae8c87277b60",
                "span_id": "bc8c9efea1ae311b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "69f2ae8c87277b60",
                "span_id": "12363f15ad1a68c5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "69f2ae8c87277b60",
                "span_id": "e4e0990c311a41f2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "69f2ae8c87277b60",
                "queued_behind": "0",
                "span_id": "8128dd0c144ead98",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "69f2ae8c87277b60",
                "queued_behind": "0",
                "span_id": "d6bee28190bccbc3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "d6bee28190bccbc3",
                "span_id": "605f2fa92acb1ab9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "d6bee28190bccbc3",
                "queued_behind": "0",
                "span_id": "595cb0d99f3151e1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  40.090s] 887 tests run: 886 passed, 1 failed, 1 skipped
        FAIL [   2.968s] (887/887) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Deferred

The plan marked these test lines deferred: the executor lacks the lane, so nothing here ran them and they still owe evidence.

line lane
./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm vm

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Closes #2910

min host stop <host> stops each running box on the local host as
min box stop does, then its daemon, and its VM on a VM host. With
--force, each box gets the forced stop and the daemon is stopped
without a wait for its clean shutdown. A VM is then stopped from
this machine.

The host-side VM stop that min stop --force uses moves into a shared
helper, so both commands stop a VM the same way.
On a VM-backed lane, min host stop on the VM host stops two running
boxes, then the daemon and its VM. The case checks the printed lines,
that minvmd status reads the VM as stopped, and that each box stays
listed as stopped.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 33426e3f-5489-4711-8bc6-137f19ef6a12

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@agent-137

Copy link
Copy Markdown
Member

/revise Review at head bf0a2a2. cli.rs and cmd/mod.rs are accepted as wiring. Fix these:

  1. --force does not stop a wedged VM host (crates/minimal/src/cmd/hosts.rs ~484-512, BCLI-049). probe_host returns HostState::Unreachable when the connect works but GetVersion fails or times out. cmd_host_stop branches only on Stopped, so it goes on to Client::connect, which succeeds. Then list_box_records fails with "the boxes on were not listed". The command exits non-zero, the VM stays up, and the message gives no next step. That is the stuck guest --force exists for, and min stop --force recovers from it today. The same happens when one forced StopBox fails: the ? returns before shut_down_host_daemon.

    With --force on a VM host, an Unreachable probe, a failed list, or a failed box stop must fall through to the forced shutdown, or else to host_unreachable's host-side VM stop. Report each box that could not be stopped, then still take the VM down. Add a test for a host that connects but does not answer.

  2. The "does not answer" failures in host_unreachable (~551-556) exit 1. min stop exits 7 for an unreachable host through HostUnreachable::over (BCLI-034). Use the same.

  3. stopped += 1 (~513) also counts a box whose stop answered already_exited. Count only the boxes this command stopped.

  4. The --force path prints UNACKNOWLEDGED_STOP_CAVEAT (lifecycle.rs ~576), which says "Running sessions were killed". From min host stop, say boxes. Do it without changing what min stop prints, or change both if one string serves both (AGENTS.md: one name for one thing).

Change nothing else.

An unanswered probe, a failed box listing or a failed forced box stop
on a VM host now falls through to the host-side VM stop. A host that
does not answer exits 7, as min stop does. The box count leaves out
boxes that had already exited, and the forced-stop caveat names boxes.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a /revise note, pushed as 736ed4e0252b.

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-2e4f... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "b8afd356ecc10b6f",
                "span_id": "3582d8c67950ecdc",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "b8afd356ecc10b6f",
                "span_id": "545f0326d66c882f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "b8afd356ecc10b6f",
                "span_id": "30807fcc3a2efc49",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "b8afd356ecc10b6f",
                "queued_behind": "0",
                "span_id": "c6eb5f46cb9270ed",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "b8afd356ecc10b6f",
                "queued_behind": "0",
                "span_id": "35dc371c09ce9e9b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "35dc371c09ce9e9b",
                "span_id": "30c73c5c9136d7a1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "35dc371c09ce9e9b",
                "queued_behind": "0",
                "span_id": "6ca61e2db04303ba",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  51.038s] 892 tests run: 891 passed, 1 failed, 1 skipped
        FAIL [   3.154s] (892/892) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Converted to a draft: something above needs a person before review.

min host stop stops each box on the host, then its daemon and its VM. With --force, a VM host whose daemon connects but does not answer still has its VM stopped from this machine.

Notes from the agent: Revise round 1, one item at a time. (1) In cmd_host_stop, --force on a VM host with an Unreachable probe goes straight to host_unreachable, which stops the VM from the host. A failed box listing goes to host_unreachable in every mode, so it exits 7 and names --force on a VM host. A failed forced box stop on a VM host is logged and the loop goes on. Each such box then prints <box> did not answer the stop. It ended when its VM stopped. after the VM is down. Without --force, or on a native host, a failed box stop still ends the command as before. The new test host_stop_force_forces_boxes_and_daemon_when_daemon_does_not_answer uses a socket that accepts and never writes. It checks that the forced run exits 0 inside the probe budget, and that the unforced run fails with HostUnreachable and names min host stop local-minvmd0 --force. Its VM dir has no running VM, so the forced run prints local-minvmd0 is not running. (HostStop::NothingSignalled). The kill of a live wedged guest is left to the VM lane. (2) Both refusals in host_unreachable now use HostUnreachable::over, so they exit 7. (3) stop_listed_box now returns Ok(bool): true only when this stop stopped the box. min host stop counts only those. min box stop ignores the value. (4) A new HOST_UNACKNOWLEDGED_STOP_CAVEAT says boxes and stop steps. shut_down_host_daemon prints it. What min stop prints is unchanged. Deferred, not run: ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm (lane: vm). It is unchanged this round. just clippy-strict was not run.

@agent-137

Copy link
Copy Markdown
Member

/revise The --force fix at head 736ed4e is correct. Four small follow-ups in crates/minimal/src/cmd/hosts.rs:

  1. ~522 and ~539: "<box> did not answer the stop. It ended when its VM stopped." prints for every Err from stop_listed_box. That includes a refusal the daemon did answer (box_rpc_error, such as a box removed between the list and the stop) and a failed write to out. Say "did not answer" only for a timeout or a lost connection. Otherwise name the refusal (AGENTS.md: say only what the code can prove).
  2. ~518-535: when StopBox times out on a guest that still answers ListBoxes, every remaining box waits the full timeout, then the forced Shutdown waits again, so the stop takes (N+1)×60 s. After the first timeout under --force, skip the remaining per-box stops and go straight to the forced shutdown. Report the boxes it skipped.
  3. ~535: if shut_down_host_daemon returns an error, the ? returns before the not_stopped lines print. Print them first, then return the error.
  4. ~507: without --force, a ListBoxes answer that is an error (Errorable::Err) now refuses as "does not answer" with exit 7, though the daemon answered. Keep exit 7 and "does not answer" for a timeout or a lost connection. For an error answer, name it, as "the boxes on were not listed: " did.

Update or add the tests that pin these lines. Change nothing else.

Only a timeout or a lost connection prints "did not answer". A daemon
refusal or a box gone before the stop is named. After the first stop with
no answer, the remaining boxes are skipped and reported, so the forced
shutdown follows at once. The box lines print before a shutdown error
returns. Without --force, a ListBoxes error answer is named, not exit 7.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 2910b43b0087.

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-0650... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "553e5576d64e6822",
                "span_id": "e606a1372ee33c4f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "553e5576d64e6822",
                "span_id": "475de2e888084dc4",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "553e5576d64e6822",
                "span_id": "4178c57c007c1871",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "553e5576d64e6822",
                "queued_behind": "0",
                "span_id": "5d56c79a24303286",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "553e5576d64e6822",
                "queued_behind": "0",
                "span_id": "9e6d84744f7176bb",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "9e6d84744f7176bb",
                "span_id": "16b6970244c6a55e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "9e6d84744f7176bb",
                "queued_behind": "0",
                "span_id": "8946eafd1305da82",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  49.854s] 895 tests run: 894 passed, 1 failed, 1 skipped
        FAIL [   3.032s] (895/895) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Converted to a draft: something above needs a person before review.

min host stop stops each box on the host, then its daemon and its VM. With --force, a box it did not stop now gets a line that says why: no answer, skipped after an earlier box got no answer, no longer on the host, or the daemon's own answer.

Notes from the agent: Revise round 2. (1) A new rpc_unanswered in lifecycle.rs treats an error as no answer only for a russh error in the chain, the client's "RPC timed out after" deadline, or an empty reply that did not decode. minimal-client has no typed timeout error, so the timeout and the empty reply are matched on the client's message text. That crate is outside the layers. A refusal prints " was not stopped. The daemon on answered: ", and a box gone before the stop prints " was not stopped, because it is no longer on ." A failed write to out after a successful stop counts the box as stopped, and the write error returns after the VM stop. (2) After the first unanswered forced stop, the remaining boxes are not asked. Each prints " was not asked to stop, because did not answer the stop." (3) The lines print before the shutdown error returns. "It ended when its VM stopped." is appended only when the shutdown worked. (4) Without --force on a VM host, a ListBoxes error answer returns "the boxes on were not listed: ". A timeout or a lost connection still exits 7 with "does not answer". Item 4 is pinned by the classification test, not by an end-to-end test, because the harness daemon has no way to answer ListBoxes with an error. Deferred, not run: ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm (lane: vm). just clippy-strict was not run.

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 2910b43. fb6991f: 'did not answer' now prints only for a timeout or lost connection; an answered refusal is named, and a box gone since the listing says so. Under --force the first unanswered stop skips the remaining per-box stops and goes to the forced shutdown, naming the skipped boxes. The not-stopped lines print before a VM-stop error returns. Without --force a ListBoxes error answer is named, and only an unanswered listing exits 7. Every --force failure still ends in a VM stop. Low follow-ups (untested lines, subsystem refusal under version skew, RPC names in two rare messages) are in #3027.

@agent-137

Copy link
Copy Markdown
Member

/review

@minimal-foundry

minimal-foundry Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviewed: 1 finding, none blocking at bdd1651148ef.

Address the comments on the diff.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The code conforms to architecture.md line 540. Each running box stops as min box stop stops it, then the daemon stops, and on a VM host the VM stops too. --force forces both. The VM half has proof only in host_stop_stops_boxes_then_daemon_and_vm, and no CI lane runs that case. The KVM lane runs session-e2e.sh with no argument, and the case is not in that full run. Add the call to the full run, as C1 says.

Ruled at 2910b43 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
A Shutdown error that the daemon reported is an answer, and the VM stays up. min host stop now returns that error at once, not after a 20 s wait.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The code conforms to architecture.md line 540. It stops each running box as min box stop does, then the daemon, and on a VM host the VM. --force forces both. The VM half has no proof that any lane runs. The e2e case host_stop_stops_boxes_then_daemon_and_vm is in the selector, but not in the whole-lane order that CI runs. Add the case to that order, as C1 says.

Ruled at fa288d4 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as fa288d4196cd.

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-e91b... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "d60c8162b06acfd6",
                "span_id": "bd4523a63d3e07bf",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "d60c8162b06acfd6",
                "span_id": "967104ab1fca6375",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "d60c8162b06acfd6",
                "span_id": "2318014cab51cb4f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "d60c8162b06acfd6",
                "queued_behind": "0",
                "span_id": "10ded95c7a87a132",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "d60c8162b06acfd6",
                "queued_behind": "0",
                "span_id": "d5f91f9069f112ab",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "d5f91f9069f112ab",
                "span_id": "9cb50bab59bd4155",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "d5f91f9069f112ab",
                "queued_behind": "0",
                "span_id": "db4da5ce658e92b1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  53.076s] 895 tests run: 894 passed, 1 failed, 1 skipped
        FAIL [   3.228s] (895/895) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/boxes/lifecycle.rs: Gated the VM wait in the Shutdown error arm on rpc_unanswered, so an error the daemon reported returns at once and only a lost reply waits for the VM to stop.

min host stop <host> stops each box on the host, then its daemon and its VM. On a VM host without --force, an error that the daemon reports now returns at once, with no 20 s wait.

Notes from the agent: Revise round 3: one finding, fixed. The VM-host Shutdown error arm in shut_down_host_daemon now waits for the VM only when rpc_unanswered says the reply was lost. No new test pins this arm, because the in-process harness has no VM host. The existing test host_stop_force_forces_boxes_and_daemon_tells_no_answer_from_an_answer pins the rpc_unanswered classification. Deferred (lane: vm): ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm, not run on this box.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 5, 2026 01:00
@agent-137

Copy link
Copy Markdown
Member

/revise Arch C1 (threads PRRT_kwDOPdfcxM6z3zeW, PRRT_kwDOPdfcxM6z39TL): proof_host_stop_stops_boxes_then_daemon_and_vm (scripts/session-e2e.sh ~30856) is called only by the single-case selector (~31119). The no-argument run (~31020-31043) never calls it, so no CI lane proves the VM half of min host stop. Add the call to that full run where the later arch ruling says: after proof_escapes_and_builds_stay_inside_box_rules and before proof_host_ip_deny_all. Add a comment that it stops the VM host and the next command autospawns a fresh one. Change nothing else.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a /revise note, pushed as fdffc0f4f842.

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-d0e9... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling client-config v0.0.1 (/wo

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "f8a75c5fb0a43fe5",
                "span_id": "f5d611f860796c7f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "f8a75c5fb0a43fe5",
                "span_id": "abca7b63e7f3e7ba",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "f8a75c5fb0a43fe5",
                "span_id": "5b019b4cf6a018fd",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "f8a75c5fb0a43fe5",
                "queued_behind": "0",
                "span_id": "db742231307e7bd8",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "f8a75c5fb0a43fe5",
                "queued_behind": "0",
                "span_id": "c7b4d59e38cc42ab",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "c7b4d59e38cc42ab",
                "span_id": "0f9890df75c8e1e4",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "c7b4d59e38cc42ab",
                "queued_behind": "0",
                "span_id": "9a461f10ab35ad97",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  52.005s] 900 tests run: 899 passed, 1 failed, 1 skipped
        FAIL [   3.229s] (900/900) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — scripts/session-e2e.sh:30856: The full no-argument run now calls proof_host_stop_stops_boxes_then_daemon_and_vm. It runs after proof_escapes_and_builds_stay_inside_box_rules, not after proof_published_proxy_routes_from_host, because the later arch ruling put it there.
  • 👍 valid — scripts/session-e2e.sh:30856: The full run now calls proof_host_stop_stops_boxes_then_daemon_and_vm after proof_escapes_and_builds_stay_inside_box_rules, with a comment that the next command autospawns a fresh VM host.

min host stop <host> stops each box on the host, then its daemon and its VM. The full no-argument run of scripts/session-e2e.sh now calls proof_host_stop_stops_boxes_then_daemon_and_vm, so the VM lane proves the VM half.

Notes from the agent: This round changes only scripts/session-e2e.sh, as the /revise note asks. The full run calls the host stop proof after proof_escapes_and_builds_stay_inside_box_rules and before proof_host_ip_deny_all. A comment says that the proof stops the VM host and that the next command autospawns a fresh one. Deferred (lane: vm): ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm. I did not run it, because this box has no VM lane. bash -n passes on the script. The commitlint failure is on the earlier commit fa288d4: one body line is longer than 100 characters. The rules do not permit me to rewrite or force-push commits already on the branch, so that check stays red until a person rewords that commit or squashes on merge.

@agent-137
agent-137 marked this pull request as ready for review November 5, 2026 02:22

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved at fdffc0f: fdffc0f: the full no-argument e2e run now calls proof_host_stop_stops_boxes_then_daemon_and_vm after proof_escapes_and_builds_stay_inside_box_rules and before proof_host_ip_deny_all, with a comment that the next command autospawns a fresh VM host (arch C1).

@agent-137

Copy link
Copy Markdown
Member

/review

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 2 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh:30856, minimal-arch[bot] scripts/session-e2e.sh:30856.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head conforms to architecture.md line 540. The fdffc0f4 commit adds the host stop proof to the full run of scripts/session-e2e.sh, so the required VM lanes now run the VM half of min host stop. The earlier ruling stands for the Rust code, because the compare does not change it. The deferred VM leg must pass in ci-linux-kvm-success and ci-macos-success before the merge. A red lane reopens this ruling.

Ruled at fdffc0f against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @agent-137 closed the last one. The review of fdffc0f4f842 withheld this approval on the threads open then. Posted as a comment, as the review itself was; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 5, 2026
In the whole-lane run the earlier proofs can leave more boxes
running, and a daemon respawn can leave the shared session stopped.
The proof now starts two boxes of its own, and checks that the
summary count equals the box lines that min host stop printed.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change still conforms to architecture.md line 540. The code is the same as on fdffc0f4, which passed. The new commit changes only the e2e proof. The proof now starts its own two boxes. It checks that the summary count equals the box lines that min host stop printed. That still proves the rule, which is to stop each running box before the daemon and the VM.

Ruled at b156d93 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Nov 5, 2026
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a failed check suite, pushed as b156d9363135.

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-abc2... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "9381d618a61817a8",
                "span_id": "e65044f17dd5ad79",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "9381d618a61817a8",
                "span_id": "a91a248d6bc3f0b6",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "9381d618a61817a8",
                "span_id": "314e591d0dc9005f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "9381d618a61817a8",
                "queued_behind": "0",
                "span_id": "476bc5ae534f3b25",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "9381d618a61817a8",
                "queued_behind": "0",
                "span_id": "a6f3e078c8165ece",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "a6f3e078c8165ece",
                "span_id": "cf1359bfd04ece8d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "a6f3e078c8165ece",
                "queued_behind": "0",
                "span_id": "3bd8f1e602fd5af5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  52.733s] 905 tests run: 904 passed, 1 failed, 1 skipped
        FAIL [   3.526s] (905/905) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Converted to a draft: something above needs a person before review.

A person runs min host stop <host> on a VM host. It prints Stopped <box>. for each running box, then "Stopped boxes, the daemon and its VM on ." The VM is down, and the box records stay as stopped. The e2e proof now checks this in the whole-lane run too, with two boxes of its own.

Notes from the agent: test-kvm: the job log excerpt shows no failure line, only the ::error:: strings in the workflow step source. So the cause is not certain. I found one fault that a whole-lane run hits. The proof asserted exactly 2 boxes and the shared session, but earlier proofs can leave more boxes running, and a daemon respawn can leave the shared session stopped. The proof now starts its own two boxes (e2e-host-stop-a, e2e-host-stop-b), and checks that the summary count is at least 2 and equals the Stopped <box>. lines printed. It still removes the shared session after the stop, so later proofs activate a fresh one. Deferred (lane: vm): ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm. I did not run it on this box. I checked the script with bash -n and shellcheck only. ci-linux-kvm-success is the aggregator of test-kvm and fails for the same reason. commitlint: the body of commit fa288d4 has a line over 100 characters. A fix needs a rewrite of that commit, and the rules for this round forbid a rewrite or a force-push. A person must reword it, or squash the pull request on merge with a valid message. The new commit has body lines under 72 characters.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 5, 2026 02:59
@agent-137
agent-137 marked this pull request as ready for review November 5, 2026 03:07

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at b156d93. d3d4abf makes the host-stop proof start its own two boxes (an earlier respawn in a whole-lane run can leave the shared session stopped) and checks that the summary's count equals the number of 'Stopped .' lines, at least 2, since earlier proofs can leave more running. The two boxes are then listed as stopped after the VM boots again.

@agent-137

Copy link
Copy Markdown
Member

/review

@agent-137
agent-137 added this pull request to the merge queue Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 5, 2026
…t-with-its-boxes-daemon-and-vm

# Conflicts:
#	scripts/session-e2e.sh

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head is a merge of main (#3028) and has no new branch commit. The one merge conflict is in the VM-lane selector of scripts/session-e2e.sh. The resolution keeps the case from #3028 and adds the host stop case. The host stop proof keeps its place in the full run. BCLI-049 conforms to architecture.md line 540, as it did on b156d936.

Ruled at bdd1651 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

A merge of main before round 6, not counted against the cap (1 of 3), pushed as bdd1651148ef.

Resolved conflicts in: scripts/session-e2e.sh

line exit tail
cargo nextest run -p minimal host_stop_force_forces_boxes_and_daemon 0 Applying loadouts: default Running task runtime-implement-test-0 in session task-runtime-implement-test-0-ca90... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot) Compiling args v0.0.1 (/workbench/crates/args) Compiling client-config v0.0.1 (/wo

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

dSpan {
            name: "session.message",
            fields: {
                "kind": "GetNetSwitch",
                "parent_span_id": "0810ed14cd13c8fd",
                "span_id": "f3124893a2023346",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetDenyAllOptOut",
                "parent_span_id": "0810ed14cd13c8fd",
                "span_id": "f937944ea8d1667c",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "GetPaths",
                "parent_span_id": "0810ed14cd13c8fd",
                "span_id": "9c1fd7c1eac29483",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "0810ed14cd13c8fd",
                "queued_behind": "0",
                "span_id": "d7f568d433e63632",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "0810ed14cd13c8fd",
                "queued_behind": "0",
                "span_id": "465b4302bfec0b01",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "465b4302bfec0b01",
                "span_id": "29a51bcfda050981",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "465b4302bfec0b01",
                "queued_behind": "0",
                "span_id": "8ed6f8de8d31addb",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  51.524s] 905 tests run: 904 passed, 1 failed, 1 skipped
        FAIL [   3.098s] (905/905) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cli.rs
  • crates/minimal/src/cmd/mod.rs

Converted to a draft: something above needs a person before review.

min host stop stops each box on the host, then its daemon and its VM. This round keeps that work and merges main into the branch without a conflict.

Notes from the agent: Revise round: resolved the merge conflict in scripts/session-e2e.sh. The VM-lane selector case list now carries both host_exposures_follow_the_table (from main) and host_stop_stops_boxes_then_daemon_and_vm (this task). The merge is committed. Deferred (lane: vm): ./scripts/session-e2e.sh host_stop_stops_boxes_then_daemon_and_vm was not run on this box. bash -n on the script passes.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 5, 2026 04:24
@agent-137
agent-137 marked this pull request as ready for review November 5, 2026 04:38

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved at bdd1651: a merge of main. The only change to the PR's net diff is the e2e case list resolving around main's new host_exposures_follow_the_table case; the host stop proof is still in the full run.

@agent-137
agent-137 added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 6cced61 Nov 5, 2026
35 of 36 checks passed
@agent-137
agent-137 deleted the agent/2910-stop-a-host-with-its-boxes-daemon-and-vm branch November 5, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T28 — Stop a host with its boxes, daemon and VM

1 participant