Skip to content

ci(kani): run the proofs on PRs that touch mlog or minvmd; drop the dead sessions path - #3118

Merged
bryan-minimal merged 2 commits into
mainfrom
ci/kani-filter-mlog-minvmd
Nov 9, 2026
Merged

bryan-minimal merged 2 commits into
mainfrom
ci/kani-filter-mlog-minvmd

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Closes #3117.

scripts/kani.sh expects 9 harnesses in mlog and 5 in minvmd, but ci-kani.yml's changes filter listed neither, so a PR changing only one of those crates merged with its proofs unrun; they ran again only on the push to main. This adds crates/mlog/** and crates/minvmd/** to the filter and drops crates/sessions/**, which no longer exists.

One hunk in the workflow, no Rust. actionlint is clean. Found while measuring the lab's prepush runs (min-regress #93): the lab's own Kani gate ran on three PR tips where this filter would not have.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI change filtering to cover the renamed crate and two additional crates.
    • Changes to the former crate no longer trigger the Kani filter.

…ead sessions path

scripts/kani.sh expects 9 harnesses in mlog and 5 in minvmd, but ci-kani.yml's paths-filter
listed neither, so a PR changing only one of those crates merged with its proofs unrun; they ran
again only on the push to main. crates/sessions/** no longer exists.

Closes #3117

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 7, 2026 00:21
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Kani workflow change filter now matches crates/mlog/** and crates/minvmd/**. It replaces crates/sessions/** with crates/boxes/** and adds comments about the crates listed in scripts/kani.sh.

Changes: Kani workflow filter

Layer / File(s) Summary
Update Kani filter paths
.github/workflows/ci-kani.yml
The filter adds crates/mlog/** and crates/minvmd/**. It replaces crates/sessions/** with crates/boxes/** and documents that the filter should cover crates listed in scripts/kani.sh.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: mitodrummer

Merge Risk: Minimal · up to cf4d7

This change makes pull requests that touch the mlog or minvmd crates run their Kani proofs, and it removes an obsolete path. It affects CI only, with no runtime impact, and carries no identified merge risk.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the Kani filter changes: adding coverage for mlog and minvmd and removing the obsolete sessions path.
Description check Passed The description explains the change and its rationale, references issue #3117, and reports that actionlint is clean. It does not include the template’s Checklist section or pasted test output, but i…
Linked Issues check Passed [#3117] The pull-request filter now matches crates/mlog/** and crates/minvmd/**, so changes to either crate select the Kani job. The filter removes the obsolete crates/sessions/** path and retai…
Out of Scope Changes check Passed The workflow comments document the path-filter rule and the sessions to boxes rename. These changes support [#3117]. The diff contains no unrelated changes.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Description check

Explanation

The description explains the change and its rationale, references issue #3117, and reports that actionlint is clean. It does not include the template’s Checklist section or pasted test output, but it is otherwise mostly complete.

Full details: Linked Issues check

Explanation

[#3117] The pull-request filter now matches crates/mlog/** and crates/minvmd/**, so changes to either crate select the Kani job. The filter removes the obsolete crates/sessions/** path and retains crates/boxes/**. The workflow runs ./scripts/kani.sh when the filter matches. Deriving the paths from the script was optional.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the Kani list,
New crate paths join the shift.
Boxes stays; sessions departs,
Mlog, minvmd take their parts.
Proofs await each changed track,
I nibble greens and hop right back.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0682f8c5-32bd-448d-8684-16a25adc6834
Commits

Reviewing files that changed from the base of the PR and between 505265b and cf4d73a.

Files selected for processing: 1

  • .github/workflows/ci-kani.yml
Files skipped from review as they are similar to previous changes: 1

  • .github/workflows/ci-kani.yml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

@minimal-foundry

minimal-foundry Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewed: no findings; approval withheld, 1 thread unresolved at cf4d73a80153.

APPROVE withheld: 1 unresolved thread — norrietaylor .github/workflows/ci-kani.yml. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 7, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title. The PR changes one hunk in .github/workflows/ci-kani.yml and no Rust. Clobber none. git log on the workflow shows the last related edits are #1537 (bep path) and #2200. This diff keeps both. Correctness the filter now matches the crates that scripts/kani.sh proves: boxes, rcache, mlog, minvmd and bep (the expect lines at scripts/kani.sh 161-165). crates/sessions does not exist in the tree, so the PR removes a dead path. Every harness lives in its own crate (mlog/src/otel/{spool,switches}.rs, minvmd/src/vm.rs), and the harnesses import only super:: and std or third-party items. So the two new globs cover the proof closure, with no other workspace crate needed. AGENTS.md calls .github/workflows/ frozen and CODEOWNER-gated. This PR needs a CODEOWNER approval for that reason. Outside the diff: the workflow header comment (lines 3-6) still names only rcache and PathDecision, and the scripts/kani.sh cost table still says sessions. Both are stale, and a follow-up can fix them. Not checked: an actual lane run. That needs CI.

Comment thread .github/workflows/ci-kani.yml Outdated
# scripts/kani.sh also proves mlog (the OTel spool and
# switch harnesses) and minvmd (vm.rs); without these
# two a PR touching only one of them merged with its
# proofs unrun (#3117).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit · The comment tells the history of the bug ("merged with its proofs unrun (#3117)"). It does not state the rule a future editor must follow. Say what keeps the filter correct: the filter must list every crate that has an expect line in scripts/kani.sh. Then the next crate that gains a harness gets a filter path too.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in cf4d73a: the comment now states the rule (the filter lists every crate with an expect line in scripts/kani.sh, five today, and a crate that gains a harness gets a path in the same change), with the miss as the example rather than the subject.

…the miss

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — norrietaylor .github/workflows/ci-kani.yml. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Nov 9, 2026
@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 838e26b Nov 9, 2026
35 checks passed
@bryan-minimal
bryan-minimal deleted the ci/kani-filter-mlog-minvmd branch November 9, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci-kani.yml never runs the mlog and minvmd proofs on a PR that touches only those crates

2 participants