Repository navigation
Conversation
`min box start`, `min session start`, `min task run` and `min box run` now take `--dynamic-ingress`, `--dynamic-range`, `--credentialed-upstream`, `--no-loadouts` and `--no-hooks`, as `min session activate` does (BCLI-024, BCLI-075, BCLI-076). A session entry's start passes them to the activation. The run path puts the dynamic ingress and the credentialed upstream on the box's policy, turns hooks off under `--no-hooks`, and selects no loadouts under `--no-loadouts`. `--no-loadouts` with `--loadout` is exit 2. main.rs gains one line: its test builds a `TaskRunArgs` literal.
The session start table lists --dynamic-ingress, --dynamic-range, --credentialed-upstream, --no-loadouts and --no-hooks. The text says which of them a task entry's start, min task run and min box run take.
Pre-merge checks:
|
|
Undrafted by the BCLI babysitter under the owner's standing rules. The only file outside |
|
Approved: every review thread resolved at @agent-137 resolved the last thread, which releases the approval this review had withheld. Nothing to do. |
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The change puts the override flags in the right place and conforms to BCLI-075 and BCLI-076. BCLI-024 is not complete. Type nouns line 458 gives a flag for each [network] key, and --quic443 and --vpn-network-names are still missing. The PR calls them a later gap but links no issue. File the issue and name it, as C1 says. The reference row for --credentialed-upstream names an entry key that the design says an entry never declares (Box Spec lines 951-953). Rewrite that row, as C2 says.
Ruled at 6b956be against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
…run-take-every-override-flag-that-sess
minimal.toml has no network.credentialed_upstream key. Also note in cli.rs that --quic443 and --vpn-network-names have no flag yet.
There was a problem hiding this comment.
arch-review: CONDITIONS · 1 condition · the full ruling
Start and run now take --dynamic-ingress, --dynamic-range, --credentialed-upstream, --no-loadouts and --no-hooks. The placement, the hook handling and the exit 2 conflict conform to the Type nouns paragraph. One gap stays open. Line 458 of the design gives every start and run a flag for each [network] key. quic443 and vpn_network_names are such keys and still have no flag. The comment in cli.rs says the gap needs an issue, but it names none. Do C1: file the issue and put its URL in the comment and the PR body, or add the two flags.
Ruled at a4400df against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 3 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:1324, minimal-arch[bot] docs/reference/cli-min.md, minimal-arch[bot] crates/minimal/src/cli.rs:1333. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
|
Round 1 of 10 on a failed check suite, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
A box that Notes from the agent: Revise round 1. The failed checks look like infrastructure. The e2e job exited 100 after an install-action error in its setup steps, and ci-macos-success only aggregates that job. Nothing in this round addresses them. A re-run is the next step. I ran the four test lines in one nextest invocation with all four filters, and all four passed. Vale is not installed on this box, so |
|
/revise Head Add Reply on the arch thread with the commit. Run the whole |
…run-take-every-override-flag-that-sess
BCLI-024 gives every [network] key a flag. --quic443 replaces the box's network.quic443 stance, and each --vpn-network-names adds a name to network.vpn_network_names in the stored spec. Both reach the start and run paths the other network-key flags use.
|
Round 2 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
A box started with min session start or min box start, or run with min task run or min box run, stores the value of each activate override flag. It also stores --quic443 as network.quic443 and each --vpn-network-names name in network.vpn_network_names. --no-hooks stores no hooks, and --no-loadouts applies no loadouts. Notes from the agent: Revise round 2. BoxOverrideArgs takes --quic443 <auto|block|allow> and --vpn-network-names , and the follow-up comment above the struct is gone. --quic443 replaces policy.quic443 (the declared minimal.toml stance) on the start path (activate_box) and the run path (apply_run_overrides). Each --vpn-network-names adds one name to network.vpn_network_names in the request's spec JSON (add_vpn_network_names in create.rs). The name is not added twice. BoxPolicy and mfile's BoxSpec have no field for vpn_network_names, so the names go in the spec JSON. The daemon stores that JSON as sent and warns that it does not enforce the section (BOX-076). A BoxSpec still reads from that JSON. The start path carries the two values on ActivationOptions, not ActivateArgs, because attach.rs, vm_host.rs and list.rs build ActivateArgs literals, and those files are outside the layers. So min session activate does not take the two flags. The arch thread asked for that too, but the /revise note asks for BoxOverrideArgs only. The every_create_session_asserts_the_daemon_build inventory needed the new test site in its list (tests.rs). The runner writes the PR body, so I did not edit its 'Gaps for a later task' entry. Remove the quic443/vpn line there. I did not run just lint-prose on docs/reference/cli-min.md because vale is not installed on this box. |
|
Undrafted by the BCLI babysitter after the latest round, under the owner's standing rules. The only draft causes are files a round asked for and the runtime's nextest-missing test lines. |
…run-take-every-override-flag-that-sess
There was a problem hiding this comment.
arch-review: CONDITIONS · 1 condition · the full ruling
--quic443 conforms, and it closes the gap that the last ruling left open. --vpn-network-names does not conform. The client-built spec never holds the entry's declared network.vpn_network_names, so add_vpn_network_names appends to an empty list. A declared name is then lost when the flag is given. Section Type nouns (line 458) says a flag for a list key adds to the list. Make the change in C1: seed the list from the entry on both paths, and pin it with a test.
Ruled at 43c7819 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
add_vpn_network_names returned Ok without a change when the request carried no spec, so an interactive task run dropped the names. It now refuses them, and the run path calls it on both branches.
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
The start and run verbs take the override flags, and each flag reaches the stored spec, as Type nouns line 458 requires. One gap is left. min box show --network reads the record policy, so it does not show --vpn-network-names values. The client cannot read the stored spec, so the fix needs daemon work outside this task. Do C1: file the issue, name it in the PR body, and say in the reference that show --network does not print the names yet.
Ruled at 8e85ff4 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
Round 3 of 10 on the runtime's review findings, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
A box started or run with any of the activate override flags stores those values. Notes from the agent: Revise round 3: the one open thread is valid. add_vpn_network_names now refuses non-empty names when the request has no spec, and task.rs calls it on both branches. The start path always stamps a spec, so the refusal can only fire on the run path for an interactive task. The task load refuses an interactive task today (BOX-054), so this path is latent. New refusal text: "Cannot use --vpn-network-names here: this box does not store a |
|
/revise Head Register the new create site in the inventory. |
|
Round 4 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
A box started or run with any of the activate override flags stores those values. --no-hooks stores no hooks, and --no-loadouts applies none. The whole minimal suite now passes at the branch head, the create-site inventory test included. Notes from the agent: This round changes only the create-site inventory, as the /revise note asks. The four task test: lines were not run one by one this round. They passed inside the whole-crate run. Thread verdicts: the first two threads find a real gap, but its fix is out of this round and out of the layers, so the verdicts are invalid with that reason. A follow-up issue is needed: SpecNetwork in crates/mfile/src/spec.rs has no vpn_network_names field, so BoxSpec::build drops a declared network.vpn_network_names. |
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 7 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:1324, minimal-arch[bot] docs/reference/cli-min.md, minimal-arch[bot] crates/minimal/src/cli.rs, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:2721, minimal-arch[bot] crates/minimal/src/task.rs, …. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
The change conforms to the Type nouns section, line 458. The start and run verbs take the override flags, --no-loadouts and --no-hooks in the client layer, and the stored spec carries the values. The compare since 8e85ff4c only lists a test in the inventory. One proof gap stays open. The run-path test for --no-hooks checks the parsed flag, not the stored spec of the run box. Close it with C1. The missing run-path --ingress and --loadout, and the min box spec <entry> flags, are residuals under #3163, #3237 and #2906.
Ruled at c5208e5 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
/revise Head
Reply on the arch thread with the commit. Run the whole |
start_no_hooks_stores_no_hooks now builds the run request and spec as task::run_entry does, and asserts the spec's hooks_enabled is false for min task run and min box run.
…run-take-every-override-flag-that-sess
|
Round 5 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
A box started or run with any of the activate override flags stores those values. With --no-hooks, the stored spec has hooks_enabled false for min session start, min box start, min task run and min box run. --no-loadouts applies no loadout, and with --loadout it exits 2. Notes from the agent: Revise round 5, commit 03cf691. start_no_hooks_stores_no_hooks now builds the run request as task::run_entry does: hooks_enabled = !run.other.no_hooks, the spec from task_box_spec with crate::spec_flags(&request), then put_spec. It asserts that the stored spec has hooks_enabled false for min task run --no-hooks and min box run --no-hooks. To call them from tests.rs, task_box_spec and declared_task in task.rs changed from private to pub(crate). That is the only change in task.rs. The test builds a CreateSessionRequest that it never sends, so every_create_session_asserts_the_daemon_build lists it as 'asserts nothing', the same as the entry for start_and_run_take_every_network_key_flag. The whole minimal suite passed: 1068 passed, 1 skipped. I cannot post on the arch thread. The thread reply below names the commit. |
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 8 unresolved threads — minimal-arch[bot] crates/minimal/src/cli.rs:1324, minimal-arch[bot] docs/reference/cli-min.md, minimal-arch[bot] crates/minimal/src/cli.rs, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:2721, minimal-arch[bot] crates/minimal/src/task.rs, …. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
There was a problem hiding this comment.
arch-review: PASS · the full ruling
This head conforms to the Type nouns paragraph (architecture.md line 458). The new commit checks the stored spec of a run box under --no-hooks. It uses the real spec builders, and it does not relax a check. The merge of main is clean and changes no line of this PR. Every [network] key now has its flag on start and run, and the hook and loadout flags behave as line 458 says. One residual stays open: the daemon stores --vpn-network-names but does not enforce it, under #1420.
Ruled at 814054e against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — every review thread is resolved; @agent-137 closed the last one. The review of 814054e422f8 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.
T40 — Start and run take every override flag that session activate takes
slice: S3
kind: task
covers: BCLI-024, BCLI-075, BCLI-076
size: M
est: 200 code, 200 tests
executor: agent
difficulty: routine
model: standard
diagnostics:
--no-loadoutswith--loadoutis exit 2 naming both flags, pinned by start_no_loadouts_with_loadout_exit2observability: none new
layers:
- client:
- crates/minimal/src/cli.rs: the start and run verbs take the remaining override flags:
--dynamic-ingress,--dynamic-range,--credentialed-upstreamand every other[network]key flag that BCLI-024's rule gives, plus--no-hooksand--no-loadouts- crates/minimal/src/cmd/boxes/create.rs:
min session startandmin box startpass those flags to the command-line override layer, through the shared path #3159 added;--no-hooksempties the composed hooks;--no-loadoutswith--loadoutis exit 2- crates/minimal/src/task.rs:
min task runandmin box runtake the same flags on the run path- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
- docs/reference/cli-min.md: documents the flags on each start and run verb
test: cargo nextest run -p minimal start_and_run_take_every_network_key_flag
test: cargo nextest run -p minimal start_no_hooks_stores_no_hooks
test: cargo nextest run -p minimal start_no_loadouts_with_loadout_exit2
test: cargo nextest run -p minimal run_verbs_take_dynamic_ingress_and_credentialed_upstream
produces: none
consumes: none
proof: A box started or run with any of the activate override flags stores those values;
--no-hooksstores no hooks;--no-loadoutsapplies none.depends on:
- blocked by #2903
- blocked by #3159
Residuals
network.vpn_network_names(mfileSpecNetwork), so--vpn-network-namesadds to a declared list, andmin box show --networkprints the names.--loadouton the run path.Proof
min box start,min session start,min task runandmin box runnow take--dynamic-ingress,--dynamic-range,--credentialed-upstream,--no-loadoutsand--no-hooks. A box started with the dynamic ingress or credentialed upstream flags has those values in its stored spec and in the record the daemon keeps. A box started with--no-hookssends no lifecycle hook, and its spec and record keep hooks off.--no-loadoutsselects no loadouts, and--no-loadoutswith--loadoutends with exit 2 and names both flags.docs/reference/cli-min.mddocuments each flag on the start and run verbs.Notes from the agent: Outside the layers: crates/minimal/src/main.rs gains one line (
other: minimal::BoxOverrideArgs::default()). Its testtask_run_is_a_stdout_contractbuilds aTaskRunArgsliteral, and the crate does not compile without the new field.Design: a new flattened
BoxOverrideArgsin cli.rs holds the five flags, andStartOverrideArgs,TaskRunArgsandBoxRunArgsflatten it. The--loadoutarg ofStartOverrideArgsdeclares the conflict with--no-loadouts, because the run verbs take--no-loadoutsand no--loadout. The exit-2 refusal is clap's ArgumentConflict message ("the argument '--no-loadouts' cannot be used with '--loadout '"). On the run path,task::apply_run_overridesputs the dynamic ingress and credentialed upstream on the policy and refuses a dynamic flag off own_ip with activate's message.refuse_dynamic_ingress_off_own_ipnow takesimpl Into<boxes::NetworkMode>.--no-hookssetshooks_enabled = false, usesHookPrep::Disabled, and stops the dropped-hooks upload warning. The run's host_ip residency now usesadmit_declaring, so a host_ip run box with--credentialed-upstreamopens its lane on a VM host as activate's box does.Gaps for a later task:
--quic443and--vpn-network-names(fornetwork.quic443andnetwork.vpn_network_names). `min session activ…[truncated]Tests
cargo nextest run -p minimal start_and_run_take_every_network_key_flagcargo nextest run -p minimal start_no_hooks_stores_no_hookscargo nextest run -p minimal start_no_loadouts_with_loadout_exit2cargo nextest run -p minimal run_verbs_take_dynamic_ingress_and_credentialed_upstreamVerify
min task run agent-verifyexited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.Out of scope
These files are outside the task's
layers:, so this PR is a draft:crates/minimal/src/main.rsCloses #3281