Repository navigation
feat(minimal): T19 — List and show the box types - #3293
Conversation
min type list prints the six built-in types and each type of the project's [box_types], each with its source (builtin or project) and the type it extends (BCLI-019). min type show <name> prints a type's defaults and constraints, each with the type that sets it and that type's source (BCLI-020). The values come from mfile's box type data, the same data the expansion folds.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Reviewed: 2 findings, none blocking at Address the comments on the diff. Clobber: none seen in the touched hunks. |
There was a problem hiding this comment.
arch-review: CONDITIONS · 5 conditions · the full ruling
min type list conforms to line 463. min type show does not yet render the shipped-types table at lines 1212-1224. mfile gives every built-in type empty tables, and the verify test compares the output to that same data. C1 makes the test pin the architecture rows. C2 files the mfile gap as the BCLI-020 residual. C3 prints the extends chain that line 463 names, and C4 restores exit 3 and exit 4 for a bad minimal.toml and an unknown type. C5 files the residuals that the PR body declares.
Ruled at 160cb82 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
/revise Head 1. C1: the shipped-table test.
Remove the 2. C2: #3294 is the residual. 3. C3: the chain. 4. C4: typed errors and exit codes. 5. C5: build the two residuals instead of filing them.
Reply on the arch threads with the commit. Run the whole |
|
That Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet. |
--repo-dir names the project root, so min type list and min type show no longer read a minimal.toml from a parent directory. Type names, keys and values from minimal.toml print with control characters escaped.
There was a problem hiding this comment.
arch-review: CONDITIONS · 4 conditions · the full ruling
BCLI-019 conforms, and the head fixes the --repo-dir scope and escapes type names. min type show prints only the parent and the root. Line 463 says that it renders the whole extends chain. C1 adds the chain to TypeDetail and to the text. The built-ins show no values, and lines 1212-1220 state values for them. That fix belongs in mfile, so it is a residual. Three residuals in the PR body have no issue: the built-in rows, exit codes 3 and 4, and -o. File them and name them in the PR body (C2, C3, C4).
Ruled at 720e0f6 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
APPROVE withheld: 10 unresolved threads — minimal-foundry[bot] crates/minimal/src/cmd/types.rs:292, minimal-foundry[bot] crates/minimal/src/cmd/types.rs:132, minimal-arch[bot] crates/minimal/src/tests.rs:15136, minimal-arch[bot] crates/minimal/src/cmd/types.rs:247, minimal-arch[bot] crates/minimal/src/cmd/types.rs:307, ….
minimal-review — advisory review
Verdict COMMENT — No findings.
Panel: 2 of 3 personas ran (security, supply-chain); did not complete: correctness.
|
Round 1 of 10 on the runtime's review findings, pushed as
Verify Review threads the coder judged:
Notes from the agent: Revise round 1. Both review findings were valid and are fixed in one commit. load_types now takes search_ancestors and uses mfile::File::from_dir when --repo-dir is set, as min init does. The text output escapes names, keys, values and set_by with the existing box_audit::printable helper. The -o json output is unchanged, because JSON encoding escapes control characters. The list test now also pins the --repo-dir case and the escaped name. cargo clippy -p minimal --all-targets and cargo fmt --check printed nothing. just clippy-strict did not run. |
…how-the-box-types
min type list and min type show take -o json|yaml|toml and write min/v1/type objects. min type show prints every type of the extends chain. A minimal.toml whose box types do not load exits 3, and a name that is no type exits 4. The shipped-table test compares to a fixture of the architecture's rows and waits on #3294.
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The compare adds -o, the type chain, and exit codes 3 and 4, and these conform to lines 346, 381 and 463. BCLI-020 is still open. The proof fixture architecture_builtin_table() holds only part of the shipped-types table at architecture.md lines 1216-1222. With that fixture, the test passes against an mfile that ships only part of the table. C1 lists the missing cells. The PR body is stale, and its residual note names no issue. C2 names #3294 and corrects notes 2 and 3.
Ruled at 0bfd4c1 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
Round 2 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Notes from the agent: Revise round 2. C1: the shipped-table test now compares to a fixture and is #[ignore = "https://github.com//issues/3294"]. The project-type assertions moved to type_show_names_the_type_and_source_of_each_value, which runs. FIXTURE GAP: the architecture document (gominimal/arch architecture.md, rows 1216-1224) is not in this repository, and this box has no network, so I was not able to read the table rows. The fixture holds only the cells that the BOX spec (docs/specs/29) quotes from that table: lifetime = until_complete for session, task, agent, build and container-build, loadout_mode = open (session default), sealed (task default), and sealed as a constraint of build and container-build. A comment on the fixture says this. Somebody must copy the other cells from the table rows before #3294 removes the ignore. C2: I cannot edit the PR body. The runner or a person must list #3294 as the BCLI-020 residual and change |
|
The runtime will not revise this pull request again on its own: the diff is +1375/-0 (1375 lines), past 3x the plan's estimate of 340 lines (est: 220 code, 120 tests, as #2899 reads now), at round 2 (the last trigger was a /revise note). A person decides now. Remove |
|
Undrafted by the BCLI babysitter after the latest round, under the owner's standing rules. The only draft causes are files a round asked for and the runtime's nextest-missing test lines. |
|
/revise Head The fixture holds the whole shipped-types table.
Each Reply on the arch thread with the commit. Run the whole |
Add pty_enabled, exec_enabled, nesting.allowed and timeout, and the missing service lifetime and agent/service loadout_mode defaults, with each (constrains) cell as a constraint.
There was a problem hiding this comment.
arch-review: CONDITIONS · 1 condition · the full ruling
The compare fills the shipped-types fixture, and the cells it adds match the design table. Two rows are still missing: restart = "never" for service, and github_token_mode for every type. Lines 1223-1224 of the architecture give them, and they are not — cells. Add them as C1 says. The empty built-in defaults stay a residual on #3294.
Ruled at 775d587 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 14 unresolved threads — minimal-foundry[bot] crates/minimal/src/cmd/types.rs:132, minimal-arch[bot] crates/minimal/src/tests.rs, minimal-arch[bot] crates/minimal/src/cmd/types.rs:263, minimal-arch[bot] crates/minimal/src/cmd/types.rs, minimal-arch[bot] crates/minimal/src/cmd/types.rs, …. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
|
Round 1 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review.
Notes from the agent: The runner already merged origin/main into the branch (d93bd37). HEAD contains origin/main. The only change in this round adds ("type", "types") to the countable nouns in plural_nouns_accepted. The |
|
The runtime will not revise this pull request again on its own: the diff is +1482/-0 (1482 lines), past 3x the plan's estimate of 340 lines (est: 220 code, 120 tests, as #2899 reads now), at round 1 (the last trigger was a /revise note). A person decides now. Remove |
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
This head adds the main merge and one test row. The row puts the type noun in plural_nouns_accepted, and that adds coverage. The earlier ruling on 91e00948 stands. BCLI-019 conforms. BCLI-020 stays open for built-in types until #3294 ships the table that architecture.md lines 1212-1224 state. C1 un-ignores the proof when #3294 lands.
Ruled at c2e8b46 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
/revise Head
Make the start directory absolute, from the current directory, before the upward search. Add a test that runs Reply on the thread with the commit. Run the whole |
…how-the-box-types
min type list and min type show searched up from a relative ".", whose parent never reaches a real directory. Start from the absolute current directory.
|
Round 1 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Run in a subdirectory of a project, Notes from the agent: Revise round 1: fix commit cd83b7b. Without --repo-dir, min type now starts the upward minimal.toml search from the absolute current directory. cmd_type_list_in and cmd_type_show_in take that directory, so the test can run both verbs from /nested/a/b without a change to the process current directory. type_show_matches_shipped_table_with_sources stays #[ignore] for issue #3294. The directive said to change nothing else. |
|
The runtime will not revise this pull request again on its own: the diff is +1544/-0 (1544 lines), past 3x the plan's estimate of 340 lines (est: 220 code, 120 tests, as #2899 reads now), at round 1 (the last trigger was a /revise note). A person decides now. Remove |
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 2 conditions · the full ruling
The new commit conforms. min type list and min type show now find the project's types from a subdirectory, as line 463 ("resolvable here") and the reference doc require. The merge of #3292 makes min type show print the built-in constraints that the expansion checks. The PR body still says that no built-in values ship. Correct the Proof paragraph (C2). C1 stays open on #3294 for the rest of the shipped-types table.
Ruled at cd83b7b against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
The change conforms to the design for min type list and for project types in min type show. Line 463 says min type show renders the fully resolved definition of a type. For a built-in type, mfile ships the constraints of the table at lines 1212-1224, but only the loadout_mode default. The test that proves the full table is ignored on #3294. C1 removes that #[ignore] when #3294 lands, and the residual on #3294 tracks it. Update the PR body: min type show session now lists one default and one constraint, not none.
Ruled at cd24e39 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
| /// and constraints exactly as the architecture's table of built-in types | ||
| /// states them, each value set by that type, as builtin. | ||
| #[test] | ||
| #[ignore = "https://github.com/gominimal/minimal/issues/3294"] |
There was a problem hiding this comment.
C1 · This leg stays open until #3294 ships the built-in defaults in builtin_defaults. Remove this #[ignore] then. Do not change the fixture architecture_builtin_table. It states the table at architecture.md lines 1212-1224.
T19 — List and show the box types
slice: S5
kind: task
covers: BCLI-019, BCLI-020
size: M
est: 220 code, 120 tests
executor: agent
difficulty: routine
model: standard
diagnostics:
min type listprints each type with its source, "builtin" or "project", pinned by type_list_shows_builtin_and_project_types_with_sourceobservability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cmd/types.rs (new):
min type listandmin type show <name>with the source of every value- crates/minimal/src/cmd/mod.rs: dispatches the verb
- crates/minimal/src/cli.rs: the verb's arguments and help in the one command model
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal type_list_shows_builtin_and_project_types_with_source
test: cargo nextest run -p minimal type_show_matches_shipped_table_with_sources
produces:
- crates/minimal/src/cmd/types.rs (entry point)
consumes:
- crates/minimal/src/cmd/output.rs
proof:
min type listshows every type with its source, andmin type showshows a type's defaults and constraints.depends on:
- blocked by #2891
- blocked by #2410
- blocked by #2420
Proof
min type list(aliasmin types ls) prints a table of the six built-in types and each [box_types.] of the project's minimal.toml. Each row shows the name, the source (builtin or project), the type it extends and its built-in type.min type show <name>prints the type's source, the type it extends, its built-in type, and each default and constraint along the extends chain with the type and source that set it (for exampletimeout = "30m" from base (project)). Partial: for a built-in type it shows the values that mfile ships for it, and today mfile ships none, somin type show sessionlists no defaults and no constraints.Notes (rewritten by the BCLI babysitter for arch ruling 1151 C2, owner rule 2026-11-10; the round-0 notes predated rounds 1 and 2):
mfile::box_types. Until thentype_show_matches_shipped_table_with_sourcesis ignored on mfile: built-in Box Types resolve with their shipped defaults and constraints (for min type show, BCLI-020) #3294, and its fixture holds the architecture's table.min type listandmin type showtake-o json|yaml|tomland emit amin/v1/typeobject. An invalid[box_types]exits 3 (BoxTypesInvalid), and an unknown type name exits 4 (BoxTypeNotFound).docs/reference/cli-min.mddocumentsmin type listandmin type show.Tests
cargo nextest run -p minimal type_list_shows_builtin_and_project_types_with_sourcecargo nextest run -p minimal type_show_matches_shipped_table_with_sourcesVerify
min task run agent-verifyexited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.Part of #2899