Skip to content

T30 — The session and task nouns as filtered box verbs - #3297

Merged
mitodrummer merged 10 commits into
mainfrom
agent/2921-the-session-and-task-nouns-as-filtered-box-verbs
Nov 12, 2026
Merged

mitodrummer merged 10 commits into
mainfrom
agent/2921-the-session-and-task-nouns-as-filtered-box-verbs

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

T30 — The session and task nouns as filtered box verbs

slice: S8
kind: task
covers: BCLI-030, BCLI-027
size: M
est: 250 code, 120 tests
executor: agent
difficulty: routine
model: standard
diagnostics: min session list prints the same columns as min box list, with only session boxes, pinned by type_noun_verbs_alias_box_forms
observability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cli.rs: the verb's arguments and help in the one command model
- crates/minimal/src/cmd/mod.rs: dispatches the verb
- crates/minimal/src/cmd/session.rs: min session list|start|attach|logs|stop|rm call the box verbs filtered to sessions
- crates/minimal/src/task.rs: min task run|list|logs|stop|rm call the box verbs filtered to tasks
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal type_noun_verbs_alias_box_forms
test: cargo nextest run -p minimal plural_nouns_accepted
produces: none
consumes: none
proof: Every min session and min task verb behaves as its min box form, filtered to that type, and every noun takes its plural.
depends on:
- blocked by #2890
- blocked by #2892
- blocked by #2897
- blocked by #2898
- blocked by #2912

Residuals

Proof

A person can run min session list|start|attach|logs|stop|rm and min task run|list|logs|stop|rm. Each one acts as its min box form, with the same flags and output, but sees only boxes of that type. A name that only a box of the other type holds is refused as not found. min session list prints the min box list columns with only session boxes. Every countable noun takes its plural, and min boxes and min secrets are new.

Notes from the agent: Already present before this task: session start, session attach, session logs, task run, task logs. New: session stop, session rm, task stop, task rm, and the boxes and secrets aliases. Behaviour change: min session list (and min session ls) now prints the min box list table with --all and -o json, filtered to session boxes. It no longer takes --raw or --json. Bare min ls keeps --raw and --json. min task list gained -o json, and TaskListArgs is gone (it uses BoxListArgs). In cmd/session.rs, resolve_box_of_type copies the private resolve_typed_box_on_hosts in cmd/boxes.rs, because boxes.rs is not in this task's layers. The type nouns and min box logs share one resolver in #3299 (rewritten by the BCLI babysitter for arch ruling 1160 C1). task_list_on_hosts moved from task.rs into tests.rs as typed_list_on_hosts, because only the tests used it. min session stop --exec and min task stop --exec resolve the box by type and then stop the exec on that box's host only. Docs (docs/reference/cli-min.md) do not yet list session stop|rm or task stop|rm. BCLI-044 owns that, outside these layers. just clippy-strict and just lint-prose were not run.

Tests

line exit tail
cargo nextest run -p minimal type_noun_verbs_alias_box_forms 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimal plural_nouns_accepted 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify

min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "2ab20eff57ba09e1",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "33fc3cb43644d6f0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "33fc3cb43644d6f0",
                "queued_behind": "0",
                "span_id": "a436ddc3e8520666",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "2ab20eff57ba09e1",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "f739789e04dff73f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "f739789e04dff73f",
                "queued_behind": "0",
                "span_id": "6db04ab52904cd73",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "f739789e04dff73f",
                "queued_behind": "0",
                "span_id": "7e5d220b54bf2824",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "7e5d220b54bf2824",
                "span_id": "3a673a70078da47f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "7e5d220b54bf2824",
                "queued_behind": "0",
                "span_id": "3872cdd1c87701e6",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  62.712s] 1075 tests run: 1074 passed, 1 failed, 1 skipped
        FAIL [   2.868s] (1075/1075) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Closes #2921

min session list|stop|rm and min task list|stop|rm now run the min box
verbs, filtered to boxes of that type (BCLI-030). min boxes and
min secrets are the plural nouns that were missing (BCLI-027).
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: caa7f906-8d9d-4636-82b8-38936ec2dde9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Pre-merge checks: Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Description check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at 2ca4507f734c.

Nothing to do.

Clobber: none found. The --exec re-resolve defect was already raised and fixed in earlier threads: box_stop_exec_in_resolved now takes the resolved box.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/session.rs Resolved
Comment thread crates/minimal/src/cmd/session.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The list, stop and rm verbs under min session and min task conform, and so do the plurals. One path does not. min session stop <box> --exec <id> resolves the box by type and then gives the address to box_stop_exec_on_hosts. That function resolves the address again over every type. Section 8 (line 338) and Type nouns (line 458) say a type-noun verb is the min box verb filtered to the type. Line 389 allows a stopped session box and a running task box with the same name. In that state, the exec stop reaches the task box. C1 stops the exec on the box that the typed resolution found. C2 adds a test for the same-name case.

Ruled at 911f5b4 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/session.rs Resolved
Comment thread crates/minimal/src/tests.rs Resolved
min session stop --exec and min task stop --exec passed the raw target
to the exec stop, which resolved it again with no type filter. A name or
id prefix held by a box of the other type could then reach that box.
Pass the resolved box id instead.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

Comment thread crates/minimal/src/cmd/session.rs Resolved

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The compare fixes the --exec stop. It now reaches only the box of the noun's type, as §8 line 338 requires. BCLI-030 and BCLI-027 conform. One item is open. The PR body names a follow-up to remove the copy resolve_box_of_type, but it links no issue. File that issue and link it from the PR body (C1). The change can merge with C1 open.

Ruled at f07ced8 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/session.rs Resolved
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as f07ced8b8ae4.

line exit tail
cargo nextest run -p minimal type_noun_verbs_alias_box_forms 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimal plural_nouns_accepted 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "7a2667bf73dd29f9",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "dc0cdf5b45c8e0f3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "dc0cdf5b45c8e0f3",
                "queued_behind": "0",
                "span_id": "211408d9530a623e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "7a2667bf73dd29f9",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "744116a54fb1240c",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "744116a54fb1240c",
                "queued_behind": "0",
                "span_id": "c47da5d4463e5990",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "744116a54fb1240c",
                "queued_behind": "0",
                "span_id": "d24920709d96b16e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "d24920709d96b16e",
                "span_id": "e81f326d339181e2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "d24920709d96b16e",
                "queued_behind": "0",
                "span_id": "a70a0faba1409675",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  68.472s] 1075 tests run: 1074 passed, 1 failed, 1 skipped
        FAIL [   3.122s] (1075/1075) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/session.rs:1001: typed_box_stop_on_hosts now passes the resolved box's full id to box_stop_exec_on_hosts, so the second lookup matches only that box. type_noun_verbs_alias_box_forms pins it with a task box named as the session id's prefix.
  • 👍 valid — PRRT_kwDOPdfcxM62ZC8t: Same fix as the sibling thread: the exec stop takes the type-checked box id, not the raw target, so a task box that holds the target as its name is never read. (not posted on the thread: not an open thread on the pull request)

Every min session and min task verb behaves as its min box form, filtered to that type, and every noun takes its plural. min session stop <target> --exec <id> now reaches only the session box the type filter resolved, even when a task box holds a name that matches the same target.

Notes from the agent: Revise round 1: both threads report one defect. The exec stop now takes the full id of the resolved box. The exec id text is checked first against the user's target, so a malformed exec id still names the user's text. An unknown exec id now names the box by its full id in the refusal. The new check in type_noun_verbs_alias_box_forms creates a task box named with the first 8 hex digits of the session box id. It fails without the fix (verified by reverting session.rs) and passes with it. cargo clippy -p minimal --all-targets is clean.

@agent-137

Copy link
Copy Markdown
Member

/revise

Head f07ced8b. One finding from minimal-review, thread PRRT_kwDOPdfcxM62ZZrx. Change nothing else.

min session stop <name> --exec <id> prints what min box stop <name> --exec <id> prints.
typed_box_stop_on_hosts (crates/minimal/src/cmd/session.rs, about lines 994–1000) passes the box's full id to box_stop_exec_on_hosts as its target. So these say the full id where the min box form says the name the person typed:

  • the "Stopped exec in " line;
  • the exec-id refusal;
  • the refused-address text.

The second lookup also logs under the verb box stop. Resolve once and reuse the ResolvedBox:

  • give box_stop_exec_on_hosts (crates/minimal/src/cmd/boxes/exec.rs) a variant that takes the resolved box, plus the typed target for printing and the calling verb for the span;
  • have the typed stop call that variant.

exec.rs is outside layers:, but the change needs it. Pin it in a test: min session stop <name> --exec <id> prints the typed name, and so does min task stop.

Also make sure the test arch ruling 1160 asked for is present (thread PRRT_kwDOPdfcxM62ZDxz): a stopped session box and a running task box hold the same name, the task box runs an exec, and a session-typed stop with --exec does not stop the task box's exec. If type_noun_verbs_alias_box_forms already covers it, reply on that thread with the line.

Reply on the threads with the commit. Run the whole minimal suite.

min session stop and min task stop with --exec now reuse the box the type
resolved, print the address the person typed, and log under their own
verb. Tests pin the line for both nouns, and a stopped session box that
shares its name with a running task box leaves the task's exec alone.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 49e624685193.

line exit tail
cargo nextest run -p minimal type_noun_verbs_alias_box_forms 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimal plural_nouns_accepted 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "81a99d2b87fa37af",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "b88437965337af5d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "b88437965337af5d",
                "queued_behind": "0",
                "span_id": "b9f99e0f1be80987",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "81a99d2b87fa37af",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "707684f7bfe52004",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "707684f7bfe52004",
                "queued_behind": "0",
                "span_id": "791dcac996086ec7",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "707684f7bfe52004",
                "queued_behind": "0",
                "span_id": "9073c1905d1bef0d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "9073c1905d1bef0d",
                "span_id": "1aa2799e3603d951",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "9073c1905d1bef0d",
                "queued_behind": "0",
                "span_id": "ec491182531f1a89",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  63.267s] 1075 tests run: 1074 passed, 1 failed, 1 skipped
        FAIL [   2.838s] (1075/1075) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/session.rs: 49e6246: the StopExec send is split out of box_stop_exec_on_hosts as box_stop_exec_in_resolved, and the typed stop sends it to resolved.box_id with no second lookup.
  • 👍 valid — crates/minimal/src/tests.rs:13414: 49e6246: type_noun_verbs_alias_box_forms now stops a session box "twin", starts a task box "twin" with an exec, and asserts that session stop twin --exec fails and the task box's exec still shows in its live execs.
  • 👍 valid — crates/minimal/src/cmd/session.rs:1000: 49e6246: the typed stop reuses its ResolvedBox, prints and refuses with the typed address, and logs under its own verb. The test pins the line for session stop web and task stop build, and the refusal now names the typed address.
  • 👍 valid — crates/minimal/src/cmd/session.rs:918: The duplicate holds, and cmd/boxes.rs stays unchanged in this PR. This agent has no access to file the issue or edit the PR body, so a person must file the follow-up issue and link it.

Every min session and min task verb behaves as its min box form, filtered to that type, and every noun takes its plural. min session stop web --exec <id> and min task stop build --exec <id> now print the line of min box stop --exec, with the name the person typed and not the box's full id.

Notes from the agent: This round touches crates/minimal/src/cmd/boxes/exec.rs, which is outside layers:. The directive asked for it. box_stop_exec_on_hosts now calls a private send_stop_exec, and the new box_stop_exec_in_resolved takes the ResolvedBox, the typed target and the calling verb. The typed stop calls it, so the box is resolved one time and the log records the session or task verb. Thread PRRT_kwDOPdfcxM62ZaZq asks for an issue and a PR body link. This session has no gh access, so a person must file the issue and edit the PR body. Commit: 49e6246.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 12, 2026 01:10

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The typed --exec stop now goes to the box that the type resolved. It prints the address that the person typed, and it logs under session stop or task stop. Design principle 8 and the type-noun section (lines 338 and 458) require this: each type-noun verb is the min box verb, filtered to that type. Both BCLI-030 and BCLI-027 conform. The copied resolver stays a filed residual in #3299.

Ruled at 49e6246 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cli.rs Resolved
Comment thread crates/minimal/src/cmd/session.rs Resolved
@agent-137
agent-137 marked this pull request as ready for review November 12, 2026 01:15
@agent-137

Copy link
Copy Markdown
Member

/revise

Head 49e62468. One minimal-review finding, thread PRRT_kwDOPdfcxM62bHks. Change nothing else.

The docs match the new min session list.
min session list now takes BoxListArgs and prints the box table, the filtered min box list (BCLI-030). min ls keeps --raw and --json. Scripts use min ls --raw (scripts/install.sh and the e2e), so keep min ls unchanged. Update the text that still calls min ls the alias of min session list with --raw/--json:

  • the comment at crates/minimal/src/cli.rs (about line 68);
  • docs/reference/cli.md (about line 57);
  • docs/reference/cli-min.md (about lines 44–47).

min session list takes min box list's arguments, limited to session boxes. min ls is the host-wide listing with --raw/--json. The docs are outside layers:, but the change needs them.

Reply on the thread with the commit.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #2921. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

The typed resolver now logs each host that did not answer and the
refusal's own outcome, as resolve_box_on_hosts does.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as 6b24ba5d04cb.

line exit tail
cargo nextest run -p minimal type_noun_verbs_alias_box_forms 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimal plural_nouns_accepted 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "4cf5d711325e442b",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "6107d70f6fea8865",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "6107d70f6fea8865",
                "queued_behind": "0",
                "span_id": "403a6e049c19537a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "4cf5d711325e442b",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "427cc598873be052",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "427cc598873be052",
                "queued_behind": "0",
                "span_id": "4ccd3156caed30be",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "427cc598873be052",
                "queued_behind": "0",
                "span_id": "2cb4ae5ee4bb8f19",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "2cb4ae5ee4bb8f19",
                "span_id": "6fc478c50fd6ec95",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "2cb4ae5ee4bb8f19",
                "queued_behind": "0",
                "span_id": "fbe49ee8666b1252",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  69.775s] 1080 tests run: 1079 passed, 1 failed, 1 skipped
        FAIL [   3.053s] (1080/1080) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cli.rs:231: Rewrote the comment on Command::Ls in cli.rs: min ls keeps --raw/--json and is not an alias of min session list, which takes the min box list flags (BCLI-030). The CLI reference docs are outside this task's layers, so BCLI-044 must update them.
  • 👍 valid — PRRT_kwDOPdfcxM62bHkw: resolve_box_of_type now logs each host that did not answer and records ambiguous / not found / host unreachable as resolve_box_on_hosts does. The shared resolver in cmd/boxes/address.rs is outside the layers, so the copy stays and gets no type-filter parameter. (not posted on the thread: not an open thread on the pull request)

Every min session and min task verb behaves as its min box form, filtered to that type, and every noun takes its plural. A refused typed resolve now logs the hosts that did not answer and the same outcome names that min box records.

Notes from the agent: The docs/reference/cli.md and docs/reference/cli-min.md text that still shows min session list [--raw] [--json] is outside this task's layers. BCLI-044 (the CLI reference) must update it. BoxAddressRefusal::outcome() is private in cmd/boxes/address.rs, which is outside the layers. So session.rs maps the refusal variants to the same outcome names locally. The shared resolver did not get a type-filter parameter for the same reason, and typed_box_list_on_hosts stays a copy of the cmd_box_list loop.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 12, 2026 01:34
min ls keeps --raw and --json and is no longer described as an alias
of min session list, which takes the min box list flags.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms. The new log lines in resolve_box_of_type use the outcome names of resolve_box_on_hosts. The merge of #3284 gives session start and task run the same override flags as their min box forms. That is what section 8 line 338 and lines 453-454 require. Residual #3299 owns the copied resolver. CI must still clear the otel_cli failure that the PR body reports.

Ruled at 6b24ba5 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/session.rs Resolved
@agent-137
agent-137 marked this pull request as ready for review November 12, 2026 01:47
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a /revise note, pushed as e1de636c8a94.

line exit tail
cargo nextest run -p minimal type_noun_verbs_alias_box_forms 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimal plural_nouns_accepted 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "c46f70179a2276d1",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "def73ac4cd107cfb",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "def73ac4cd107cfb",
                "queued_behind": "0",
                "span_id": "8aab63536b7d8a30",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "c46f70179a2276d1",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "05edb0bb49edb0ce",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "05edb0bb49edb0ce",
                "queued_behind": "0",
                "span_id": "edf31a7457e071d6",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "05edb0bb49edb0ce",
                "queued_behind": "0",
                "span_id": "6e229b727c849520",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "6e229b727c849520",
                "span_id": "fa3eddb4cc4724c9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "6e229b727c849520",
                "queued_behind": "0",
                "span_id": "57cae87bc2a5d805",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  69.936s] 1080 tests run: 1079 passed, 1 failed, 1 skipped
        FAIL [   3.049s] (1080/1080) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • docs/reference/cli-min.md
  • docs/reference/cli.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM62bHks: e1de636: docs/reference/cli.md and cli-min.md no longer call min ls an alias of min session list. The cli.rs comment changed in 20d808c. (not posted on the thread: not an open thread on the pull request)

Every min session and min task verb behaves as its min box form, filtered to that type, and every noun takes its plural. The reference docs now say that min session list takes the min box list flags, and that min ls is a separate host-wide listing with --raw and --json.

Notes from the agent: Revise round 4 addresses thread PRRT_kwDOPdfcxM62bHks in commit e1de636. The cli.rs comment (about line 68) was already fixed in 20d808c, so this round changes only the two docs. docs/reference/cli.md and docs/reference/cli-min.md are outside layers:, and the directive asks for them. In cli-min.md the old session list section is now a ls section, and a new session list section documents min session list [--all] [-o json]. I did not run just lint-prose because vale is not installed on this box.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 12, 2026 01:53

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change since the last ruling is a merge of main and one docs commit. The docs now describe min session list as min box list limited to session boxes, and the code does that (design principle 8, line 338). min ls keeps its own flags. Spec 28 leaves it as it is, and the ruling on 6b24ba5d accepted this shape. The copied resolver stays as residual #3299. No change is necessary.

Ruled at e1de636 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/session.rs Resolved
A typed list with no match printed the untyped empty text, which said
the project had no boxes when it had boxes of another type.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on the runtime's review findings, pushed as 2ca4507f734c.

line exit tail
cargo nextest run -p minimal type_noun_verbs_alias_box_forms 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimal plural_nouns_accepted 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "34b673a5bd8c457a",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "46a26000a92322b2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "46a26000a92322b2",
                "queued_behind": "0",
                "span_id": "99655d92c7c18e1d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "34b673a5bd8c457a",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "c2993677860dadac",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "c2993677860dadac",
                "queued_behind": "0",
                "span_id": "1d992b87a510977a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "c2993677860dadac",
                "queued_behind": "0",
                "span_id": "aef4c87a160aef37",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "aef4c87a160aef37",
                "span_id": "5c0c2c7bf2ca9e0c",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "aef4c87a160aef37",
                "queued_behind": "0",
                "span_id": "5a33b689c2d03fc3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  69.656s] 1080 tests run: 1079 passed, 1 failed, 1 skipped
        FAIL [   3.180s] (1080/1080) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • docs/reference/cli-min.md
  • docs/reference/cli.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/session.rs:916: An empty typed list now prints text that names the type: "This project has no session boxes. Run min session list --all ...", or "No session boxes on this machine." with --all. The tests pin it for task lists.

Every min session and min task verb behaves as its min box form, filtered to that type, and every noun takes its plural. An empty min session list or min task list now names the type, for example "This project has no session boxes. Run min session list --all to list the session boxes of every project." or "No task boxes on this machine."

Notes from the agent: Revise round 5: the typed list now prints its own empty text from session.rs (empty_typed_list). The shared EMPTY_PROJECT_LIST and EMPTY_HOST_LIST in crates/minimal/src/cmd/boxes/list.rs are unchanged, because that file is outside the layers. Two existing tests in tests.rs pinned the old untyped text for a task list. They now pin the new text.

@agent-137
agent-137 marked this pull request as ready for review November 12, 2026 03:45

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The new commit changes only the empty line of min session list and min task list. The line now names the box type and gives min <type> list --all as the next step. That is the min box list empty line with the type filter applied, as design principle 8 requires. Both typed lists take --all, so the command in the message runs. The rest of the change keeps the PASS on e1de636c.

Ruled at 2ca4507 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 12, 2026

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 89d0d25 Nov 12, 2026
38 checks passed
@mitodrummer
mitodrummer deleted the agent/2921-the-session-and-task-nouns-as-filtered-box-verbs branch November 12, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T30 — The session and task nouns as filtered box verbs

2 participants