Repository navigation
T30 — The session and task nouns as filtered box verbs - #3297
mitodrummer merged 10 commits into
Conversation
min session list|stop|rm and min task list|stop|rm now run the min box verbs, filtered to boxes of that type (BCLI-030). min boxes and min secrets are the plural nouns that were missing (BCLI-027).
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Approved: no findings at Nothing to do. Clobber: none found. The |
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The list, stop and rm verbs under min session and min task conform, and so do the plurals. One path does not. min session stop <box> --exec <id> resolves the box by type and then gives the address to box_stop_exec_on_hosts. That function resolves the address again over every type. Section 8 (line 338) and Type nouns (line 458) say a type-noun verb is the min box verb filtered to the type. Line 389 allows a stopped session box and a running task box with the same name. In that state, the exec stop reaches the task box. C1 stops the exec on the box that the typed resolution found. C2 adds a test for the same-name case.
Ruled at 911f5b4 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
min session stop --exec and min task stop --exec passed the raw target to the exec stop, which resolved it again with no type filter. A name or id prefix held by a box of the other type could then reach that box. Pass the resolved box id instead.
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
The compare fixes the --exec stop. It now reaches only the box of the noun's type, as §8 line 338 requires. BCLI-030 and BCLI-027 conform. One item is open. The PR body names a follow-up to remove the copy resolve_box_of_type, but it links no issue. File that issue and link it from the PR body (C1). The change can merge with C1 open.
Ruled at f07ced8 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
Round 1 of 10 on the runtime's review findings, pushed as
Verify Review threads the coder judged:
Every Notes from the agent: Revise round 1: both threads report one defect. The exec stop now takes the full id of the resolved box. The exec id text is checked first against the user's target, so a malformed exec id still names the user's text. An unknown exec id now names the box by its full id in the refusal. The new check in type_noun_verbs_alias_box_forms creates a task box named with the first 8 hex digits of the session box id. It fails without the fix (verified by reverting session.rs) and passes with it. cargo clippy -p minimal --all-targets is clean. |
|
/revise Head
The second lookup also logs under the verb
Also make sure the test arch ruling 1160 asked for is present (thread PRRT_kwDOPdfcxM62ZDxz): a stopped session box and a running task box hold the same name, the task box runs an exec, and a session-typed stop with Reply on the threads with the commit. Run the whole |
…n-and-task-nouns-as-filtered-box-verbs
min session stop and min task stop with --exec now reuse the box the type resolved, print the address the person typed, and log under their own verb. Tests pin the line for both nouns, and a stopped session box that shares its name with a running task box leaves the task's exec alone.
|
Round 2 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Every Notes from the agent: This round touches crates/minimal/src/cmd/boxes/exec.rs, which is outside layers:. The directive asked for it. box_stop_exec_on_hosts now calls a private send_stop_exec, and the new box_stop_exec_in_resolved takes the ResolvedBox, the typed target and the calling verb. The typed stop calls it, so the box is resolved one time and the log records the session or task verb. Thread PRRT_kwDOPdfcxM62ZaZq asks for an issue and a PR body link. This session has no gh access, so a person must file the issue and edit the PR body. Commit: 49e6246. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The typed --exec stop now goes to the box that the type resolved. It prints the address that the person typed, and it logs under session stop or task stop. Design principle 8 and the type-noun section (lines 338 and 458) require this: each type-noun verb is the min box verb, filtered to that type. Both BCLI-030 and BCLI-027 conform. The copied resolver stays a filed residual in #3299.
Ruled at 49e6246 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
/revise Head The docs match the new
Reply on the thread with the commit. |
|
That Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet. |
The typed resolver now logs each host that did not answer and the refusal's own outcome, as resolve_box_on_hosts does.
…n-and-task-nouns-as-filtered-box-verbs
|
Round 3 of 10 on the runtime's review findings, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Every Notes from the agent: The docs/reference/cli.md and docs/reference/cli-min.md text that still shows |
…n-and-task-nouns-as-filtered-box-verbs
min ls keeps --raw and --json and is no longer described as an alias of min session list, which takes the min box list flags.
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The change conforms. The new log lines in resolve_box_of_type use the outcome names of resolve_box_on_hosts. The merge of #3284 gives session start and task run the same override flags as their min box forms. That is what section 8 line 338 and lines 453-454 require. Residual #3299 owns the copied resolver. CI must still clear the otel_cli failure that the PR body reports.
Ruled at 6b24ba5 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
Round 4 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Every Notes from the agent: Revise round 4 addresses thread PRRT_kwDOPdfcxM62bHks in commit e1de636. The cli.rs comment (about line 68) was already fixed in 20d808c, so this round changes only the two docs. docs/reference/cli.md and docs/reference/cli-min.md are outside layers:, and the directive asks for them. In cli-min.md the old |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The change since the last ruling is a merge of main and one docs commit. The docs now describe min session list as min box list limited to session boxes, and the code does that (design principle 8, line 338). min ls keeps its own flags. Spec 28 leaves it as it is, and the ruling on 6b24ba5d accepted this shape. The copied resolver stays as residual #3299. No change is necessary.
Ruled at e1de636 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
A typed list with no match printed the untyped empty text, which said the project had no boxes when it had boxes of another type.
|
Round 5 of 10 on the runtime's review findings, pushed as
Verify Outside the task's
Converted to a draft: something above needs a person before review. Review threads the coder judged:
Every Notes from the agent: Revise round 5: the typed list now prints its own empty text from session.rs (empty_typed_list). The shared EMPTY_PROJECT_LIST and EMPTY_HOST_LIST in crates/minimal/src/cmd/boxes/list.rs are unchanged, because that file is outside the layers. Two existing tests in tests.rs pinned the old untyped text for a task list. They now pin the new text. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The new commit changes only the empty line of min session list and min task list. The line now names the box type and gives min <type> list --all as the next step. That is the min box list empty line with the type filter applied, as design principle 8 requires. Both typed lists take --all, so the command in the message runs. The rest of the change keeps the PASS on e1de636c.
Ruled at 2ca4507 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
T30 — The session and task nouns as filtered box verbs
slice: S8
kind: task
covers: BCLI-030, BCLI-027
size: M
est: 250 code, 120 tests
executor: agent
difficulty: routine
model: standard
diagnostics:
min session listprints the same columns asmin box list, with only session boxes, pinned by type_noun_verbs_alias_box_formsobservability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cli.rs: the verb's arguments and help in the one command model
- crates/minimal/src/cmd/mod.rs: dispatches the verb
- crates/minimal/src/cmd/session.rs:
min session list|start|attach|logs|stop|rmcall the box verbs filtered to sessions- crates/minimal/src/task.rs:
min task run|list|logs|stop|rmcall the box verbs filtered to tasks- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal type_noun_verbs_alias_box_forms
test: cargo nextest run -p minimal plural_nouns_accepted
produces: none
consumes: none
proof: Every
min sessionandmin taskverb behaves as itsmin boxform, filtered to that type, and every noun takes its plural.depends on:
- blocked by #2890
- blocked by #2892
- blocked by #2897
- blocked by #2898
- blocked by #2912
Residuals
min box logs.Proof
A person can run
min session list|start|attach|logs|stop|rmandmin task run|list|logs|stop|rm. Each one acts as itsmin boxform, with the same flags and output, but sees only boxes of that type. A name that only a box of the other type holds is refused as not found.min session listprints themin box listcolumns with only session boxes. Every countable noun takes its plural, andmin boxesandmin secretsare new.Notes from the agent: Already present before this task:
session start,session attach,session logs,task run,task logs. New:session stop,session rm,task stop,task rm, and theboxesandsecretsaliases. Behaviour change:min session list(andmin session ls) now prints themin box listtable with--alland-o json, filtered to session boxes. It no longer takes--rawor--json. Baremin lskeeps--rawand--json.min task listgained-o json, andTaskListArgsis gone (it usesBoxListArgs). Incmd/session.rs,resolve_box_of_typecopies the privateresolve_typed_box_on_hostsincmd/boxes.rs, becauseboxes.rsis not in this task's layers. The type nouns andmin box logsshare one resolver in #3299 (rewritten by the BCLI babysitter for arch ruling 1160 C1).task_list_on_hostsmoved fromtask.rsintotests.rsastyped_list_on_hosts, because only the tests used it.min session stop --execandmin task stop --execresolve the box by type and then stop the exec on that box's host only. Docs (docs/reference/cli-min.md) do not yet listsession stop|rmortask stop|rm. BCLI-044 owns that, outside these layers.just clippy-strictandjust lint-prosewere not run.Tests
cargo nextest run -p minimal type_noun_verbs_alias_box_formscargo nextest run -p minimal plural_nouns_acceptedVerify
min task run agent-verifyexited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.Closes #2921