Skip to content

feat(minimald): T44 — Detach from an exec attach with the detach keys - #3341

Merged
agent-137 merged 15 commits into
mainfrom
agent/3331-detach-from-an-exec-attach-with-the-detach-keys
Nov 13, 2026
Merged

agent-137 merged 15 commits into
mainfrom
agent/3331-detach-from-an-exec-attach-with-the-detach-keys

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

T44 — Detach from an exec attach with the detach keys

slice: S4
kind: task
covers: BCLI-068
size: M
est: 140 code, 160 tests
executor: agent
difficulty: needs care
model: strongest
diagnostics: a detach from an exec attach exits 0, pinned by exec_attach_detach_key_returns_0_exec_keeps_running
observability: none new
layers:
- client:
- crates/minimal/src/cmd/boxes/attach.rs: the exec attach and min box exec -t's first attach send the session keys, as the box attach does
- crates/minimal-client/src/attach.rs: attach_command sends the session keys on an ExecAttach channel
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running
- daemon:
- crates/minimald/src/exec/bridge.rs: serve_exec_attach runs the same leader/detach state machine as the box PTY attach. A detach ends the channel as a detach, with exit 0, and leaves the exec running.
test: cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs
produces: none
consumes: none
proof: Ctrl-] then d ends min box attach <box> --exec <id> with exit 0, the exec keeps running, and a second attach reaches it.

Proof

Ctrl-] then d (or the configured leader and detach keys) ends min box attach <box> --exec <id> with exit 0. The terminal shows Detached from exec <id>. It keeps running., the exec keeps running, min box show still lists it, and a second min box attach <box> --exec <id> reaches it.

Notes from the agent: Out of scope: crates/minimald/src/exec.rs changed in one call site. serve_exec_attach needs the keys the channel negotiated, and only the dispatcher in exec.rs holds the channel's env vars. Without this change the daemon cannot honour a remapped leader or detach key.

Not done: min box exec -t's first attach is in crates/minimal/src/cmd/boxes/exec.rs (attach_exec_terminal), not in attach.rs, and that path has no config_dir. It still sends no keys. The daemon now gives a channel without keys the default keys, so Ctrl-] d detaches there too, but a remapped chord in config.toml does not apply to min box exec -t. A follow-up can thread global.config_dir into TtyAttach::Terminal and call exec_attach_ssh.

minimal-client/src/attach.rs: attach_command already sent the keys when given Some. Only its doc comments changed, to say an ExecAttach channel sends them.

New printed text, not fixed by the task: the daemon writes Detached from exec <id>. It keeps running. on the terminal at a detach. The box attach writes Detaching from session. in the same place. The exec detach does not write terminal unwind codes, because the daemon does not track the exec terminal's modes.

The minimal test cannot drive a real detach through the in-process harness, because TestServer::list_running_exec registers an exec with no terminal. It checks the keys the attach's ssh sends (default and configured), the 0 ending, the live listing and a second attach. The minimald test drives the detach through attach_terminal_keyed on a live terminal.

Tests

line exit tail
cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify

min task run agent-verify timed out after 1800s, so this PR is a draft.

Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 3m 50s
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimald/src/exec.rs

Closes #3331

serve_exec_attach now runs the leader and detach state machine of the
box's own terminal, with the keys the channel negotiated. A detach ends
the channel with status 0 and leaves the exec running (BCLI-068).
min box attach <box> --exec <id> now sends the session keys from the
config, as the box attach does, so the daemon detaches on them (BCLI-068).
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 97697660-af1f-494c-b259-d391827cd861

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at 09a572a1f269.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The min box attach --exec path conforms. The daemon detaches with status 0 and keeps the exec running, as architecture.md lines 492 and 498 say. The first attach of min box exec -t still sends no keys. The daemon now gives it the default chord, so a remapped leader or detach key does not apply there. Line 498 says a -t exec re-attaches like a PTY box, and the PTY box uses the configured keys. The PR body names this gap but links no issue. Make the edit in C1, or file the issue and name it as a residual.

Ruled at b1370c2 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/minimald/src/exec.rs Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/exec/bridge.rs Resolved
A client that does not read held the detach on the notice write. The
writes now wait at most EXIT_NOTICE_BOUND, and the detach goes on.
The first terminal attach of min box exec -t sent no keys, so a
remapped leader or detach key did not apply. It now builds its ssh
command through exec_attach_ssh, as min box attach --exec does.
@agent-137

Copy link
Copy Markdown
Member

/revise

Head b1370c24. Arch ruling 1215 C1, and one minimal-review finding. Change nothing else.

1. C1: min box exec -t's first attach sends the configured keys.
attach_exec_terminal() (crates/minimal/src/cmd/boxes/exec.rs) takes config_dir: Option<&Path> and builds its ssh through crate::cmd::boxes::attach::exec_attach_ssh(sock, id, exec_id, config_dir), or attach_command(..., Some(&resolve_session_keys(config_dir)?)), instead of attach_command(sock, id, Some(attach_wire), None). cmd_box_exec passes global.config_dir.as_deref() through TtyAttach::Terminal. Add a tests.rs case: with detach = "q" configured, that ssh carries the leader and detach env vars and the SendEnv options. exec.rs is outside layers:, but the change needs it.

2. The detach can't stall behind a full window (thread PRRT_kwDOPdfcxM623fwj).
In relay_terminal_keyed, the detach path awaits out.write_all and out.flush for the notice before it returns Detached. If the client stopped reading, the SSH window is full, those awaits never finish, and the chord does nothing. Bound the notice write with a timeout, as the box terminal in box_runtime.rs does for KeyAction::Detach with send_timeout, or return Detached first and ignore a write error. Treat the bell write in EnterCommandMode the same way.

Reply on both threads with the commit. Run the whole minimal and minimald suites.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #3331. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as 9a4287f2247c.

line exit tail
cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify timed out after 1800s.

Checking common v0.0.1 (/workbench/crates/common)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 12s
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • crates/minimald/src/exec.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/exec.rs:501: attach_exec_terminal in min box exec -t now builds its ssh through exec_attach_ssh, so it sends the session keys from --config-dir like min box attach --exec.
  • 👍 valid — crates/minimald/src/exec/bridge.rs:2290: The bell and the detach notice now go through write_bounded (EXIT_NOTICE_BOUND, errors ignored). A new test pins a detach with status 0 for a client that does not read.

Ctrl-] then d ends min box attach <box> --exec <id> with exit 0, the exec keeps running, and a second attach reaches it. The detach also works when the client does not read, and min box exec -t now sends the user's configured keys, so a remapped detach key works on its first attach too.

Notes from the agent: This round touched crates/minimal/src/cmd/boxes/exec.rs, which is outside the layers. The task's attach.rs note asks that min box exec -t's first attach send the session keys, and that attach is built in exec.rs (attach_exec_terminal). It now calls exec_attach_ssh from attach.rs, and box_exec_on_hosts takes a config_dir argument. The unused with_forced_tty helper is removed. box_exec_on_hosts now has 8 arguments, so it carries #[allow(clippy::too_many_arguments)], as five other functions in the crate do. The daemon fix bounds only the bell and the detach notice. A live output write to a client that does not read can still stall the relay loop before it reads the detach keys. That is a wider issue than this finding, and it is not changed here. just clippy-strict was not run.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 12, 2026 23:40

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. A -t exec now detaches with the detach keys, ends the attach with 0, and runs on, as architecture.md line 498 and line 492 require. The two commits after the earlier head close its gaps. The detach notice cannot hold the detach, and min box exec -t sends the configured keys. The PR body still says min box exec -t sends no keys. Update that paragraph before the PR leaves draft.

Ruled at 9a4287f against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 2 unresolved threads — minimal-arch[bot] crates/minimald/src/exec.rs:501, minimal-foundry[bot] crates/minimald/src/exec/bridge.rs:2290.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

The ssh that min box exec -t's first attach runs now comes from
exec_terminal_ssh. A test checks that, with detach = "q" configured,
it carries the leader and detach env vars and their SendEnv options.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as b2b8cf4eeaa9.

line exit tail
cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify timed out after 1800s.

switch)
    Checking sysinfo v0.39.6
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking wait-timeout v0.2.1
    Checking quick-error v1.2.3
    Checking bit-vec v0.10.1
    Checking rand_xorshift v0.5.0
    Checking rusty-fork v0.3.1
    Checking bit-set v0.11.1
    Checking unarray v0.1.4
    Checking core_detect v1.0.0
    Checking castaway v0.2.4
    Checking strum v0.28.0
    Checking proptest v1.12.0
    Checking compact_str v0.9.1
    Checking signal-hook v0.3.18
    Checking unicode-truncate v2.0.1
    Checking kasuari v0.4.12
    Checking lru v0.18.2
    Checking signal-hook-mio v0.2.5
    Checking derive_more v2.1.1
    Checking line-clipping v0.3.8
    Checking crossterm v0.29.0
    Checking ratatui-core v0.1.2
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking fuzzy-matcher v0.3.7
    Checking ratatui-widgets v0.3.2
    Checking ratatui-crossterm v0.1.2
    Checking ratatui-macros v0.7.2
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking ratatui v0.30.2
    Checking inquire v0.9.4
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking similar v2.7.0
    Checking insta v1.49.0
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking serial_test v4.0.1
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 2m 03s
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • crates/minimald/src/exec.rs

Converted to a draft: something above needs a person before review.

Ctrl-] then d ends min box attach <box> --exec <id> with exit 0. The exec keeps running, and a second attach reaches it. min box exec -t's first attach now sends the configured detach keys too, and a test pins that.

Notes from the agent: Revise round 2. Both directive items were already in code from an earlier round: 44b620e bounds the detach notice and bell writes (item 2, thread PRRT_kwDOPdfcxM623fwj), and 9a4287f makes min box exec -t's attach send the session keys (item 1, C1, thread PRRT_kwDOPdfcxM623ehQ). This round adds the C1 test that the directive asks for (commit 4c70bd8). exec.rs gets exec_terminal_ssh, the ssh builder that attach_exec_terminal uses. tests.rs gets box_exec_t_attach_sends_configured_session_keys: with detach = "q" configured, that ssh carries the leader and detach env vars and their SendEnv options. exec.rs is outside layers:, as the directive says. Full suites: cargo nextest run -p minimal -p minimald --no-fail-fast ran 2589 tests. 2585 passed, and no minimal test failed. minimald env::tests::task_entrypoint_carries_env_cwd_and_args failed: it does not parse this box's inherited environment. minimald env::tests::minenv_run_forwards_stdin_to_the_task and task_run_pipes_stdin_through_the_in_box_helper hung for more than 17 minutes, so I stopped the run, and it has no exit code. All three tests are in crates/minimald/src/env.rs, which this branch does not change. I deleted the run's log because it held this box's environment, including tokens. just clippy-strict was not run.

@agent-137
agent-137 marked this pull request as ready for review November 13, 2026 02:14

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design at this head. Since the last PASS, the PR adds a wrapper that does not change behaviour, a test for the keys on min box exec -t, and a clean merge of main. Line 498 of the architecture says a -t exec is re-attachable and a detach leaves it running. Line 376 says a detach exits 0. The daemon and both clients still do this. The "Not done" note in the PR body is stale. Update it to say that min box exec -t sends the configured keys.

Ruled at b2b8cf4 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/exec.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/attach.rs Resolved
A session-key config that is not valid now ends min box exec -t with
no exec started, not with a running exec that has no attach.
@agent-137

Copy link
Copy Markdown
Member

/revise

Head b2b8cf4e. Two minimal-review findings. Change nothing else.

1. Read the session keys before the exec starts (thread PRRT_kwDOPdfcxM627PtE).
attach_exec_terminal reads config.toml through exec_attach_ssh after started_exec_id has already started the exec. So an invalid session-keys config fails min box exec -t and leaves the exec running with nothing attached. Resolve the session keys in cmd_box_exec before it asks the daemon to start the exec, and pass the resolved keys down to the attach. An invalid config then fails before anything starts, with the same refusal min box attach gives. Add a test: with an invalid detach key in config.toml, min box exec -t fails and starts no exec.

2. Fix the contradicting comment (thread PRRT_kwDOPdfcxM627PtK).
In box_via_ssh (crates/minimal-client/src/attach.rs, about lines 163–165), say only what the code does: the wire path sends no session keys. The exec attach sends them through exec_attach_ssh.

Reply on both threads with the commit. Run the whole minimal suite.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #3331. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as d6d59e950543.

line exit tail
cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify exited 100.

pan_id": "73a230d2e8af17a3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "83f4403f66bd6aab",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "d32ca80742ae4478",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "d32ca80742ae4478",
                "queued_behind": "0",
                "span_id": "2b69bc48563c84df",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "d32ca80742ae4478",
                "queued_behind": "0",
                "span_id": "1cd4e6dd2ca812f9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "1cd4e6dd2ca812f9",
                "span_id": "af0b8383a1828f7a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "1cd4e6dd2ca812f9",
                "queued_behind": "0",
                "span_id": "b84fdbf2b9faccbf",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   5.012s] (1219/2719) minimal-client box_registration::tests::resume_timeout_goes_on_and_an_absent_host_fails_closed
        PASS [   4.382s] (1220/2719) minimal-client tty_relay::tests::resume_after_drop_prints_line_and_nudges_winsize
        PASS [   6.175s] (1221/2719) minimal-client box_registration::tests::a_silent_daemon_does_not_hold_the_exit_past_the_deadline
────────────
     Summary [  75.833s] 1221/2719 tests run: 1220 passed, 1 failed, 29 skipped
        FAIL [   3.058s] (1218/2719) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
warning: 1498/2719 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • crates/minimald/src/exec.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/boxes/exec.rs:426: min box exec -t now resolves the session keys before it starts the exec, and passes them to the attach. A bad config ends the command with no exec started. Pinned by box_exec_t_invalid_session_keys_starts_no_exec.
  • 👍 valid — crates/minimal/src/cmd/boxes/attach.rs:165: Changed the box_via_ssh doc comment. It now says only that the exec path (wire set) sends no keys.

Ctrl-] then d ends min box attach <box> --exec <id> with exit 0. The exec keeps running, and a second attach reaches it. min box exec -t sends the same keys. A session-key config that is not valid now stops min box exec -t before any exec starts.

Notes from the agent: Revise round 3. crates/minimal/src/cmd/boxes/exec.rs is outside the task's layers. An earlier round already changed it to send the session keys on min box exec -t's first attach, for the answered thread on crates/minimald/src/exec.rs. This round changes it again, for thread PRRT_kwDOPdfcxM627PtE. A tty exec now resolves the session keys in exec_in_resolved_box, before the exec starts. TtyAttach::Terminal carries the resolved SessionKeys in place of config_dir. attach.rs gains exec_attach_ssh_with_keys. New test: box_exec_t_invalid_session_keys_starts_no_exec. clippy -p minimal --all-targets is clean. I did not run just ci or clippy-strict.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 02:52

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The new commit makes min box exec -t resolve the session keys before it starts the exec. A session-key config that is not valid now stops the command before any side effect, so no PTY exec runs without its attach. This is consistent with min box exec (architecture.md line 498) and with the fail-closed rule. The rest of the change keeps the status from the PASS on b2b8cf4e. There are no conditions.

Ruled at d6d59e9 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/exec/bridge.rs Resolved
@agent-137
agent-137 marked this pull request as ready for review November 13, 2026 03:16
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a /revise note, pushed as a20e18393d68.

line exit tail
cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify timed out after 1800s.

cking bit-set v0.11.1
    Checking unarray v0.1.4
    Checking castaway v0.2.4
    Checking strum v0.28.0
    Checking proptest v1.12.0
    Checking compact_str v0.9.1
    Checking signal-hook v0.3.18
    Checking unicode-truncate v2.0.1
    Checking op v0.0.1 (/workbench/crates/op)
    Checking kasuari v0.4.12
    Checking lru v0.18.2
    Checking signal-hook-mio v0.2.5
    Checking derive_more v2.1.1
    Checking ratatui-core v0.1.2
    Checking line-clipping v0.3.8
    Checking crossterm v0.29.0
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking ratatui-widgets v0.3.2
    Checking ratatui-crossterm v0.1.2
    Checking fuzzy-matcher v0.3.7
    Checking inquire v0.9.4
    Checking ratatui-macros v0.7.2
    Checking ratatui v0.30.2
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking similar v2.7.0
    Checking insta v1.49.0
   Compiling serial_test_derive v4.0.1
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking serial_test v4.0.1
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 56s
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • crates/minimald/src/exec.rs

Converted to a draft: something above needs a person before review.

Ctrl-] then d ends min box attach <box> --exec <id> with exit 0. The exec keeps running, and a second attach reaches it. min box exec -t with an invalid detach key in config.toml fails before it starts an exec.

Notes from the agent: Revise round 4. The note names head b2b8cf4, but commit d6d59e9 on the branch already addressed both findings. Finding 1: cmd_box_exec resolves the session keys before the exec starts, and passes them to exec_attach_ssh_with_keys. The test box_exec_t_invalid_session_keys_starts_no_exec pins it. Finding 2: d6d59e9 fixed the doc comment on box_via_ssh. This round fixed only the inline comment in box_via_ssh_with, which still said the exec path 'has no detach'. It now says that the wire path sends no session keys (commit 8cafb4d). The whole minimal suite passes. Both threads are in 'Threads already answered' with verdict valid, and the verdict did not change, so result.json gives no thread entries.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 03:41

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head conforms to the design. The compare from the last PASS changes one code comment in box_via_ssh_with, and the comment is correct. The two merges of main contain no conflict edits and do not touch the exec attach path. The exec detach still exits 0 and leaves the exec running, as architecture.md lines 376 and 498 require.

Ruled at a20e183 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/exec/bridge.rs Resolved
@agent-137
agent-137 marked this pull request as ready for review November 13, 2026 03:45
An awaited bell parked the exec attach relay for up to 5 s per leader
press behind a client that does not read. The bell now goes only when
the client has room for it. The detach notice waits at most the 2 s
host probe bound, as the box terminal's detach does.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on the runtime's review findings, pushed as 09a572a1f269.

line exit tail
cargo nextest run -p minimal exec_attach_detach_key_returns_0_exec_keeps_running 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Comp
cargo nextest run -p minimald serve_exec_attach_detach_key_ends_channel_exec_runs 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify min task run agent-verify timed out after 1800s.

v0.0.1 (/workbench/crates/args)
    Checking fuzzy-matcher v0.3.7
    Checking similar v2.7.0
    Checking common v0.0.1 (/workbench/crates/common)
    Checking inquire v0.9.4
    Checking ratatui-macros v0.7.2
    Checking insta v1.49.0
    Checking ratatui v0.30.2
   Compiling serial_test_derive v4.0.1
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking serial_test v4.0.1
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 59s
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/exec.rs
  • crates/minimald/src/exec.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM627xmL: The leader bell is now one non-blocking write (ring_bell). It is skipped when the client has no room, so the relay loop never waits on it. (not posted on the thread: not an open thread on the pull request)
  • 👍 valid — PRRT_kwDOPdfcxM628bhU: The bell no longer awaits. The detach notice is bounded by HOST_PROBE_TIMEOUT (2 s) as in box_runtime.rs, and the comment now says that bound. (not posted on the thread: not an open thread on the pull request)

Ctrl-] then d ends min box attach <box> --exec <id> with exit 0. The exec keeps running, and a second attach reaches it. A leader press no longer stalls the attach when the client does not read.

Notes from the agent: Revise round 5. The leader bell is now a single non-blocking write (ring_bell, one poll by now_or_never). The detach notice now waits at most DETACH_NOTICE_BOUND, which is HOST_PROBE_TIMEOUT (2 s), the same bound as the box terminal's detach. The comment no longer says the notice never holds the detach. New test serve_exec_attach_detach_key_ends_channel_exec_runs_bell_never_stalls pins this. I did not check that the new test fails on the old code.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 04:38

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The new commit changes only the exec attach relay in bridge.rs. The leader bell no longer waits on a client that does not read. The detach notice now waits at most 2 s. The box terminal does the same thing in box_runtime.rs. A detach still exits 0 and the exec keeps running, as architecture.md line 498 and line 376 require. The earlier PASS stands for the rest of the change. The PR body still says min box exec -t sends no keys. Commit d6d59e95 fixed that, so update the body.

Ruled at 09a572a against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 13, 2026
@agent-137
agent-137 marked this pull request as ready for review November 13, 2026 04:45

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2026
@agent-137
agent-137 added this pull request to the merge queue Nov 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2026
@agent-137
agent-137 added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit dd7d8cf Nov 13, 2026
40 checks passed
@agent-137
agent-137 deleted the agent/3331-detach-from-an-exec-attach-with-the-detach-keys branch November 13, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T44 — Detach from an exec attach with the detach keys

2 participants