Repository navigation
fix(minimal): min task list in a project with only session boxes says the project has no task boxes - #3363
Conversation
A scoped min task list in a project that holds only a session box prints the task-typed empty line, not the min box list empty line.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Approved: no findings at Nothing to do. Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it. Clobber: none. |
bryan-minimal
left a comment
There was a problem hiding this comment.
Read at the current head against #3351 and #3203. A test-only PR is the right shape here: the behaviour #3203
asked for landed with #3297 on 2026-11-12, and this test pins it in the one case the existing empty-list test
cannot tell apart (a project that holds a session box and no task box). It first proves the session box is
there through the scoped session list, then asserts the exact task-typed line and an empty stderr; the line
comes from empty_typed_list in session.rs, reached through the same function min task list calls, and
the unwrapped call turns an error exit into a failure. Approving, with three small things to tidy:
- The title's type is
fix(minimal)but nothing but a test changes; the squash commit wantstest(minimal).
The title is 99 characters, so the shorter prefix keeps it under the limit. - The comment at crates/minimal/src/tests.rs:13328 opens with the plan key "D3203:". The file's other
comments cite a requirement id; "BCLI-030:", which #3203 itself names, matches them. - The
min box listcheck at tests.rs:13368 renders an empty list against a constant, so its not-equal
assertion is always true (the bot's open nit). Either list the real project through the box-list code and
assert thewebrow, or drop those lines.
Also: "Fixes #3351" closes only the task issue; #3203 should close against #3297 and this PR.
Checked and fine: the exact text and newline match what the code prints; no ordering or user-daemon
dependency (the test runs its own daemon as its neighbours do); the name follows the file's sentence style;
session.rs was in the task's "may touch" list only for the case the test did not need, so leaving it alone
was right. One known gap, shared with the sibling test: the project root is passed directly, so the
project-from-cwd step and minimal.toml are never read; the filter works on box records, so that is fine.
|
/revise One change, from the open NIT on The |
…ist-in-a-project-with-only-session-box
The min box list check now renders the boxes of the project that holds the session box, and asserts the session box is in it, in place of an always-true assert_ne against an empty listing.
|
Round 1 of 10 on a /revise note, pushed as
Verify Converted to a draft: something above needs a person before review. Review threads the coder judged:
In a project that holds only a session box, the test shows that min task list prints This project has no task boxes. The test also shows that min box list for the same project lists the session box web, not its empty line. Notes from the agent: Revise round 1: only the min box list half of the test changed. It now reads the boxes from the local hosts, keeps the ones in the project, and renders them as the scoped min box list. It asserts a header and one session row for web, and no EMPTY_PROJECT_LIST line. The assert_ne is gone. crates/minimal/src/cmd/session.rs needed no change. |
|
Every failing check on
Re-run the failed jobs. If the same checks go red again on this head, the next failed suite starts a round; if this red is not the flake, |
norrietaylor
left a comment
There was a problem hiding this comment.
Re-read at db79ff8a. The one change since 8fc8832d (besides the main merge) is the NIT: the min box list half of task_list_in_a_session_only_project_says_no_task_boxes now lists the project's real boxes and asserts the session row, so it can fail. Required CI is green; agent-verify fails only on #3398.
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of db79ff8a602e withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.
|
/arch-review db79ff8 |
|
/revise One change, from the arch ruling on In Do:
|
…ist-in-a-project-with-only-session-box
The box list half of task_list_in_a_session_only_project_says_no_task_boxes now asks the daemon for the project's boxes through list_box_records, as min box list does, in place of a filter in the test.
|
Round 2 of 10 on a /revise note, pushed as
Verify Converted to a draft: something above needs a person before review. In a project that holds only a session box, min task list prints This project has no task boxes, and min box list, scoped to the project through ListBoxes as the command sends it, prints a header and the web session row and not its own empty line. Notes from the agent: Revise round 2: the box list half of the test now connects with connect_daemon and calls list_box_records(&mut client, Some(root.clone())), maps the records to cmd::ListedBox with the selected host's provider and host, and renders them with cmd::render_box_list. The assertions are unchanged. crates/minimal/src/cmd/session.rs needed no change. |
|
/arch-review a6884fb |
Defect
Fixes #3351
crates/minimal/src/tests.rscrates/minimal/src/cmd/session.rsTask marker
Proof
A test now creates a project that holds only a session box. In that project, a scoped min task list prints "This project has no task boxes. Run
min task list --allto list the task boxes of every project." The line is not the min box list empty line. min box list still prints its own line, "This project has no boxes. ...", for a project with no boxes.Notes from the agent: The current code already prints the task-typed line through empty_typed_list. The new test passed on its first run, so crates/minimal/src/cmd/session.rs needs no change and I did not change it.
Tests
cargo test -p minimal task_list_in_a_session_only_project_says_no_task_boxesVerify
min task run agent-verifyexited 100, so this PR is a draft.