Skip to content

fix(minimald,minvmd): git clone in a hostname-allowlist VM box is not refused on its own loopback - #3375

Open
minimal-foundry[bot] wants to merge 10 commits into
mainfrom
agent/3353-git-clone-in-a-hostname-allowlist-vm-box-is-not
Open

minimal-foundry[bot] wants to merge 10 commits into
mainfrom
agent/3353-git-clone-in-a-hostname-allowlist-vm-box-is-not

Conversation

@minimal-foundry

@minimal-foundry minimal-foundry Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Defect

Fixes #3353

Task marker
### D2996 — git clone in a hostname-allowlist VM box is not refused on its own loopback connect, and hostname_allowlist_toolchain_completes passes each run
  kind: task
  size: S
  est: 80 code, 90 tests
  executor: agent
  defect: bug
  epic: 1437
  layers:
    - classifier:
      - crates/minimald/src/net/classifier.rs: finds the rule or leaf placement that put git's 127.0.0.1 connect through a refusing chain, and admits a box's in-box loopback connect
      - scripts/install-host-classifier.sh: keeps deny_out and proxy_lane off a box's in-box loopback flow, if the guest ruleset is where the refusal comes from
      - crates/minimald/src/box_runtime/launcher.rs: places the exec of an own-address hostname-allowlist box in the leaf its verdict names, if the exec lands in the deny subtree
      test: cargo test -p minimald hostname_allowlist_box_loopback_connect_is_admitted
    - e2e:
      - crates/minvmd/tests/egress_allowlist_integration.rs: asserts that the boot log has no minimal-classifier refused line on lo while the toolchain runs
      - docs/specs/18-spec-box-networking/18-spec-box-networking.md: records under NET-068 that a box's own loopback traffic is not refused by the guest table
      test: cargo nextest run -p minvmd hostname_allowlist_toolchain_completes
  proof: Repeated runs of hostname_allowlist_toolchain_completes pass, and the guest boot log has no minimal-classifier refused line for 127.0.0.1 on lo.

Proof

Green KVM runs of the test: at f5c3434c (job 133595848876, 78.0s) and at 58b6f65b (job 133868140076, PASS [72.710s] minvmd::egress_allowlist_integration hostname_allowlist_toolchain_completes), the second with Docker Hub's S3 blob host on the list. A third at f346f577 (job 133903558230, PASS [93.353s]), with skip_boot_log waiting for a quiet boot log.

That run includes the new assertion that no minimal-classifier: refused line on lo appears while the toolchain runs. The agent's notes below were written before it.

Not delivered on this box. A person can now see two things. First, a unit test pins that no rule of the guest table can refuse an own-IP hostname-allowlist box's loopback connect. Second, hostname_allowlist_toolchain_completes reads the guest boot log only from the first tool on, and fails if a minimal-classifier refused line on lo appears while the toolchain runs. Repeated passing VM runs are still owed by a VM lane.

Notes from the agent: Finding: the guest table does not refuse git's 127.0.0.1 connect. An own-IP box has its own network namespace (OwnIpNetwork relays its own tap) and gets no classifier leaf (launcher.rs places a leaf for HostNet only). A hostname allowlist is not deny-all, so verdict_of gives Allow. Every refusing rule of the guest render needs a socket of the boxes subtree. The refused line on lo for 127.0.0.1 comes from the guest's effect probe. At boot the probe connects from boxes/deny/filter-probe- to the daemon's own loopback listener, and deny_out logs that refusal by design. The e2e test read the boot log from offset 0, so git's tail (the first tool) carried the probe's boot-time line, and the line looked like git's. Changes: (1) classifier.rs adds hostname_allowlist_box_loopback_connect_is_admitted, which pins these facts against the installer's rendered guest table. (2) The e2e test calls skip_boot_log before the tools, collects 'minimal-classifier: refused' lines with OUT=lo, and asserts there are none. (3) NET-068 in spec 18 gets a second verify line and a comment that records the fact. No change to scripts/install-host-classifier.sh or box_runtime/launcher.rs: their layer notes were conditional ('if the guest ruleset is where the refusal comes from', 'if the exec lands in the deny subtree'), and neither condition holds. Widening deny_out to the loopback would also break NET-079 (host_ip_deny_all_reaches_only_the_answerer). Not verified: the VM run. The e2e edit was type-checked and linted with 'cargo clippy -p minvmd …[truncated]

Tests

line exit tail
cargo test -p minimald hostname_allowlist_box_loopback_connect_is_admitted 0 running 1 test test net::classifier::tests::hostname_allowlist_box_loopback_connect_is_admitted ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1469 filtered out; finished in 0.10s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 10 filtered out; fi
cargo nextest run -p minvmd hostname_allowlist_toolchain_completes 4 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Comp

Verify

min task run agent-verify timed out after 1800s, so this PR is a draft.

HE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.685s] ( 600/2237) minimald env::tests::refresh_remaps_the_installed_set_onto_the_new_graph
        PASS [   0.723s] ( 601/2237) minimald env::tests::refresh_does_not_adopt_the_repos_top_levels
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1440.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

An own-IP box with a hostname allowlist is placed in no leaf and runs in
its own network namespace. Every refusing rule of the guest table needs
a socket of the boxes subtree, so the one refused line on lo in a guest
boot log is the effect probe's, from its deny leaf.
The boot log tail started at the boot, so git's tail carried the guest
effect probe's refusal on lo and read as git's. Read the log from the
first tool on, and assert that no minimal-classifier refusal on lo
appears while the toolchain runs. Record the fact under NET-068.
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6a043a76-6904-4a87-9d89-ad0b4c87bc22

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/18-spec-box-networking/18-spec-box-networking.md — 10 finding(s)

docs/specs/18-spec-box-networking/18-spec-box-networking.md:171: P004 NET-009 names test 'native_resolution_without_proxy_env', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:378: P004 NET-040 names test 'fresh_install_own_ip_ingress_publishes_loopback', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:388: P004 NET-041 names test 'installer_switch_binary_executable', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:435: P004 NET-048 names test 'linux_amd64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:440: P004 NET-049 names test 'fresh_linux_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:445: P004 NET-050 names test 'linux_arm64_manifest_ships_vm_stack', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:450: P004 NET-051 names test 'fresh_arm64_kvm_activate_local_minvmd', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:946: P004 NET-132 names test 'proxy_sees_each_vm_box_by_its_switch_address', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:972: P004 NET-134 names test 'deny_all_box_reaches_proxy_and_no_other_host_port', which was not found in the repository
docs/specs/18-spec-box-networking/18-spec-box-networking.md:996: P004 NET-107 names test 'session_outbound_request', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@5ffd41cf, spec format: How Minimal Writes Specs.

@norrietaylor

Copy link
Copy Markdown
Member

/revise make min task run agent-verify finish: it timed out after 1800s on this head (b16437269acc), so this PR is a draft.

Evidence: the PR body says min task run agent-verify timed out after 1800s. This task's own test: lines ran, and GitHub CI is green on every required lane.

Do:

  1. Run the verify, and find out whether a test this change adds or touches hangs, or runs much longer than the others.
  2. If so, fix the cause, so that the test ends in bounded time. Do not mark it ignored, and do not narrow what it checks.
  3. If the run is slow only because the workspace builds cold, and no test of this change hangs, change no file. Give the evidence (the slowest tests and their times) in your final message.

@norrietaylor

Copy link
Copy Markdown
Member

/revise make min task run agent-verify finish: it timed out after 1800s on this head (b16437269acc), so this PR is a draft.

This repeats the /revise from 05:29Z. Its round (job c3dfab7f) ran, then failed in decide with HTTP 401 and pushed nothing (agent-runtime#501).

Evidence: the PR body says min task run agent-verify timed out after 1800s. This task's own test: lines ran, and GitHub CI is green on every required lane.

Do:

  1. Run the verify, and find out whether a test this change adds or touches hangs, or runs much longer than the others.
  2. If so, fix the cause, so that the test ends in bounded time. Do not mark it ignored, and do not narrow what it checks.
  3. If the run is slow only because the workspace builds cold, and no test of this change hangs, change no file. Give the evidence (the slowest tests and their times) in your final message.

@norrietaylor

Copy link
Copy Markdown
Member

/revise make min task run agent-verify finish: it timed out after 1800s on this head (b16437269acc), so this PR is a draft.

This repeats the /revise from 2026-11-13. Its two rounds (jobs c3dfab7f, 30a07b29) ran, then lost their result to an HTTP 401 when the round was posted. That was a runtime bug, now fixed (agent-runtime#501).

Evidence: the PR body says min task run agent-verify timed out after 1800s. This task's own test: lines ran, and GitHub CI is green on every required lane. The timeout is most likely env::tests::minenv_run_forwards_stdin_to_the_task hanging. That is a known flake on main (#3415), and it hangs on branches that do not touch it.

Do:

  1. Run the verify, and find out which tests hang or run much longer than the others.
  2. If a test this change adds or touches hangs, fix the cause, so that the test ends in bounded time. Do not mark it ignored, and do not narrow what it checks.
  3. If the only hang is minenv_run_forwards_stdin_to_the_task (flake: minenv_run_forwards_stdin_to_the_task hangs in agent-verify (CI skips it) #3415), or the run is slow only because the workspace builds cold, change no file. Give the evidence (the hung or slowest tests and their times) in your final message.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on a /revise note: the coder changed nothing. No file changed, as the directive's item 3 says. I ran the steps of agent-verify with this branch's crates (minimald, minvmd). fmt passed. Clippy passed in 7m 15s, cold. nextest took 25m 26s of wall time. Hangs: minimald env::tests::minenv_run_forwards_stdin_to_the_task (#3415) and minimald env::tests::task_run_pipes_stdin_through_the_in_box_helper. Each one was still running after 780s, and I killed them. The second test is in the same module and also forwards stdin, so it is probably the same flake. Nextest reported the two killed tests as failed. Failures this box can reproduce on its own: minvmd net::egress_gate::tests::a_stalled_switch_does_not_hold_the_relay_past_a_guest_close fails at egress_gate.rs:21346 in about 5s. minimald env::tests::task_entrypoint_carries_env_cwd_and_args fails because this sandbox sets MINIMAL_OTEL=off, so the request starts with otel%off% and the run% prefix check fails. This branch touches neither env.rs nor egress_gate.rs. Slowest tests th…[truncated]

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a failed check suite: the coder changed nothing. Revise round 4 changes nothing. The directive gives two failed checks: ci-linux-native-success, which is the aggregator, and tests. The tests excerpt shows only PASS lines from the decode crate and job cleanup. It does not name a failing test, and I have no way to fetch the full log. This branch changes only a unit test in crates/minimald/src/net/classifier.rs, the ignored VM test in crates/minvmd/tests/egress_allowlist_integration.rs, and a comment and verify line in the 18 spec. No other test reads the spec file. Local results: the new unit test passes. cargo nextest run -p minimald --lib net:: ran 472 tests and all passed. Under cargo test (one process, threads in parallel), 10 net::switch and net::answerer tests failed, and each one passed when run alone. They are a contention flake in code that this branch does not touch. A full cargo nextest run -p minimald -p minvmd --no-fail-fast ran past the 30-minute tool limit and gave no result. The CI failure is probably …[truncated]

@norrietaylor
norrietaylor marked this pull request as ready for review November 16, 2026 21:40
@norrietaylor
norrietaylor requested a review from a team as a code owner November 16, 2026 21:40

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at f5c3434c against D2996. No product code changes. The coder found the minimal-classifier: refused line on lo was the guest effect probe's boot-time connect from boxes/deny/filter-probe-*, not git's: the e2e test read the boot log from offset 0, so the first tool's tail carried it. hostname_allowlist_box_loopback_connect_is_admitted pins against the installer's rendered guest table that every refusing rule needs a socket of the boxes subtree, and that a hostname allowlist is never placed in the deny subtree. The e2e test now skips the boot log, collects refusals with OUT=lo, and fails on any. The conditional layers (installer, launcher) were left alone because their conditions do not hold, and widening deny_out would break NET-079. That is the right call. VM evidence: test-kvm ran it on this head, PASS [78.024s] minvmd::egress_allowlist_integration hostname_allowlist_toolchain_completes (job 133595848876). That is one run, not the repeated runs the proof names, so the flake's absence rests on the merge queue and later runs.

@minimal-foundry

minimal-foundry Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at f346f577d4da.

@norrietaylor resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The change conforms to the design. An own-IP box owns its localhost (UC1), and the classifier decides only sockets of the boxes subtree (§4.1 line 54). The new unit test pins this against the installer's render, and the PR correctly keeps deny_out closed on the loopback. The proof of NET-068 is open. hostname_allowlist_toolchain_completes did not run (exit 4, #[ignore] without MINVMD_E2E=1), but the body still says Fixes #3353. C1 keeps the issue open until a green KVM run exists, or files the proof as a residual with an issue.

Ruled at f5c3434 against gominimal/arch@327e1b57d16b by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/net/classifier.rs Resolved
The loopback test now asserts that the output and ipv6_out chains
have rules before it checks them, and that an own-IP launch is placed
in no classifier leaf, through the launcher's named gate.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on the runtime's review findings, pushed as e5a84b7a0fbb.

line exit tail
cargo test -p minimald hostname_allowlist_box_loopback_connect_is_admitted 0 running 1 test test net::classifier::tests::hostname_allowlist_box_loopback_connect_is_admitted ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1487 filtered out; finished in 0.11s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 10 filtered out; fi
cargo nextest run -p minvmd hostname_allowlist_toolchain_completes 4 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Compiling args v0.0.1 (/workben

Verify min task run agent-verify timed out after 1800s.

t/some dir\u{1f}RUSTC_WRAPPER=sccache\u{1f}SCCACHE_BUCKET=agent-runtime-sccache-gominimal-minimal\u{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   1.029s] ( 612/2262) minimald env::tests::refresh_remaps_the_installed_set_onto_the_new_graph
        PASS [   0.294s] ( 613/2262) minimald env::tests::task_entrypoint_relays_the_task_exit_code
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minvmd/tests/egress_allowlist_integration.rs:511: Holds: the test is #[ignore] without MINVMD_E2E=1 and this box has no /dev/kvm, so it exited 4 again this round. No code change can fix that. The PR body needs Refs D2996 — git clone in a hostname-allowlist VM box is not refused on its own loopback connect, and hostname_allowlist_toolchain_completes passes each run #3353 until a green ci-linux-kvm run is linked. I cannot edit the PR body, so I flagged this in the result notes.
  • 👍 valid — docs/specs/18-spec-box-networking/18-spec-box-networking.md:582: Holds: NET-068 stays open until a KVM lane runs hostname_allowlist_toolchain_completes green. This box cannot run it. The spec text stays as it is, and the evidence is owed by ci-linux-kvm.
  • 👍 valid — crates/minimald/src/net/classifier.rs:7355: The test now asserts that the output and ipv6_out chains are not empty before it checks them. It also asserts through the launcher's new placed_in_classifier_leaf gate that an own-IP box gets no leaf.

A person can run hostname_allowlist_box_loopback_connect_is_admitted and see that no rule of the guest table refuses a box's own loopback connect. The test also shows that an own-IP box is placed in no classifier leaf. The repeated-run half of the proof (hostname_allowlist_toolchain_completes passes, and the boot log has no minimal-classifier refused line for 127.0.0.1 on lo) is NOT shown by this branch yet. Only a KVM lane can run it, and no run of it is on record for this head.

Notes from the agent: Revise round 5. I added the named gate placed_in_classifier_leaf to launcher.rs and used it at the one place where the launch decides to allocate a leaf. The behaviour does not change. The unit test now uses this gate to check the own-IP claim, and it asserts that the output and ipv6_out chains have rules. The minvmd test line exited 4 here because there is no /dev/kvm and MINVMD_E2E is not set. The evidence for NET-068 and the repeated-run proof is owed by the ci-linux-kvm lane. Until a green ci-linux-kvm run of hostname_allowlist_toolchain_completes is linked, the PR body must say Refs #3353, not Fixes #3353. I cannot edit the PR body.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 16, 2026 22:31

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms. An own-IP allowlist box has its own localhost and no classifier leaf, as UC1 line 83 and section 4.1 line 54 require. The launcher and the test now share one placement predicate, placed_in_classifier_leaf. The deny-all refusal stays loopback-wide, and the e2e leg now fails on any refusal on lo while the tools run. No conditions.

Ruled at e5a84b7 against gominimal/arch@327e1b57d16b by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on the runtime's review findings: the coder changed nothing. Revise round 6: no code change. The one open finding is correct that no production behaviour changes, and that is deliberate. The earlier rounds found that the refused line on lo in the boot log came from the guest effect probe's deny leaf, not from git, and the e2e test read the log from boot start. The fix is in the test and the pinned table facts. The PR body is written by the runner, and no commit on this branch carries a closing keyword. Until a green ci-linux-kvm run of hostname_allowlist_toolchain_completes exists, the PR body must say 'Refs #3353', not 'Fixes #3353'. The minvmd test line is deferred to the KVM lane: this box has no /dev/kvm.

Review threads the coder judged:

  • 👎 invalid — crates/minimald/src/box_runtime/launcher.rs:1288: No production change is deliberate: the investigation showed the refused line on lo was the guest effect probe's (its deny leaf), not git's, and an own-IP box is in no leaf and has no refusing rule. The defect was the e2e test reading the log from boot start, fixed in b164372. No commit carries 'Fi

@norrietaylor

Copy link
Copy Markdown
Member

/revise Add Docker Hub's S3 blob host to the NET-068 allowlist. Change nothing else.

The merge-queue test-kvm run for #3396 (job 133676771871, 2026-11-16) failed hostname_allowlist_toolchain_completes on the container pull:

level=fatal msg="copying system image from manifest list: reading blob sha256:4f55086f…: Get \"https://docker-images-prod.s3.dualstack.us-east-1.amazonaws.com/registry-v2/docker/registry/v2/blobs/…/data?…\": dial tcp: lookup docker-images-prod.s3.dualstack.us-east-1.amazonaws.com on 100.64.0.1:53: no such host

Docker Hub's blob redirect can land on S3 directly, not only on production.cloudflare.docker.com or production.cloudfront.docker.com. The DNS gate refused the name because it is not on the list. This PR says Fixes #3353 ("passes each run"), so the list must name every host the pull may contact.

Do:

  1. Add docker-images-prod.s3.dualstack.us-east-1.amazonaws.com to NET068_TOOLCHAIN_EGRESS_HOSTS in crates/boxes/src/lib.rs, and update its doc comment to name the third redirect target.
  2. Update the NET-068 comment in docs/specs/18-spec-box-networking/18-spec-box-networking.md that names the CDNs ("cloudflare and cloudfront"), so it names S3 too.
  3. Fix any test that pins the list's length or contents, such as in crates/minimald/src/net/dns_gate.rs.
  4. Run cargo test -p minimald hostname_allowlist_box_loopback_connect_is_admitted, cargo test -p boxes, and cargo test -p minimald dns_gate.

Docker Hub's blob redirect can land on
docker-images-prod.s3.dualstack.us-east-1.amazonaws.com, not only on its
two CDNs. The DNS gate refused that name, and the container pull in
hostname_allowlist_toolchain_completes failed.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 7 of 10 on a /revise note, pushed as 58b6f65bc4f7.

line exit tail
cargo test -p minimald hostname_allowlist_box_loopback_connect_is_admitted 0 running 1 test test net::classifier::tests::hostname_allowlist_box_loopback_connect_is_admitted ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1492 filtered out; finished in 0.08s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; fi
cargo nextest run -p minvmd hostname_allowlist_toolchain_completes 4 ded litrs v1.0.0 Downloaded darling v0.24.0 Downloaded similar v2.7.0 Downloaded pest_meta v2.8.8 Downloaded boringtun v0.7.1 Downloaded finl_unicode v1.4.0 Downloaded mockall_derive v0.15.0 Downloaded ratatui v0.30.2 Downloaded prettyplease v0.2.37 Downloaded signal-hook v0.3.18

Verify min task run agent-verify timed out after 1800s.

e-sccache-gominimal-minimal\u{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.393s] (1262/2926) minimald env::tests::search_finds_known_package
        PASS [   3.096s] (1263/2926) minimald env::tests::run_task_relays_exit_through_both_paths
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Outside the task's layers::

  • crates/boxes/src/lib.rs
  • crates/minimald/src/net/dns_gate.rs

Converted to a draft: something above needs a person before review.

The NET-068 allowlist now names docker-images-prod.s3.dualstack.us-east-1.amazonaws.com, so the DNS gate resolves Docker Hub's S3 blob redirect in a hostname-allowlist box. The dns_gate unit test resolves and pins that name. Repeated passing runs of hostname_allowlist_toolchain_completes still need a KVM lane. This box did not run them.

Notes from the agent: The directive asked for this round's change. It changes crates/boxes/src/lib.rs and crates/minimald/src/net/dns_gate.rs, and the task's layers do not name these files. The test toolchain_hosts_admitted_by_gate in dns_gate.rs pins the constant's contents and order, so it got a new S3 entry with a representative us-east-1 S3 address (52.217.161.40). denied_range_resolution_logged fails in a parallel run with or without this change. It counts log lines from a shared capture, and it passes with --test-threads=1. The boxes doctests did not run because rustdoc is missing on this box. cargo nextest run -p minvmd hostname_allowlist_toolchain_completes did not run this round. It needs KVM and MINVMD_E2E=1 (deferred: ci-linux-kvm). No thread verdict changed this round.

@norrietaylor
norrietaylor marked this pull request as ready for review November 17, 2026 07:10

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-read at 58b6f65b. Since my last approval: round 5 asserts that the output and ipv6_out rule lists are not empty (the LOW finding) and moves the launcher's HostNet-only leaf check into placed_in_classifier_leaf, which the unit test pins (no behaviour change). Round 7 adds docker-images-prod.s3.dualstack.us-east-1.amazonaws.com to NET068_TOOLCHAIN_EGRESS_HOSTS, the DNS-gate fixture and the spec 18 note, after two merge-queue test-kvm runs failed on that redirect. boxes/src/lib.rs and dns_gate.rs are accepted as out of scope at this head. test-kvm on this head: PASS [72.710s] hostname_allowlist_toolchain_completes. The agent-verify hang is #3415.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms. Since the PASS on e5a84b7a, the only change in this PR's files adds Docker Hub's S3 blob host to the test-only NET-068 allow-list. UC3 line 99 provides for named DNS hosts on a per-box allow-list. The classifier, launcher and e2e changes are as they were at the earlier PASS.

Ruled at 58b6f65 against gominimal/arch@327e1b57d16b by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/net/classifier.rs Resolved
The effect probe's refusal on lo can reach the console after the
offset moves. Wait until the log stops growing, so a late boot line
does not count as a refusal from a tool's run.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 8 of 10 on the runtime's review findings, pushed as f346f577d4da.

line exit tail
cargo test -p minimald hostname_allowlist_box_loopback_connect_is_admitted 0 running 1 test test net::classifier::tests::hostname_allowlist_box_loopback_connect_is_admitted ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1494 filtered out; finished in 0.10s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; fi
cargo nextest run -p minvmd hostname_allowlist_toolchain_completes 4 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-1 in box runtime-implement-test-1-1... Compiling args v0.0.1 (/workben

Verify min task run agent-verify timed out after 1800s.

e-sccache-gominimal-minimal\u{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.366s] (1264/2928) minimald env::tests::search_finds_known_package
        PASS [   3.186s] (1265/2928) minimald env::tests::run_task_relays_exit_through_both_paths
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Outside the task's layers::

  • crates/boxes/src/lib.rs
  • crates/minimald/src/net/dns_gate.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👎 invalid — PRRT_kwDOPdfcxM64JojD: This holds on this branch now: two green ci-linux-kvm runs of hostname_allowlist_toolchain_completes (on f5c3434 and 58b6f65) are linked in the PR body's Proof, so Fixes D2996 — git clone in a hostname-allowlist VM box is not refused on its own loopback connect, and hostname_allowlist_toolchain_completes passes each run #3353 has its evidence. No code change is necessary. (not posted on the thread: not an open thread on the pull request)
  • 👎 invalid — PRRT_kwDOPdfcxM64JojK: The KVM lane ran the NET-068 verify line green twice (jobs 133595848876 and 133868140076), and both runs are linked in the PR body. The requirement has its evidence, so the spec text stays as it is. (not posted on the thread: not an open thread on the pull request)
  • 👎 invalid — crates/minimald/src/net/classifier.rs:7370: This is deliberate. The unit test cannot load nft or drive a real flow, so it proves the ruleset's shape: every refusal needs a boxes-subtree socket, and an own-IP box is in no leaf. The hard-coded chain list must fail on a new refusing chain, so that a person re-checks the loopback case. The real f
  • 👍 valid — crates/minvmd/tests/egress_allowlist_integration.rs:323: skip_boot_log now waits until the boot log does not grow for 1 s (at most 10 s) before it moves the offset, so a late console line from the boot's probe stays out of the tools' tail.

The PR links two green ci-linux-kvm runs of hostname_allowlist_toolchain_completes (on f5c3434 and 58b6f65). The test fails on any minimal-classifier refused line on lo while the toolchain runs. This round, the test also waits for the boot log to stop growing before the tools run, so a late boot-time probe line cannot fail it.

Notes from the agent: This round changed only the e2e test: skip_boot_log now waits until the guest boot log does not grow for 1 s (at most 10 s) before it moves the offset. The VM test cannot run on this box (no KVM), so the nextest line exited 4 with no tests run. The ci-linux-kvm lane owes the run on this head. The nextest exit code comes from nextest itself, not from the pipe.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 17, 2026 07:56

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head changes only the e2e harness. skip_boot_log now waits for a quiet boot log before the tools run. The lo_refusals assertion does not change, and the wait ends before the first tool runs. So the proof of NET-068 does not get weaker (UC1 line 83, UC3 line 99). If the log never gets quiet or is missing, the test still fails closed. The ruling on 58b6f65b stands for the rest of the change. No condition is open. The KVM lane run of hostname_allowlist_toolchain_completes on this head is the proof of record.

Ruled at f346f57 against gominimal/arch@327e1b57d16b by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-foundry[bot] crates/minimald/src/net/classifier.rs:7370, minimal-foundry[bot] crates/minvmd/tests/egress_allowlist_integration.rs:323. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@norrietaylor
norrietaylor marked this pull request as ready for review November 17, 2026 08:41

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-read at f346f577. Round 8 is test-only: skip_boot_log now waits until the guest boot log stops growing for 1s (10s at most) before it moves the offset, so a late console line from the boot probe's refusal cannot land in the first tool's tail. I agree with the coder's rejection of the other LOW: the unit test cannot load nft, and its fixed chain list is meant to fail on a new refusing chain. The rest is a main merge. The out-of-scope files are unchanged since 58b6f65b. test-kvm on this head: PASS [93.353s] hostname_allowlist_toolchain_completes (job).

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of f346f577d4da withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 17, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Nov 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

1 participant