Skip to content

fix(minimal): in a machine output mode, a box address refusal prints the error kind that its exit - #3386

Merged
mitodrummer merged 6 commits into
mainfrom
agent/3345-in-a-machine-output-mode-a-box-address-refusal-p
Nov 14, 2026
Merged

mitodrummer merged 6 commits into
mainfrom
agent/3345-in-a-machine-output-mode-a-box-address-refusal-p

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

Defect

Fixes #3345

Task marker
### D3010 — In a machine output mode, a box address refusal prints the error kind that its exit code stands for, not unspecified
  kind: task
  size: S
  est: 40 code, 70 tests
  executor: agent
  defect: bug
  epic: 2879
  layers:
    - cli:
      - crates/minimal/src/main.rs: adds a BoxAddressRefusal arm to machine_mode_answer: not_found for exit 4, host_unreachable for exit 7, the usage kind for exit 2, with the refusal text as message; adds unit tests per kind
      - crates/minimal/src/cmd/boxes/address.rs: adds a pub code() method (and a hint) on BoxAddressRefusal that gives the machine-mode error kind for each variant, beside exit_code()
      test: cargo test -p minimal box_address_refusals_answer_with_their_error_kinds
  proof: A min box verb with -o json for a box that does not exist exits 4 and its min/v1/error object has code not_found, and an unreachable host gives host_unreachable with exit 7.

Proof

With -o json, a min box verb for a box that does not exist exits 4, and its min/v1/error object has code not_found. A box on a host that does not answer gives code host_unreachable with exit 7. An ambiguous name or id start gives code usage with exit 2.

Notes from the agent: The repository names no error kind for a usage error, so the code for exit 2 is usage. Change it in BoxAddressRefusal::code() if the error model names it otherwise. The hint for each variant repeats the next step of its message. The not-found hint changed from "min box list lists the boxes there are" to "Run min box list --all to see the boxes on every host." No test pinned the old hint for this refusal. The whole min binary unit test suite (35 tests) passes, and cargo clippy -p minimal --all-targets is clean.

Tests

line exit tail
cargo test -p minimal box_address_refusals_answer_with_their_error_kinds 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 953 filtered out; finished in 0.00s running 1 test test tests::box_address_refusals_answer_with_their_error_kinds ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 34 filtered out; finished in 0.00s r

Verify

min task run agent-verify exited 100, so this PR is a draft.

 {
                "parent_span_id": "7571f8acb216624c",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "ebce70bd54f972f0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "ebce70bd54f972f0",
                "queued_behind": "0",
                "span_id": "ed86e802c50123e5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "7571f8acb216624c",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "c845bb39be7a240e",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "c845bb39be7a240e",
                "queued_behind": "0",
                "span_id": "562c77a120526278",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "c845bb39be7a240e",
                "queued_behind": "0",
                "span_id": "45e45450f10ad778",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "45e45450f10ad778",
                "span_id": "b9f6cef5d12f98db",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "45e45450f10ad778",
                "queued_behind": "0",
                "span_id": "20b2133be3d309ea",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  61.714s] 1114 tests run: 1113 passed, 1 failed, 2 skipped
        FAIL [   2.745s] (1114/1114) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

A box address refusal in a machine output mode answered with code
unspecified unless it was not found. Ambiguous names now answer usage
(exit 2), and an unreachable host answers host_unreachable (exit 7).
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f4245973-104a-4f68-88bf-d425a421b266

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at c30ff8dd00a1.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. A box address refusal in a machine mode now answers with the error kind that its exit code stands for: not_found for 4, host_unreachable for 7 and usage for 2 (architecture.md lines 363, 365, 368 and 383). The kind lives on BoxAddressRefusal beside exit_code(), and machine_mode_answer stays the one mapper. The design names no code for exit 2, so usage is acceptable until the design names one. One note outside the design: min box list --all widens to every project, not every host. Correct the not-found hint text.

Ruled at 584dd25 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/address.rs Resolved

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/address.rs Resolved
The --all flag lists the boxes of every project, not of every host.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as c8dc73d522ce.

line exit tail
cargo test -p minimal box_address_refusals_answer_with_their_error_kinds 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 958 filtered out; finished in 0.00s running 1 test test tests::box_address_refusals_answer_with_their_error_kinds ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 34 filtered out; finished in 0.01s r

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "c30ca46b8f3709c6",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "b2eb9f53a0efcc58",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "b2eb9f53a0efcc58",
                "queued_behind": "0",
                "span_id": "a9bb30efd68a6813",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "c30ca46b8f3709c6",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "02beef1043bc0442",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "02beef1043bc0442",
                "queued_behind": "0",
                "span_id": "a36bcd85a4b97570",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "02beef1043bc0442",
                "queued_behind": "0",
                "span_id": "c8a030a2ca47162a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "c8a030a2ca47162a",
                "span_id": "10b1de0db019613c",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "c8a030a2ca47162a",
                "queued_behind": "0",
                "span_id": "a9afa543bd7a25f1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  80.481s] 1119 tests run: 1118 passed, 1 failed, 2 skipped
        FAIL [   3.368s] (1119/1119) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/boxes/address.rs: The NotFound hint now reads "Run min box list --all to see the boxes of every project." The older Display text, which is also in list.rs and show.rs, is outside this task's files. It needs a follow-up.
  • 👎 invalid — crates/minimal/src/cmd/boxes/address.rs:125: No error code for exit 2 exists anywhere to settle against. The architecture calls exit 2 a usage error, so usage follows it. Documenting it needs docs/reference/cli-min.md, and that file is outside this task's layers. It needs a follow-up docs change, not a code change here.

A min box verb with -o json for a box that does not exist exits 4 and writes a min/v1/error object with code not_found. Its hint now says min box list --all shows the boxes of every project. An unreachable host gives code host_unreachable with exit 7.

Notes from the agent: Only the hint() text changed this round. The NotFound Display text (address.rs:198) still says 'to see the boxes on every host'. The same sentence is in list.rs, show.rs and tests.rs. That text was there before this task, and list.rs, show.rs and tests.rs are outside the layers, so a follow-up must change all of them together. The 'usage' code for exit 2 stays as it is. No other code name exists for a usage error, and the docs/reference/cli-min.md error-code list is outside the layers. A follow-up must document it there.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 15:45

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design, and the earlier PASS on 584dd25f stands. The new commit changes only the NotFound hint. The hint now says that min box list --all shows the boxes of every project, and list.rs agrees. Each address refusal still gives one min/v1/error object with a code that matches its exit code (Output conventions, line 383, and Exit codes, lines 363 to 368).

Ruled at c8dc73d against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@norrietaylor
norrietaylor marked this pull request as ready for review November 13, 2026 16:18

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 2 unresolved threads — minimal-arch[bot] crates/minimal/src/cmd/boxes/address.rs, minimal-foundry[bot] crates/minimal/src/cmd/boxes/address.rs:125.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against D3010 at c8dc73d5. A box address refusal in a machine output mode now answers with its kind: not_found (exit 4), host_unreachable (exit 7), usage (exit 2), with the refusal text and a per-variant hint. The NotFound hint says --all lists every project's boxes, as the arch note asked. The usage name follows the plan. Documenting the codes is #3402. Arch: PASS on head.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of c8dc73d522ce withheld this approval on the threads open then. Posted as a comment, as the review itself was; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 13, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Nov 13, 2026

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at c8dc73d against the CLI error vocabulary and the exit-code tests. The change is right: every
address refusal in machine mode now yields the shared min/v1/error object (code, message, hint), the
exit code comes from the same exit_code() the text path uses, stdout stays empty, and the new test covers
all four variants and all three codes. One change before it merges, since scripts match on the string:

  • Name the failure, not the exit class: ambiguous, not usage (crates/minimal/src/cmd/boxes/address.rs:122).
    Every other code says what went wrong: not_found, host_unreachable, timeout, wait_timeout,
    insufficient_resources, github_sign_in_required, daemon_unreachable, policy_unavailable,
    output_failed. Exit 2 has many causes (a misplaced flag, rm without --force, a held rename), and
    those still answer unspecified, so usage would mean "ambiguous address" today and something blurrier
    the first time another exit-2 refusal reuses it. The tree already calls this failure ambiguous: it is the
    tracing outcome for the same variants in address.rs:141, session.rs:982 and attach.rs:668. A script that
    sees ambiguous also knows the fix (qualify the address). Return "ambiguous" and update the two test
    rows in crates/minimal/src/main.rs (lines 1325 and 1332).

Two nits, no ask:

  • For NotFound the message says --all shows the boxes "on every host" while the hint says "of every
    project" (address.rs:196-199 vs :131). The arch read ruled "every project" right; the message text is shared
    with list.rs, show.rs and the tests, so it wants its own small follow-up rather than this PR.
  • The new hints are capitalised sentences with periods; the older ones are lowercase fragments
    ("run min auth login, then create the box again"). Unspecified either way; worth matching the neighbours.

Checked and fine: the object shape and schema line match every other machine error; the message carries the
full chain; -o yaml and the jsonl commands enter the same branch; the refusal arm sits after the
registration-time host-unreachable arm and both give host_unreachable/7, so the overlap is harmless;
docs/reference/cli-min.md lists only part of the vocabulary and #3402 already tracks that.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2026
@agent-137

Copy link
Copy Markdown
Member

/revise

Head c8dc73d5. One change from @bryan-minimal's CHANGES_REQUESTED review. Change nothing else.

Name the failure, not the exit class: ambiguous, not usage.
In crates/minimal/src/cmd/boxes/address.rs (about line 122), return the code "ambiguous" for the ambiguous-address refusals instead of "usage". Every other machine code says what went wrong (not_found, host_unreachable, timeout, …). Exit 2 has many causes that still answer unspecified, so usage would blur as soon as another exit-2 refusal reused it. The tree already calls this failure ambiguous: it is the tracing outcome for the same variants in address.rs:141, session.rs:982 and attach.rs:668. Update the two test rows in crates/minimal/src/main.rs (about lines 1325 and 1332).

His two nits need no change in this PR.

Reply on the review with the commit.

Exit 2 has many causes, so the code names the failure, not the exit
class. The tree already calls this outcome ambiguous in its tracing.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on a /revise note, pushed as b3e655efcfd1.

line exit tail
cargo test -p minimal box_address_refusals_answer_with_their_error_kinds 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 961 filtered out; finished in 0.00s running 1 test test tests::box_address_refusals_answer_with_their_error_kinds ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 34 filtered out; finished in 0.00s r

Verify min task run agent-verify exited 100.

 ( 652/1122) minimal tests::an_exact_name_wins_and_an_ambiguous_fold_resolves_to_none
        PASS [   0.037s] ( 653/1122) minimal tests::an_exact_name_wins_over_an_id_prefix
        PASS [   0.039s] ( 654/1122) minimal tests::assess_at_risk_classifies_clean_dirty_and_unknowable
        PASS [   0.673s] ( 655/1122) minimal tests::a_stopped_vm_does_not_hold_a_listing
        PASS [   0.737s] ( 656/1122) minimal tests::a_stopped_vm_does_not_hold_a_box_name_resolution
        PASS [   0.724s] ( 657/1122) minimal tests::attach_connection_failure_exit7
        PASS [   1.751s] ( 658/1122) minimal tests::ambiguous_name_across_hosts_exit2_lists_candidates_for_stop_and_rm
        PASS [   1.302s] ( 659/1122) minimal tests::attach_detach_or_entrypoint_exit_returns_0
        PASS [   0.022s] ( 660/1122) minimal tests::attach_error_printed_after_terminal_restore
        PASS [   1.822s] ( 661/1122) minimal tests::attach_fall_through_hands_off_the_owning_vm
        PASS [   2.957s] ( 662/1122) minimal tests::attach_ended_from_other_side_notice_exit254
        PASS [   0.025s] ( 663/1122) minimal tests::bare_status_counts_elsewhere_sessions
        PASS [   0.025s] ( 664/1122) minimal tests::bare_status_lists_at_most_two_cwd_sessions
        PASS [   0.027s] ( 665/1122) minimal tests::bare_status_renders_a_cwd_session_verbatim
        PASS [   0.029s] ( 666/1122) minimal tests::bare_status_renders_the_empty_state_verbatim
        FAIL [   2.654s] ( 667/1122) minimal tests::attach_ended_from_other_side_notice_exit254_before_the_record
  stdout ───

    running 1 test
    test tests::attach_ended_from_other_side_notice_exit254_before_the_record ... FAILED

    failures:

    failures:
        tests::attach_ended_from_other_side_notice_exit254_before_the_record

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 960 filtered out; finished in 2.62s

  stderr ───

    thread 'tests::attach_ended_from_other_side_notice_exit254_before_the_record' (8865) panicked at crates/minimal/src/tests.rs:11022:9:
    assertion `left == right` failed: reported 0
      left: AttachEnding { code: 0, notice: None }
     right: AttachEnding { code: 254, notice: Some("Detached: web was stopped.") }
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.073s] ( 668/1122) minimal tests::both_creators_share_the_composition_failure_message
        PASS [   1.913s] ( 669/1122) minimal tests::attach_refuses_a_box_name_two_vms_know
        PASS [   6.055s] ( 670/1122) minimal tests::attach_and_resume_verbs_resume_stopped_pty_box
────────────
     Summary [  33.016s] 670/1122 tests run: 669 passed, 1 failed, 2 skipped
        FAIL [   2.654s] ( 667/1122) minimal tests::attach_ended_from_other_side_notice_exit254_before_the_record
warning: 452/1122 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Converted to a draft: something above needs a person before review.

A min box verb with -o json for a box that does not exist exits 4 with code not_found in its min/v1/error object. An unreachable host gives host_unreachable with exit 7. An ambiguous box address now gives code ambiguous with exit 2, in place of usage.

Notes from the agent: Revise round 3. Commit b3e655e changes the code for the Ambiguous and AmbiguousIdStart refusals from usage to ambiguous in BoxAddressRefusal::code(). It updates the two test rows in main.rs to match. The commit also changes the doc comment on code() and the comment above the machine_mode_answer arm, because both named usage. The directive listed no review threads. The two nits need no change, so this round changes nothing for them.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 18:24

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms. The exit-2 refusals now answer with code ambiguous, and the exit code stays 2. The design names machine-mode codes only by example, so ambiguous contradicts no line. The rest of the PASS on c8dc73d5 stands.

Ruled at b3e655e against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/address.rs Resolved
@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Nov 13, 2026
The -o json error object carries the refusal text and the hint. Both now
say min box list --all lists the boxes of every project, as the flag does.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on the runtime's review findings, pushed as c30ff8dd00a1.

line exit tail
cargo test -p minimal box_address_refusals_answer_with_their_error_kinds 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 961 filtered out; finished in 0.00s running 1 test test tests::box_address_refusals_answer_with_their_error_kinds ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 34 filtered out; finished in 0.00s r

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "6683f3fe4e8cd3b5",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "802a35693a0e4e53",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "802a35693a0e4e53",
                "queued_behind": "0",
                "span_id": "caf6c01e96a6a2c2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "6683f3fe4e8cd3b5",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "969c970569a9a99d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "969c970569a9a99d",
                "queued_behind": "0",
                "span_id": "e4d32f593eb19244",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "969c970569a9a99d",
                "queued_behind": "0",
                "span_id": "00b6a86106881c44",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "00b6a86106881c44",
                "span_id": "1341818d9352c2d0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "00b6a86106881c44",
                "queued_behind": "0",
                "span_id": "330d2863a9ff548b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  73.384s] 1122 tests run: 1121 passed, 1 failed, 2 skipped
        FAIL [   3.096s] (1122/1122) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • crates/minimal/src/tests.rs

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM63Oof_: The NotFound refusal text now says min box list --all shows the boxes of every project, the same as the hint. The test that pins the text changed with it. (not posted on the thread: not an open thread on the pull request)

A min box verb with -o json for a box that does not exist exits 4, and its min/v1/error object has code not_found. Its message and its hint now both say that min box list --all shows the boxes of every project. A host that does not answer gives code host_unreachable with exit 7.

Notes from the agent: Round 4. The NotFound Display text changed from 'on every host' to 'of every project' to match the hint and the --all flag help in cli.rs. crates/minimal/src/tests.rs is outside the layers: its test unknown_box_address_exit4_names_address pins the old text, so its expected string changed in the same commit. Two other not-found messages still say 'to see the boxes on every host': cmd/boxes/show.rs:328 and cmd/boxes/list.rs:541. They are outside this task's layers and were not changed. A follow-up can align them.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 18:48

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The new commit changes one refusal text and its test. The text now says that min box list --all shows the boxes of every project. That matches the flag's own help text and the hint of the same refusal. The design names --all but does not define its scope. The error codes and exit codes do not change, so the earlier PASS stands.

Ruled at c30ff8d against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 13, 2026
@agent-137
agent-137 marked this pull request as ready for review November 13, 2026 19:15
@agent-137

Copy link
Copy Markdown
Member

@bryan-minimal your requested change is in. Ambiguous-address refusals now answer code = "ambiguous" (crates/minimal/src/cmd/boxes/address.rs:122), and the two test rows in main.rs are updated. Your --all wording nit is tracked as #3408. Could you re-review at c30ff8d? CI is green, and arch passes.

@mitodrummer
mitodrummer dismissed bryan-minimal’s stale review November 14, 2026 02:28

Stale: the requested change (ambiguous, not usage) is in at c30ff8d.

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 8f6ca07 Nov 14, 2026
40 checks passed
@mitodrummer
mitodrummer deleted the agent/3345-in-a-machine-output-mode-a-box-address-refusal-p branch November 14, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3010 — In a machine output mode, a box address refusal prints the error kind that its exit code stands for, not unspecified

4 participants